From 9ff38dfe4edc65278f49e8746beb322c4f993a1e Mon Sep 17 00:00:00 2001 From: Kyle Isom Date: Fri, 25 Sep 2026 20:17:03 -0700 Subject: [PATCH] v2.3 review: drop a duplicate logIdentityMode call; README wording; review notes Co-Authored-By: Claude Opus 5.5 --- README.md | 2 +- cmd/crossbar/main.go | 1 - docs/implementer-log.md | 11 +++++++++++ 3 files changed, 12 insertions(+), 2 deletions(-) diff --git a/README.md b/README.md index 5553cb0..09f80fb 100644 --- a/README.md +++ b/README.md @@ -111,7 +111,7 @@ curl -H 'X-Crossbar-Route: opencode-a' \ Some clients connect to one crossbar address and manage a llama-server slot themselves: they pin `id_slot`, poll `/slots`, and steer a running completion through -`/v1/chat/completions/control`. `inferproxy`, Boxmaker's router, is one. crossbar serves such a +`/v1/chat/completions/control`. Boxmaker's `inferproxy` is one. crossbar serves such a client from a route that has its own `listen` address and `affinity = "route"`, so the whole route lives on one host: diff --git a/cmd/crossbar/main.go b/cmd/crossbar/main.go index d60e9db..3831ba8 100644 --- a/cmd/crossbar/main.go +++ b/cmd/crossbar/main.go @@ -98,7 +98,6 @@ func run() error { // Identity: gate the proxy on the route's peers when a backend is // configured; off leaves the proxy unwrapped. The same checker gates each // route's dedicated listener. - logIdentityMode(log, cfg.Identity) var checker *identity.Checker if cfg.Identity != "off" { diff --git a/docs/implementer-log.md b/docs/implementer-log.md index 0deacd3..d8c6de5 100644 --- a/docs/implementer-log.md +++ b/docs/implementer-log.md @@ -112,3 +112,14 @@ it; (b) task — the task text did not state that `httputil.ReverseProxy` aborts test design — timing-based tests (limiter, queue, spread, cancel) have margins tuned for an idle host; widen or retry in a later plan. + +### v2.3 review (owner, 2026-09-25) + +Checked: gate, `-race -count=3` on proxy and limiter, smoke (check 6: dedicated listener). Task 01 +clean (nit: the Debug log block copies the Info block's fields). Task 02: release-on-first-flush +reverted by the owner (limiter stopped limiting streams; cause was the owner's racy given test, +now fixed, with `TestLoadIsHeldForTheWholeStream`). Task 03: correct; `main.go` called +`logIdentityMode` twice (removed). Task 04: stopped correctly on the owner's missed v2.1 router +test; resumed after the replacement. README: "Boxmaker's router" → "Boxmaker's `inferproxy`". +Model faults this plan: one timing hack (logged as a deviation), one refusal-ending, one +malformed tool call ending a session with no change. Owner faults: racy test, missed router test.