From 7a31edd6ad4107f1ddde0361c27924a3d9f2320c Mon Sep 17 00:00:00 2001 From: "K. Isom" Date: Wed, 21 Oct 2026 22:42:14 -0700 Subject: [PATCH] ci: build tines-core on MSRV instead of testing it The msrv job ran `cargo test` on 1.82, which can't parse a proptest dev-dependency that needs edition 2024 (B5). The MSRV promise covers building tines-core, so the job now builds it on 1.82 with default features, with --no-default-features, and for thumbv7em-none-eabihf. `cargo +1.82.0` makes the toolchain explicit over rust-toolchain.toml. All three builds pass locally on 1.82.0. Co-Authored-By: Claude Opus 5.5 --- .github/workflows/ci.yml | 13 ++++++++++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index b5d08851..a6090791 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -57,11 +57,18 @@ jobs: uses: dtolnay/rust-toolchain@683b588c487a69d01f6c6ddf40f036ff682cc2c8 # master with: toolchain: 1.82.0 + targets: thumbv7em-none-eabihf - name: Cache cargo registry and target uses: Swatinem/rust-cache@6323deb102c322ba6fcbdcafc7e3dddab59af2b6 # v2.9.2 - - name: Build + test tines-core on MSRV + # Build only: the MSRV promise covers building tines-core, not its + # dev-dependencies. proptest pulls in crates that need edition 2024, + # which 1.82 can't parse, so `cargo test` can't run here. The tests run + # on the pinned toolchain in the `ci` job. `+1.82.0` overrides + # rust-toolchain.toml. + - name: Build tines-core on MSRV run: | - cargo test --locked -p tines-core - cargo test --locked -p tines-core --no-default-features + cargo +1.82.0 build --locked -p tines-core + cargo +1.82.0 build --locked -p tines-core --no-default-features + cargo +1.82.0 build --locked -p tines-core --no-default-features --target thumbv7em-none-eabihf