Review M3a: accept with fifteen findings; record the server change

Two medium findings in the audit writer (a startup panic on a record-less log file, and a log-name filter that disagrees with bxctl's), one in the missing runbook pointers for startup failures, and twelve low ones. Lessons I14 and T21, T22; two new AGENTS rules; m3a's T18 renumbered to T20 so master's T18 and T19 survive the merge. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
2026-09-22 20:48:43 -07:00
parent ffbff501d6
commit 22a26aad45
3 changed files with 78 additions and 1 deletions
@@ -69,6 +69,10 @@ These come from defects found in review. The evidence is in `docs/implementer-le
 - A rule about one path applies to every path that does the same thing, including early returns
  and error paths the task did not walk through.
 - A file that exists but cannot be read is an error. Only a missing file may count as absent.
+- A file your own program can create before it writes anything must load like an empty one. Test
+  the state a crash leaves behind, not only the states you write on purpose.
+- When two programs must agree about a set of things (which files are a log, which names are ids),
+  one of them deciding alone is a bug. Write the case that walks both.

 ## The gate