docs: M5d-2: after gate: ok, do not sum test results
Task 01 told Ornith to add up every `test result:` N passed. A greedy sed kept the last digit (1512 became 1022) and it stopped with the correct T1 and given test uncommitted. T50/T59: the last line of make gate is the count; summing is not a stop. Co-Authored-By: Grok 4.6 <noreply@x.ai>
This commit is contained in:
@@ -90,10 +90,10 @@ become
|
||||
--test compact_turn`: every test passes, 4 in `session_slot` and the others as before.
|
||||
- [ ] **5. Check.** `git diff --stat` lists exactly `crates/loopd/src/turn.rs`.
|
||||
- [ ] **6. Run the gate.** `cargo fmt --all`, then `make gate`, with a shell timeout of 600000 ms.
|
||||
Expected last line: `gate: ok`. The test count is **1512** after this task, 1508 before it,
|
||||
and the 4 new ones are the tests of `session_slot.rs`. To count, add up the `N passed` of
|
||||
every `test result:` line the gate's `cargo test --workspace` printed, and add 1. Never run
|
||||
the gate again only to count.
|
||||
Expected last line: `gate: ok`. That is done counting: **1512** (1508 before, plus the 4 of
|
||||
`session_slot.rs`). After `gate: ok`, do not add up `test result:` lines and do not run
|
||||
`cargo test --workspace`. A `sed` of `.*([0-9]+) passed` keeps only the last digit and
|
||||
reports about 1022.
|
||||
- [ ] **7. Log and commit.** Add your row to `docs/implementer-log.md`; its Task cell is
|
||||
`M5d2/01-loopd-session-slot`. Stage with
|
||||
`git add crates/loopd docs/implementer-log.md Cargo.lock`, then commit as `AGENTS.md` says.
|
||||
@@ -116,7 +116,6 @@ become
|
||||
- The fix seems to need a change anywhere else. It does not; stop and say why you think so.
|
||||
- A test outside `session_slot.rs` fails in the gate: check once whether it fails without your
|
||||
change (`git stash -u`, run it, `git stash pop`), then stop and report both results.
|
||||
- The gate passes with a count other than 1512.
|
||||
|
||||
## What the given tests pin
|
||||
|
||||
|
||||
@@ -139,7 +139,8 @@ become
|
||||
- [ ] **5. Check.** `git diff --stat` lists `crates/bxcore/src/log.rs`,
|
||||
`crates/loopd/src/baseline.rs`, `crates/loopd/tests/support/turn.rs`.
|
||||
- [ ] **6. Run the gate.** `cargo fmt --all`, then `make gate`, timeout 600000 ms. Last line
|
||||
`gate: ok`. Test count **1518** (1512 before, plus 6).
|
||||
`gate: ok`. Test count **1518** (1512 before, plus 6). After `gate: ok`, do not add up
|
||||
`test result:` lines.
|
||||
- [ ] **7. Log and commit.** Task cell `M5d2/02-bxcore-tool-summary`. Stage with
|
||||
`git add crates/bxcore crates/loopd docs/implementer-log.md Cargo.lock`, then commit as
|
||||
`AGENTS.md` says.
|
||||
@@ -155,7 +156,7 @@ become
|
||||
## Stop and report if
|
||||
|
||||
- The branch check fails; a "before" block is not found exactly once; step 2 differs; `cargo
|
||||
check` warns; a test fails; the gate count is not 1518; you replay a summary as a `User` or
|
||||
check` warns; a test fails; the gate's last line is not `gate: ok`; you replay a summary as a `User` or
|
||||
`Tool` message; you add `truncated`; you change `Setup::turn`'s return type.
|
||||
|
||||
## What the given tests pin
|
||||
|
||||
@@ -216,7 +216,8 @@ The test still forbids `m2b()`, `m3a()` and `m5a()` in `main.rs`. Do not weaken
|
||||
`crates/loopd/src/main.rs` and `crates/loopd/tests/ask_memory_tool.rs`. `git status --short`
|
||||
shows the new test and `config/heartbeat.md`.
|
||||
- [ ] **6. Run the gate.** `cargo fmt --all`, then `make gate`, timeout 600000 ms. Last line
|
||||
`gate: ok`. Test count **1526** (1518 before, plus 8).
|
||||
`gate: ok`. Test count **1526** (1518 before, plus 8). After `gate: ok`, do not add up
|
||||
`test result:` lines.
|
||||
- [ ] **7. Log and commit.** Task cell `M5d2/03-loopd-heartbeat-config`. Stage with
|
||||
`git add crates/loopd config/heartbeat.md docs/implementer-log.md Cargo.lock`, then commit
|
||||
as `AGENTS.md` says.
|
||||
@@ -231,7 +232,7 @@ The test still forbids `m2b()`, `m3a()` and `m5a()` in `main.rs`. Do not weaken
|
||||
## Stop and report if
|
||||
|
||||
- The branch check fails; a "before" block is not found exactly once; step 2 differs; `cargo
|
||||
check` warns; a test fails; the gate count is not 1526; you leave the `m5c()` count at 1;
|
||||
check` warns; a test fails; the gate's last line is not `gate: ok`; you leave the `m5c()` count at 1;
|
||||
you join `heartbeat.prompt` onto `system.md`'s directory instead of the config file's parent;
|
||||
you reject an empty `summarise` list; you check names inside `parse`.
|
||||
|
||||
|
||||
@@ -169,7 +169,8 @@ If `is_multiple_of` is not in scope on `u32` in this toolchain, use `value % n =
|
||||
- [ ] **5. Check.** `git diff --stat` lists `crates/loopd/src/cron.rs` and
|
||||
`crates/loopd/src/lib.rs`.
|
||||
- [ ] **6. Run the gate.** `cargo fmt --all`, then `make gate`, timeout 600000 ms. Last line
|
||||
`gate: ok`. Test count **1537** (1526 before, plus 11).
|
||||
`gate: ok`. Test count **1537** (1526 before, plus 11). After `gate: ok`, do not add up
|
||||
`test result:` lines.
|
||||
- [ ] **7. Log and commit.** Task cell `M5d2/04-loopd-cron`. Stage with
|
||||
`git add crates/loopd docs/implementer-log.md Cargo.lock`, then commit as `AGENTS.md` says.
|
||||
|
||||
@@ -181,8 +182,8 @@ If `is_multiple_of` is not in scope on `u32` in this toolchain, use `value % n =
|
||||
|
||||
## Stop and report if
|
||||
|
||||
- The branch check fails; step 2 differs; `cargo check` warns; a test fails; the gate count is
|
||||
not 1537; you add a dependency; you treat DOM and DOW as OR; you accept `@daily` or a sixth
|
||||
- The branch check fails; step 2 differs; `cargo check` warns; a test fails; the gate's last
|
||||
line is not `gate: ok`; you add a dependency; you treat DOM and DOW as OR; you accept `@daily` or a sixth
|
||||
field; `cron.rs` exceeds 500 lines.
|
||||
|
||||
## What the given tests pin
|
||||
|
||||
@@ -194,7 +194,8 @@ Replace the four stub bodies in the same task. Do not leave a stub that returns
|
||||
- [ ] **6. Check.** `git diff --stat` lists `crates/loopd/src/jobs.rs`,
|
||||
`crates/loopd/src/lib.rs`, `crates/loopd/src/main.rs`, `docs/runbook.md`.
|
||||
- [ ] **7. Run the gate.** `cargo fmt --all`, then `make gate`, timeout 600000 ms. Last line
|
||||
`gate: ok`. Test count **1545** (1537 before, plus 8).
|
||||
`gate: ok`. Test count **1545** (1537 before, plus 8). After `gate: ok`, do not add up
|
||||
`test result:` lines.
|
||||
- [ ] **8. Log and commit.** Task cell `M5d2/05-loopd-jobs`. Stage with
|
||||
`git add crates/loopd docs/runbook.md docs/implementer-log.md Cargo.lock`, then commit as
|
||||
`AGENTS.md` says.
|
||||
@@ -207,8 +208,8 @@ Replace the four stub bodies in the same task. Do not leave a stub that returns
|
||||
|
||||
## Stop and report if
|
||||
|
||||
- The branch check fails; step 2 differs; `cargo check` warns; a test fails; the gate count is
|
||||
not 1545; you add a cron crate; a missing jobs directory is an error; `Display` for `Invalid`
|
||||
- The branch check fails; step 2 differs; `cargo check` warns; a test fails; the gate's last
|
||||
line is not `gate: ok`; you add a cron crate; a missing jobs directory is an error; `Display` for `Invalid`
|
||||
does not end with the runbook pointer; `jobs.rs` exceeds 500 lines; you write a job file.
|
||||
|
||||
## What the given tests pin
|
||||
|
||||
@@ -197,7 +197,8 @@ pass so it runs once.
|
||||
|
||||
`grep -c '^## heartbeat-prompt-unreadable$' docs/runbook.md` prints `1`.
|
||||
- [ ] **6. Run the gate.** `cargo fmt --all`, then `make gate`, timeout 600000 ms. Last line
|
||||
`gate: ok`. Test count **1551** (1545 before, plus 6).
|
||||
`gate: ok`. Test count **1551** (1545 before, plus 6). After `gate: ok`, do not add up
|
||||
`test result:` lines.
|
||||
- [ ] **7. Log and commit.** Task cell `M5d2/06-loopd-scheduler-heartbeat`. Stage with
|
||||
`git add crates/loopd docs/runbook.md docs/implementer-log.md Cargo.lock`, then commit as
|
||||
`AGENTS.md` says.
|
||||
@@ -212,7 +213,7 @@ pass so it runs once.
|
||||
## Stop and report if
|
||||
|
||||
- The branch check fails; a "before" block is not found exactly once; step 2 differs; `cargo
|
||||
check` warns; a test fails; the gate count is not 1551; you sleep in a test; you post to
|
||||
check` warns; a test fails; the gate's last line is not `gate: ok`; you sleep in a test; you post to
|
||||
Mattermost; you send `slots.main`; you set a speaker; you `chmod 000`; `Held` stays private;
|
||||
`hold` returns `Result<_, ()>`.
|
||||
|
||||
|
||||
@@ -82,7 +82,8 @@ Do not change heartbeat behaviour. Do not add a sleep.
|
||||
--test jobs --test cron`: every test passes, 6 in `scheduler_cron`.
|
||||
- [ ] **5. Check.** `git diff --stat` lists exactly `crates/loopd/src/scheduler.rs`.
|
||||
- [ ] **6. Run the gate.** `cargo fmt --all`, then `make gate`, timeout 600000 ms. Last line
|
||||
`gate: ok`. Test count **1557** (1551 before, plus 6).
|
||||
`gate: ok`. Test count **1557** (1551 before, plus 6). After `gate: ok`, do not add up
|
||||
`test result:` lines.
|
||||
- [ ] **7. Log and commit.** Task cell `M5d2/07-loopd-scheduler-cron`. Stage with
|
||||
`git add crates/loopd docs/implementer-log.md Cargo.lock`, then commit as `AGENTS.md` says.
|
||||
|
||||
@@ -95,7 +96,7 @@ Do not change heartbeat behaviour. Do not add a sleep.
|
||||
## Stop and report if
|
||||
|
||||
- The branch check fails; step 2 differs (tests do not compile, or a different assertion
|
||||
fails); `cargo check` warns; a test fails; the gate count is not 1557; you reuse a session
|
||||
fails); `cargo check` warns; a test fails; the gate's last line is not `gate: ok`; you reuse a session
|
||||
across runs; you send `slots.main`; you set a speaker; you skip leftovers that are not busy;
|
||||
a heartbeat test fails.
|
||||
|
||||
|
||||
@@ -230,7 +230,8 @@ Facts). The `Err(TurnError::SessionFull)` arm gets the same `missing` call befor
|
||||
- [ ] **5. Check.** `git diff --stat` lists `crates/loopd/src/summarise.rs`,
|
||||
`crates/loopd/src/lib.rs`, `crates/loopd/src/compact.rs`.
|
||||
- [ ] **6. Run the gate.** `cargo fmt --all`, then `make gate`, timeout 600000 ms. Last line
|
||||
`gate: ok`. Test count **1563** (1557 before, plus 6).
|
||||
`gate: ok`. Test count **1563** (1557 before, plus 6). After `gate: ok`, do not add up
|
||||
`test result:` lines.
|
||||
- [ ] **7. Log and commit.** Task cell `M5d2/08-loopd-tool-summary`. Stage with
|
||||
`git add crates/loopd config/summarise.md docs/implementer-log.md Cargo.lock`, then commit
|
||||
as `AGENTS.md` says.
|
||||
@@ -245,7 +246,7 @@ Facts). The `Err(TurnError::SessionFull)` arm gets the same `missing` call befor
|
||||
## Stop and report if
|
||||
|
||||
- The branch check fails; a "before" block is not found exactly once; step 2 differs; `cargo
|
||||
check` warns; a test fails; the gate count is not 1563; you send tools on the summary
|
||||
check` warns; a test fails; the gate's last line is not `gate: ok`; you send tools on the summary
|
||||
request; you send `slots.main`; you replay the summary in `messages()`; you summarise a
|
||||
name not in the list; you summarise twice; you compact before summarising.
|
||||
|
||||
|
||||
@@ -117,7 +117,8 @@ results are indexed. A comment that does not fit its code: stop.
|
||||
test passes, 5 in `tool_summary_index`.
|
||||
- [ ] **5. Check.** `git diff --stat` lists exactly `crates/memoryd/src/index.rs`.
|
||||
- [ ] **6. Run the gate.** `cargo fmt --all`, then `make gate`, timeout 600000 ms. Last line
|
||||
`gate: ok`. Test count **1568** (1563 before, plus 5).
|
||||
`gate: ok`. Test count **1568** (1563 before, plus 5). After `gate: ok`, do not add up
|
||||
`test result:` lines.
|
||||
- [ ] **7. Log and commit.** Task cell `M5d2/09-memoryd-summary-index`. Stage with
|
||||
`git add crates/memoryd docs/implementer-log.md Cargo.lock`, then commit as `AGENTS.md`
|
||||
says.
|
||||
@@ -131,7 +132,7 @@ results are indexed. A comment that does not fit its code: stop.
|
||||
## Stop and report if
|
||||
|
||||
- The branch check fails; a "before" block is not found exactly once; step 2 differs; `cargo
|
||||
check` warns; a test fails; the gate count is not 1568; you index `ToolResult` content; you
|
||||
check` warns; a test fails; the gate's last line is not `gate: ok`; you index `ToolResult` content; you
|
||||
leave `kind` as `"session"`; a secret summary is searchable on a private index.
|
||||
|
||||
## What the given tests pin
|
||||
|
||||
@@ -226,7 +226,8 @@ Do not edit `cli_memory.rs`. This file is the M5c pin of the same USAGE string.
|
||||
- [ ] **5. Check.** `git diff --stat` lists the files in "Every place that changes" except
|
||||
the new tests and starter (those are untracked until `git add`).
|
||||
- [ ] **6. Run the gate.** `cargo fmt --all`, then `make gate`, timeout 600000 ms. Last line
|
||||
`gate: ok`. Test count **1574** (1568 before, plus 6).
|
||||
`gate: ok`. Test count **1574** (1568 before, plus 6). After `gate: ok`, do not add up
|
||||
`test result:` lines.
|
||||
- [ ] **7. Log and commit.** Task cell `M5d2/10-memoryd-tiers`. Stage with
|
||||
`git add crates/bxcore crates/memoryd crates/bxctl config/jobs docs/implementer-log.md
|
||||
Cargo.lock`, then commit as `AGENTS.md` says.
|
||||
@@ -239,7 +240,7 @@ Do not edit `cli_memory.rs`. This file is the M5c pin of the same USAGE string.
|
||||
## Stop and report if
|
||||
|
||||
- The branch check fails; a "before" block is not found exactly once; step 2 differs; `cargo
|
||||
check` warns; a test fails; the gate count is not 1574; you edit `cli_memory.rs`; you leave
|
||||
check` warns; a test fails; the gate's last line is not `gate: ok`; you edit `cli_memory.rs`; you leave
|
||||
the `cli_memory_sync` USAGE pin on the old string; identity entries show a non-zero hit
|
||||
count; untrusted notes are omitted; you add a cron crate; you special-case the name `tier`
|
||||
in `loopd`.
|
||||
|
||||
Reference in New Issue
Block a user