docs: M5c-1 review finding 7 closed: the two flaky tests fixed

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This commit is contained in:
2026-09-28 14:26:52 -07:00
co-authored by Claude Opus 5.5
parent e83b53b8b6
commit 572b582038
2 changed files with 9 additions and 7 deletions
+8 -6
View File
@@ -98,13 +98,15 @@ owner's Mattermost.
- Task 12 decides only; task 13 sends. Task 15 was added for the owner's decision 1 and for the
matching of conclusions by peer found while writing task 13.
## Known issue
## Known issue (fixed in review)
`gatewayd`'s `gateway_sock` test `brokerd_closing_first_ends_it_as_no_longer_pending` fails now and
then on a loaded machine (2 of 10 runs without any M5c-1 change, at a load average near 10, on
talos): after `Ended` arrives, the handler can still hold the answer's receiver for a moment. It is
a timing race in the test, not in `memoryd`. Tasks 13 to 15 tell the implementer: if it is the one
test that fails, run the gate once more. To be fixed after M5c-1.
`gatewayd`'s `gateway_sock` test `brokerd_closing_first_ends_it_as_no_longer_pending` failed now
and then on a loaded machine (2 of 10 runs without any M5c-1 change, at a load average near 10, on
talos), and `loopd`'s `pointers` once in task 15. Tasks 13 to 15 told the implementer to run the
gate once more if it was the one test that failed. Both were fixed in the review (review finding
7 in `docs/implementer-log.md`): the first was a race in `gatewayd`'s handler, which said an
approval had ended while it still held the answer's receiver; the second was the serve tests
stopping `loopd` as soon as its socket appeared, before it had printed its startup lines.
## Before hand-over