tests: every temporary path is removed by a guard; no leftovers in /tmp

About 10,000 test leftovers had built up in titan's /tmp. loopd's Home
and FakeServer, its fake broker's socket, bxctl's temp sockets, fake
loopd and command homes, inferproxy's socket, and a few brokerd and
toolkit tests created uniquely named directories or sockets and never
removed them, or removed them by hand at the end, which a failing test
skips. Each is now a guard removed on drop (bxctl gains
tests/support/temp.rs). Two races also left gatewayd homes behind: the
test Running only signalled its server to stop, and two Stage structs
declared the home first, so it was removed while the server could still
write into it. Running's drop now waits for the thread (with a 5-second
limit), and every home is declared last.

Checked: make gate twice, then the gate and three rounds of gatewayd and
loopd tests; no new entry in /tmp; 944 tests pass.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This commit is contained in:
2026-09-26 01:29:32 -07:00
co-authored by Claude Opus 5.5
parent 53532e04ff
commit a15c428ea6
19 changed files with 230 additions and 51 deletions
+29 -3
View File
@@ -14,11 +14,37 @@ use std::time::Duration;
static NEXT: AtomicU32 = AtomicU32::new(0);
fn socket_path() -> PathBuf {
/// A socket path in a fresh directory of its own, removed when the value is dropped (tip T44).
struct TempSocket {
dir: PathBuf,
path: PathBuf,
}
impl std::ops::Deref for TempSocket {
type Target = PathBuf;
fn deref(&self) -> &PathBuf {
&self.path
}
}
impl AsRef<std::path::Path> for TempSocket {
fn as_ref(&self) -> &std::path::Path {
&self.path
}
}
impl Drop for TempSocket {
fn drop(&mut self) {
let _ = std::fs::remove_dir_all(&self.dir);
}
}
fn socket_path() -> TempSocket {
let n = NEXT.fetch_add(1, Ordering::SeqCst);
let dir = std::env::temp_dir().join(format!("inferproxy-test-{}-{n}", std::process::id()));
std::fs::create_dir_all(&dir).unwrap();
dir.join("infer.sock")
let path = dir.join("infer.sock");
TempSocket { dir, path }
}
/// An upstream that reads until the client stops sending, then answers with what it read,
@@ -52,7 +78,7 @@ fn silent_upstream() -> String {
addr
}
fn start(upstream: String, limits: Limits) -> PathBuf {
fn start(upstream: String, limits: Limits) -> TempSocket {
let path = socket_path();
let listener = UnixListener::bind(&path).unwrap();
thread::spawn(move || serve(listener, upstream, limits));