Review M3b tasks 14 to 17: accept; M3b done
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This commit is contained in:
@@ -485,3 +485,22 @@ nothing read, and `#[allow]` forbidden), then two sessions ran out of room plann
|
||||
in one turn; a skeleton, and then a finer one with `run` as glue over small helpers, got it done.
|
||||
Every stop was a task-writing problem or a turn-size problem, not a wrong implementation.
|
||||
|
||||
### M3b, tasks 14 to 17 — reviewed 2026-09-23 by the design model (Claude)
|
||||
|
||||
Accepted; M3b is done. All four by Ornith, each committed on its first attempt: task 14 a pure
|
||||
move, tasks 15 and 16 with the glue given exactly, task 17 small. The given tests are unchanged;
|
||||
`make gate` prints `gate: ok` with 649 tests, the reference's count; `thread::spawn` and `as u64`
|
||||
are gone from `brokerd` and `toolkit`; `container.rs` is 374 lines and `pipes.rs` 128.
|
||||
|
||||
On straylight with the final code (image `sha256:08dfabf0…`), every row of the first review's
|
||||
table held again, and the glob URL made one request. One behaviour to know: a shell command that
|
||||
leaves a background process (`sleep 30 &`) runs to the time limit and is then killed and removed,
|
||||
because `toolkit shell` reads its output to the end (task 05) and the container has not ended; the
|
||||
grace period of task 15 covers only a container that has.
|
||||
|
||||
Open, low: finding 6 (`is_public` does not refuse local-use NAT64 `64:ff9b:1::/48` or 6to4
|
||||
`2002::/16` with a private IPv4 inside; neither is in use on straylight, and it has no public
|
||||
address of its own), and M3a findings 17, 18 and 20. Owner foot-guns noted by the independent review
|
||||
and not fixed: a grant path that overlaps a container path (`/bin`, `/tmp`, `/run/egress`), and a
|
||||
`home` containing `:`.
|
||||
|
||||
|
||||
Reference in New Issue
Block a user