M5a plan: tasks 16 and 17, the review's nits
Task 16: memoryd takes the day and the month of a time with str::get, never a slice. Task 17: repeated error lines in memoryd, proto, brokerd and bxctl written once. Neither changes behaviour. Both were applied to a scratch tree from 5f82260: the gate passes with 936 tests, and four mutations of the new helpers are caught by the existing tests. The README runs with OPENCODE_MODEL. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This commit is contained in:
@@ -1,7 +1,7 @@
|
||||
# M5a implementation plan: local memory
|
||||
|
||||
> **For the implementing model:** do not work from this file. The owner gives you one task file at
|
||||
> a time (`01-…` to `15-…`). This file is the index for the owner and the reviewer.
|
||||
> a time (`01-…` to `17-…`). This file is the index for the owner and the reviewer.
|
||||
|
||||
**Goal:** a new role, `memoryd`, owns the agent's memory: identity (`soul.md`, `memory.md`,
|
||||
`user.md`, in every new session's prompt) and experience (`notes.md` and the session logs, found
|
||||
@@ -64,8 +64,11 @@ the skeletons were cut (tip T25).
|
||||
| 13 | `13-loopd-memory.md` | the block, the core tools, `session_updated` | `memory.rs`; `baseline.rs`, `pointers.rs`, `channel.rs` updated | reference; 6 mutations caught |
|
||||
| 14 | `14-bxctl-memory.md` | `bxctl reindex`, `bxctl memory` | `cli_memory.rs` | reference; 5 mutations caught |
|
||||
| 15 | `15-soul-and-device.md` | the starter soul; device checks with `memoryd` | `device.rs` updated, `support/memoryd.rs` | reference; `make verify-device` on straylight |
|
||||
| 16 | `16-memoryd-no-slicing.md` | the day and the month with `get`, not a slice (review nit) | the existing ones | reference |
|
||||
| 17 | `17-repeated-code.md` | repeated error lines written once (review nit) | the existing ones | reference; 4 mutations caught |
|
||||
|
||||
At the end of task 15: 936 tests (854 before task 01). Each task's count was checked by running
|
||||
At the end of task 15: 936 tests (854 before task 01); tasks 16 and 17 change no behaviour and
|
||||
keep 936. Each task's count was checked by running
|
||||
the gate at its end state on its own.
|
||||
|
||||
## Changes during the run
|
||||
@@ -87,12 +90,15 @@ the gate at its end state on its own.
|
||||
are rustfmt-clean. The attempt is saved in `.state/runs/M5a/04-attempt-2/`. Resume from task
|
||||
04. The measurements behind this are in `docs/research/2026-09-24-chat-template-tokens.md`,
|
||||
added after the run.
|
||||
- 2026-09-24, after the review: tasks 16 and 17 clean up the review's nits. Resume from task 16.
|
||||
|
||||
## Running it
|
||||
|
||||
```sh
|
||||
git switch m5a
|
||||
BOXMAKER_MODEL=straylight/ornith-1.5-35b-a3b tools/run-plan.sh docs/plans/M5a
|
||||
OPENCODE_MODEL=straylight/ornith-1.5-35b-a3b tools/run-plan.sh docs/plans/M5a
|
||||
# the review's follow-ups:
|
||||
OPENCODE_MODEL=straylight/ornith-1.5-35b-a3b tools/run-plan.sh docs/plans/M5a 16
|
||||
```
|
||||
|
||||
Keep the OpenCode TUI closed while it runs.
|
||||
|
||||
Reference in New Issue
Block a user