kyle/boxmaker
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Review M1: accept with two follow-up tasks

Browse Source 
The branch passes the checklist: seven commits, copied files unchanged,
gate and audit green. Reading and probing found that AuditRecord and
ToolCall accept unknown fields, that large Timestamps panic when
formatted, and that the dependency-direction scripts miss table-form
dependencies and pass when their inputs are missing. The last two
families were gaps in the tasks, not only in the code.

Tasks 08 and 09 carry the fixes, defined by an exhaustive unknown-field
test, a bounded-Timestamp test and an extended gate-script self-test.
All three were checked against the reference implementation and fail on
the current branch.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This commit is contained in:
kyle
2026-09-17 09:14:29 -07:00
co-authored by Claude Fable 5.1
parent 8c1852ec47
commit dcdcf65d83
9 changed files with 388 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
docs/implementer-log.md
+43
View File
@@ -14,3 +14,46 @@ reviewer adds findings under "Reviews" once per milestone.
| M1/07-brokerd-decision | 2026-09-17 | done | 1 | pass | none | Added Decision (Debug only, private fields), decide (Err(NoGrant) until M3) and the run stub (ToolResponse::Failed) in crates/brokerd; Decision::new carries expect(dead_code). 2 unit + 3 doctests (2 compile_fail) pass; verified the compile_fail guards by temporarily making new pub. `make gate` prints `gate: ok`. |
## Reviews
### M1, tasks 01 to 07 — reviewed 2026-09-17 by the design model (Claude)
**Verdict: accepted, with two follow-up tasks (08, 09).** Nothing has to be redone.
Checklist from `docs/plans/M1/README.md`:
| Check | Result |
|---|---|
| Seven commits on `m1`, one per task, each with the `Implemented-By` trailer | pass |
| All 23 copied files (tests, fixtures, `Makefile`, `deny.toml`, self-test) byte-identical to the plan | pass |
| No change to the brief, specs, plans, `AGENTS.md`, `CLAUDE.md`; working tree clean; nothing pushed | pass |
| `make gate` | `gate: ok`, 45 tests |
| `make audit` | `advisories ok` |
| No `unwrap`, `expect`, `panic!`, `#[allow]` or `unsafe` in library code; no dependency the tasks did not name | pass |
| Field order, derives and signatures match the tasks | pass |
Process: first gate run passed in 4 of 7 tasks. The three failures were two compile fixes (task 04)
and rustfmt reordering `lib.rs` re-exports (tasks 04 to 06). Commits run from 06:45 to 09:05.
Findings. "Implementer" means the task said it and the code missed it. "Task" means the task or its
tests, written by the reviewer, were wrong or silent; the reference implementation had the same
defect in both such cases.
| # | Severity | Owner | Finding | Fix |
|---|---|---|---|---|
| 1 | medium | implementer, and a gap in the given tests | `AuditRecord` and `ToolCall` lack `deny_unknown_fields`. An audit line with an extra `"forged":true` field decodes. The given tests only checked the enums. | Task 08; new `tests/strict.rs` checks every object at every depth |
| 2 | medium | task | `Timestamp::from_unix_millis` accepts any `u64`, but `to_rfc3339` and serialization panic above year 9999, because `humantime`'s `Display` returns an error and `to_string()` panics on that. | Task 08 |
| 3 | medium | task | `[dependencies.brokerd]` with `workspace = true` lets a role depend on another role while both dependency scripts pass. Dotted `brokerd.path = …` is also missed. The self-test had no such case. | Task 09 |
| 4 | low | implementer | All three scripts pass when `ROOT/crates` is missing, and hide tool errors with `2>/dev/null`. A gate check that cannot look must fail. | Task 09 |
| 5 | low | implementer | `check-lines.sh` does not print the line count. | Task 09 |
| 6 | nit | implementer | `frame.rs` uses bounded `as` casts where `try_from` would say the same without a second look. `read_bytes` has two match arms that do the same thing. `Constraints` has a needless `rename_all`. `ids.rs`, `class.rs`, `wire.rs` have no module doc comment. | Not worth a task; fix when next touched |
| 7 | low | task | The tasks told the implementer how to order `lib.rs` lines, and rustfmt disagreed, which cost three gate runs. | `AGENTS.md` now says to run `cargo fmt --all` before the gate |
Open question for the owner: the task 01 row says the skeleton files were "already present
untracked from a prior attempt". The log has no row for that attempt, so its gate runs and the
reason it ended are not recorded.
On the experiment (review once per milestone): it held up for M1. None of the defects was built on
by a later task, and all were found by reading the branch and probing it from outside. M1 is the
easy case, though: types pinned by byte-exact fixtures. M2 has behaviour that fixtures cannot pin
as tightly (a streaming HTTP client, the turn loop), so an early mistake there is more likely to
be built on.