bxcore, gatewayd, loopd: the secret store moves to bxcore::secrets

Co-Authored-By: ornith-1.5-35b-a3b <agent@wntrmute.dev>

crates/gatewayd/src/main.rs

@@ -7,8 +7,8 @@ use std::process::ExitCode;
 use std::sync::Arc;
 use std::sync::atomic::AtomicBool;
 
+use bxcore::secrets;
 use gatewayd::config::{Config, MATTERMOST_TOKEN};
-use gatewayd::secrets;
 use gatewayd::serve::{START_FAILED, Tuning, run};
 
 fn main() -> ExitCode {
@@ -30,8 +30,9 @@ fn serve(path: &Path) -> ExitCode {
     //    "gatewayd: {e}\n{START_FAILED}".
     // 2. `let source = match config.token_source() { ... }`: an Err(why) prints
     //    "gatewayd: {}: {why}\n{START_FAILED}" with `path.display()`.
-    // 3. `let loaded = match secrets::load(MATTERMOST_TOKEN, &source, &|k| std::env::var_os(k))`:
-    //    an Err(e) prints "gatewayd: {e}" (the error carries its own pointer).
+    // 3. `let env = |k: &str| std::env::var_os(k);`, then
+    //    `let loaded = match secrets::load("gatewayd", MATTERMOST_TOKEN, &source, &env)`: an Err(e)
+    //    prints "gatewayd: {e}" (the error carries its own pointer).
     //    Then `if let Some(warning) = &loaded.warning { eprintln!("{warning}"); }`.
     // 4. The state file's directory:
     //    `let dir = config.state_path().parent().map(Path::to_path_buf).unwrap_or_default();`
@@ -54,7 +55,8 @@ fn serve(path: &Path) -> ExitCode {
             return ExitCode::from(1);
         }
     };
-    let loaded = match secrets::load(MATTERMOST_TOKEN, &source, &|k| std::env::var_os(k)) {
+    let env = |k: &str| std::env::var_os(k);
+    let loaded = match secrets::load("gatewayd", MATTERMOST_TOKEN, &source, &env) {
         Ok(loaded) => loaded,
         Err(e) => {
             eprintln!("gatewayd: {e}");