memoryd (files, the check, edits, journal, index, recall, serving), the memory tools and built-in grants in brokerd, the memory block in loopd, bxctl reindex and memory, and the device checks with memoryd. Each task was built as a reference and gated. Each was replayed on its own at its end state (854 to 936 tests) and mutation-checked. Each skeleton compiles and fails its tests. Every todo comment was read beside its signature. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
123 lines
4.9 KiB
Rust
123 lines
4.9 KiB
Rust
//! Memory, as `loopd` sees it (M5a spec, section 9): the block `memoryd` renders for a new
|
|
//! session's baseline, the schemas of the two core memory tools, and the notice after a turn.
|
|
//! `loopd` keeps no memory itself; `brokerd` decides the tool calls and `memoryd` runs them.
|
|
|
|
use std::os::unix::net::UnixStream;
|
|
use std::path::PathBuf;
|
|
use std::time::Duration;
|
|
|
|
use proto::{
|
|
Empty, Envelope, Message, PROTOCOL_VERSION, SessionId, SessionUpdated, read_frame, write_frame,
|
|
};
|
|
|
|
use crate::llama::ToolSchema;
|
|
|
|
/// Where a new session's baseline points when there is no memory block.
|
|
pub const UNAVAILABLE: &str = "see docs/runbook.md#memory-unavailable";
|
|
|
|
/// How long `loopd` waits for `memoryd`.
|
|
pub const MEMORY_WAIT: Duration = Duration::from_secs(10);
|
|
|
|
/// Where the memory block comes from, and who hears that a session has new records.
|
|
pub trait MemorySource: Send + Sync {
|
|
/// The block for a new session. `Err` ends in `UNAVAILABLE`: no session starts without it.
|
|
fn block(&self) -> Result<String, String>;
|
|
/// The session has new records; best effort, a failure is only logged by the caller.
|
|
fn updated(&self, session: &SessionId) -> Result<(), String>;
|
|
}
|
|
|
|
/// No memory: for tests and the self-test, never for `loopd serve`.
|
|
pub struct NoMemory;
|
|
|
|
impl MemorySource for NoMemory {
|
|
fn block(&self) -> Result<String, String> {
|
|
Ok(String::new())
|
|
}
|
|
fn updated(&self, _session: &SessionId) -> Result<(), String> {
|
|
Ok(())
|
|
}
|
|
}
|
|
|
|
/// A client of `memoryd`'s `loopd` socket. One connection per request.
|
|
pub struct MemoryPort {
|
|
socket: PathBuf,
|
|
wait: Duration,
|
|
}
|
|
|
|
impl MemoryPort {
|
|
pub fn new(socket: PathBuf, wait: Duration) -> MemoryPort {
|
|
MemoryPort { socket, wait }
|
|
}
|
|
|
|
fn ask(&self, msg: Message) -> Result<Message, String> {
|
|
// Every error is format!("memoryd at {}: {e}; {UNAVAILABLE}", self.socket.display()).
|
|
// `UnixStream::connect(&self.socket)`, read and write timeouts of `self.wait`,
|
|
// `write_frame` an Envelope { v: PROTOCOL_VERSION, id: 1, final: true, msg }, then
|
|
// `read_frame`; Ok(its msg).
|
|
todo!()
|
|
}
|
|
}
|
|
|
|
impl MemorySource for MemoryPort {
|
|
fn block(&self) -> Result<String, String> {
|
|
// `self.ask(Message::MemoryBlock(Empty {}))?`: MemoryBlockReply(reply) -> Ok(reply.text);
|
|
// Error(e) -> Err(format!("memoryd: {}; {UNAVAILABLE}", e.detail)); anything else ->
|
|
// Err(format!("memoryd answered with the wrong message; {UNAVAILABLE}")).
|
|
todo!()
|
|
}
|
|
|
|
fn updated(&self, session: &SessionId) -> Result<(), String> {
|
|
// `self.ask(Message::SessionUpdated(SessionUpdated { session: session.clone() }))?`: Ok(_)
|
|
// -> Ok(()); Error(e) -> Err(format!("memoryd: {}", e.detail)); anything else ->
|
|
// Err("memoryd answered with the wrong message").
|
|
todo!()
|
|
}
|
|
}
|
|
|
|
pub const RECALL: &str = "recall";
|
|
pub const MEMORY: &str = "memory";
|
|
|
|
pub fn recall_schema() -> ToolSchema {
|
|
ToolSchema {
|
|
name: RECALL.to_string(),
|
|
description: "Search your memory: past conversations and notes. Each hit says where it \
|
|
came from: identity, memory, or memory-tainted (from a session that read \
|
|
untrusted content)."
|
|
.to_string(),
|
|
parameters: serde_json::json!({
|
|
"type": "object",
|
|
"properties": {
|
|
"query": { "type": "string", "description": "Words to search for." },
|
|
"k": { "type": "integer", "description": "How many hits, 1 to 10. Default 5." }
|
|
},
|
|
"required": ["query"]
|
|
}),
|
|
}
|
|
}
|
|
|
|
pub fn memory_schema() -> ToolSchema {
|
|
ToolSchema {
|
|
name: MEMORY.to_string(),
|
|
description: "Write memory. note: record something seen or told. add, replace, remove: \
|
|
edit memory.md (your work) or user.md (your owner); entries are named by \
|
|
their exact text. consolidate: rewrite a whole file, moving or dropping \
|
|
entries to notes. Takes effect in the next session."
|
|
.to_string(),
|
|
parameters: serde_json::json!({
|
|
"type": "object",
|
|
"properties": {
|
|
"action": { "type": "string", "enum": ["note", "add", "replace", "remove", "consolidate"] },
|
|
"file": { "type": "string", "enum": ["memory", "user"] },
|
|
"text": { "type": "string", "description": "The new entry, or the note." },
|
|
"old": { "type": "string", "description": "The exact text of the entry to replace or remove." },
|
|
"entries": {
|
|
"type": "array",
|
|
"description": "consolidate: every current entry once, as {old, keep: true}, {old, text}, {old, move: true} or {old, drop: true}; new entries as {text}.",
|
|
"items": { "type": "object" }
|
|
}
|
|
},
|
|
"required": ["action"]
|
|
}),
|
|
}
|
|
}
|