v1 plan: fix spread test config, queue test read, admin pin via lease.Candidates; note the findings

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
2026-09-25 04:29:16 -07:00
parent 29b3a5c38e
commit 1cc645a85b
3 changed files with 61 additions and 8 deletions
@@ -83,3 +83,12 @@ tools/run-plan.sh docs/plans/v1          # from a clean checkout on master
  hold. Ornith spent its first ten minutes puzzling over exactly that. Test fault (mine): the
  assertion now checks order and content (a pin event naming beta, followed later by a release),
  not positions.
+- 2026-09-25, before task 05 ran: a hand walk of the remaining given tests against the task rules
+  (which I should have done before handover) found two more faults of mine and one flake:
+  `TestDifferentConversationsSpreadByFreeSlots` assumed two conversations would both land on the
+  weight-2 host, but the scoring rule's tie-break sends the second to the other host — it now
+  uses a config where beta's weight is 10; `TestPinReleaseDrain` (admin) pins a route no request
+  has used, which `lease.Pin`'s "host must have been seen" rule refuses — task 06 now adds
+  `lease.Table.Candidates` and has the admin and `main` register configured hosts;
+  `TestQueueFullIs503` read the store right after the responses without the retry loop the
+  accounting test has. Task 05 restarted from a clean tree on the corrected files.