kyle/crossbar
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

v1 limiter test: release before reporting in TestParallelAndQueue (race with the final count check)

Browse Source 
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This commit is contained in:
kyle
2026-09-25 11:02:07 -07:00
co-authored by Claude Fable 5.1
parent 7710352462
commit 27debb9790
2 changed files with 6 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
docs/plans/v1/_files/internal/limiter/limiter_test.go
+1 -1
View File
@@ -32,10 +32,10 @@ func TestParallelAndQueue(t *testing.T) {
go func() { go func() {
rel, waited, err := l.Acquire(ctx, "alpha", "m") rel, waited, err := l.Acquire(ctx, "alpha", "m")
if err == nil { if err == nil {
defer rel()
if waited < 40*time.Millisecond { if waited < 40*time.Millisecond {
err = errors.New("third acquire did not wait") err = errors.New("third acquire did not wait")
} }
rel() // release before reporting, so the final count check cannot race it
} }
got3 <- err got3 <- err
}() }()
docs/plans/v2/README.md
+5
View File
@@ -82,3 +82,8 @@ reason.
per argv element, so check 3 could never pass. Test fault (mine): the body now goes through a per argv element, so check 3 could never pass. Test fault (mine): the body now goes through a
file (`-d @file`). Ornith diagnosed it correctly. Resumed from the working tree with the file (`-d @file`). Ornith diagnosed it correctly. Resumed from the working tree with the
corrected script. corrected script.
- 2026-09-25, task 05, third session: `TestParallelAndQueue` (v1 given `limiter_test.go`) failed
once under full-suite `-race` load with `after releases: inflight 1 queued 0`. Test fault
(mine): the third acquirer sent its result before its deferred release ran, so the final
count check could observe one slot still held. The given file now releases before reporting.
Ornith found it and measured the flake rate rather than editing the protected file.