kyle/crossbar
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

v1 plan: split task 06 into admin (06) and main wiring (07); smoke becomes 08; note the finding

Browse Source 
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This commit is contained in:
kyle
2026-09-25 06:07:53 -07:00
co-authored by Claude Fable 5.1
parent ebcf6e4536
commit 4da47b3dfa
4 changed files with 106 additions and 42 deletions
Download Patch File Download Diff File Expand all files Collapse all files
docs/plans/v1/README.md
+11 -4
View File
@@ -38,8 +38,9 @@ v1.59.0 (pure Go; `go.sum` given). No other module.
| 03 | `03-limiter-choose.md` | `internal/limiter`, `internal/choose` | `limiter_test.go`, `choose_test.go` |
| 04 | `04-lease.md` | `internal/lease`: the sticky table | `lease_test.go` |
| 05 | `05-proxy.md` | proxy v1: leases, queue, SSE tee, accounting, header route | `proxy_test.go` (replaces v0's) |
| 06 | `06-admin-main.md` | admin v1 (pin/release/drain/usage/metrics), `cmd/crossbar` wiring | `admin_test.go` (replaces), start/stop check |
| 07 | `07-smoke-readme.md` | `tools/smoke.sh` v1 run, README update | `make smoke` |
| 06 | `06-admin.md` | admin v1 (pin/release/drain/usage/metrics) | `admin_test.go` (replaces) |
| 07 | `07-main.md` | `cmd/crossbar` wiring, background loops | start/stop check |
| 08 | `08-smoke-readme.md` | `tools/smoke.sh` v1 run, README update | `make smoke` |
## For the owner: running a task
@@ -47,9 +48,9 @@ v1.59.0 (pure Go; `go.sum` given). No other module.
tools/run-plan.sh docs/plans/v1 # from a clean checkout on master
```
## For the reviewer: after task 07
## For the reviewer: after task 08
1. `git log --oneline master..v1`: seven commits with the trailer.
1. `git log --oneline master..v1`: eight task commits with the trailer (plus owner merges).
2. Copied files byte-identical to `_files/`; `git diff <merge-base>..v1 --stat -- PLAN.md AGENTS.md docs/plans` empty.
3. `make gate`, `make smoke`.
4. Read every source file against its task. Probe outside the tests: a lease whose host is
@@ -108,3 +109,9 @@ tools/run-plan.sh docs/plans/v1 # from a clean checkout on master
of stopping. Test-file fault (mine): the rig and fake-upstream scaffolding moved into
`helpers_test.go` (211 + 271 lines). Ornith's own `proxy.go` was also at 411 lines; splitting it
is part of the task as written.
- 2026-09-25, task 06, first session: 50 minutes, admin package never compiled (duplicate
`Handler`, re-reading the same files in a loop) while the store and lease additions it made
were correct. Too large a task for one session — the size lesson from boxmaker, mine to apply.
Split into `06-admin.md` (handler only; inherits the store/lease additions from the tree) and
`07-main.md` (wiring); the smoke task became 08. Session stopped by the owner; the broken
`admin.go` draft was left in the tree for the next session to replace.