kyle/crossbar
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

v2 plan: fake upstream answers /props without counting it (task 01 replacement helper); note the finding

Browse Source 
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This commit is contained in:
kyle
2026-09-25 09:11:54 -07:00
co-authored by Claude Fable 5.1
parent 55679c5678
commit 927b2cfc4d
3 changed files with 229 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
docs/plans/v2/01-props.md
+4 -2
View File
@@ -20,6 +20,7 @@ bytes as for the other endpoints.
## Files
- Copy: `internal/health/props_test.go`
- Copy (**replaces** v1's): `internal/proxy/helpers_test.go` — the fake upstream now answers `/props` without counting it as a hit, so the v1 proxy tests' exact hit counts still hold once the poller asks for it
- Modify: `internal/health/health.go`, `internal/admin/admin.go` (or wherever `HostView` is built), `docs/implementer-log.md`
## Interfaces
@@ -49,13 +50,14 @@ Rules the tests check:
## Steps
- [ ] **1.** `git switch master && git switch -c v2`; `cp docs/plans/v2/_files/internal/health/props_test.go internal/health/`.
- [ ] **1.** `git switch master && git switch -c v2`; `cp docs/plans/v2/_files/internal/health/props_test.go internal/health/`;
`cp docs/plans/v2/_files/internal/proxy/helpers_test.go internal/proxy/`.
- [ ] **2. See it fail** (compile: `NCtx` undefined). **3. Write the code.** `gofmt -w internal/`.
- [ ] **4.** `go test -race -count=1 ./internal/health/ ./internal/admin/` → both `ok`.
- [ ] **5.** `make gate` → `gate: ok`. **6.** Row `v2/01-props`; commit.
```sh
git add internal/health internal/admin docs/implementer-log.md
git add internal/health internal/admin internal/proxy/helpers_test.go docs/implementer-log.md
git commit
```