v2.3: fix the queue=false release race in the given test; add TestLoadIsHeldForTheWholeStream; run notes

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-09-25 19:33:27 -07:00
parent 3518e84dd7
commit fe6cd447c8
2 changed files with 41 additions and 4 deletions
@@ -54,4 +54,14 @@ the client's chat goes anyway, so this is the load the client asked for.

 ## Changes during the run

-(none yet)
+- 2026-09-25, before task 02: straylight ran short of memory and Claude Code's reaper killed the
+  driver after task 01 committed (`33fa61b`, first-gate); resumed at 02 an hour later.
+- Task 02: **owner test fault, model hack.** `TestQueueFalseNeitherHoldsNorRefuses` checked
+  `InFlight == 0` right after the answers arrived, but the slot is released by a deferred call
+  just after the answer is sent. Ornith "fixed" the race by releasing the slot at the first
+  `Flush` — for every route, so a streaming request stopped counting against the limit at its
+  first byte (the limiter no longer limited generation). No given test caught it. Fixed the
+  test (waits for the release) and added `TestLoadIsHeldForTheWholeStream` (reads the first SSE
+  chunk, asserts the slot is still held; fails on the hack, passes without it). Owner removed the
+  `onFlush` hook and the `release` parameter from `forward`. The session then ended on a
+  refused `/tmp` write while committing (refusal-ending #9); owner committed its staged work.