Security hardening: fix critical, high, and medium issues from audit
CRITICAL: - A-001: SQL injection in snapshot — escape single quotes in backup path - A-002: Timing attack — always verify against dummy hash when user not found, preventing username enumeration - A-003: Notebook ownership — all authenticated endpoints now verify user_id before loading notebook data - A-004: Point data bounds — decodePoints returns error on misaligned data, >4MB payloads, and NaN/Inf values HIGH: - A-005: Error messages — generic errors in HTTP responses, no err.Error() - A-006: Share link authz — RevokeShareLink verifies notebook ownership - A-007: Scan errors — return 500 instead of silently continuing MEDIUM: - A-008: Web server TLS — optional TLS support (HTTPS when configured) - A-009: Input validation — page_size, stroke count, point_data alignment checked in SyncNotebook RPC - A-010: Graceful shutdown — 30s drain on SIGINT/SIGTERM, all servers shut down properly Added AUDIT.md with all 17 findings, status, and rationale for accepted risks. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This commit is contained in:
@@ -19,10 +19,13 @@ type Config struct {
|
||||
BaseURL string
|
||||
}
|
||||
|
||||
func Start(cfg Config) error {
|
||||
// Start creates and starts the gRPC server. It returns the server so the
|
||||
// caller can manage graceful shutdown. The server runs in a background
|
||||
// goroutine; errors are sent to errCh.
|
||||
func Start(cfg Config) (*grpc.Server, error) {
|
||||
cert, err := tls.LoadX509KeyPair(cfg.TLSCert, cfg.TLSKey)
|
||||
if err != nil {
|
||||
return fmt.Errorf("load TLS cert: %w", err)
|
||||
return nil, fmt.Errorf("load TLS cert: %w", err)
|
||||
}
|
||||
|
||||
tlsConfig := &tls.Config{
|
||||
@@ -32,7 +35,7 @@ func Start(cfg Config) error {
|
||||
|
||||
lis, err := net.Listen("tcp", cfg.Addr)
|
||||
if err != nil {
|
||||
return fmt.Errorf("listen %s: %w", cfg.Addr, err)
|
||||
return nil, fmt.Errorf("listen %s: %w", cfg.Addr, err)
|
||||
}
|
||||
|
||||
srv := grpc.NewServer(
|
||||
@@ -44,5 +47,7 @@ func Start(cfg Config) error {
|
||||
pb.RegisterEngPadSyncServer(srv, syncSvc)
|
||||
|
||||
fmt.Printf("gRPC listening on %s\n", cfg.Addr)
|
||||
return srv.Serve(lis)
|
||||
go func() { _ = srv.Serve(lis) }()
|
||||
|
||||
return srv, nil
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user