CRITICAL: - A-001: SQL injection in snapshot — escape single quotes in backup path - A-002: Timing attack — always verify against dummy hash when user not found, preventing username enumeration - A-003: Notebook ownership — all authenticated endpoints now verify user_id before loading notebook data - A-004: Point data bounds — decodePoints returns error on misaligned data, >4MB payloads, and NaN/Inf values HIGH: - A-005: Error messages — generic errors in HTTP responses, no err.Error() - A-006: Share link authz — RevokeShareLink verifies notebook ownership - A-007: Scan errors — return 500 instead of silently continuing MEDIUM: - A-008: Web server TLS — optional TLS support (HTTPS when configured) - A-009: Input validation — page_size, stroke count, point_data alignment checked in SyncNotebook RPC - A-010: Graceful shutdown — 30s drain on SIGINT/SIGTERM, all servers shut down properly Added AUDIT.md with all 17 findings, status, and rationale for accepted risks. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
171 lines
3.5 KiB
Go
171 lines
3.5 KiB
Go
package render
|
|
|
|
import (
|
|
"encoding/binary"
|
|
"math"
|
|
"strings"
|
|
"testing"
|
|
)
|
|
|
|
func makePointData(points ...float32) []byte {
|
|
data := make([]byte, len(points)*4)
|
|
for i, p := range points {
|
|
binary.LittleEndian.PutUint32(data[i*4:], math.Float32bits(p))
|
|
}
|
|
return data
|
|
}
|
|
|
|
func TestRenderSVG(t *testing.T) {
|
|
strokes := []Stroke{
|
|
{
|
|
PenSize: 4.49,
|
|
Color: -16777216, // 0xFF000000 (black)
|
|
Style: "plain",
|
|
PointData: makePointData(100, 200, 300, 400),
|
|
},
|
|
}
|
|
|
|
svg, err := RenderSVG("REGULAR", strokes)
|
|
if err != nil {
|
|
t.Fatalf("render: %v", err)
|
|
}
|
|
|
|
if !strings.Contains(svg, "<svg") {
|
|
t.Fatal("expected SVG element")
|
|
}
|
|
if !strings.Contains(svg, "viewBox") {
|
|
t.Fatal("expected viewBox")
|
|
}
|
|
if !strings.Contains(svg, "<path") {
|
|
t.Fatal("expected path element")
|
|
}
|
|
if !strings.Contains(svg, `stroke="black"`) {
|
|
t.Fatal("expected black stroke")
|
|
}
|
|
}
|
|
|
|
func TestRenderSVGDashed(t *testing.T) {
|
|
strokes := []Stroke{
|
|
{
|
|
PenSize: 4.49,
|
|
Color: -16777216,
|
|
Style: "dashed",
|
|
PointData: makePointData(100, 200, 300, 400),
|
|
},
|
|
}
|
|
|
|
svg, err := RenderSVG("REGULAR", strokes)
|
|
if err != nil {
|
|
t.Fatalf("render: %v", err)
|
|
}
|
|
if !strings.Contains(svg, "stroke-dasharray") {
|
|
t.Fatal("expected stroke-dasharray for dashed line")
|
|
}
|
|
}
|
|
|
|
func TestRenderSVGArrow(t *testing.T) {
|
|
strokes := []Stroke{
|
|
{
|
|
PenSize: 4.49,
|
|
Color: -16777216,
|
|
Style: "arrow",
|
|
PointData: makePointData(100, 200, 500, 200),
|
|
},
|
|
}
|
|
|
|
svg, err := RenderSVG("REGULAR", strokes)
|
|
if err != nil {
|
|
t.Fatalf("render: %v", err)
|
|
}
|
|
if !strings.Contains(svg, "<line") {
|
|
t.Fatal("expected arrow head lines")
|
|
}
|
|
}
|
|
|
|
func TestRenderJPG(t *testing.T) {
|
|
strokes := []Stroke{
|
|
{
|
|
PenSize: 4.49,
|
|
Color: -16777216,
|
|
Style: "plain",
|
|
PointData: makePointData(100, 200, 300, 400),
|
|
},
|
|
}
|
|
|
|
data, err := RenderJPG("REGULAR", strokes, 90)
|
|
if err != nil {
|
|
t.Fatalf("render: %v", err)
|
|
}
|
|
if len(data) == 0 {
|
|
t.Fatal("expected non-empty JPG")
|
|
}
|
|
// Check JPEG magic bytes
|
|
if data[0] != 0xFF || data[1] != 0xD8 {
|
|
t.Fatal("expected JPEG magic bytes")
|
|
}
|
|
}
|
|
|
|
func TestRenderPDF(t *testing.T) {
|
|
pages := []Page{
|
|
{
|
|
PageNumber: 1,
|
|
Strokes: []Stroke{
|
|
{
|
|
PenSize: 4.49,
|
|
Color: -16777216,
|
|
Style: "plain",
|
|
PointData: makePointData(100, 200, 300, 400),
|
|
},
|
|
},
|
|
},
|
|
}
|
|
|
|
data, err := RenderPDF("REGULAR", pages)
|
|
if err != nil {
|
|
t.Fatalf("render: %v", err)
|
|
}
|
|
if len(data) == 0 {
|
|
t.Fatal("expected non-empty PDF")
|
|
}
|
|
if !strings.HasPrefix(string(data), "%PDF") {
|
|
t.Fatal("expected PDF header")
|
|
}
|
|
}
|
|
|
|
func TestPageSizePt(t *testing.T) {
|
|
w, h := PageSizePt("REGULAR")
|
|
if int(w) != 612 || int(h) != 792 {
|
|
t.Fatalf("REGULAR: got %v x %v, want 612 x 792", w, h)
|
|
}
|
|
w, h = PageSizePt("LARGE")
|
|
if int(w) != 792 || int(h) != 1224 {
|
|
t.Fatalf("LARGE: got %v x %v, want 792 x 1224", w, h)
|
|
}
|
|
}
|
|
|
|
func TestDecodePointsInvalidLength(t *testing.T) {
|
|
// Not a multiple of 4
|
|
data := []byte{1, 2, 3}
|
|
_, err := decodePoints(data)
|
|
if err == nil {
|
|
t.Fatal("expected error for non-multiple-of-4 data")
|
|
}
|
|
}
|
|
|
|
func TestDecodePointsNaN(t *testing.T) {
|
|
data := make([]byte, 4)
|
|
binary.LittleEndian.PutUint32(data, math.Float32bits(float32(math.NaN())))
|
|
_, err := decodePoints(data)
|
|
if err == nil {
|
|
t.Fatal("expected error for NaN point data")
|
|
}
|
|
}
|
|
|
|
func TestDecodePointsOversize(t *testing.T) {
|
|
data := make([]byte, maxPointDataSize+4)
|
|
_, err := decodePoints(data)
|
|
if err == nil {
|
|
t.Fatal("expected error for oversized point data")
|
|
}
|
|
}
|