Compare commits

...

2 Commits

Author SHA1 Message Date
fb1b1ffcad Update CHANGELOG for v1.15.4. 2025-11-19 02:57:40 -08:00
7bb6973341 QoL for CSR generation. 2025-11-19 02:57:26 -08:00
5 changed files with 42 additions and 12 deletions

View File

@@ -1,5 +1,8 @@
CHANGELOG CHANGELOG
v1.15.4 - 2025-11-19
Quality of life fixes for CSR generation.
v1.15.3 - 2025-11-19 v1.15.3 - 2025-11-19
Minor bug fixes. Minor bug fixes.

View File

@@ -63,12 +63,7 @@ type CertificateRequest struct {
Profile Profile `yaml:"profile"` Profile Profile `yaml:"profile"`
} }
func (cs CertificateRequest) Generate() (crypto.PrivateKey, *x509.CertificateRequest, error) { func (cs CertificateRequest) Request(priv crypto.PrivateKey) (*x509.CertificateRequest, error) {
pub, priv, err := cs.KeySpec.Generate()
if err != nil {
return nil, nil, err
}
subject := pkix.Name{} subject := pkix.Name{}
subject.CommonName = cs.Subject.CommonName subject.CommonName = cs.Subject.CommonName
subject.Country = []string{cs.Subject.Country} subject.Country = []string{cs.Subject.Country}
@@ -81,13 +76,13 @@ func (cs CertificateRequest) Generate() (crypto.PrivateKey, *x509.CertificateReq
for i, ip := range cs.Subject.IPAddresses { for i, ip := range cs.Subject.IPAddresses {
ipAddresses = append(ipAddresses, net.ParseIP(ip)) ipAddresses = append(ipAddresses, net.ParseIP(ip))
if ipAddresses[i] == nil { if ipAddresses[i] == nil {
return nil, nil, fmt.Errorf("invalid IP address: %s", ip) return nil, fmt.Errorf("invalid IP address: %s", ip)
} }
} }
req := &x509.CertificateRequest{ req := &x509.CertificateRequest{
PublicKeyAlgorithm: 0, PublicKeyAlgorithm: 0,
PublicKey: pub, PublicKey: getPublic(priv),
Subject: subject, Subject: subject,
DNSNames: cs.Subject.DNSNames, DNSNames: cs.Subject.DNSNames,
IPAddresses: ipAddresses, IPAddresses: ipAddresses,
@@ -95,12 +90,26 @@ func (cs CertificateRequest) Generate() (crypto.PrivateKey, *x509.CertificateReq
reqBytes, err := x509.CreateCertificateRequest(rand.Reader, req, priv) reqBytes, err := x509.CreateCertificateRequest(rand.Reader, req, priv)
if err != nil { if err != nil {
return nil, nil, fmt.Errorf("failed to create certificate request: %w", err) return nil, fmt.Errorf("failed to create certificate request: %w", err)
} }
req, err = x509.ParseCertificateRequest(reqBytes) req, err = x509.ParseCertificateRequest(reqBytes)
if err != nil { if err != nil {
return nil, nil, fmt.Errorf("failed to parse certificate request: %w", err) return nil, fmt.Errorf("failed to parse certificate request: %w", err)
}
return req, nil
}
func (cs CertificateRequest) Generate() (crypto.PrivateKey, *x509.CertificateRequest, error) {
_, priv, err := cs.KeySpec.Generate()
if err != nil {
return nil, nil, err
}
req, err := cs.Request(priv)
if err != nil {
return nil, nil, err
} }
return priv, req, nil return priv, req, nil

View File

@@ -71,3 +71,16 @@ func GenerateKey(algorithm x509.PublicKeyAlgorithm, bitSize int) (crypto.PublicK
return pub, key, nil return pub, key, nil
} }
func getPublic(priv crypto.PrivateKey) crypto.PublicKey {
switch priv := priv.(type) {
case *rsa.PrivateKey:
return &priv.PublicKey
case *ecdsa.PrivateKey:
return &priv.PublicKey
case *ed25519.PrivateKey:
return priv.Public()
default:
return nil
}
}

View File

@@ -131,3 +131,7 @@ func LoadCSR(path string) (*x509.CertificateRequest, error) {
req, _, err := ParseCSR(in) req, _, err := ParseCSR(in)
return req, err return req, err
} }
func ExportCSRAsPEM(req *x509.CertificateRequest) []byte {
return pem.EncodeToMemory(&pem.Block{Type: pemTypeCertificateRequest, Bytes: req.Raw})
}

View File

@@ -77,6 +77,7 @@ var DelegationExtension = pkix.Extension{
const ( const (
pemTypeCertificate = "CERTIFICATE" pemTypeCertificate = "CERTIFICATE"
pemTypeCertificateRequest = "CERTIFICATE REQUEST"
pemTypePrivateKey = "PRIVATE KEY" pemTypePrivateKey = "PRIVATE KEY"
) )