Remove Buffer::Rows() and the Line wrapper

Browse Source

The row cache rebuilt a string for every line of the file after each edit
and had one production caller left (filetype detection in the ImGui
frontend, which needs only the first line). Removed with it: rows_,
nrows_, the dirty flag set on every edit, ensure_rows_cache and a mutex
guarding only that cache. Tests read lines with GetLineString, Nrows or,
where they compare every line, a test-only LinesForTests().

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_015rcVQiiWyTzoNrsvLSaAfB

...

This commit is contained in:

Claude

2026-09-24 12:19:59 -07:00

committed by Kyle Isom

parent 7dae9cc305

commit 29d0ee8244

16 changed files with 262 additions and 496 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download Patch File Download Diff File Expand all files Collapse all files

tests/test_undo.cc

+210 -210

File diff suppressed because it is too large Load Diff