Undo: hold large texts as storage spans; byte budget with pruning

- Undo texts of 4 KiB or more (Insert/Paste from the buffer, Delete from
  the spans the piece table remembers for its last large deletion) are
  held as TextSpan references into the piece table's append-only
  storage, after checking they hold exactly the recorded bytes. Undo and
  redo insert them with Buffer::insert_spans, which adds pieces over the
  stored bytes instead of copying them into storage again (the journal
  still gets the bytes, as one record). A replace-all session on a 26 MB
  file peaks at 181 MB instead of 332 MB; undo/redo cycles of a 6.6 MB
  kill no longer grow memory by 6.6 MB each.
- UndoSystem keeps a byte budget (default max(64 MiB, twice the buffer
  size); SetByteBudget). Over it, history is pruned to 75% of the budget:
  branches off the current path, then the oldest edits (an undo group
  goes whole, and never the current state's group), then the redo line.
  When the saved state is dropped the buffer stays modified until saved.
- replace_all_bytes clears undo history, which was recorded against (and
  may reference the storage of) the previous content.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_015rcVQiiWyTzoNrsvLSaAfB
This commit is contained in:
Claude
2026-09-24 09:16:04 -07:00
committed by Kyle Isom
parent 7165bb286b
commit 404b983009
11 changed files with 687 additions and 29 deletions
+30
View File
@@ -90,6 +90,21 @@ public:
void UpdateBufferReference(Buffer &new_buf);
// History memory budget in bytes (node texts, spans and nodes). When
// committed history exceeds it, branches off the current path and then
// the oldest edits are dropped. 0 (the default) means max(64 MiB, twice
// the buffer's size).
void SetByteBudget(std::size_t bytes)
{
budget_ = bytes;
}
[[nodiscard]] std::size_t HistoryBytes() const
{
return bytes_;
}
#if defined(KTE_TESTS)
// Test-only introspection hook.
const UndoTree &TreeForTests() const
@@ -119,6 +134,21 @@ private:
void update_dirty_flag();
// Hold a large committed text as storage spans (see UndoNode::spans).
void try_convert_to_spans(UndoNode *node);
// Enforce the byte budget (outside groups).
void maybe_prune();
void prune_to(std::size_t target);
// The saved state's node is being dropped: no state in history matches
// the file any more.
void forget_saved_state();
std::size_t bytes_ = 0; // approximate bytes held by committed history
std::size_t budget_ = 0;
PendingAppendMode pending_mode_ = PendingAppendMode::Append;
std::uint64_t active_group_id_ = 0;