Fix review findings in the regex engine, search count and journal v2
- PCRE2: compile with the ANYCRLF newline convention and DOLLAR_ENDONLY,
as ECMAScript reads '.' and '$'. With PCRE2's default (LF only) '.'
matched the CR of a CRLF line, so regex replace-all deleted CRs.
- Replacement $0 is the whole match, two digits are read greedily and a
group the pattern lacks expands to nothing, as std::regex_replace
(libstdc++) does; these cases are now compared in the tests.
- Plain search visits overlapping matches going forward too, and counts
them, as the backward search found them ('aa' in 'aaa' read 2/1).
- The recovery prompt's replayed content is used on 'y' only if the
journal is unchanged since; otherwise it is replayed again.
- A version 1 journal continued after recovery is rewritten as a
compacted version 2 journal when it needs a chunked checkpoint,
instead of receiving records an older kte would skip. (The version is
read through a separate descriptor: the journal fd is write-only.)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_015rcVQiiWyTzoNrsvLSaAfB
This commit is contained in:
@@ -721,6 +721,7 @@ private:
|
||||
// produced it: "y" installs it instead of replaying the journal again.
|
||||
std::string pending_recovery_content_;
|
||||
std::uint64_t pending_recovery_valid_bytes_ = 0;
|
||||
std::uint64_t pending_recovery_swap_size_ = 0; // the journal's size then
|
||||
bool pending_recovery_have_content_ = false;
|
||||
|
||||
// GUI-only state (safe no-op in terminal builds)
|
||||
|
||||
Reference in New Issue
Block a user