kyle/kte
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

TerminalRenderer: restart the span cursor on any backward lookup

Browse Source 
The restart test compared against the previous span's start, so a lookup
that moved back into an earlier span returned the default kind. Not
reachable today (drawing only moves forward); found in review.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_015rcVQiiWyTzoNrsvLSaAfB
This commit is contained in:
Claude
2026-09-24 12:19:59 -07:00
committed by Kyle Isom
parent 8f9a99899b
commit e1ebf5900b
1 changed files with 5 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
TerminalRenderer.cc
+5 -3
View File
@@ -170,11 +170,13 @@ TerminalRenderer::Draw(Editor &ed)
// Called left to right while drawing: walk the spans with a // Called left to right while drawing: walk the spans with a
// cursor (rescanning from the first span for every byte was // cursor (rescanning from the first span for every byte was
// quadratic on long highlighted lines). // quadratic on long highlighted lines).
std::size_t span_i = 0; std::size_t span_i = 0;
int last_token_si = -1;
auto token_at = [&](std::size_t src_index) -> kte::TokenKind { auto token_at = [&](std::size_t src_index) -> kte::TokenKind {
const int si = static_cast<int>(src_index); const int si = static_cast<int>(src_index);
if (span_i > 0 && span_i <= sane_spans.size() && si < sane_spans[span_i - 1].col_start) if (si < last_token_si)
span_i = 0; // moved backwards: restart span_i = 0; // asked about an earlier byte: restart
last_token_si = si;
while (span_i < sane_spans.size() && sane_spans[span_i].col_end <= si) while (span_i < sane_spans.size() && sane_spans[span_i].col_end <= si)
++span_i; ++span_i;
if (span_i < sane_spans.size() && sane_spans[span_i].col_start <= si) if (span_i < sane_spans.size() && sane_spans[span_i].col_start <= si)