kyle/sift
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

p5a: split task 06 (too large: looped 3h) into 06-api-pdf and 07-api-cache-pages; old 07 is 08

Browse Source 
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
kyle
2026-09-26 03:12:07 -07:00
co-authored by Claude Opus 5.5
parent 6a3b6dab71
commit 5ce625be33
5 changed files with 271 additions and 155 deletions
Download Patch File Download Diff File Expand all files Collapse all files
docs/plans/p5a/README.md
+17 -3
View File
@@ -14,10 +14,11 @@ vendored by the owner before the run.
| 03-dcache | `internal/dcache` | `dcache/pdf_test.go` |
| 04-pdfpool | `internal/pdfpool` | `pdfpool/pdfpool_test.go` |
| 05-pdfdoc | `internal/pdfdoc` | `pdfdoc/pdfdoc_test.go` |
| 06-api | `internal/api` | `api/pdf_test.go` |
| 07-digest-cli-docs | `internal/digest`, `internal/metrics`, `cmd/sift`, `internal/api` (metric calls), `skill/`, `nix/module.nix`, `README.md` | `digest/pages_test.go`, `metrics/pdf_test.go` |
| 06-api-pdf | `internal/api` (+ one field in `internal/fetch`) | `api/pdf_test.go` |
| 07-api-cache-pages | `internal/api` | (same file; its last 3 tests) |
| 08-digest-cli-docs | `internal/digest`, `internal/metrics`, `cmd/sift`, `internal/api` (metric calls), `skill/`, `nix/module.nix`, `README.md` | `digest/pages_test.go`, `metrics/pdf_test.go` |
**Order matters:** 05 imports 02's types; 06 uses 01–05; 07 wires metrics into 06's file.
**Order matters:** 05 imports 02's types; 06 and 07 use 01–05; 08 wires metrics into 06/07's file.
**How this plan was made:** acceptance tests first, no reference implementation. The given tests
compiled against a panic-only skeleton of every new name, on this repository at the plan
@@ -50,3 +51,16 @@ reaches orion until the owner's review, the merge, and straylight's pin bump.
implementation done but debug prints in `pdf.go` and a `zz_debug_test.go`. Owner fixed the test
(copy the slice under the lock, release before the next request), removed the debug scaffolding,
and resumed the session to finish and commit.
- 2026-09-26, task 06 (the original, API integration in one task): **owner sizing fault.** The
session looped for 3 h 13 min (731 KB log, repeated context compaction, false beliefs about
the tree: "the given test is committed", "the child is /bin/true") without a compiling
`pdf.go`. It is the same failure as crossbar v1/06: one task spanning detection, pool,
errors, rendering, cache, pages, grep, digest and scrape. Killed by pid. Split into
**06-api-pdf** (detection, extraction under the pool, errors, full text/map, scrape; 7 of the
10 given tests) and **07-api-cache-pages** (cache and revalidation, pages, grep, the question
limit; the other 3). The old 07 is now 08. Both task texts state the exact API of tasks 01–05,
so the model need not re-read five packages. The working tree was reset: the draft
`pdf.go`, the `api.go` hooks and a `fetch.Error.RetryAfter` field that was outside the task's
files (task 06 now allows exactly that field).
- 2026-09-26, the given test's gate note: task 06 ends with `make gate` red on exactly the three
task-07 tests (the pattern crossbar v2.2 used); the gate runs green after 07.