sc/sgard
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Step 8: Polish — lint, clock abstraction, e2e test.

Browse Source 
- golangci-lint config with errcheck, govet, staticcheck, errorlint
- Fix all lint issues (unchecked error returns in cleanup paths, De Morgan)
- Inject jonboulle/clockwork into Garden for deterministic timestamps
- Add manifest.NewWithTime() for clock-aware initialization
- E2e lifecycle test: init → add → checkpoint → modify → status → restore → verify
- Update CLAUDE.md, PROJECT_PLAN.md, PROGRESS.md

Phase 1 (local) is now complete. All 9 CLI commands implemented and tested.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This commit is contained in:
Kyle Isom
2026-03-23 22:03:53 -07:00
parent 08e24b44e0
commit d1a6e533a4
11 changed files with 200 additions and 37 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
garden/garden_test.go
View File

@@ -321,7 +321,7 @@ func TestCheckpointMissingFileSkipped(t *testing.T) {
}
// Remove the file before checkpoint.
os.Remove(testFile)
_ = os.Remove(testFile)
// Checkpoint should not fail.
if err := g.Checkpoint(""); err != nil {
@@ -360,7 +360,7 @@ func TestStatusReportsCorrectly(t *testing.T) {
if err := os.WriteFile(modFile, []byte("changed"), 0o644); err != nil {
t.Fatalf("modifying file: %v", err)
}
os.Remove(missingFile)
_ = os.Remove(missingFile)
statuses, err := g.Status()
if err != nil {
@@ -412,7 +412,7 @@ func TestRestoreFile(t *testing.T) {
}
// Delete the file, then restore it.
os.Remove(testFile)
_ = os.Remove(testFile)
if err := g.Restore(nil, true, nil); err != nil {
t.Fatalf("Restore: %v", err)
@@ -445,7 +445,7 @@ func TestRestorePermissions(t *testing.T) {
t.Fatalf("Add: %v", err)
}
os.Remove(testFile)
_ = os.Remove(testFile)
if err := g.Restore(nil, true, nil); err != nil {
t.Fatalf("Restore: %v", err)
@@ -482,7 +482,7 @@ func TestRestoreSymlink(t *testing.T) {
t.Fatalf("Add: %v", err)
}
os.Remove(link)
_ = os.Remove(link)
if err := g.Restore(nil, true, nil); err != nil {
t.Fatalf("Restore: %v", err)
@@ -520,7 +520,7 @@ func TestRestoreCreatesParentDirs(t *testing.T) {
}
// Remove the entire directory tree.
os.RemoveAll(filepath.Join(root, "a"))
_ = os.RemoveAll(filepath.Join(root, "a"))
if err := g.Restore(nil, true, nil); err != nil {
t.Fatalf("Restore: %v", err)
@@ -557,8 +557,8 @@ func TestRestoreSelectivePaths(t *testing.T) {
t.Fatalf("Add: %v", err)
}
os.Remove(file1)
os.Remove(file2)
_ = os.Remove(file1)
_ = os.Remove(file2)
// Restore only file1.
if err := g.Restore([]string{file1}, true, nil); err != nil {