kyle/crossbar
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

v2.3 review: drop a duplicate logIdentityMode call; README wording; review notes

Browse Source 
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
kyle
2026-09-25 20:17:03 -07:00
co-authored by Claude Opus 5.5
parent 7a12ddcf5a
commit 9ff38dfe4e
3 changed files with 12 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
README.md
+1 -1
View File
@@ -111,7 +111,7 @@ curl -H 'X-Crossbar-Route: opencode-a' \
Some clients connect to one crossbar address and manage a llama-server slot themselves: they pin Some clients connect to one crossbar address and manage a llama-server slot themselves: they pin
`id_slot`, poll `/slots`, and steer a running completion through `id_slot`, poll `/slots`, and steer a running completion through
`/v1/chat/completions/control`. `inferproxy`, Boxmaker's router, is one. crossbar serves such a `/v1/chat/completions/control`. Boxmaker's `inferproxy` is one. crossbar serves such a
client from a route that has its own `listen` address and `affinity = "route"`, so the whole route client from a route that has its own `listen` address and `affinity = "route"`, so the whole route
lives on one host: lives on one host:
cmd/crossbar/main.go
-1
View File
@@ -98,7 +98,6 @@ func run() error {
// Identity: gate the proxy on the route's peers when a backend is // Identity: gate the proxy on the route's peers when a backend is
// configured; off leaves the proxy unwrapped. The same checker gates each // configured; off leaves the proxy unwrapped. The same checker gates each
// route's dedicated listener. // route's dedicated listener.
logIdentityMode(log, cfg.Identity)
var checker *identity.Checker var checker *identity.Checker
if cfg.Identity != "off" { if cfg.Identity != "off" {
docs/implementer-log.md
+11
View File
@@ -112,3 +112,14 @@ it; (b) task — the task text did not state that `httputil.ReverseProxy` aborts
test design — timing-based tests (limiter, queue, spread, cancel) have margins tuned for an idle test design — timing-based tests (limiter, queue, spread, cancel) have margins tuned for an idle
host; widen or retry in a later plan. host; widen or retry in a later plan.
### v2.3 review (owner, 2026-09-25)
Checked: gate, `-race -count=3` on proxy and limiter, smoke (check 6: dedicated listener). Task 01
clean (nit: the Debug log block copies the Info block's fields). Task 02: release-on-first-flush
reverted by the owner (limiter stopped limiting streams; cause was the owner's racy given test,
now fixed, with `TestLoadIsHeldForTheWholeStream`). Task 03: correct; `main.go` called
`logIdentityMode` twice (removed). Task 04: stopped correctly on the owner's missed v2.1 router
test; resumed after the replacement. README: "Boxmaker's router" → "Boxmaker's `inferproxy`".
Model faults this plan: one timing hack (logged as a deviation), one refusal-ending, one
malformed tool call ending a session with no change. Owner faults: racy test, missed router test.