28 lines
1.4 KiB
Markdown
28 lines
1.4 KiB
Markdown
# v1.1 implementation plan: review follow-ups
|
|
|
|
> **For the implementing model:** do not work from this file. The owner gives you one task file at
|
|
> a time. This file is the index for the owner and the reviewer.
|
|
|
|
**Goal:** close findings 1 and 2 of the v1 review (`docs/implementer-log.md`): a request whose
|
|
client disconnects — mid-stream or while queued — must still write its accounting row (status
|
|
499), and `/_crossbar/usage` with no rows must answer `[]`, not `null`.
|
|
|
|
**How this plan was made:** acceptance tests first, from the findings; no reference
|
|
implementation. Both given tests were run against `master` at the merge of `v1`: all three fail
|
|
there (the two cancel tests find no 499 row; the empty-usage test gets `null`).
|
|
|
|
## Tasks
|
|
|
|
| # | File | Delivers | Tests that define it |
|
|
|---|---|---|---|
|
|
| 01 | `01-review-fixes.md` | 499 rows on both cancel paths; `[]` for empty usage | `internal/proxy/cancel_test.go`, `internal/admin/usage_empty_test.go` |
|
|
|
|
Branch `v1.1`. One task, one fresh OpenCode session, one commit.
|
|
|
|
## For the reviewer
|
|
|
|
1. `git log --oneline master..v1.1`: one commit with the trailer.
|
|
2. `cmp` both copied tests; `git diff master..v1.1 --stat -- PLAN.md AGENTS.md docs/plans` empty.
|
|
3. `make gate`, `make smoke`.
|
|
4. Probe: cut a stream with `curl -m 0.4 -N …` against the smoke rig and confirm one `status="499"` line in `/_crossbar/metrics`.
|