Compare commits
16 Commits
| Author | SHA1 | Date | |
|---|---|---|---|
| 37472c71ec | |||
| 5ff4b2ed3e | |||
| ab2f9918f3 | |||
| d2b53601e2 | |||
| 78b9345799 | |||
| 495183ebd2 | |||
| 998b1b9817 | |||
| dc2cf4c0a6 | |||
| f6c4a5ab34 | |||
| 35ef74910d | |||
| b17672d440 | |||
| cb1d16ebbc | |||
| cbbde43dc2 | |||
| 45b2b88623 | |||
| 389dcf9cc7 | |||
| c98d9e717a |
3
.idea/codeStyles/Project.xml
generated
3
.idea/codeStyles/Project.xml
generated
@@ -141,6 +141,9 @@
|
||||
<pair source="c++m" header="" fileNamingConvention="NONE" />
|
||||
</extensions>
|
||||
</files>
|
||||
<codeStyleSettings language="Markdown">
|
||||
<option name="RIGHT_MARGIN" value="72" />
|
||||
</codeStyleSettings>
|
||||
<codeStyleSettings language="ObjectiveC">
|
||||
<indentOptions>
|
||||
<option name="INDENT_SIZE" value="8" />
|
||||
|
||||
@@ -1,8 +1,7 @@
|
||||
/*
|
||||
* AppendBuffer.h - selector header to choose GapBuffer or PieceTable
|
||||
*/
|
||||
#ifndef KTE_APPENDBUFFER_H
|
||||
#define KTE_APPENDBUFFER_H
|
||||
#pragma once
|
||||
|
||||
#ifdef KTE_USE_PIECE_TABLE
|
||||
#include "PieceTable.h"
|
||||
@@ -10,6 +9,4 @@ using AppendBuffer = PieceTable;
|
||||
#else
|
||||
#include "GapBuffer.h"
|
||||
using AppendBuffer = GapBuffer;
|
||||
#endif
|
||||
|
||||
#endif // KTE_APPENDBUFFER_H
|
||||
#endif
|
||||
21
Buffer.h
21
Buffer.h
@@ -1,8 +1,7 @@
|
||||
/*
|
||||
* Buffer.h - editor buffer representing an open document
|
||||
*/
|
||||
#ifndef KTE_BUFFER_H
|
||||
#define KTE_BUFFER_H
|
||||
#pragma once
|
||||
|
||||
#include <cstddef>
|
||||
#include <memory>
|
||||
@@ -17,6 +16,11 @@
|
||||
#include "syntax/HighlighterEngine.h"
|
||||
#include "Highlight.h"
|
||||
|
||||
// Forward declaration for swap journal integration
|
||||
namespace kte {
|
||||
class SwapRecorder;
|
||||
}
|
||||
|
||||
|
||||
class Buffer {
|
||||
public:
|
||||
@@ -424,6 +428,13 @@ public:
|
||||
}
|
||||
|
||||
|
||||
// Swap journal integration (set by Editor)
|
||||
void SetSwapRecorder(kte::SwapRecorder *rec)
|
||||
{
|
||||
swap_rec_ = rec;
|
||||
}
|
||||
|
||||
|
||||
// Raw, low-level editing APIs used by UndoSystem apply().
|
||||
// These must NOT trigger undo recording. They also do not move the cursor.
|
||||
void insert_text(int row, int col, std::string_view text);
|
||||
@@ -466,6 +477,6 @@ private:
|
||||
bool syntax_enabled_ = true;
|
||||
std::string filetype_;
|
||||
std::unique_ptr<kte::HighlighterEngine> highlighter_;
|
||||
};
|
||||
|
||||
#endif // KTE_BUFFER_H
|
||||
// Non-owning pointer to swap recorder managed by Editor/SwapManager
|
||||
kte::SwapRecorder *swap_rec_ = nullptr;
|
||||
};
|
||||
@@ -3,8 +3,8 @@ project(kte)
|
||||
|
||||
include(GNUInstallDirs)
|
||||
|
||||
set(CMAKE_CXX_STANDARD 17)
|
||||
set(KTE_VERSION "1.3.0")
|
||||
set(CMAKE_CXX_STANDARD 20)
|
||||
set(KTE_VERSION "1.3.9")
|
||||
|
||||
# Default to terminal-only build to avoid SDL/OpenGL dependency by default.
|
||||
# Enable with -DBUILD_GUI=ON when SDL2/OpenGL/Freetype are available.
|
||||
@@ -15,6 +15,16 @@ set(KTE_FONT_SIZE "18.0" CACHE STRING "Default font size for GUI")
|
||||
option(KTE_UNDO_DEBUG "Enable undo instrumentation logs" OFF)
|
||||
option(KTE_ENABLE_TREESITTER "Enable optional Tree-sitter highlighter adapter" OFF)
|
||||
|
||||
# Optionally enable AddressSanitizer (ASan)
|
||||
option(ENABLE_ASAN "Enable AddressSanitizer for builds" OFF)
|
||||
|
||||
if (ENABLE_ASAN)
|
||||
message(STATUS "ASan enabled")
|
||||
set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -fsanitize=address -fno-omit-frame-pointer")
|
||||
# Ensure the sanitizer is linked too (especially important on some platforms)
|
||||
set(CMAKE_EXE_LINKER_FLAGS "${CMAKE_EXE_LINKER_FLAGS} -fsanitize=address")
|
||||
endif ()
|
||||
|
||||
if (CMAKE_HOST_UNIX)
|
||||
message(STATUS "Build system is POSIX.")
|
||||
else ()
|
||||
@@ -22,25 +32,23 @@ else ()
|
||||
endif ()
|
||||
|
||||
add_compile_options(
|
||||
"-static"
|
||||
"-Wall"
|
||||
"-Wextra"
|
||||
"-Werror"
|
||||
"-Wno-unused-function"
|
||||
"-Wno-unused-parameter"
|
||||
"-g"
|
||||
"$<$<CONFIG:RELEASE>:-O2>"
|
||||
|
||||
)
|
||||
|
||||
if (MSVC)
|
||||
add_compile_options("/W4" "$<$<CONFIG:RELEASE>:/O2>")
|
||||
else ()
|
||||
add_compile_options(
|
||||
"-static"
|
||||
"-Wall"
|
||||
"-Wextra"
|
||||
"-Werror"
|
||||
"-pedantic"
|
||||
"-Wno-unused-function"
|
||||
"-Wno-unused-parameter"
|
||||
"$<$<CONFIG:RELEASE>:-O2>"
|
||||
"$<$<CONFIG:DEBUG>:-g>"
|
||||
"$<$<CONFIG:RELEASE>:-O2>")
|
||||
)
|
||||
if ("${CMAKE_CXX_COMPILER_ID}" STREQUAL "Clang")
|
||||
add_compile_options("-stdlib=libc++")
|
||||
else ()
|
||||
@@ -110,6 +118,7 @@ set(COMMON_SOURCES
|
||||
Command.cc
|
||||
HelpText.cc
|
||||
KKeymap.cc
|
||||
Swap.cc
|
||||
TerminalInputHandler.cc
|
||||
TerminalRenderer.cc
|
||||
TerminalFrontend.cc
|
||||
@@ -195,6 +204,7 @@ set(COMMON_HEADERS
|
||||
Command.h
|
||||
HelpText.h
|
||||
KKeymap.h
|
||||
Swap.h
|
||||
InputHandler.h
|
||||
TerminalInputHandler.h
|
||||
Renderer.h
|
||||
|
||||
619
Command.cc
619
Command.cc
@@ -4,6 +4,7 @@
|
||||
#include <regex>
|
||||
#include <fstream>
|
||||
#include <sstream>
|
||||
#include <cmath>
|
||||
#include <cctype>
|
||||
|
||||
#include "Command.h"
|
||||
@@ -18,6 +19,8 @@
|
||||
#include "syntax/CppHighlighter.h"
|
||||
#ifdef KTE_BUILD_GUI
|
||||
#include "GUITheme.h"
|
||||
#include "fonts/FontRegistry.h"
|
||||
#include "imgui.h"
|
||||
#endif
|
||||
|
||||
|
||||
@@ -101,24 +104,24 @@ static bool
|
||||
is_mutating_command(CommandId id)
|
||||
{
|
||||
switch (id) {
|
||||
case CommandId::InsertText:
|
||||
case CommandId::Newline:
|
||||
case CommandId::Backspace:
|
||||
case CommandId::DeleteChar:
|
||||
case CommandId::KillToEOL:
|
||||
case CommandId::KillLine:
|
||||
case CommandId::Yank:
|
||||
case CommandId::DeleteWordPrev:
|
||||
case CommandId::DeleteWordNext:
|
||||
case CommandId::IndentRegion:
|
||||
case CommandId::UnindentRegion:
|
||||
case CommandId::ReflowParagraph:
|
||||
case CommandId::KillRegion:
|
||||
case CommandId::Undo:
|
||||
case CommandId::Redo:
|
||||
return true;
|
||||
default:
|
||||
return false;
|
||||
case CommandId::InsertText:
|
||||
case CommandId::Newline:
|
||||
case CommandId::Backspace:
|
||||
case CommandId::DeleteChar:
|
||||
case CommandId::KillToEOL:
|
||||
case CommandId::KillLine:
|
||||
case CommandId::Yank:
|
||||
case CommandId::DeleteWordPrev:
|
||||
case CommandId::DeleteWordNext:
|
||||
case CommandId::IndentRegion:
|
||||
case CommandId::UnindentRegion:
|
||||
case CommandId::ReflowParagraph:
|
||||
case CommandId::KillRegion:
|
||||
case CommandId::Undo:
|
||||
case CommandId::Redo:
|
||||
return true;
|
||||
default:
|
||||
return false;
|
||||
}
|
||||
}
|
||||
|
||||
@@ -694,6 +697,10 @@ cmd_refresh(CommandContext &ctx)
|
||||
ctx.editor.ClearSearchOrigin();
|
||||
ctx.editor.SetSearchIndex(-1);
|
||||
}
|
||||
// Clear any pending close/overwrite state associated with prompts
|
||||
ctx.editor.SetCloseConfirmPending(false);
|
||||
ctx.editor.SetCloseAfterSave(false);
|
||||
ctx.editor.ClearPendingOverwritePath();
|
||||
ctx.editor.CancelPrompt();
|
||||
ctx.editor.SetStatus("Canceled");
|
||||
return true;
|
||||
@@ -762,6 +769,15 @@ cmd_unknown_kcommand(CommandContext &ctx)
|
||||
}
|
||||
|
||||
|
||||
static bool
|
||||
cmd_unknown_esc_command(CommandContext &ctx)
|
||||
{
|
||||
(void) ctx;
|
||||
ctx.editor.SetStatus("invalid escape command");
|
||||
return true;
|
||||
}
|
||||
|
||||
|
||||
// --- Syntax highlighting commands ---
|
||||
static void
|
||||
apply_filetype(Buffer &buf, const std::string &ft)
|
||||
@@ -954,7 +970,9 @@ cmd_theme_set_by_name(const CommandContext &ctx)
|
||||
ltrim(name);
|
||||
rtrim(name);
|
||||
if (name.empty()) {
|
||||
ctx.editor.SetStatus("theme: missing name");
|
||||
// Show current theme when no argument provided
|
||||
ctx.editor.SetStatus(
|
||||
std::string("Current theme: ") + kte::CurrentThemeName());
|
||||
return true;
|
||||
}
|
||||
if (kte::ApplyThemeByName(name)) {
|
||||
@@ -984,6 +1002,132 @@ cmd_theme_set_by_name(CommandContext &ctx)
|
||||
#endif
|
||||
|
||||
|
||||
// Font set by name (GUI)
|
||||
#ifdef KTE_BUILD_GUI
|
||||
static bool
|
||||
cmd_font_set_by_name(const CommandContext &ctx)
|
||||
{
|
||||
using namespace kte::Fonts;
|
||||
std::string name = ctx.arg;
|
||||
// trim
|
||||
auto ltrim = [](std::string &s) {
|
||||
s.erase(s.begin(), std::find_if(s.begin(), s.end(), [](unsigned char ch) {
|
||||
return !std::isspace(ch);
|
||||
}));
|
||||
};
|
||||
auto rtrim = [](std::string &s) {
|
||||
s.erase(std::find_if(s.rbegin(), s.rend(), [](unsigned char ch) {
|
||||
return !std::isspace(ch);
|
||||
}).base(), s.end());
|
||||
};
|
||||
ltrim(name);
|
||||
rtrim(name);
|
||||
std::transform(name.begin(), name.end(), name.begin(), [](unsigned char c) {
|
||||
return (char) std::tolower(c);
|
||||
});
|
||||
if (name.empty()) {
|
||||
// Show current font when no argument provided
|
||||
auto ® = FontRegistry::Instance();
|
||||
std::string current_font = reg.CurrentFontName();
|
||||
if (current_font.empty())
|
||||
current_font = "default";
|
||||
ctx.editor.SetStatus(std::string("Current font: ") + current_font);
|
||||
return true;
|
||||
}
|
||||
|
||||
auto ® = FontRegistry::Instance();
|
||||
if (!reg.HasFont(name)) {
|
||||
ctx.editor.SetStatus("font: unknown name");
|
||||
return true;
|
||||
}
|
||||
|
||||
float size = reg.CurrentFontSize();
|
||||
if (size <= 0.0f) {
|
||||
// Fallback to current ImGui font size if available
|
||||
size = ImGui::GetFontSize();
|
||||
if (size <= 0.0f)
|
||||
size = 16.0f;
|
||||
}
|
||||
reg.RequestLoadFont(name, size);
|
||||
ctx.editor.SetStatus(std::string("Font: ") + name + " (" + std::to_string((int) std::round(size)) + ")");
|
||||
return true;
|
||||
}
|
||||
#else
|
||||
static bool
|
||||
cmd_font_set_by_name(CommandContext &ctx)
|
||||
{
|
||||
(void) ctx;
|
||||
return true;
|
||||
}
|
||||
#endif
|
||||
|
||||
|
||||
// Font size set (GUI)
|
||||
#ifdef KTE_BUILD_GUI
|
||||
static bool
|
||||
cmd_font_set_size(const CommandContext &ctx)
|
||||
{
|
||||
using namespace kte::Fonts;
|
||||
std::string a = ctx.arg;
|
||||
auto ltrim = [](std::string &s) {
|
||||
s.erase(s.begin(), std::find_if(s.begin(), s.end(), [](unsigned char ch) {
|
||||
return !std::isspace(ch);
|
||||
}));
|
||||
};
|
||||
auto rtrim = [](std::string &s) {
|
||||
s.erase(std::find_if(s.rbegin(), s.rend(), [](unsigned char ch) {
|
||||
return !std::isspace(ch);
|
||||
}).base(), s.end());
|
||||
};
|
||||
ltrim(a);
|
||||
rtrim(a);
|
||||
if (a.empty()) {
|
||||
// Show current font size when no argument provided
|
||||
auto ® = FontRegistry::Instance();
|
||||
float current_size = reg.CurrentFontSize();
|
||||
if (current_size <= 0.0f) {
|
||||
// Fallback to current ImGui font size if available
|
||||
current_size = ImGui::GetFontSize();
|
||||
if (current_size <= 0.0f)
|
||||
current_size = 16.0f;
|
||||
}
|
||||
ctx.editor.SetStatus(
|
||||
std::string("Current font size: ") + std::to_string((int) std::round(current_size)));
|
||||
return true;
|
||||
}
|
||||
char *endp = nullptr;
|
||||
float size = strtof(a.c_str(), &endp);
|
||||
if (endp == a.c_str() || !std::isfinite(size)) {
|
||||
ctx.editor.SetStatus("font-size: expected number");
|
||||
return true;
|
||||
}
|
||||
// Clamp to a reasonable range
|
||||
if (size < 6.0f)
|
||||
size = 6.0f;
|
||||
if (size > 96.0f)
|
||||
size = 96.0f;
|
||||
|
||||
auto ® = FontRegistry::Instance();
|
||||
std::string name = reg.CurrentFontName();
|
||||
if (name.empty())
|
||||
name = "default";
|
||||
if (!reg.HasFont(name))
|
||||
name = "default";
|
||||
|
||||
reg.RequestLoadFont(name, size);
|
||||
ctx.editor.SetStatus(std::string("Font size: ") + std::to_string((int) std::round(size)));
|
||||
return true;
|
||||
}
|
||||
#else
|
||||
static bool
|
||||
cmd_font_set_size(CommandContext &ctx)
|
||||
{
|
||||
(void) ctx;
|
||||
return true;
|
||||
}
|
||||
#endif
|
||||
|
||||
|
||||
// Background set command (GUI)
|
||||
#ifdef KTE_BUILD_GUI
|
||||
static bool
|
||||
@@ -1243,6 +1387,14 @@ cmd_buffer_close(const CommandContext &ctx)
|
||||
std::size_t idx = ctx.editor.CurrentBufferIndex();
|
||||
Buffer *b = ctx.editor.CurrentBuffer();
|
||||
std::string name = b ? buffer_display_name(*b) : std::string("");
|
||||
// If buffer is dirty, prompt to save first (for both named and unnamed buffers)
|
||||
if (b && b->Dirty()) {
|
||||
ctx.editor.StartPrompt(Editor::PromptKind::Confirm, "Save", "");
|
||||
ctx.editor.SetCloseConfirmPending(true);
|
||||
ctx.editor.SetStatus(std::string("Save changes to ") + name + "? (y/N)");
|
||||
return true;
|
||||
}
|
||||
// Otherwise close immediately
|
||||
if (b && b->Undo())
|
||||
b->Undo()->discard_pending();
|
||||
ctx.editor.CloseBuffer(idx);
|
||||
@@ -2060,6 +2212,28 @@ cmd_newline(CommandContext &ctx)
|
||||
ctx.editor.SetStatus("Saved as " + value);
|
||||
if (auto *u = buf->Undo())
|
||||
u->mark_saved();
|
||||
// If a close-after-save was requested (from closing a dirty, unnamed buffer),
|
||||
// close the buffer now.
|
||||
if (ctx.editor.CloseAfterSave()) {
|
||||
ctx.editor.SetCloseAfterSave(false);
|
||||
std::size_t idx_close = ctx.editor.CurrentBufferIndex();
|
||||
std::string name_close = buffer_display_name(*buf);
|
||||
if (buf->Undo())
|
||||
buf->Undo()->discard_pending();
|
||||
ctx.editor.CloseBuffer(idx_close);
|
||||
if (ctx.editor.BufferCount() == 0) {
|
||||
Buffer empty;
|
||||
ctx.editor.AddBuffer(std::move(empty));
|
||||
ctx.editor.SwitchTo(0);
|
||||
}
|
||||
const Buffer *cur = ctx.editor.CurrentBuffer();
|
||||
ctx.editor.SetStatus(
|
||||
std::string("Closed: ") + name_close +
|
||||
std::string(" Now: ")
|
||||
+ (cur
|
||||
? buffer_display_name(*cur)
|
||||
: std::string("")));
|
||||
}
|
||||
}
|
||||
}
|
||||
}
|
||||
@@ -2083,11 +2257,86 @@ cmd_newline(CommandContext &ctx)
|
||||
ctx.editor.SetStatus("Saved as " + target);
|
||||
if (auto *u = buf->Undo())
|
||||
u->mark_saved();
|
||||
// If this overwrite confirm was part of a close-after-save flow, close now.
|
||||
if (ctx.editor.CloseAfterSave()) {
|
||||
ctx.editor.SetCloseAfterSave(false);
|
||||
std::size_t idx_close = ctx.editor.CurrentBufferIndex();
|
||||
std::string name_close = buffer_display_name(*buf);
|
||||
if (buf->Undo())
|
||||
buf->Undo()->discard_pending();
|
||||
ctx.editor.CloseBuffer(idx_close);
|
||||
if (ctx.editor.BufferCount() == 0) {
|
||||
Buffer empty;
|
||||
ctx.editor.AddBuffer(std::move(empty));
|
||||
ctx.editor.SwitchTo(0);
|
||||
}
|
||||
const Buffer *cur = ctx.editor.CurrentBuffer();
|
||||
ctx.editor.SetStatus(
|
||||
std::string("Closed: ") + name_close + std::string(
|
||||
" Now: ")
|
||||
+ (cur ? buffer_display_name(*cur) : std::string("")));
|
||||
}
|
||||
}
|
||||
} else {
|
||||
ctx.editor.SetStatus("Save canceled");
|
||||
}
|
||||
ctx.editor.ClearPendingOverwritePath();
|
||||
// Regardless of answer, end any close-after-save pending state for safety.
|
||||
ctx.editor.SetCloseAfterSave(false);
|
||||
} else if (ctx.editor.CloseConfirmPending() && buf) {
|
||||
bool yes = false;
|
||||
if (!value.empty()) {
|
||||
char c = value[0];
|
||||
yes = (c == 'y' || c == 'Y');
|
||||
}
|
||||
// Prepare close details
|
||||
std::size_t idx_close = ctx.editor.CurrentBufferIndex();
|
||||
std::string name_close = buffer_display_name(*buf);
|
||||
bool proceed_to_close = true;
|
||||
if (yes) {
|
||||
std::string err;
|
||||
if (buf->IsFileBacked()) {
|
||||
if (!buf->Save(err)) {
|
||||
ctx.editor.SetStatus(err);
|
||||
proceed_to_close = false;
|
||||
} else {
|
||||
buf->SetDirty(false);
|
||||
if (auto *u = buf->Undo())
|
||||
u->mark_saved();
|
||||
}
|
||||
} else if (!buf->Filename().empty()) {
|
||||
if (!buf->SaveAs(buf->Filename(), err)) {
|
||||
ctx.editor.SetStatus(err);
|
||||
proceed_to_close = false;
|
||||
} else {
|
||||
buf->SetDirty(false);
|
||||
if (auto *u = buf->Undo())
|
||||
u->mark_saved();
|
||||
}
|
||||
} else {
|
||||
// No filename; fall back to Save As flow and set close-after-save
|
||||
ctx.editor.StartPrompt(Editor::PromptKind::SaveAs, "Save as", "");
|
||||
ctx.editor.SetCloseAfterSave(true);
|
||||
ctx.editor.SetStatus("Save as: ");
|
||||
ctx.editor.SetCloseConfirmPending(false);
|
||||
return true;
|
||||
}
|
||||
}
|
||||
if (proceed_to_close) {
|
||||
if (buf->Undo())
|
||||
buf->Undo()->discard_pending();
|
||||
ctx.editor.CloseBuffer(idx_close);
|
||||
if (ctx.editor.BufferCount() == 0) {
|
||||
Buffer empty;
|
||||
ctx.editor.AddBuffer(std::move(empty));
|
||||
ctx.editor.SwitchTo(0);
|
||||
}
|
||||
const Buffer *cur = ctx.editor.CurrentBuffer();
|
||||
ctx.editor.SetStatus(
|
||||
std::string("Closed: ") + name_close + std::string(" Now: ")
|
||||
+ (cur ? buffer_display_name(*cur) : std::string("")));
|
||||
}
|
||||
ctx.editor.SetCloseConfirmPending(false);
|
||||
} else {
|
||||
ctx.editor.SetStatus("Nothing to confirm");
|
||||
}
|
||||
@@ -3523,7 +3772,9 @@ cmd_reflow_paragraph(CommandContext &ctx)
|
||||
ensure_at_least_one_line(*buf);
|
||||
auto &rows = buf->Rows();
|
||||
std::size_t y = buf->Cury();
|
||||
int width = ctx.count > 0 ? ctx.count : 72;
|
||||
// Treat a universal-argument count of 1 as "no width specified".
|
||||
// Editor::UArgGet() returns 1 when no explicit count was provided.
|
||||
int width = ctx.count > 1 ? ctx.count : 72;
|
||||
std::size_t para_start = y;
|
||||
while (para_start > 0 && !rows[para_start - 1].empty())
|
||||
--para_start;
|
||||
@@ -3532,50 +3783,222 @@ cmd_reflow_paragraph(CommandContext &ctx)
|
||||
++para_end;
|
||||
if (para_start > para_end)
|
||||
return false;
|
||||
std::string text;
|
||||
for (std::size_t i = para_start; i <= para_end; ++i) {
|
||||
if (i > para_start && !text.empty() && text.back() != ' ')
|
||||
text += ' ';
|
||||
const auto &line = rows[i];
|
||||
for (std::size_t j = 0; j < line.size(); ++j) {
|
||||
char c = line[j];
|
||||
if (c == '\t')
|
||||
text += ' ';
|
||||
else
|
||||
text += c;
|
||||
|
||||
auto is_space = [](char c) {
|
||||
return c == ' ' || c == '\t';
|
||||
};
|
||||
|
||||
auto leading_ws = [&](const std::string &s) {
|
||||
std::size_t i = 0;
|
||||
while (i < s.size() && is_space(s[i]))
|
||||
++i;
|
||||
return s.substr(0, i);
|
||||
};
|
||||
|
||||
auto starts_with = [](const std::string &s, const std::string &pfx) {
|
||||
return s.size() >= pfx.size() && std::equal(pfx.begin(), pfx.end(), s.begin());
|
||||
};
|
||||
|
||||
auto is_bullet_line = [&](const std::string &s, std::string &indent_out, char &marker_out,
|
||||
std::size_t &after_prefix_idx) -> bool {
|
||||
indent_out = leading_ws(s);
|
||||
std::size_t i = indent_out.size();
|
||||
if (i + 1 < s.size()) {
|
||||
char m = s[i];
|
||||
if ((m == '-' || m == '+' || m == '*') && s[i + 1] == ' ') {
|
||||
marker_out = m;
|
||||
after_prefix_idx = i + 2; // after marker + space
|
||||
return true;
|
||||
}
|
||||
}
|
||||
}
|
||||
return false;
|
||||
};
|
||||
|
||||
auto normalize_spaces = [](const std::string &in) {
|
||||
std::string out;
|
||||
out.reserve(in.size());
|
||||
bool in_space = false;
|
||||
for (char c: in) {
|
||||
char cc = (c == '\t') ? ' ' : c;
|
||||
if (cc == ' ') {
|
||||
if (!in_space) {
|
||||
out.push_back(' ');
|
||||
in_space = true;
|
||||
}
|
||||
} else {
|
||||
out.push_back(cc);
|
||||
in_space = false;
|
||||
}
|
||||
}
|
||||
// trim leading/trailing spaces
|
||||
// leading
|
||||
std::size_t start = 0;
|
||||
while (start < out.size() && out[start] == ' ')
|
||||
++start;
|
||||
// trailing
|
||||
std::size_t end = out.size();
|
||||
while (end > start && out[end - 1] == ' ')
|
||||
--end;
|
||||
return out.substr(start, end - start);
|
||||
};
|
||||
|
||||
auto wrap_with_prefixes = [&](const std::string &content,
|
||||
const std::string &first_prefix,
|
||||
const std::string &cont_prefix,
|
||||
int w,
|
||||
std::vector<std::string> &dst) {
|
||||
// Tokenize by spaces
|
||||
std::vector<std::string> words;
|
||||
std::size_t pos = 0;
|
||||
while (pos < content.size()) {
|
||||
while (pos < content.size() && content[pos] == ' ')
|
||||
++pos;
|
||||
if (pos >= content.size())
|
||||
break;
|
||||
std::size_t ws = pos;
|
||||
while (pos < content.size() && content[pos] != ' ')
|
||||
++pos;
|
||||
words.emplace_back(content.substr(ws, pos - ws));
|
||||
}
|
||||
std::string line = first_prefix;
|
||||
std::size_t cur_len = line.size();
|
||||
bool first_word_on_line = true;
|
||||
auto flush_line = [&]() {
|
||||
dst.emplace_back(line);
|
||||
line = cont_prefix;
|
||||
cur_len = line.size();
|
||||
first_word_on_line = true;
|
||||
};
|
||||
if (words.empty()) {
|
||||
// Still emit a line with just the prefix (e.g., empty bullet)
|
||||
dst.emplace_back(line);
|
||||
return;
|
||||
}
|
||||
for (std::size_t i = 0; i < words.size(); ++i) {
|
||||
const std::string &wrd = words[i];
|
||||
std::size_t needed = wrd.size() + (first_word_on_line ? 0 : 1);
|
||||
if (static_cast<int>(cur_len + needed) > w) {
|
||||
// wrap
|
||||
flush_line();
|
||||
}
|
||||
if (!first_word_on_line) {
|
||||
line.push_back(' ');
|
||||
++cur_len;
|
||||
}
|
||||
line += wrd;
|
||||
cur_len += wrd.size();
|
||||
first_word_on_line = false;
|
||||
}
|
||||
if (!line.empty())
|
||||
dst.emplace_back(line);
|
||||
};
|
||||
|
||||
std::vector<std::string> new_lines;
|
||||
std::string line;
|
||||
std::size_t pos = 0;
|
||||
while (pos < text.size()) {
|
||||
while (pos < text.size() && text[pos] == ' ')
|
||||
++pos;
|
||||
if (pos >= text.size())
|
||||
|
||||
// Determine if this region looks like a list: any line starting with bullet
|
||||
bool region_has_bullet = false;
|
||||
for (std::size_t i = para_start; i <= para_end; ++i) {
|
||||
std::string s = static_cast<std::string>(rows[i]);
|
||||
std::string indent;
|
||||
char marker;
|
||||
std::size_t idx;
|
||||
if (is_bullet_line(s, indent, marker, idx)) {
|
||||
region_has_bullet = true;
|
||||
break;
|
||||
std::size_t word_start = pos;
|
||||
while (pos < text.size() && text[pos] != ' ')
|
||||
++pos;
|
||||
std::string word = text.substr(word_start, pos - word_start);
|
||||
if (line.empty()) {
|
||||
line = word;
|
||||
} else if (static_cast<int>(line.size() + 1 + word.size()) <= width) {
|
||||
line += ' ';
|
||||
line += word;
|
||||
} else {
|
||||
new_lines.push_back(line);
|
||||
line = word;
|
||||
}
|
||||
}
|
||||
if (!line.empty())
|
||||
new_lines.push_back(line);
|
||||
|
||||
if (region_has_bullet) {
|
||||
// Parse as list items; support hanging indent continuations
|
||||
for (std::size_t i = para_start; i <= para_end; ++i) {
|
||||
std::string s = static_cast<std::string>(rows[i]);
|
||||
std::string indent;
|
||||
char marker = 0;
|
||||
std::size_t after_idx = 0;
|
||||
if (is_bullet_line(s, indent, marker, after_idx)) {
|
||||
std::string first_prefix = indent + std::string(1, marker) + " ";
|
||||
std::string cont_prefix = indent + " ";
|
||||
std::string content = s.substr(after_idx);
|
||||
// consume continuation lines that are part of this bullet item
|
||||
std::size_t j = i + 1;
|
||||
while (j <= para_end) {
|
||||
std::string ns = static_cast<std::string>(rows[j]);
|
||||
if (starts_with(ns, indent + " ")) {
|
||||
content += ' ';
|
||||
content += ns.substr(indent.size() + 2);
|
||||
++j;
|
||||
continue;
|
||||
}
|
||||
// stop if next bullet at same indentation or different structure
|
||||
std::string nindent;
|
||||
char nmarker;
|
||||
std::size_t nidx;
|
||||
if (is_bullet_line(ns, nindent, nmarker, nidx)) {
|
||||
break; // next item
|
||||
}
|
||||
// Not a continuation and not a bullet: stop (treat as separate paragraph chunk)
|
||||
break;
|
||||
}
|
||||
content = normalize_spaces(content);
|
||||
wrap_with_prefixes(content, first_prefix, cont_prefix, width, new_lines);
|
||||
i = j - 1; // advance
|
||||
} else {
|
||||
// A non-bullet line within a list region; treat as its own wrapped paragraph preserving its indent
|
||||
std::string base_indent = leading_ws(s);
|
||||
std::string content = s.substr(base_indent.size());
|
||||
std::size_t j = i + 1;
|
||||
while (j <= para_end) {
|
||||
std::string ns = static_cast<std::string>(rows[j]);
|
||||
std::string nindent = leading_ws(ns);
|
||||
std::string tmp_indent;
|
||||
char tmp_marker;
|
||||
std::size_t tmp_idx;
|
||||
if (is_bullet_line(ns, tmp_indent, tmp_marker, tmp_idx)) {
|
||||
break; // next bullet starts
|
||||
}
|
||||
if (nindent.size() >= base_indent.size()) {
|
||||
content += ' ';
|
||||
content += ns.substr(base_indent.size());
|
||||
++j;
|
||||
} else {
|
||||
break;
|
||||
}
|
||||
}
|
||||
content = normalize_spaces(content);
|
||||
wrap_with_prefixes(content, base_indent, base_indent, width, new_lines);
|
||||
i = j - 1;
|
||||
}
|
||||
}
|
||||
} else {
|
||||
// Normal paragraph: preserve indentation of first line
|
||||
std::string s0 = static_cast<std::string>(rows[para_start]);
|
||||
std::string pfx = leading_ws(s0);
|
||||
std::string content;
|
||||
for (std::size_t i = para_start; i <= para_end; ++i) {
|
||||
std::string si = static_cast<std::string>(rows[i]);
|
||||
// strip the same prefix length if present
|
||||
if (si.size() >= pfx.size() && starts_with(si, pfx))
|
||||
si.erase(0, pfx.size());
|
||||
if (!content.empty())
|
||||
content.push_back(' ');
|
||||
content += si;
|
||||
}
|
||||
content = normalize_spaces(content);
|
||||
wrap_with_prefixes(content, pfx, pfx, width, new_lines);
|
||||
}
|
||||
|
||||
if (new_lines.empty())
|
||||
new_lines.push_back("");
|
||||
|
||||
rows.erase(rows.begin() + static_cast<std::ptrdiff_t>(para_start),
|
||||
rows.begin() + static_cast<std::ptrdiff_t>(para_end + 1));
|
||||
rows.insert(rows.begin() + static_cast<std::ptrdiff_t>(para_start),
|
||||
new_lines.begin(), new_lines.end());
|
||||
buf->SetCursor(0, para_start);
|
||||
|
||||
// Place cursor at the end of the paragraph
|
||||
std::size_t new_last_y = para_start + (new_lines.empty() ? 0 : new_lines.size() - 1);
|
||||
std::size_t new_last_x = new_lines.empty() ? 0 : new_lines.back().size();
|
||||
buf->SetCursor(new_last_x, new_last_y);
|
||||
buf->SetDirty(true);
|
||||
ensure_cursor_visible(ctx.editor, *buf);
|
||||
return true;
|
||||
@@ -3684,35 +4107,45 @@ InstallDefaultCommands()
|
||||
CommandRegistry::Register({CommandId::SaveAndQuit, "save-quit", "Save and quit (request)", cmd_save_and_quit});
|
||||
CommandRegistry::Register({CommandId::Refresh, "refresh", "Force redraw", cmd_refresh});
|
||||
CommandRegistry::Register(
|
||||
{CommandId::KPrefix, "k-prefix", "Entering k-command prefix (show hint)", cmd_kprefix});
|
||||
{CommandId::KPrefix, "k-prefix", "Entering k-command prefix (show hint)", cmd_kprefix, false, false});
|
||||
CommandRegistry::Register({
|
||||
CommandId::UnknownKCommand, "unknown-k", "Unknown k-command (status)",
|
||||
cmd_unknown_kcommand
|
||||
});
|
||||
CommandRegistry::Register({CommandId::FindStart, "find-start", "Begin incremental search", cmd_find_start});
|
||||
CommandRegistry::Register({
|
||||
CommandId::RegexFindStart, "regex-find-start", "Begin regex search", cmd_regex_find_start
|
||||
cmd_unknown_kcommand, false, false
|
||||
});
|
||||
CommandRegistry::Register({
|
||||
CommandId::RegexpReplace, "regex-replace", "Begin regex search & replace", cmd_regex_replace_start
|
||||
CommandId::UnknownEscCommand, "unknown-esc", "Unknown ESC command (status)",
|
||||
cmd_unknown_esc_command, false, false
|
||||
});
|
||||
CommandRegistry::Register({
|
||||
CommandId::SearchReplace, "search-replace", "Begin search & replace", cmd_search_replace_start
|
||||
CommandId::FindStart, "find-start", "Begin incremental search", cmd_find_start, false, false
|
||||
});
|
||||
CommandRegistry::Register({
|
||||
CommandId::OpenFileStart, "open-file-start", "Begin open-file prompt", cmd_open_file_start
|
||||
CommandId::RegexFindStart, "regex-find-start", "Begin regex search", cmd_regex_find_start, false, false
|
||||
});
|
||||
CommandRegistry::Register({
|
||||
CommandId::RegexpReplace, "regex-replace", "Begin regex search & replace", cmd_regex_replace_start,
|
||||
false, false
|
||||
});
|
||||
CommandRegistry::Register({
|
||||
CommandId::SearchReplace, "search-replace", "Begin search & replace", cmd_search_replace_start, false,
|
||||
false
|
||||
});
|
||||
CommandRegistry::Register({
|
||||
CommandId::OpenFileStart, "open-file-start", "Begin open-file prompt", cmd_open_file_start, false, false
|
||||
});
|
||||
// Buffers
|
||||
CommandRegistry::Register({
|
||||
CommandId::BufferSwitchStart, "buffer-switch-start", "Begin buffer switch prompt",
|
||||
cmd_buffer_switch_start
|
||||
cmd_buffer_switch_start, false, false
|
||||
});
|
||||
CommandRegistry::Register({CommandId::BufferNext, "buffer-next", "Switch to next buffer", cmd_buffer_next});
|
||||
CommandRegistry::Register({CommandId::BufferPrev, "buffer-prev", "Switch to previous buffer", cmd_buffer_prev});
|
||||
CommandRegistry::Register({CommandId::BufferClose, "buffer-close", "Close current buffer", cmd_buffer_close});
|
||||
CommandRegistry::Register({
|
||||
CommandId::BufferClose, "buffer-close", "Close current buffer", cmd_buffer_close, false, false
|
||||
});
|
||||
// Editing
|
||||
CommandRegistry::Register({
|
||||
CommandId::InsertText, "insert", "Insert text at cursor (no newlines)", cmd_insert_text
|
||||
CommandId::InsertText, "insert", "Insert text at cursor (no newlines)", cmd_insert_text, false, true
|
||||
});
|
||||
CommandRegistry::Register({CommandId::Newline, "newline", "Insert newline at cursor", cmd_newline});
|
||||
CommandRegistry::Register({CommandId::Backspace, "backspace", "Delete char before cursor", cmd_backspace});
|
||||
@@ -3754,22 +4187,23 @@ InstallDefaultCommands()
|
||||
CommandId::DeleteWordNext, "delete-word-next", "Delete next word", cmd_delete_word_next
|
||||
});
|
||||
CommandRegistry::Register({
|
||||
CommandId::MoveCursorTo, "move-cursor-to", "Move cursor to y:x", cmd_move_cursor_to
|
||||
CommandId::MoveCursorTo, "move-cursor-to", "Move cursor to y:x", cmd_move_cursor_to, false, false
|
||||
});
|
||||
// Direct navigation by line number
|
||||
CommandRegistry::Register({
|
||||
CommandId::JumpToLine, "goto-line", "Prompt for line and jump", cmd_jump_to_line_start
|
||||
CommandId::JumpToLine, "goto-line", "Prompt for line and jump", cmd_jump_to_line_start, false, false
|
||||
});
|
||||
// Undo/Redo
|
||||
CommandRegistry::Register({CommandId::Undo, "undo", "Undo last edit", cmd_undo});
|
||||
CommandRegistry::Register({CommandId::Redo, "redo", "Redo edit", cmd_redo});
|
||||
CommandRegistry::Register({CommandId::Undo, "undo", "Undo last edit", cmd_undo, false, true});
|
||||
CommandRegistry::Register({CommandId::Redo, "redo", "Redo edit", cmd_redo, false, true});
|
||||
// Region formatting
|
||||
CommandRegistry::Register({CommandId::IndentRegion, "indent-region", "Indent region", cmd_indent_region});
|
||||
CommandRegistry::Register(
|
||||
{CommandId::UnindentRegion, "unindent-region", "Unindent region", cmd_unindent_region});
|
||||
CommandRegistry::Register({
|
||||
CommandId::ReflowParagraph, "reflow-paragraph", "Reflow paragraph to column width", cmd_reflow_paragraph
|
||||
});
|
||||
CommandId::ReflowParagraph, "reflow-paragraph",
|
||||
"Reflow paragraph to column width", cmd_reflow_paragraph
|
||||
});
|
||||
// Read-only
|
||||
CommandRegistry::Register({
|
||||
CommandId::ToggleReadOnly, "toggle-read-only", "Toggle buffer read-only", cmd_toggle_read_only
|
||||
@@ -3779,24 +4213,32 @@ InstallDefaultCommands()
|
||||
CommandRegistry::Register({CommandId::ThemePrev, "theme-prev", "Cycle to previous GUI theme", cmd_theme_prev});
|
||||
// Theme by name (public in command prompt)
|
||||
CommandRegistry::Register({
|
||||
CommandId::ThemeSetByName, "theme", "Set GUI theme by name", cmd_theme_set_by_name, true
|
||||
CommandId::ThemeSetByName, "theme", "Set GUI theme by name", cmd_theme_set_by_name, true, false
|
||||
});
|
||||
// Font by name (public)
|
||||
CommandRegistry::Register({
|
||||
CommandId::FontSetByName, "font", "Set GUI font by name", cmd_font_set_by_name, true, false
|
||||
});
|
||||
// Font size (public)
|
||||
CommandRegistry::Register({
|
||||
CommandId::FontSetSize, "font-size", "Set GUI font size (pixels)", cmd_font_set_size, true, false
|
||||
});
|
||||
// Background light/dark (public)
|
||||
CommandRegistry::Register({
|
||||
CommandId::BackgroundSet, "background", "Set GUI background light|dark", cmd_background_set, true
|
||||
CommandId::BackgroundSet, "background", "Set GUI background light|dark", cmd_background_set, true, false
|
||||
});
|
||||
// Generic command prompt (C-k ;)
|
||||
CommandRegistry::Register({
|
||||
CommandId::CommandPromptStart, "command-prompt-start", "Start generic command prompt",
|
||||
cmd_command_prompt_start
|
||||
cmd_command_prompt_start, false, false
|
||||
});
|
||||
// Buffer operations
|
||||
CommandRegistry::Register({
|
||||
CommandId::ReloadBuffer, "reload-buffer", "Reload buffer from disk", cmd_reload_buffer
|
||||
CommandId::ReloadBuffer, "reload-buffer", "Reload buffer from disk", cmd_reload_buffer, false, false
|
||||
});
|
||||
// Help
|
||||
CommandRegistry::Register({
|
||||
CommandId::ShowHelp, "help", "+HELP+ buffer with manual text", cmd_show_help
|
||||
CommandId::ShowHelp, "help", "+HELP+ buffer with manual text", cmd_show_help, false, false
|
||||
});
|
||||
CommandRegistry::Register({
|
||||
CommandId::MarkAllAndJumpEnd, "mark-all-jump-end", "Set mark at beginning and jump to end",
|
||||
@@ -3805,20 +4247,20 @@ InstallDefaultCommands()
|
||||
// GUI
|
||||
CommandRegistry::Register({
|
||||
CommandId::VisualFilePickerToggle, "file-picker-toggle", "Toggle visual file picker",
|
||||
cmd_visual_file_picker_toggle
|
||||
cmd_visual_file_picker_toggle, false, false
|
||||
});
|
||||
// Working directory
|
||||
CommandRegistry::Register({
|
||||
CommandId::ShowWorkingDirectory, "show-working-directory", "Show current working directory",
|
||||
cmd_show_working_directory
|
||||
cmd_show_working_directory, false, false
|
||||
});
|
||||
CommandRegistry::Register({
|
||||
CommandId::ChangeWorkingDirectory, "change-working-directory", "Change current working directory",
|
||||
cmd_change_working_directory_start
|
||||
cmd_change_working_directory_start, false, false
|
||||
});
|
||||
// UI helpers
|
||||
CommandRegistry::Register(
|
||||
{CommandId::UArgStatus, "uarg-status", "Update universal-arg status", cmd_uarg_status});
|
||||
{CommandId::UArgStatus, "uarg-status", "Update universal-arg status", cmd_uarg_status, false, false});
|
||||
// Syntax highlighting (public commands)
|
||||
CommandRegistry::Register({CommandId::Syntax, "syntax", "Syntax: on|off|reload", cmd_syntax, true});
|
||||
CommandRegistry::Register({CommandId::SetOption, "set", "Set option: key=value", cmd_set_option, true});
|
||||
@@ -3850,7 +4292,22 @@ Execute(Editor &ed, CommandId id, const std::string &arg, int count)
|
||||
}
|
||||
}
|
||||
|
||||
CommandContext ctx{ed, arg, count};
|
||||
// Source repeat count from editor-level universal argument per new design.
|
||||
int final_count = 0;
|
||||
if (cmd->repeatable) {
|
||||
final_count = ed.UArgGet(); // returns 1 if no active uarg
|
||||
} else {
|
||||
// Special-case non-repeatables that should NOT consume/clear uarg:
|
||||
// - KPrefix: keeps uarg for the following k-suffix command.
|
||||
// - UnknownKCommand / UnknownEscCommand: user mistyped; keep uarg for next try.
|
||||
if (id != CommandId::KPrefix && id != CommandId::UnknownKCommand && id !=
|
||||
CommandId::UnknownEscCommand) {
|
||||
ed.UArgClear();
|
||||
}
|
||||
final_count = 0;
|
||||
}
|
||||
|
||||
CommandContext ctx{ed, arg, final_count};
|
||||
return cmd->handler ? cmd->handler(ctx) : false;
|
||||
}
|
||||
|
||||
|
||||
13
Command.h
13
Command.h
@@ -1,8 +1,7 @@
|
||||
/*
|
||||
* Command.h - command model and registry for editor actions
|
||||
*/
|
||||
#ifndef KTE_COMMAND_H
|
||||
#define KTE_COMMAND_H
|
||||
#pragma once
|
||||
|
||||
#include <functional>
|
||||
#include <string>
|
||||
@@ -91,12 +90,15 @@ enum class CommandId {
|
||||
ShowHelp, // open +HELP+ buffer with manual text (C-k h)
|
||||
// Meta
|
||||
UnknownKCommand, // arg: single character that was not recognized after C-k
|
||||
UnknownEscCommand, // invalid ESC (meta) command; show status and exit escape mode
|
||||
// Generic command prompt
|
||||
CommandPromptStart, // begin generic command prompt (C-k ;)
|
||||
// Theme by name
|
||||
ThemeSetByName,
|
||||
// Font by name (GUI)
|
||||
FontSetByName,
|
||||
// Font size (GUI)
|
||||
FontSetSize,
|
||||
// Background mode (GUI)
|
||||
BackgroundSet,
|
||||
// Syntax highlighting
|
||||
@@ -127,6 +129,9 @@ struct Command {
|
||||
CommandHandler handler;
|
||||
// Public commands are exposed in the ": " prompt (C-k ;)
|
||||
bool isPublic = false;
|
||||
// Whether this command should consume and honor a universal argument repeat count.
|
||||
// Default true per issue request; authors can turn off per-command.
|
||||
bool repeatable = true;
|
||||
};
|
||||
|
||||
|
||||
@@ -153,6 +158,4 @@ void InstallDefaultCommands();
|
||||
// Returns true if the command executed successfully.
|
||||
bool Execute(Editor &ed, CommandId id, const std::string &arg = std::string(), int count = 0);
|
||||
|
||||
bool Execute(Editor &ed, const std::string &name, const std::string &arg = std::string(), int count = 0);
|
||||
|
||||
#endif // KTE_COMMAND_H
|
||||
bool Execute(Editor &ed, const std::string &name, const std::string &arg = std::string(), int count = 0);
|
||||
85
Editor.cc
85
Editor.cc
@@ -8,7 +8,10 @@
|
||||
#include "syntax/NullHighlighter.h"
|
||||
|
||||
|
||||
Editor::Editor() = default;
|
||||
Editor::Editor()
|
||||
{
|
||||
swap_ = std::make_unique<kte::SwapManager>();
|
||||
}
|
||||
|
||||
|
||||
void
|
||||
@@ -123,6 +126,11 @@ std::size_t
|
||||
Editor::AddBuffer(const Buffer &buf)
|
||||
{
|
||||
buffers_.push_back(buf);
|
||||
// Attach swap recorder
|
||||
if (swap_) {
|
||||
buffers_.back().SetSwapRecorder(swap_.get());
|
||||
swap_->Attach(&buffers_.back());
|
||||
}
|
||||
if (buffers_.size() == 1) {
|
||||
curbuf_ = 0;
|
||||
}
|
||||
@@ -134,6 +142,10 @@ std::size_t
|
||||
Editor::AddBuffer(Buffer &&buf)
|
||||
{
|
||||
buffers_.push_back(std::move(buf));
|
||||
if (swap_) {
|
||||
buffers_.back().SetSwapRecorder(swap_.get());
|
||||
swap_->Attach(&buffers_.back());
|
||||
}
|
||||
if (buffers_.size() == 1) {
|
||||
curbuf_ = 0;
|
||||
}
|
||||
@@ -157,6 +169,12 @@ Editor::OpenFile(const std::string &path, std::string &err)
|
||||
bool ok = cur.OpenFromFile(path, err);
|
||||
if (!ok)
|
||||
return false;
|
||||
// Ensure swap recorder is attached for this buffer
|
||||
if (swap_) {
|
||||
cur.SetSwapRecorder(swap_.get());
|
||||
swap_->Attach(&cur);
|
||||
swap_->NotifyFilenameChanged(cur);
|
||||
}
|
||||
// Setup highlighting using registry (extension + shebang)
|
||||
cur.EnsureHighlighter();
|
||||
std::string first = "";
|
||||
@@ -187,6 +205,12 @@ Editor::OpenFile(const std::string &path, std::string &err)
|
||||
if (!b.OpenFromFile(path, err)) {
|
||||
return false;
|
||||
}
|
||||
if (swap_) {
|
||||
b.SetSwapRecorder(swap_.get());
|
||||
// path is known, notify
|
||||
swap_->Attach(&b);
|
||||
swap_->NotifyFilenameChanged(b);
|
||||
}
|
||||
// Initialize syntax highlighting by extension + shebang via registry (v2)
|
||||
b.EnsureHighlighter();
|
||||
std::string first = "";
|
||||
@@ -278,8 +302,67 @@ Editor::Reset()
|
||||
msgtm_ = 0;
|
||||
uarg_ = 0;
|
||||
ucount_ = 0;
|
||||
repeatable_ = false;
|
||||
quit_requested_ = false;
|
||||
quit_confirm_pending_ = false;
|
||||
// Reset close-confirm/save state
|
||||
close_confirm_pending_ = false;
|
||||
close_after_save_ = false;
|
||||
buffers_.clear();
|
||||
curbuf_ = 0;
|
||||
}
|
||||
|
||||
|
||||
// --- Universal argument helpers ---
|
||||
void
|
||||
Editor::UArgStart()
|
||||
{
|
||||
// If not active, start fresh; else multiply by 4 per ke semantics
|
||||
if (uarg_ == 0) {
|
||||
ucount_ = 0;
|
||||
} else {
|
||||
if (ucount_ == 0) {
|
||||
ucount_ = 1;
|
||||
}
|
||||
ucount_ *= 4;
|
||||
}
|
||||
uarg_ = 1;
|
||||
char buf[64];
|
||||
std::snprintf(buf, sizeof(buf), "C-u %d", ucount_);
|
||||
SetStatus(buf);
|
||||
}
|
||||
|
||||
|
||||
void
|
||||
Editor::UArgDigit(int d)
|
||||
{
|
||||
if (d < 0)
|
||||
d = 0;
|
||||
if (d > 9)
|
||||
d = 9;
|
||||
if (uarg_ == 0) {
|
||||
uarg_ = 1;
|
||||
ucount_ = 0;
|
||||
}
|
||||
ucount_ = ucount_ * 10 + d;
|
||||
char buf[64];
|
||||
std::snprintf(buf, sizeof(buf), "C-u %d", ucount_);
|
||||
SetStatus(buf);
|
||||
}
|
||||
|
||||
|
||||
void
|
||||
Editor::UArgClear()
|
||||
{
|
||||
uarg_ = 0;
|
||||
ucount_ = 0;
|
||||
}
|
||||
|
||||
|
||||
int
|
||||
Editor::UArgGet()
|
||||
{
|
||||
int n = (ucount_ > 0) ? ucount_ : 1;
|
||||
UArgClear();
|
||||
return n;
|
||||
}
|
||||
78
Editor.h
78
Editor.h
@@ -1,15 +1,14 @@
|
||||
/*
|
||||
* Editor.h - top-level editor state and buffer management
|
||||
*/
|
||||
#ifndef KTE_EDITOR_H
|
||||
#define KTE_EDITOR_H
|
||||
|
||||
#pragma once
|
||||
#include <cstddef>
|
||||
#include <ctime>
|
||||
#include <string>
|
||||
#include <vector>
|
||||
|
||||
#include "Buffer.h"
|
||||
#include "Swap.h"
|
||||
|
||||
|
||||
class Editor {
|
||||
@@ -158,6 +157,33 @@ public:
|
||||
}
|
||||
|
||||
|
||||
// --- Universal argument control (C-u) ---
|
||||
// Begin or extend a universal argument (like ke's uarg_start)
|
||||
void UArgStart();
|
||||
|
||||
// Add a digit 0..9 to the current universal argument (like ke's uarg_digit)
|
||||
void UArgDigit(int d);
|
||||
|
||||
// Clear universal-argument state (like ke's uarg_clear)
|
||||
void UArgClear();
|
||||
|
||||
// Consume the current universal argument, returning count >= 1.
|
||||
// If no universal argument active, returns 1.
|
||||
int UArgGet();
|
||||
|
||||
// Repeatable command flag: input layer can mark the next command as repeatable
|
||||
void SetRepeatable(bool on)
|
||||
{
|
||||
repeatable_ = on;
|
||||
}
|
||||
|
||||
|
||||
[[nodiscard]] bool Repeatable() const
|
||||
{
|
||||
return repeatable_;
|
||||
}
|
||||
|
||||
|
||||
// Status message storage. Rendering is renderer-dependent; the editor
|
||||
// merely stores the current message and its timestamp.
|
||||
void SetStatus(const std::string &message);
|
||||
@@ -194,6 +220,31 @@ public:
|
||||
}
|
||||
|
||||
|
||||
// --- Buffer close/save confirmation state ---
|
||||
void SetCloseConfirmPending(bool on)
|
||||
{
|
||||
close_confirm_pending_ = on;
|
||||
}
|
||||
|
||||
|
||||
[[nodiscard]] bool CloseConfirmPending() const
|
||||
{
|
||||
return close_confirm_pending_;
|
||||
}
|
||||
|
||||
|
||||
void SetCloseAfterSave(bool on)
|
||||
{
|
||||
close_after_save_ = on;
|
||||
}
|
||||
|
||||
|
||||
[[nodiscard]] bool CloseAfterSave() const
|
||||
{
|
||||
return close_after_save_;
|
||||
}
|
||||
|
||||
|
||||
[[nodiscard]] std::time_t StatusTime() const
|
||||
{
|
||||
return msgtm_;
|
||||
@@ -467,6 +518,13 @@ public:
|
||||
}
|
||||
|
||||
|
||||
// Swap manager access (for advanced integrations/tests)
|
||||
[[nodiscard]] kte::SwapManager *Swap()
|
||||
{
|
||||
return swap_.get();
|
||||
}
|
||||
|
||||
|
||||
// --- GUI: Visual File Picker state ---
|
||||
void SetFilePickerVisible(bool on)
|
||||
{
|
||||
@@ -500,17 +558,23 @@ private:
|
||||
std::string msg_;
|
||||
std::time_t msgtm_ = 0;
|
||||
int uarg_ = 0, ucount_ = 0; // C-u support
|
||||
bool repeatable_ = false; // whether the next command is repeatable
|
||||
|
||||
std::vector<Buffer> buffers_;
|
||||
std::size_t curbuf_ = 0; // index into buffers_
|
||||
|
||||
// Swap journaling manager (lifetime = editor)
|
||||
std::unique_ptr<kte::SwapManager> swap_;
|
||||
|
||||
// Kill ring (Emacs-like)
|
||||
std::vector<std::string> kill_ring_;
|
||||
std::size_t kill_ring_max_ = 60;
|
||||
|
||||
// Quit state
|
||||
bool quit_requested_ = false;
|
||||
bool quit_confirm_pending_ = false;
|
||||
bool quit_requested_ = false;
|
||||
bool quit_confirm_pending_ = false;
|
||||
bool close_confirm_pending_ = false; // awaiting y/N to save-before-close
|
||||
bool close_after_save_ = false; // if true, close buffer after successful Save/SaveAs
|
||||
|
||||
// Search state
|
||||
bool search_active_ = false;
|
||||
@@ -561,6 +625,4 @@ public:
|
||||
private:
|
||||
std::string replace_find_tmp_;
|
||||
std::string replace_with_tmp_;
|
||||
};
|
||||
|
||||
#endif // KTE_EDITOR_H
|
||||
};
|
||||
@@ -1,9 +1,7 @@
|
||||
/*
|
||||
* Frontend.h - top-level container that couples Input + Renderer and runs the loop
|
||||
*/
|
||||
#ifndef KTE_FRONTEND_H
|
||||
#define KTE_FRONTEND_H
|
||||
|
||||
#pragma once
|
||||
|
||||
class Editor;
|
||||
class InputHandler;
|
||||
@@ -21,6 +19,4 @@ public:
|
||||
|
||||
// Shutdown/cleanup
|
||||
virtual void Shutdown() = 0;
|
||||
};
|
||||
|
||||
#endif // KTE_FRONTEND_H
|
||||
};
|
||||
@@ -1,8 +1,7 @@
|
||||
/*
|
||||
* GUIConfig - loads simple GUI configuration from $HOME/.config/kte/kge.ini
|
||||
*/
|
||||
#ifndef KTE_GUI_CONFIG_H
|
||||
#define KTE_GUI_CONFIG_H
|
||||
#pragma once
|
||||
|
||||
#include <string>
|
||||
|
||||
@@ -31,6 +30,4 @@ public:
|
||||
|
||||
// Load from explicit path. Returns true if file existed and was parsed.
|
||||
bool LoadFromFile(const std::string &path);
|
||||
};
|
||||
|
||||
#endif // KTE_GUI_CONFIG_H
|
||||
};
|
||||
@@ -17,6 +17,7 @@
|
||||
#include "GUIConfig.h"
|
||||
#include "GUITheme.h"
|
||||
#include "fonts/Font.h" // embedded default font (DefaultFont)
|
||||
#include "fonts/FontRegistry.h"
|
||||
#include "syntax/HighlighterRegistry.h"
|
||||
#include "syntax/NullHighlighter.h"
|
||||
|
||||
@@ -30,7 +31,9 @@ static auto kGlslVersion = "#version 150"; // GL 3.2 core (macOS compatible)
|
||||
bool
|
||||
GUIFrontend::Init(Editor &ed)
|
||||
{
|
||||
(void) ed; // editor dimensions will be initialized during the first Step() frame
|
||||
// Attach editor to input handler for editor-owned features (e.g., universal argument)
|
||||
input_.Attach(&ed);
|
||||
// editor dimensions will be initialized during the first Step() frame
|
||||
if (SDL_Init(SDL_INIT_VIDEO | SDL_INIT_TIMER) != 0) {
|
||||
return false;
|
||||
}
|
||||
@@ -196,8 +199,19 @@ GUIFrontend::Init(Editor &ed)
|
||||
}
|
||||
#endif
|
||||
|
||||
// Initialize GUI font from embedded default (use configured size or compiled default)
|
||||
LoadGuiFont_(nullptr, (float) cfg.font_size);
|
||||
// Install embedded fonts into registry and load configured font
|
||||
kte::Fonts::InstallDefaultFonts();
|
||||
// Initialize font atlas using configured font name and size; fallback to embedded default helper
|
||||
if (!kte::Fonts::FontRegistry::Instance().LoadFont(cfg.font, (float) cfg.font_size)) {
|
||||
LoadGuiFont_(nullptr, (float) cfg.font_size);
|
||||
// Record defaults in registry so subsequent size changes have a base
|
||||
kte::Fonts::FontRegistry::Instance().RequestLoadFont("default", (float) cfg.font_size);
|
||||
std::string n;
|
||||
float s = 0.0f;
|
||||
if (kte::Fonts::FontRegistry::Instance().ConsumePendingFontRequest(n, s)) {
|
||||
kte::Fonts::FontRegistry::Instance().LoadFont(n, s);
|
||||
}
|
||||
}
|
||||
|
||||
return true;
|
||||
}
|
||||
@@ -210,22 +224,36 @@ GUIFrontend::Step(Editor &ed, bool &running)
|
||||
while (SDL_PollEvent(&e)) {
|
||||
ImGui_ImplSDL2_ProcessEvent(&e);
|
||||
switch (e.type) {
|
||||
case SDL_QUIT:
|
||||
running = false;
|
||||
break;
|
||||
case SDL_WINDOWEVENT:
|
||||
if (e.window.event == SDL_WINDOWEVENT_SIZE_CHANGED) {
|
||||
width_ = e.window.data1;
|
||||
height_ = e.window.data2;
|
||||
}
|
||||
break;
|
||||
default:
|
||||
break;
|
||||
case SDL_QUIT:
|
||||
running = false;
|
||||
break;
|
||||
case SDL_WINDOWEVENT:
|
||||
if (e.window.event == SDL_WINDOWEVENT_SIZE_CHANGED) {
|
||||
width_ = e.window.data1;
|
||||
height_ = e.window.data2;
|
||||
}
|
||||
break;
|
||||
default:
|
||||
break;
|
||||
}
|
||||
// Map input to commands
|
||||
input_.ProcessSDLEvent(e);
|
||||
}
|
||||
|
||||
// Apply pending font change before starting a new frame
|
||||
{
|
||||
std::string fname;
|
||||
float fsize = 0.0f;
|
||||
if (kte::Fonts::FontRegistry::Instance().ConsumePendingFontRequest(fname, fsize)) {
|
||||
if (!fname.empty() && fsize > 0.0f) {
|
||||
kte::Fonts::FontRegistry::Instance().LoadFont(fname, fsize);
|
||||
// Recreate backend font texture
|
||||
ImGui_ImplOpenGL3_DestroyFontsTexture();
|
||||
ImGui_ImplOpenGL3_CreateFontsTexture();
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
// Start a new ImGui frame BEFORE processing commands so dimensions are correct
|
||||
ImGui_ImplOpenGL3_NewFrame();
|
||||
ImGui_ImplSDL2_NewFrame(window_);
|
||||
|
||||
@@ -1,9 +1,7 @@
|
||||
/*
|
||||
* GUIFrontend - couples GUIInputHandler + GUIRenderer and owns SDL2/ImGui lifecycle
|
||||
*/
|
||||
#ifndef KTE_GUI_FRONTEND_H
|
||||
#define KTE_GUI_FRONTEND_H
|
||||
|
||||
#pragma once
|
||||
#include "Frontend.h"
|
||||
#include "GUIConfig.h"
|
||||
#include "GUIInputHandler.h"
|
||||
@@ -35,6 +33,4 @@ private:
|
||||
SDL_GLContext gl_ctx_ = nullptr;
|
||||
int width_ = 1280;
|
||||
int height_ = 800;
|
||||
};
|
||||
|
||||
#endif // KTE_GUI_FRONTEND_H
|
||||
};
|
||||
@@ -7,6 +7,7 @@
|
||||
|
||||
#include "GUIInputHandler.h"
|
||||
#include "KKeymap.h"
|
||||
#include "Editor.h"
|
||||
|
||||
|
||||
static bool
|
||||
@@ -14,20 +15,17 @@ map_key(const SDL_Keycode key,
|
||||
const SDL_Keymod mod,
|
||||
bool &k_prefix,
|
||||
bool &esc_meta,
|
||||
// universal-argument state (by ref)
|
||||
bool &uarg_active,
|
||||
bool &uarg_collecting,
|
||||
bool &uarg_negative,
|
||||
bool &uarg_had_digits,
|
||||
int &uarg_value,
|
||||
std::string &uarg_text,
|
||||
MappedInput &out)
|
||||
bool &k_ctrl_pending,
|
||||
Editor *ed,
|
||||
MappedInput &out,
|
||||
bool &suppress_textinput_once)
|
||||
{
|
||||
// Ctrl handling
|
||||
const bool is_ctrl = (mod & KMOD_CTRL) != 0;
|
||||
const bool is_alt = (mod & (KMOD_ALT | KMOD_LALT | KMOD_RALT)) != 0;
|
||||
|
||||
// If previous key was ESC, interpret this as Meta via ESC keymap
|
||||
// If previous key was ESC, interpret this as Meta via ESC keymap.
|
||||
// Prefer KEYDOWN when we can derive a printable ASCII; otherwise defer to TEXTINPUT.
|
||||
if (esc_meta) {
|
||||
int ascii_key = 0;
|
||||
if (key == SDLK_BACKSPACE) {
|
||||
@@ -45,17 +43,18 @@ map_key(const SDL_Keycode key,
|
||||
ascii_key = '>';
|
||||
}
|
||||
if (ascii_key != 0) {
|
||||
esc_meta = false; // consume if we can decide on KEYDOWN
|
||||
ascii_key = KLowerAscii(ascii_key);
|
||||
CommandId id;
|
||||
if (KLookupEscCommand(ascii_key, id)) {
|
||||
// Only consume the ESC-meta prefix if we actually mapped a command
|
||||
esc_meta = false;
|
||||
out = {true, id, "", 0};
|
||||
out = {true, id, "", 0};
|
||||
return true;
|
||||
}
|
||||
// Known printable but unmapped ESC sequence: report invalid
|
||||
out = {true, CommandId::UnknownEscCommand, "", 0};
|
||||
return true;
|
||||
}
|
||||
// Unhandled meta chord at KEYDOWN: do not clear esc_meta here.
|
||||
// Leave it set so SDL_TEXTINPUT fallback can translate and suppress insertion.
|
||||
// No usable ASCII from KEYDOWN → keep esc_meta set and let TEXTINPUT handle it
|
||||
out.hasCommand = false;
|
||||
return true;
|
||||
}
|
||||
@@ -63,71 +62,83 @@ map_key(const SDL_Keycode key,
|
||||
// Movement and basic keys
|
||||
// These keys exit k-prefix mode if active (user pressed C-k then a special key).
|
||||
switch (key) {
|
||||
case SDLK_LEFT:
|
||||
k_prefix = false;
|
||||
out = {true, CommandId::MoveLeft, "", 0};
|
||||
return true;
|
||||
case SDLK_RIGHT:
|
||||
k_prefix = false;
|
||||
out = {true, CommandId::MoveRight, "", 0};
|
||||
return true;
|
||||
case SDLK_UP:
|
||||
k_prefix = false;
|
||||
out = {true, CommandId::MoveUp, "", 0};
|
||||
return true;
|
||||
case SDLK_DOWN:
|
||||
k_prefix = false;
|
||||
out = {true, CommandId::MoveDown, "", 0};
|
||||
return true;
|
||||
case SDLK_HOME:
|
||||
k_prefix = false;
|
||||
out = {true, CommandId::MoveHome, "", 0};
|
||||
return true;
|
||||
case SDLK_END:
|
||||
k_prefix = false;
|
||||
out = {true, CommandId::MoveEnd, "", 0};
|
||||
return true;
|
||||
case SDLK_PAGEUP:
|
||||
k_prefix = false;
|
||||
out = {true, CommandId::PageUp, "", 0};
|
||||
return true;
|
||||
case SDLK_PAGEDOWN:
|
||||
k_prefix = false;
|
||||
out = {true, CommandId::PageDown, "", 0};
|
||||
return true;
|
||||
case SDLK_DELETE:
|
||||
k_prefix = false;
|
||||
out = {true, CommandId::DeleteChar, "", 0};
|
||||
return true;
|
||||
case SDLK_BACKSPACE:
|
||||
k_prefix = false;
|
||||
out = {true, CommandId::Backspace, "", 0};
|
||||
return true;
|
||||
case SDLK_TAB:
|
||||
// Insert a literal tab character when not interpreting a k-prefix suffix.
|
||||
// If k-prefix is active, let the k-prefix handler below consume the key
|
||||
// (so Tab doesn't leave k-prefix stuck).
|
||||
if (!k_prefix) {
|
||||
out = {true, CommandId::InsertText, std::string("\t"), 0};
|
||||
case SDLK_LEFT:
|
||||
k_prefix = false;
|
||||
k_ctrl_pending = false;
|
||||
out = {true, CommandId::MoveLeft, "", 0};
|
||||
return true;
|
||||
}
|
||||
break; // fall through so k-prefix handler can process
|
||||
case SDLK_RETURN:
|
||||
case SDLK_KP_ENTER:
|
||||
out = {true, CommandId::Newline, "", 0};
|
||||
return true;
|
||||
case SDLK_ESCAPE:
|
||||
k_prefix = false;
|
||||
esc_meta = true; // next key will be treated as Meta
|
||||
out.hasCommand = false; // no immediate command for bare ESC in GUI
|
||||
return true;
|
||||
default:
|
||||
break;
|
||||
case SDLK_RIGHT:
|
||||
k_prefix = false;
|
||||
k_ctrl_pending = false;
|
||||
out = {true, CommandId::MoveRight, "", 0};
|
||||
return true;
|
||||
case SDLK_UP:
|
||||
k_prefix = false;
|
||||
k_ctrl_pending = false;
|
||||
out = {true, CommandId::MoveUp, "", 0};
|
||||
return true;
|
||||
case SDLK_DOWN:
|
||||
k_prefix = false;
|
||||
k_ctrl_pending = false;
|
||||
out = {true, CommandId::MoveDown, "", 0};
|
||||
return true;
|
||||
case SDLK_HOME:
|
||||
k_prefix = false;
|
||||
k_ctrl_pending = false;
|
||||
out = {true, CommandId::MoveHome, "", 0};
|
||||
return true;
|
||||
case SDLK_END:
|
||||
k_prefix = false;
|
||||
k_ctrl_pending = false;
|
||||
out = {true, CommandId::MoveEnd, "", 0};
|
||||
return true;
|
||||
case SDLK_PAGEUP:
|
||||
k_prefix = false;
|
||||
k_ctrl_pending = false;
|
||||
out = {true, CommandId::PageUp, "", 0};
|
||||
return true;
|
||||
case SDLK_PAGEDOWN:
|
||||
k_prefix = false;
|
||||
k_ctrl_pending = false;
|
||||
out = {true, CommandId::PageDown, "", 0};
|
||||
return true;
|
||||
case SDLK_DELETE:
|
||||
k_prefix = false;
|
||||
k_ctrl_pending = false;
|
||||
out = {true, CommandId::DeleteChar, "", 0};
|
||||
return true;
|
||||
case SDLK_BACKSPACE:
|
||||
k_prefix = false;
|
||||
k_ctrl_pending = false;
|
||||
out = {true, CommandId::Backspace, "", 0};
|
||||
return true;
|
||||
case SDLK_TAB:
|
||||
// Insert a literal tab character when not interpreting a k-prefix suffix.
|
||||
// If k-prefix is active, let the k-prefix handler below consume the key
|
||||
// (so Tab doesn't leave k-prefix stuck).
|
||||
if (!k_prefix) {
|
||||
out = {true, CommandId::InsertText, std::string("\t"), 0};
|
||||
return true;
|
||||
}
|
||||
break; // fall through so k-prefix handler can process
|
||||
case SDLK_RETURN:
|
||||
case SDLK_KP_ENTER:
|
||||
k_prefix = false;
|
||||
k_ctrl_pending = false;
|
||||
out = {true, CommandId::Newline, "", 0};
|
||||
return true;
|
||||
case SDLK_ESCAPE:
|
||||
k_prefix = false;
|
||||
k_ctrl_pending = false;
|
||||
esc_meta = true; // next key will be treated as Meta
|
||||
out.hasCommand = false; // no immediate command for bare ESC in GUI
|
||||
return true;
|
||||
default:
|
||||
break;
|
||||
}
|
||||
|
||||
// If we are in k-prefix, interpret the very next key via the C-k keymap immediately.
|
||||
if (k_prefix) {
|
||||
k_prefix = false;
|
||||
esc_meta = false;
|
||||
// Normalize to ASCII; preserve case for letters using Shift
|
||||
int ascii_key = 0;
|
||||
@@ -147,10 +158,23 @@ map_key(const SDL_Keycode key,
|
||||
ascii_key = static_cast<int>(key);
|
||||
}
|
||||
bool ctrl2 = (mod & KMOD_CTRL) != 0;
|
||||
// If user typed a literal 'C' (or '^') as a control qualifier, keep k-prefix active
|
||||
if (ascii_key == 'C' || ascii_key == 'c' || ascii_key == '^') {
|
||||
k_ctrl_pending = true;
|
||||
// Keep waiting for the next suffix; show status and suppress ensuing TEXTINPUT
|
||||
if (ed)
|
||||
ed->SetStatus("C-k C _");
|
||||
suppress_textinput_once = true;
|
||||
out.hasCommand = false;
|
||||
return true;
|
||||
}
|
||||
// Otherwise, consume the k-prefix now for the actual suffix
|
||||
k_prefix = false;
|
||||
if (ascii_key != 0) {
|
||||
int lower = KLowerAscii(ascii_key);
|
||||
bool ctrl_suffix_supported = (lower == 'd' || lower == 'x' || lower == 'q');
|
||||
bool pass_ctrl = ctrl2 && ctrl_suffix_supported;
|
||||
bool pass_ctrl = (ctrl2 || k_ctrl_pending) && ctrl_suffix_supported;
|
||||
k_ctrl_pending = false;
|
||||
CommandId id;
|
||||
bool mapped = KLookupKCommand(ascii_key, pass_ctrl, id);
|
||||
// Diagnostics for u/U
|
||||
@@ -167,54 +191,40 @@ map_key(const SDL_Keycode key,
|
||||
}
|
||||
if (mapped) {
|
||||
out = {true, id, "", 0};
|
||||
if (ed)
|
||||
ed->SetStatus(""); // clear "C-k _" hint after suffix
|
||||
return true;
|
||||
}
|
||||
int shown = KLowerAscii(ascii_key);
|
||||
char c = (shown >= 0x20 && shown <= 0x7e) ? static_cast<char>(shown) : '?';
|
||||
std::string arg(1, c);
|
||||
out = {true, CommandId::UnknownKCommand, arg, 0};
|
||||
if (ed)
|
||||
ed->SetStatus(""); // clear hint; handler will set unknown status
|
||||
return true;
|
||||
}
|
||||
out.hasCommand = false;
|
||||
// Non-printable/unmappable key as k-suffix (e.g., F-keys): report unknown and exit k-mode
|
||||
out = {true, CommandId::UnknownKCommand, std::string("?"), 0};
|
||||
if (ed)
|
||||
ed->SetStatus("");
|
||||
return true;
|
||||
}
|
||||
|
||||
if (is_ctrl) {
|
||||
// Universal argument: C-u
|
||||
if (key == SDLK_u) {
|
||||
if (!uarg_active) {
|
||||
uarg_active = true;
|
||||
uarg_collecting = true;
|
||||
uarg_negative = false;
|
||||
uarg_had_digits = false;
|
||||
uarg_value = 4; // default
|
||||
uarg_text.clear();
|
||||
out = {true, CommandId::UArgStatus, uarg_text, 0};
|
||||
return true;
|
||||
} else if (uarg_collecting && !uarg_had_digits && !uarg_negative) {
|
||||
if (uarg_value <= 0)
|
||||
uarg_value = 4;
|
||||
else
|
||||
uarg_value *= 4; // repeated C-u multiplies by 4
|
||||
out = {true, CommandId::UArgStatus, uarg_text, 0};
|
||||
return true;
|
||||
} else {
|
||||
// End collection if already started with digits or '-'
|
||||
uarg_collecting = false;
|
||||
if (!uarg_had_digits && !uarg_negative && uarg_value <= 0)
|
||||
uarg_value = 4;
|
||||
}
|
||||
if (ed)
|
||||
ed->UArgStart();
|
||||
out.hasCommand = false;
|
||||
return true;
|
||||
}
|
||||
// Cancel universal arg on C-g as well (it maps to Refresh via ctrl map)
|
||||
if (key == SDLK_g) {
|
||||
uarg_active = false;
|
||||
uarg_collecting = false;
|
||||
uarg_negative = false;
|
||||
uarg_had_digits = false;
|
||||
uarg_value = 0;
|
||||
uarg_text.clear();
|
||||
if (ed)
|
||||
ed->UArgClear();
|
||||
// Also cancel any pending k-prefix qualifier
|
||||
k_ctrl_pending = false;
|
||||
k_prefix = false; // treat as cancel of prefix
|
||||
}
|
||||
if (key == SDLK_k || key == SDLK_KP_EQUALS) {
|
||||
k_prefix = true;
|
||||
@@ -258,29 +268,17 @@ map_key(const SDL_Keycode key,
|
||||
}
|
||||
}
|
||||
|
||||
// If collecting universal argument, allow digits/minus on KEYDOWN path too
|
||||
if (uarg_active && uarg_collecting) {
|
||||
// If collecting universal argument, allow digits on KEYDOWN path too
|
||||
if (ed && ed->UArg() != 0) {
|
||||
if ((key >= SDLK_0 && key <= SDLK_9) && !(mod & KMOD_SHIFT)) {
|
||||
int d = static_cast<int>(key - SDLK_0);
|
||||
if (!uarg_had_digits) {
|
||||
uarg_value = 0;
|
||||
uarg_had_digits = true;
|
||||
}
|
||||
if (uarg_value < 100000000) {
|
||||
uarg_value = uarg_value * 10 + d;
|
||||
}
|
||||
uarg_text.push_back(static_cast<char>('0' + d));
|
||||
out = {true, CommandId::UArgStatus, uarg_text, 0};
|
||||
ed->UArgDigit(d);
|
||||
out.hasCommand = false;
|
||||
// We consumed a digit on KEYDOWN; SDL will often also emit TEXTINPUT for it.
|
||||
// Request suppression of the very next TEXTINPUT to avoid double-counting.
|
||||
suppress_textinput_once = true;
|
||||
return true;
|
||||
}
|
||||
if (key == SDLK_MINUS && !uarg_had_digits && !uarg_negative) {
|
||||
uarg_negative = true;
|
||||
uarg_text = "-";
|
||||
out = {true, CommandId::UArgStatus, uarg_text, 0};
|
||||
return true;
|
||||
}
|
||||
// Any other key will end collection; process it normally
|
||||
uarg_collecting = false;
|
||||
}
|
||||
|
||||
// k_prefix handled earlier
|
||||
@@ -295,307 +293,293 @@ GUIInputHandler::ProcessSDLEvent(const SDL_Event &e)
|
||||
MappedInput mi;
|
||||
bool produced = false;
|
||||
switch (e.type) {
|
||||
case SDL_MOUSEWHEEL: {
|
||||
// Let ImGui handle mouse wheel when it wants to capture the mouse
|
||||
// (e.g., when hovering the editor child window with scrollbars).
|
||||
// This enables native vertical and horizontal scrolling behavior in GUI.
|
||||
if (ImGui::GetIO().WantCaptureMouse)
|
||||
return false;
|
||||
// Otherwise, fallback to mapping vertical wheel to editor scroll commands.
|
||||
int dy = e.wheel.y;
|
||||
case SDL_MOUSEWHEEL: {
|
||||
// Let ImGui handle mouse wheel when it wants to capture the mouse
|
||||
// (e.g., when hovering the editor child window with scrollbars).
|
||||
// This enables native vertical and horizontal scrolling behavior in GUI.
|
||||
if (ImGui::GetIO().WantCaptureMouse)
|
||||
return false;
|
||||
// Otherwise, fallback to mapping vertical wheel to editor scroll commands.
|
||||
int dy = e.wheel.y;
|
||||
#ifdef SDL_MOUSEWHEEL_FLIPPED
|
||||
if (e.wheel.direction == SDL_MOUSEWHEEL_FLIPPED)
|
||||
dy = -dy;
|
||||
if (e.wheel.direction == SDL_MOUSEWHEEL_FLIPPED)
|
||||
dy = -dy;
|
||||
#endif
|
||||
if (dy != 0) {
|
||||
int repeat = dy > 0 ? dy : -dy;
|
||||
CommandId id = dy > 0 ? CommandId::ScrollUp : CommandId::ScrollDown;
|
||||
std::lock_guard<std::mutex> lk(mu_);
|
||||
for (int i = 0; i < repeat; ++i) {
|
||||
q_.push(MappedInput{true, id, std::string(), 0});
|
||||
}
|
||||
return true; // consumed
|
||||
}
|
||||
return false;
|
||||
}
|
||||
case SDL_KEYDOWN: {
|
||||
// Remember state before mapping; used for TEXTINPUT suppression heuristics
|
||||
const bool was_k_prefix = k_prefix_;
|
||||
const bool was_esc_meta = esc_meta_;
|
||||
SDL_Keymod mods = SDL_Keymod(e.key.keysym.mod);
|
||||
const SDL_Keycode key = e.key.keysym.sym;
|
||||
|
||||
// Handle Paste: Ctrl+V (Windows/Linux) or Cmd+V (macOS)
|
||||
// Note: SDL defines letter keycodes in lowercase only (e.g., SDLK_v). Shift does not change keycode.
|
||||
if ((mods & (KMOD_CTRL | KMOD_GUI)) && (key == SDLK_v)) {
|
||||
char *clip = SDL_GetClipboardText();
|
||||
if (clip) {
|
||||
std::string text(clip);
|
||||
SDL_free(clip);
|
||||
// Split on '\n' and enqueue as InsertText/Newline commands
|
||||
if (dy != 0) {
|
||||
int repeat = dy > 0 ? dy : -dy;
|
||||
CommandId id = dy > 0 ? CommandId::ScrollUp : CommandId::ScrollDown;
|
||||
std::lock_guard<std::mutex> lk(mu_);
|
||||
std::size_t start = 0;
|
||||
while (start <= text.size()) {
|
||||
std::size_t pos = text.find('\n', start);
|
||||
std::string_view segment;
|
||||
bool has_nl = (pos != std::string::npos);
|
||||
if (has_nl) {
|
||||
segment = std::string_view(text).substr(start, pos - start);
|
||||
} else {
|
||||
segment = std::string_view(text).substr(start);
|
||||
}
|
||||
if (!segment.empty()) {
|
||||
MappedInput ins{true, CommandId::InsertText, std::string(segment), 0};
|
||||
q_.push(ins);
|
||||
}
|
||||
if (has_nl) {
|
||||
MappedInput nl{true, CommandId::Newline, std::string(), 0};
|
||||
q_.push(nl);
|
||||
start = pos + 1;
|
||||
} else {
|
||||
break;
|
||||
}
|
||||
for (int i = 0; i < repeat; ++i) {
|
||||
q_.push(MappedInput{true, id, std::string(), 0});
|
||||
}
|
||||
// Suppress the corresponding TEXTINPUT that may follow
|
||||
suppress_text_input_once_ = true;
|
||||
return true; // consumed
|
||||
}
|
||||
return false;
|
||||
}
|
||||
case SDL_KEYDOWN: {
|
||||
// Remember state before mapping; used for TEXTINPUT suppression heuristics
|
||||
const bool was_k_prefix = k_prefix_;
|
||||
const bool was_esc_meta = esc_meta_;
|
||||
SDL_Keymod mods = SDL_Keymod(e.key.keysym.mod);
|
||||
const SDL_Keycode key = e.key.keysym.sym;
|
||||
|
||||
produced = map_key(key, mods,
|
||||
k_prefix_, esc_meta_,
|
||||
uarg_active_, uarg_collecting_, uarg_negative_, uarg_had_digits_, uarg_value_,
|
||||
uarg_text_,
|
||||
mi);
|
||||
// Handle Paste: Ctrl+V (Windows/Linux) or Cmd+V (macOS)
|
||||
// Note: SDL defines letter keycodes in lowercase only (e.g., SDLK_v). Shift does not change keycode.
|
||||
if ((mods & (KMOD_CTRL | KMOD_GUI)) && (key == SDLK_v)) {
|
||||
char *clip = SDL_GetClipboardText();
|
||||
if (clip) {
|
||||
std::string text(clip);
|
||||
SDL_free(clip);
|
||||
// Split on '\n' and enqueue as InsertText/Newline commands
|
||||
std::lock_guard<std::mutex> lk(mu_);
|
||||
std::size_t start = 0;
|
||||
while (start <= text.size()) {
|
||||
std::size_t pos = text.find('\n', start);
|
||||
std::string_view segment;
|
||||
bool has_nl = (pos != std::string::npos);
|
||||
if (has_nl) {
|
||||
segment = std::string_view(text).substr(start, pos - start);
|
||||
} else {
|
||||
segment = std::string_view(text).substr(start);
|
||||
}
|
||||
if (!segment.empty()) {
|
||||
MappedInput ins{
|
||||
true, CommandId::InsertText, std::string(segment), 0
|
||||
};
|
||||
q_.push(ins);
|
||||
}
|
||||
if (has_nl) {
|
||||
MappedInput nl{true, CommandId::Newline, std::string(), 0};
|
||||
q_.push(nl);
|
||||
start = pos + 1;
|
||||
} else {
|
||||
break;
|
||||
}
|
||||
}
|
||||
// Suppress the corresponding TEXTINPUT that may follow
|
||||
suppress_text_input_once_ = true;
|
||||
return true; // consumed
|
||||
}
|
||||
}
|
||||
|
||||
// If we inserted a TAB on KEYDOWN, suppress any subsequent SDL_TEXTINPUT
|
||||
// for this keystroke to avoid double insertion on platforms that emit it.
|
||||
if (produced && mi.hasCommand && mi.id == CommandId::InsertText && mi.arg == "\t") {
|
||||
suppress_text_input_once_ = true;
|
||||
}
|
||||
{
|
||||
bool suppress_req = false;
|
||||
produced = map_key(key, mods,
|
||||
k_prefix_, esc_meta_,
|
||||
k_ctrl_pending_,
|
||||
ed_,
|
||||
mi,
|
||||
suppress_req);
|
||||
if (suppress_req) {
|
||||
// Prevent the corresponding TEXTINPUT from delivering the same digit again
|
||||
suppress_text_input_once_ = true;
|
||||
}
|
||||
}
|
||||
|
||||
// If we just consumed a universal-argument digit or '-' on KEYDOWN and emitted UArgStatus,
|
||||
// suppress the subsequent SDL_TEXTINPUT for this keystroke to avoid duplicating the digit in status.
|
||||
if (produced && mi.hasCommand && mi.id == CommandId::UArgStatus) {
|
||||
// Digits without shift, or a plain '-'
|
||||
const bool is_digit_key = (key >= SDLK_0 && key <= SDLK_9) && !(mods & KMOD_SHIFT);
|
||||
const bool is_minus_key = (key == SDLK_MINUS);
|
||||
if (uarg_active_ && uarg_collecting_ &&(is_digit_key || is_minus_key)) {
|
||||
// Note: Do NOT suppress SDL_TEXTINPUT after inserting a TAB. Most platforms
|
||||
// do not emit TEXTINPUT for Tab, and suppressing here would incorrectly
|
||||
// eat the next character typed if no TEXTINPUT follows the Tab press.
|
||||
|
||||
// If we just consumed a universal-argument digit or '-' on KEYDOWN and emitted UArgStatus,
|
||||
// suppress the subsequent SDL_TEXTINPUT for this keystroke to avoid duplicating the digit in status.
|
||||
// Additional suppression handled above when KEYDOWN consumed a uarg digit
|
||||
|
||||
// Suppress the immediate following SDL_TEXTINPUT when a printable KEYDOWN was used as a
|
||||
// k-prefix suffix or Meta (Alt/ESC) chord, regardless of whether a command was produced.
|
||||
const bool is_alt = (mods & (KMOD_ALT | KMOD_LALT | KMOD_RALT)) != 0;
|
||||
const bool is_printable_letter = (key >= SDLK_SPACE && key <= SDLK_z);
|
||||
const bool is_non_text_key =
|
||||
key == SDLK_TAB || key == SDLK_RETURN || key == SDLK_KP_ENTER ||
|
||||
key == SDLK_BACKSPACE || key == SDLK_DELETE || key == SDLK_ESCAPE ||
|
||||
key == SDLK_LEFT || key == SDLK_RIGHT || key == SDLK_UP || key == SDLK_DOWN ||
|
||||
key == SDLK_HOME || key == SDLK_END || key == SDLK_PAGEUP || key == SDLK_PAGEDOWN;
|
||||
|
||||
bool should_suppress = false;
|
||||
if (!is_non_text_key) {
|
||||
// Any k-prefix suffix that is printable should suppress TEXTINPUT, even if no
|
||||
// command mapped (we report unknown via status instead of inserting text).
|
||||
if (was_k_prefix && is_printable_letter) {
|
||||
should_suppress = true;
|
||||
}
|
||||
// Alt/Meta + letter can also generate TEXTINPUT on some platforms
|
||||
const bool is_meta_symbol = (
|
||||
key == SDLK_COMMA || key == SDLK_PERIOD || key == SDLK_LESS || key ==
|
||||
SDLK_GREATER);
|
||||
if (is_alt && ((key >= SDLK_a && key <= SDLK_z) || is_meta_symbol)) {
|
||||
should_suppress = true;
|
||||
}
|
||||
// ESC-as-meta followed by printable
|
||||
if (was_esc_meta && (is_printable_letter || is_meta_symbol)) {
|
||||
should_suppress = true;
|
||||
}
|
||||
}
|
||||
if (should_suppress) {
|
||||
suppress_text_input_once_ = true;
|
||||
}
|
||||
}
|
||||
|
||||
// Suppress the immediate following SDL_TEXTINPUT when a printable KEYDOWN was used as a
|
||||
// k-prefix suffix or Meta (Alt/ESC) chord, regardless of whether a command was produced.
|
||||
const bool is_alt = (mods & (KMOD_ALT | KMOD_LALT | KMOD_RALT)) != 0;
|
||||
const bool is_printable_letter = (key >= SDLK_SPACE && key <= SDLK_z);
|
||||
const bool is_non_text_key =
|
||||
key == SDLK_TAB || key == SDLK_RETURN || key == SDLK_KP_ENTER ||
|
||||
key == SDLK_BACKSPACE || key == SDLK_DELETE || key == SDLK_ESCAPE ||
|
||||
key == SDLK_LEFT || key == SDLK_RIGHT || key == SDLK_UP || key == SDLK_DOWN ||
|
||||
key == SDLK_HOME || key == SDLK_END || key == SDLK_PAGEUP || key == SDLK_PAGEDOWN;
|
||||
|
||||
bool should_suppress = false;
|
||||
if (!is_non_text_key) {
|
||||
// Any k-prefix suffix that is printable should suppress TEXTINPUT, even if no
|
||||
// command mapped (we report unknown via status instead of inserting text).
|
||||
if (was_k_prefix && is_printable_letter) {
|
||||
should_suppress = true;
|
||||
}
|
||||
// Alt/Meta + letter can also generate TEXTINPUT on some platforms
|
||||
const bool is_meta_symbol = (
|
||||
key == SDLK_COMMA || key == SDLK_PERIOD || key == SDLK_LESS || key == SDLK_GREATER);
|
||||
if (is_alt && ((key >= SDLK_a && key <= SDLK_z) || is_meta_symbol)) {
|
||||
should_suppress = true;
|
||||
}
|
||||
// ESC-as-meta followed by printable
|
||||
if (was_esc_meta && (is_printable_letter || is_meta_symbol)) {
|
||||
should_suppress = true;
|
||||
}
|
||||
}
|
||||
if (should_suppress) {
|
||||
suppress_text_input_once_ = true;
|
||||
}
|
||||
break;
|
||||
}
|
||||
case SDL_TEXTINPUT: {
|
||||
// If the previous KEYDOWN requested suppression of this TEXTINPUT (e.g.,
|
||||
// we already handled a uarg digit/minus or a k-prefix printable), do it
|
||||
// immediately before any other handling to avoid duplicates.
|
||||
if (suppress_text_input_once_) {
|
||||
suppress_text_input_once_ = false; // consume suppression
|
||||
produced = true; // consumed event
|
||||
break;
|
||||
}
|
||||
|
||||
// If universal argument collection is active, consume digit/minus TEXTINPUT
|
||||
if (uarg_active_ && uarg_collecting_) {
|
||||
const char *txt = e.text.text;
|
||||
if (txt && *txt) {
|
||||
unsigned char c0 = static_cast<unsigned char>(txt[0]);
|
||||
if (c0 >= '0' && c0 <= '9') {
|
||||
int d = c0 - '0';
|
||||
if (!uarg_had_digits_) {
|
||||
uarg_value_ = 0;
|
||||
uarg_had_digits_ = true;
|
||||
}
|
||||
if (uarg_value_ < 100000000) {
|
||||
uarg_value_ = uarg_value_ * 10 + d;
|
||||
}
|
||||
uarg_text_.push_back(static_cast<char>(c0));
|
||||
mi = {true, CommandId::UArgStatus, uarg_text_, 0};
|
||||
produced = true; // consumed and enqueued status update
|
||||
break;
|
||||
}
|
||||
if (c0 == '-' && !uarg_had_digits_ && !uarg_negative_) {
|
||||
uarg_negative_ = true;
|
||||
uarg_text_ = "-";
|
||||
mi = {true, CommandId::UArgStatus, uarg_text_, 0};
|
||||
produced = true;
|
||||
break;
|
||||
}
|
||||
case SDL_TEXTINPUT: {
|
||||
// If the previous KEYDOWN requested suppression of this TEXTINPUT (e.g.,
|
||||
// we already handled a uarg digit/minus or a k-prefix printable), do it
|
||||
// immediately before any other handling to avoid duplicates.
|
||||
if (suppress_text_input_once_) {
|
||||
suppress_text_input_once_ = false; // consume suppression
|
||||
produced = true; // consumed event
|
||||
break;
|
||||
}
|
||||
// End collection and allow this TEXTINPUT to be processed normally below
|
||||
uarg_collecting_ = false;
|
||||
}
|
||||
|
||||
// If we are still in k-prefix and KEYDOWN path didn't handle the suffix,
|
||||
// use TEXTINPUT's actual character (handles Shifted letters on macOS) to map the k-command.
|
||||
if (k_prefix_) {
|
||||
k_prefix_ = false;
|
||||
esc_meta_ = false;
|
||||
const char *txt = e.text.text;
|
||||
if (txt && *txt) {
|
||||
unsigned char c0 = static_cast<unsigned char>(txt[0]);
|
||||
int ascii_key = 0;
|
||||
if (c0 < 0x80) {
|
||||
ascii_key = static_cast<int>(c0);
|
||||
}
|
||||
if (ascii_key != 0) {
|
||||
// Map via k-prefix table; do not pass Ctrl for TEXTINPUT case
|
||||
CommandId id;
|
||||
bool mapped = KLookupKCommand(ascii_key, false, id);
|
||||
// Diagnostics: log any k-prefix TEXTINPUT suffix mapping
|
||||
char disp = (ascii_key >= 0x20 && ascii_key <= 0x7e)
|
||||
? static_cast<char>(ascii_key)
|
||||
: '?';
|
||||
std::fprintf(stderr,
|
||||
"[kge] k-prefix TEXTINPUT suffix: ascii=%d '%c' mapped=%d id=%d\n",
|
||||
ascii_key, disp, mapped ? 1 : 0,
|
||||
mapped ? static_cast<int>(id) : -1);
|
||||
std::fflush(stderr);
|
||||
if (mapped) {
|
||||
mi = {true, id, "", 0};
|
||||
produced = true;
|
||||
break; // handled; do not insert text
|
||||
} else {
|
||||
// Unknown k-command via TEXTINPUT path
|
||||
int shown = KLowerAscii(ascii_key);
|
||||
char c = (shown >= 0x20 && shown <= 0x7e)
|
||||
? static_cast<char>(shown)
|
||||
: '?';
|
||||
std::string arg(1, c);
|
||||
mi = {true, CommandId::UnknownKCommand, arg, 0};
|
||||
produced = true;
|
||||
// If editor universal argument is active, consume digit TEXTINPUT
|
||||
if (ed_ &&ed_
|
||||
|
||||
->
|
||||
UArg() != 0
|
||||
)
|
||||
{
|
||||
const char *txt = e.text.text;
|
||||
if (txt && *txt) {
|
||||
unsigned char c0 = static_cast<unsigned char>(txt[0]);
|
||||
if (c0 >= '0' && c0 <= '9') {
|
||||
int d = c0 - '0';
|
||||
ed_->UArgDigit(d);
|
||||
produced = true; // consumed to update status
|
||||
break;
|
||||
}
|
||||
}
|
||||
// Non-digit ends collection; allow processing normally below
|
||||
}
|
||||
// Consume even if no usable ascii was found
|
||||
produced = true;
|
||||
break;
|
||||
}
|
||||
// (suppression is handled at the top of this case)
|
||||
// Handle ESC-as-meta fallback on TEXTINPUT: some platforms emit only TEXTINPUT
|
||||
// for the printable part after ESC. If esc_meta_ is set, translate first char.
|
||||
if (esc_meta_) {
|
||||
esc_meta_ = false; // consume meta prefix
|
||||
const char *txt = e.text.text;
|
||||
if (txt && *txt) {
|
||||
// Parse first UTF-8 codepoint (we care only about common ASCII cases)
|
||||
unsigned char c0 = static_cast<unsigned char>(txt[0]);
|
||||
// Map a few common symbols/letters used in our ESC map
|
||||
int ascii_key = 0;
|
||||
if (c0 < 0x80) {
|
||||
// ASCII path
|
||||
ascii_key = static_cast<int>(c0);
|
||||
ascii_key = KLowerAscii(ascii_key);
|
||||
} else {
|
||||
// Basic handling for macOS Option combos that might produce ≤/≥
|
||||
// Compare the UTF-8 prefix for these two symbols
|
||||
std::string s(txt);
|
||||
if (s.rfind("\xE2\x89\xA4", 0) == 0) {
|
||||
// U+2264 '≤'
|
||||
ascii_key = '<';
|
||||
} else if (s.rfind("\xE2\x89\xA5", 0) == 0) {
|
||||
// U+2265 '≥'
|
||||
ascii_key = '>';
|
||||
|
||||
// If we are still in k-prefix and KEYDOWN path didn't handle the suffix,
|
||||
// use TEXTINPUT's actual character (handles Shifted letters on macOS) to map the k-command.
|
||||
if (k_prefix_) {
|
||||
k_prefix_ = false;
|
||||
esc_meta_ = false;
|
||||
const char *txt = e.text.text;
|
||||
if (txt && *txt) {
|
||||
unsigned char c0 = static_cast<unsigned char>(txt[0]);
|
||||
int ascii_key = 0;
|
||||
if (c0 < 0x80) {
|
||||
ascii_key = static_cast<int>(c0);
|
||||
}
|
||||
if (ascii_key != 0) {
|
||||
// Qualifier via TEXTINPUT: 'C' or '^'
|
||||
if (ascii_key == 'C' || ascii_key == 'c' || ascii_key == '^') {
|
||||
k_ctrl_pending_ = true;
|
||||
if (ed_)
|
||||
ed_->SetStatus("C-k C _");
|
||||
// Keep k-prefix active; do not emit a command
|
||||
k_prefix_ = true;
|
||||
produced = true;
|
||||
break;
|
||||
}
|
||||
// Map via k-prefix table; do not pass Ctrl for TEXTINPUT case
|
||||
CommandId id;
|
||||
bool pass_ctrl = k_ctrl_pending_;
|
||||
k_ctrl_pending_ = false;
|
||||
bool mapped = KLookupKCommand(ascii_key, pass_ctrl, id);
|
||||
// Diagnostics: log any k-prefix TEXTINPUT suffix mapping
|
||||
char disp = (ascii_key >= 0x20 && ascii_key <= 0x7e)
|
||||
? static_cast<char>(ascii_key)
|
||||
: '?';
|
||||
std::fprintf(stderr,
|
||||
"[kge] k-prefix TEXTINPUT suffix: ascii=%d '%c' mapped=%d id=%d\n",
|
||||
ascii_key, disp, mapped ? 1 : 0,
|
||||
mapped ? static_cast<int>(id) : -1);
|
||||
std::fflush(stderr);
|
||||
if (mapped) {
|
||||
mi = {true, id, "", 0};
|
||||
if (ed_)
|
||||
ed_->SetStatus(""); // clear "C-k _" hint after suffix
|
||||
produced = true;
|
||||
break; // handled; do not insert text
|
||||
} else {
|
||||
// Unknown k-command via TEXTINPUT path
|
||||
int shown = KLowerAscii(ascii_key);
|
||||
char c = (shown >= 0x20 && shown <= 0x7e)
|
||||
? static_cast<char>(shown)
|
||||
: '?';
|
||||
std::string arg(1, c);
|
||||
mi = {true, CommandId::UnknownKCommand, arg, 0};
|
||||
if (ed_)
|
||||
ed_->SetStatus("");
|
||||
produced = true;
|
||||
break;
|
||||
}
|
||||
}
|
||||
}
|
||||
if (ascii_key != 0) {
|
||||
CommandId id;
|
||||
if (KLookupEscCommand(ascii_key, id)) {
|
||||
mi = {true, id, "", 0};
|
||||
produced = true;
|
||||
break;
|
||||
}
|
||||
}
|
||||
}
|
||||
// If we get here, swallow the TEXTINPUT (do not insert stray char)
|
||||
produced = true;
|
||||
break;
|
||||
}
|
||||
if (!k_prefix_ && e.text.text[0] != '\0') {
|
||||
// Ensure InsertText never carries a newline; those must originate from KEYDOWN
|
||||
std::string text(e.text.text);
|
||||
// Strip any CR/LF that might slip through from certain platforms/IME behaviors
|
||||
text.erase(std::remove(text.begin(), text.end(), '\n'), text.end());
|
||||
text.erase(std::remove(text.begin(), text.end(), '\r'), text.end());
|
||||
if (!text.empty()) {
|
||||
mi.hasCommand = true;
|
||||
mi.id = CommandId::InsertText;
|
||||
mi.arg = std::move(text);
|
||||
mi.count = 0;
|
||||
produced = true;
|
||||
} else {
|
||||
// Nothing to insert after filtering; consume the event
|
||||
// If no usable ASCII was found, still report an unknown k-command and exit k-mode
|
||||
mi = {true, CommandId::UnknownKCommand, std::string("?"), 0};
|
||||
if (ed_)
|
||||
ed_->SetStatus("");
|
||||
produced = true;
|
||||
break;
|
||||
}
|
||||
} else {
|
||||
produced = true; // consumed while k-prefix is active
|
||||
// (suppression is handled at the top of this case)
|
||||
// Handle ESC-as-meta fallback on TEXTINPUT: some platforms emit only TEXTINPUT
|
||||
// for the printable part after ESC. If esc_meta_ is set, translate first char.
|
||||
if (esc_meta_) {
|
||||
esc_meta_ = false; // consume meta prefix
|
||||
const char *txt = e.text.text;
|
||||
if (txt && *txt) {
|
||||
// Parse first UTF-8 codepoint (we care only about common ASCII cases)
|
||||
unsigned char c0 = static_cast<unsigned char>(txt[0]);
|
||||
// Map a few common symbols/letters used in our ESC map
|
||||
int ascii_key = 0;
|
||||
if (c0 < 0x80) {
|
||||
// ASCII path
|
||||
ascii_key = static_cast<int>(c0);
|
||||
ascii_key = KLowerAscii(ascii_key);
|
||||
} else {
|
||||
// Basic handling for macOS Option combos that might produce ≤/≥
|
||||
// Compare the UTF-8 prefix for these two symbols
|
||||
std::string s(txt);
|
||||
if (s.rfind("\xE2\x89\xA4", 0) == 0) {
|
||||
// U+2264 '≤'
|
||||
ascii_key = '<';
|
||||
} else if (s.rfind("\xE2\x89\xA5", 0) == 0) {
|
||||
// U+2265 '≥'
|
||||
ascii_key = '>';
|
||||
}
|
||||
}
|
||||
if (ascii_key != 0) {
|
||||
CommandId id;
|
||||
if (KLookupEscCommand(ascii_key, id)) {
|
||||
mi = {true, id, "", 0};
|
||||
produced = true;
|
||||
break;
|
||||
}
|
||||
}
|
||||
}
|
||||
// If we get here, unmapped ESC sequence via TEXTINPUT: report invalid
|
||||
mi = {true, CommandId::UnknownEscCommand, "", 0};
|
||||
produced = true;
|
||||
break;
|
||||
}
|
||||
if (!k_prefix_ && e.text.text[0] != '\0') {
|
||||
// Ensure InsertText never carries a newline; those must originate from KEYDOWN
|
||||
std::string text(e.text.text);
|
||||
// Strip any CR/LF that might slip through from certain platforms/IME behaviors
|
||||
text.erase(std::remove(text.begin(), text.end(), '\n'), text.end());
|
||||
text.erase(std::remove(text.begin(), text.end(), '\r'), text.end());
|
||||
if (!text.empty()) {
|
||||
mi.hasCommand = true;
|
||||
mi.id = CommandId::InsertText;
|
||||
mi.arg = std::move(text);
|
||||
mi.count = 0;
|
||||
produced = true;
|
||||
} else {
|
||||
// Nothing to insert after filtering; consume the event
|
||||
produced = true;
|
||||
}
|
||||
} else {
|
||||
produced = true; // consumed while k-prefix is active
|
||||
}
|
||||
break;
|
||||
}
|
||||
break;
|
||||
}
|
||||
default:
|
||||
break;
|
||||
default:
|
||||
break;
|
||||
}
|
||||
|
||||
if (produced && mi.hasCommand) {
|
||||
// Attach universal-argument count if present, then clear the state
|
||||
if (uarg_active_ &&mi
|
||||
|
||||
|
||||
|
||||
.
|
||||
id != CommandId::UArgStatus
|
||||
)
|
||||
{
|
||||
int count = 0;
|
||||
if (!uarg_had_digits_ && !uarg_negative_) {
|
||||
count = (uarg_value_ > 0) ? uarg_value_ : 4;
|
||||
} else {
|
||||
count = uarg_value_;
|
||||
if (uarg_negative_)
|
||||
count = -count;
|
||||
}
|
||||
mi.count = count;
|
||||
uarg_active_ = false;
|
||||
uarg_collecting_ = false;
|
||||
uarg_negative_ = false;
|
||||
uarg_had_digits_ = false;
|
||||
uarg_value_ = 0;
|
||||
uarg_text_.clear();
|
||||
}
|
||||
std::lock_guard<std::mutex> lk(mu_);
|
||||
q_.push(mi);
|
||||
}
|
||||
|
||||
@@ -1,9 +1,7 @@
|
||||
/*
|
||||
* GUIInputHandler - ImGui/SDL2-based input mapping for GUI mode
|
||||
*/
|
||||
#ifndef KTE_GUI_INPUT_HANDLER_H
|
||||
#define KTE_GUI_INPUT_HANDLER_H
|
||||
|
||||
#pragma once
|
||||
#include <mutex>
|
||||
#include <queue>
|
||||
|
||||
@@ -18,6 +16,13 @@ public:
|
||||
|
||||
~GUIInputHandler() override = default;
|
||||
|
||||
|
||||
void Attach(Editor *ed) override
|
||||
{
|
||||
ed_ = ed;
|
||||
}
|
||||
|
||||
|
||||
// Translate an SDL event to editor command and enqueue if applicable.
|
||||
// Returns true if it produced a mapped command or consumed input.
|
||||
bool ProcessSDLEvent(const SDL_Event &e);
|
||||
@@ -27,20 +32,13 @@ public:
|
||||
private:
|
||||
std::mutex mu_;
|
||||
std::queue<MappedInput> q_;
|
||||
bool k_prefix_ = false;
|
||||
bool k_prefix_ = false;
|
||||
bool k_ctrl_pending_ = false; // if true, next k-suffix is treated as Ctrl- (qualifier via literal 'C' or '^')
|
||||
// Treat ESC as a Meta prefix: next key is looked up via ESC keymap
|
||||
bool esc_meta_ = false;
|
||||
// When a printable keydown generated a non-text command, suppress the very next SDL_TEXTINPUT
|
||||
// event produced by SDL for the same keystroke to avoid inserting stray characters.
|
||||
bool suppress_text_input_once_ = false;
|
||||
|
||||
// Universal argument (C-u) state for GUI
|
||||
bool uarg_active_ = false; // an argument is pending for the next command
|
||||
bool uarg_collecting_ = false; // collecting digits / '-' right now
|
||||
bool uarg_negative_ = false; // whether a leading '-' was supplied
|
||||
bool uarg_had_digits_ = false; // whether any digits were supplied
|
||||
int uarg_value_ = 0; // current absolute value (>=0)
|
||||
std::string uarg_text_; // raw digits/minus typed for status display
|
||||
};
|
||||
|
||||
#endif // KTE_GUI_INPUT_HANDLER_H
|
||||
Editor *ed_ = nullptr; // attached editor for editor-owned uarg handling
|
||||
};
|
||||
155
GUIRenderer.cc
155
GUIRenderer.cc
@@ -140,8 +140,7 @@ GUIRenderer::Draw(Editor &ed)
|
||||
prev_buf_coloffs = buf_coloffs;
|
||||
|
||||
// Synchronize cursor and scrolling.
|
||||
// Ensure the cursor is visible even on the first frame or when it didn't move,
|
||||
// unless we already forced scrolling from Buffer::Rowoffs this frame.
|
||||
// Ensure the cursor is visible even on the first frame or when it didn't move.
|
||||
{
|
||||
// Compute visible row range using the child window height
|
||||
float child_h = ImGui::GetWindowHeight();
|
||||
@@ -151,56 +150,54 @@ GUIRenderer::Draw(Editor &ed)
|
||||
vis_rows = 1;
|
||||
long last_row = first_row + vis_rows - 1;
|
||||
|
||||
if (!forced_scroll) {
|
||||
long cyr = static_cast<long>(cy);
|
||||
if (cyr < first_row || cyr > last_row) {
|
||||
float target = (static_cast<float>(cyr) - std::max(0L, vis_rows / 2)) * row_h;
|
||||
float max_y = ImGui::GetScrollMaxY();
|
||||
if (target < 0.f)
|
||||
target = 0.f;
|
||||
if (max_y >= 0.f && target > max_y)
|
||||
target = max_y;
|
||||
ImGui::SetScrollY(target);
|
||||
// refresh local variables
|
||||
scroll_y = ImGui::GetScrollY();
|
||||
first_row = static_cast<long>(scroll_y / row_h);
|
||||
last_row = first_row + vis_rows - 1;
|
||||
}
|
||||
long cyr = static_cast<long>(cy);
|
||||
if (cyr < first_row || cyr > last_row) {
|
||||
float target = (static_cast<float>(cyr) - std::max(0L, vis_rows / 2)) * row_h;
|
||||
float max_y = ImGui::GetScrollMaxY();
|
||||
if (target < 0.f)
|
||||
target = 0.f;
|
||||
if (max_y >= 0.f && target > max_y)
|
||||
target = max_y;
|
||||
ImGui::SetScrollY(target);
|
||||
// refresh local variables
|
||||
scroll_y = ImGui::GetScrollY();
|
||||
first_row = static_cast<long>(scroll_y / row_h);
|
||||
last_row = first_row + vis_rows - 1;
|
||||
}
|
||||
|
||||
// Horizontal scroll: ensure cursor column is visible
|
||||
float child_w = ImGui::GetWindowWidth();
|
||||
long vis_cols = static_cast<long>(child_w / space_w);
|
||||
if (vis_cols < 1)
|
||||
vis_cols = 1;
|
||||
long first_col = static_cast<long>(scroll_x / space_w);
|
||||
long last_col = first_col + vis_cols - 1;
|
||||
// Horizontal scroll: ensure cursor column is visible
|
||||
float child_w = ImGui::GetWindowWidth();
|
||||
long vis_cols = static_cast<long>(child_w / space_w);
|
||||
if (vis_cols < 1)
|
||||
vis_cols = 1;
|
||||
long first_col = static_cast<long>(scroll_x / space_w);
|
||||
long last_col = first_col + vis_cols - 1;
|
||||
|
||||
// Compute cursor's rendered X position (accounting for tabs)
|
||||
std::size_t cursor_rx = 0;
|
||||
if (cy < lines.size()) {
|
||||
std::string cur_line = static_cast<std::string>(lines[cy]);
|
||||
const std::size_t tabw = 8;
|
||||
for (std::size_t i = 0; i < cx && i < cur_line.size(); ++i) {
|
||||
if (cur_line[i] == '\t') {
|
||||
cursor_rx += tabw - (cursor_rx % tabw);
|
||||
} else {
|
||||
cursor_rx += 1;
|
||||
}
|
||||
// Compute cursor's rendered X position (accounting for tabs)
|
||||
std::size_t cursor_rx = 0;
|
||||
if (cy < lines.size()) {
|
||||
std::string cur_line = static_cast<std::string>(lines[cy]);
|
||||
const std::size_t tabw = 8;
|
||||
for (std::size_t i = 0; i < cx && i < cur_line.size(); ++i) {
|
||||
if (cur_line[i] == '\t') {
|
||||
cursor_rx += tabw - (cursor_rx % tabw);
|
||||
} else {
|
||||
cursor_rx += 1;
|
||||
}
|
||||
}
|
||||
long cxr = static_cast<long>(cursor_rx);
|
||||
if (cxr < first_col || cxr > last_col) {
|
||||
float target_x = static_cast<float>(cxr) * space_w;
|
||||
// Center horizontally if possible
|
||||
target_x -= (child_w / 2.0f);
|
||||
if (target_x < 0.f)
|
||||
target_x = 0.f;
|
||||
float max_x = ImGui::GetScrollMaxX();
|
||||
if (max_x >= 0.f && target_x > max_x)
|
||||
target_x = max_x;
|
||||
ImGui::SetScrollX(target_x);
|
||||
scroll_x = ImGui::GetScrollX();
|
||||
}
|
||||
}
|
||||
long cxr = static_cast<long>(cursor_rx);
|
||||
if (cxr < first_col || cxr > last_col) {
|
||||
float target_x = static_cast<float>(cxr) * space_w;
|
||||
// Center horizontally if possible
|
||||
target_x -= (child_w / 2.0f);
|
||||
if (target_x < 0.f)
|
||||
target_x = 0.f;
|
||||
float max_x = ImGui::GetScrollMaxX();
|
||||
if (max_x >= 0.f && target_x > max_x)
|
||||
target_x = max_x;
|
||||
ImGui::SetScrollX(target_x);
|
||||
scroll_x = ImGui::GetScrollX();
|
||||
}
|
||||
// Phase 3: prefetch visible viewport highlights and warm around in background
|
||||
if (buf->SyntaxEnabled() && buf->Highlighter() && buf->Highlighter()->HasHighlighter()) {
|
||||
@@ -372,8 +369,34 @@ GUIRenderer::Draw(Editor &ed)
|
||||
|
||||
// Draw syntax-colored runs (text above background highlights)
|
||||
if (buf->SyntaxEnabled() && buf->Highlighter() && buf->Highlighter()->HasHighlighter()) {
|
||||
const kte::LineHighlight &lh = buf->Highlighter()->GetLine(
|
||||
kte::LineHighlight lh = buf->Highlighter()->GetLine(
|
||||
*buf, static_cast<int>(i), buf->Version());
|
||||
// Sanitize spans defensively: clamp to [0, line.size()], ensure end>=start, drop empties
|
||||
struct SSpan {
|
||||
std::size_t s;
|
||||
std::size_t e;
|
||||
kte::TokenKind k;
|
||||
};
|
||||
std::vector<SSpan> spans;
|
||||
spans.reserve(lh.spans.size());
|
||||
const std::size_t line_len = line.size();
|
||||
for (const auto &sp: lh.spans) {
|
||||
int s_raw = sp.col_start;
|
||||
int e_raw = sp.col_end;
|
||||
if (e_raw < s_raw)
|
||||
std::swap(e_raw, s_raw);
|
||||
std::size_t s = static_cast<std::size_t>(std::max(
|
||||
0, std::min(s_raw, static_cast<int>(line_len))));
|
||||
std::size_t e = static_cast<std::size_t>(std::max(
|
||||
static_cast<int>(s), std::min(e_raw, static_cast<int>(line_len))));
|
||||
if (e <= s)
|
||||
continue;
|
||||
spans.push_back(SSpan{s, e, sp.kind});
|
||||
}
|
||||
std::sort(spans.begin(), spans.end(), [](const SSpan &a, const SSpan &b) {
|
||||
return a.s < b.s;
|
||||
});
|
||||
|
||||
// Helper to convert a src column to expanded rx position
|
||||
auto src_to_rx_full = [&](std::size_t sidx) -> std::size_t {
|
||||
std::size_t rx = 0;
|
||||
@@ -382,24 +405,22 @@ GUIRenderer::Draw(Editor &ed)
|
||||
}
|
||||
return rx;
|
||||
};
|
||||
for (const auto &sp: lh.spans) {
|
||||
std::size_t rx_s = src_to_rx_full(
|
||||
static_cast<std::size_t>(std::max(0, sp.col_start)));
|
||||
std::size_t rx_e = src_to_rx_full(
|
||||
static_cast<std::size_t>(std::max(sp.col_start, sp.col_end)));
|
||||
|
||||
for (const auto &sp: spans) {
|
||||
std::size_t rx_s = src_to_rx_full(sp.s);
|
||||
std::size_t rx_e = src_to_rx_full(sp.e);
|
||||
if (rx_e <= coloffs_now)
|
||||
continue;
|
||||
// Clamp rx_s/rx_e to the visible portion
|
||||
continue; // fully left of viewport
|
||||
// Clamp to visible portion and expanded length
|
||||
std::size_t draw_start = (rx_s > coloffs_now) ? rx_s : coloffs_now;
|
||||
std::size_t draw_end = rx_e;
|
||||
if (draw_start >= expanded.size())
|
||||
continue;
|
||||
draw_end = std::min<std::size_t>(draw_end, expanded.size());
|
||||
continue; // fully right of expanded text
|
||||
std::size_t draw_end = std::min<std::size_t>(rx_e, expanded.size());
|
||||
if (draw_end <= draw_start)
|
||||
continue;
|
||||
// Screen position is relative to coloffs_now
|
||||
std::size_t screen_x = draw_start - coloffs_now;
|
||||
ImU32 col = ImGui::GetColorU32(kte::SyntaxInk(sp.kind));
|
||||
ImU32 col = ImGui::GetColorU32(kte::SyntaxInk(sp.k));
|
||||
ImVec2 p = ImVec2(line_pos.x + static_cast<float>(screen_x) * space_w,
|
||||
line_pos.y);
|
||||
ImGui::GetWindowDrawList()->AddText(
|
||||
@@ -434,7 +455,19 @@ GUIRenderer::Draw(Editor &ed)
|
||||
}
|
||||
// Convert to viewport x by subtracting horizontal col offset
|
||||
std::size_t rx_viewport = (rx_abs > coloffs_now) ? (rx_abs - coloffs_now) : 0;
|
||||
ImVec2 p0 = ImVec2(line_pos.x + static_cast<float>(rx_viewport) * space_w, line_pos.y);
|
||||
// For proportional fonts (Linux GUI), avoid accumulating drift by computing
|
||||
// the exact pixel width of the expanded substring up to the cursor.
|
||||
// expanded contains the line with tabs expanded to spaces and is what we draw.
|
||||
float cursor_px = 0.0f;
|
||||
if (rx_viewport > 0 && coloffs_now < expanded.size()) {
|
||||
std::size_t start = coloffs_now;
|
||||
std::size_t end = std::min(expanded.size(), start + rx_viewport);
|
||||
// Measure substring width in pixels
|
||||
ImVec2 sz = ImGui::CalcTextSize(expanded.c_str() + start,
|
||||
expanded.c_str() + end);
|
||||
cursor_px = sz.x;
|
||||
}
|
||||
ImVec2 p0 = ImVec2(line_pos.x + cursor_px, line_pos.y);
|
||||
ImVec2 p1 = ImVec2(p0.x + space_w, p0.y + line_h);
|
||||
ImU32 col = IM_COL32(200, 200, 255, 128); // soft highlight
|
||||
ImGui::GetWindowDrawList()->AddRectFilled(p0, p1, col);
|
||||
|
||||
@@ -1,9 +1,7 @@
|
||||
/*
|
||||
* GUIRenderer - ImGui-based renderer for GUI mode
|
||||
*/
|
||||
#ifndef KTE_GUI_RENDERER_H
|
||||
#define KTE_GUI_RENDERER_H
|
||||
|
||||
#pragma once
|
||||
#include "Renderer.h"
|
||||
|
||||
class GUIRenderer final : public Renderer {
|
||||
@@ -13,6 +11,4 @@ public:
|
||||
~GUIRenderer() override = default;
|
||||
|
||||
void Draw(Editor &ed) override;
|
||||
};
|
||||
|
||||
#endif // KTE_GUI_RENDERER_H
|
||||
};
|
||||
@@ -38,7 +38,7 @@ enum class ThemeId {
|
||||
|
||||
// Current theme tracking
|
||||
static inline auto gCurrentTheme = ThemeId::Nord;
|
||||
static inline std::size_t gCurrentThemeIndex = 0;
|
||||
static inline std::size_t gCurrentThemeIndex = 6; // Nord index
|
||||
|
||||
// Forward declarations for helpers used below
|
||||
static size_t ThemeIndexFromId(ThemeId id);
|
||||
|
||||
14
GapBuffer.cc
14
GapBuffer.cc
@@ -82,7 +82,7 @@ GapBuffer::~GapBuffer()
|
||||
void
|
||||
GapBuffer::Reserve(const std::size_t newCapacity)
|
||||
{
|
||||
if (newCapacity <= capacity_)
|
||||
if (newCapacity <= capacity_) [[likely]]
|
||||
return;
|
||||
// Allocate space for terminator as well
|
||||
char *nb = new char[newCapacity + 1];
|
||||
@@ -108,7 +108,7 @@ GapBuffer::AppendChar(const char c)
|
||||
void
|
||||
GapBuffer::Append(const char *s, const std::size_t len)
|
||||
{
|
||||
if (!s || len == 0)
|
||||
if (!s || len == 0) [[unlikely]]
|
||||
return;
|
||||
ensureCapacityFor(len);
|
||||
std::memcpy(buffer_ + size_, s, len);
|
||||
@@ -131,7 +131,7 @@ GapBuffer::PrependChar(char c)
|
||||
{
|
||||
ensureCapacityFor(1);
|
||||
// shift right by 1
|
||||
if (size_ > 0) {
|
||||
if (size_ > 0) [[likely]] {
|
||||
std::memmove(buffer_ + 1, buffer_, size_);
|
||||
}
|
||||
buffer_[0] = c;
|
||||
@@ -143,10 +143,10 @@ GapBuffer::PrependChar(char c)
|
||||
void
|
||||
GapBuffer::Prepend(const char *s, std::size_t len)
|
||||
{
|
||||
if (!s || len == 0)
|
||||
if (!s || len == 0) [[unlikely]]
|
||||
return;
|
||||
ensureCapacityFor(len);
|
||||
if (size_ > 0) {
|
||||
if (size_ > 0) [[likely]] {
|
||||
std::memmove(buffer_ + len, buffer_, size_);
|
||||
}
|
||||
std::memcpy(buffer_, s, len);
|
||||
@@ -175,7 +175,7 @@ GapBuffer::Clear()
|
||||
void
|
||||
GapBuffer::ensureCapacityFor(std::size_t delta)
|
||||
{
|
||||
if (capacity_ - size_ >= delta)
|
||||
if (capacity_ - size_ >= delta) [[likely]]
|
||||
return;
|
||||
auto required = size_ + delta;
|
||||
Reserve(growCapacity(capacity_, required));
|
||||
@@ -201,4 +201,4 @@ GapBuffer::setTerminator() const
|
||||
}
|
||||
|
||||
buffer_[size_] = '\0';
|
||||
}
|
||||
}
|
||||
@@ -1,9 +1,7 @@
|
||||
/*
|
||||
* GapBuffer.h - C++ replacement for abuf append/prepend buffer utilities
|
||||
*/
|
||||
#ifndef KTE_GAPBUFFER_H
|
||||
#define KTE_GAPBUFFER_H
|
||||
|
||||
#pragma once
|
||||
#include <cstddef>
|
||||
|
||||
|
||||
@@ -75,6 +73,4 @@ private:
|
||||
char *buffer_ = nullptr;
|
||||
std::size_t size_ = 0; // number of valid bytes (excluding terminator)
|
||||
std::size_t capacity_ = 0; // capacity of buffer_ excluding space for terminator
|
||||
};
|
||||
|
||||
#endif // KTE_GAPBUFFER_H
|
||||
};
|
||||
@@ -1,9 +1,7 @@
|
||||
/*
|
||||
* HelpText.h - embedded/customizable help content
|
||||
*/
|
||||
#ifndef KTE_HELPTEXT_H
|
||||
#define KTE_HELPTEXT_H
|
||||
|
||||
#pragma once
|
||||
#include <string>
|
||||
|
||||
class HelpText {
|
||||
@@ -12,6 +10,4 @@ public:
|
||||
// Project maintainers can customize the returned string below
|
||||
// (in HelpText.cc) without touching the help command logic.
|
||||
static std::string Text();
|
||||
};
|
||||
|
||||
#endif // KTE_HELPTEXT_H
|
||||
};
|
||||
@@ -1,13 +1,13 @@
|
||||
/*
|
||||
* InputHandler.h - input abstraction and mapping to commands
|
||||
*/
|
||||
#ifndef KTE_INPUT_HANDLER_H
|
||||
#define KTE_INPUT_HANDLER_H
|
||||
|
||||
#pragma once
|
||||
#include <string>
|
||||
|
||||
#include "Command.h"
|
||||
|
||||
class Editor; // fwd decl
|
||||
|
||||
|
||||
// Result of translating raw input into an editor command.
|
||||
struct MappedInput {
|
||||
@@ -21,9 +21,11 @@ class InputHandler {
|
||||
public:
|
||||
virtual ~InputHandler() = default;
|
||||
|
||||
// Optional: attach current Editor so handlers can consult editor state (e.g., universal argument)
|
||||
// Default implementation does nothing.
|
||||
virtual void Attach(Editor *) {}
|
||||
|
||||
// Poll for input and translate it to a command. Non-blocking.
|
||||
// Returns true if a command is available in 'out'. Returns false if no input.
|
||||
virtual bool Poll(MappedInput &out) = 0;
|
||||
};
|
||||
|
||||
#endif // KTE_INPUT_HANDLER_H
|
||||
};
|
||||
@@ -1,9 +1,7 @@
|
||||
/*
|
||||
* KKeymap.h - mapping for k-command (C-k prefix) keys to CommandId
|
||||
*/
|
||||
#ifndef KTE_KKEYMAP_H
|
||||
#define KTE_KKEYMAP_H
|
||||
|
||||
#pragma once
|
||||
#include "Command.h"
|
||||
|
||||
|
||||
@@ -29,6 +27,4 @@ KLowerAscii(const int key)
|
||||
if (key >= 'A' && key <= 'Z')
|
||||
return key + ('a' - 'A');
|
||||
return key;
|
||||
}
|
||||
|
||||
#endif // KTE_KKEYMAP_H
|
||||
}
|
||||
79
OptimizedSearch.cc
Normal file
79
OptimizedSearch.cc
Normal file
@@ -0,0 +1,79 @@
|
||||
#include "OptimizedSearch.h"
|
||||
|
||||
#include <algorithm>
|
||||
|
||||
|
||||
void
|
||||
OptimizedSearch::build_bad_char(const std::string &pattern)
|
||||
{
|
||||
if (pattern == last_pat_)
|
||||
return;
|
||||
last_pat_ = pattern;
|
||||
std::fill(bad_char_.begin(), bad_char_.end(), -1);
|
||||
for (std::size_t i = 0; i < pattern.size(); ++i) {
|
||||
bad_char_[static_cast<unsigned char>(pattern[i])] = static_cast<int>(i);
|
||||
}
|
||||
}
|
||||
|
||||
|
||||
std::size_t
|
||||
OptimizedSearch::find_first(const std::string &text, const std::string &pattern, std::size_t start)
|
||||
{
|
||||
const std::size_t n = text.size();
|
||||
const std::size_t m = pattern.size();
|
||||
if (m == 0)
|
||||
return start <= n ? start : std::string::npos;
|
||||
if (m > n || start >= n)
|
||||
return std::string::npos;
|
||||
build_bad_char(pattern);
|
||||
std::size_t s = start;
|
||||
while (s <= n - m) {
|
||||
std::size_t j = m;
|
||||
while (j > 0 && pattern[j - 1] == text[s + j - 1]) {
|
||||
--j;
|
||||
}
|
||||
if (j == 0) {
|
||||
return s; // match found
|
||||
}
|
||||
unsigned char badc = static_cast<unsigned char>(text[s + j - 1]);
|
||||
int bcidx = bad_char_[badc];
|
||||
std::size_t shift = (j - 1 > static_cast<std::size_t>(bcidx))
|
||||
? (j - 1 - static_cast<std::size_t>(bcidx))
|
||||
: 1;
|
||||
s += shift;
|
||||
}
|
||||
return std::string::npos;
|
||||
}
|
||||
|
||||
|
||||
std::vector<std::size_t>
|
||||
OptimizedSearch::find_all(const std::string &text, const std::string &pattern, std::size_t start)
|
||||
{
|
||||
std::vector<std::size_t> res;
|
||||
const std::size_t n = text.size();
|
||||
const std::size_t m = pattern.size();
|
||||
if (m == 0)
|
||||
return res;
|
||||
if (m > n || start >= n)
|
||||
return res;
|
||||
build_bad_char(pattern);
|
||||
std::size_t s = start;
|
||||
while (s <= n - m) {
|
||||
std::size_t j = m;
|
||||
while (j > 0 && pattern[j - 1] == text[s + j - 1]) {
|
||||
--j;
|
||||
}
|
||||
if (j == 0) {
|
||||
res.push_back(s);
|
||||
s += m; // non-overlapping
|
||||
continue;
|
||||
}
|
||||
unsigned char badc = static_cast<unsigned char>(text[s + j - 1]);
|
||||
int bcidx = bad_char_[badc];
|
||||
std::size_t shift = (j - 1 > static_cast<std::size_t>(bcidx))
|
||||
? (j - 1 - static_cast<std::size_t>(bcidx))
|
||||
: 1;
|
||||
s += shift;
|
||||
}
|
||||
return res;
|
||||
}
|
||||
23
OptimizedSearch.h
Normal file
23
OptimizedSearch.h
Normal file
@@ -0,0 +1,23 @@
|
||||
// OptimizedSearch.h - Boyer–Moore (bad character) based substring search
|
||||
#pragma once
|
||||
#include <array>
|
||||
#include <cstddef>
|
||||
#include <string>
|
||||
#include <vector>
|
||||
|
||||
class OptimizedSearch {
|
||||
public:
|
||||
OptimizedSearch() = default;
|
||||
|
||||
// Find first occurrence at or after start. Returns npos if not found.
|
||||
std::size_t find_first(const std::string &text, const std::string &pattern, std::size_t start = 0);
|
||||
|
||||
// Find all non-overlapping matches at or after start. Returns starting indices.
|
||||
std::vector<std::size_t> find_all(const std::string &text, const std::string &pattern, std::size_t start = 0);
|
||||
|
||||
private:
|
||||
std::array<int, 256> bad_char_{};
|
||||
std::string last_pat_;
|
||||
|
||||
void build_bad_char(const std::string &pattern);
|
||||
};
|
||||
@@ -1,9 +1,7 @@
|
||||
/*
|
||||
* PieceTable.h - Alternative to GapBuffer using a piece table representation
|
||||
*/
|
||||
#ifndef KTE_PIECETABLE_H
|
||||
#define KTE_PIECETABLE_H
|
||||
|
||||
#pragma once
|
||||
#include <cstddef>
|
||||
#include <string>
|
||||
#include <vector>
|
||||
@@ -93,6 +91,4 @@ private:
|
||||
mutable std::string materialized_;
|
||||
mutable bool dirty_ = true;
|
||||
std::size_t total_size_ = 0;
|
||||
};
|
||||
|
||||
#endif // KTE_PIECETABLE_H
|
||||
};
|
||||
@@ -8,5 +8,6 @@ ROADMAP / TODO:
|
||||
- [x] When the filename is longer than the message window, scoot left to
|
||||
keep it in view
|
||||
- [x] Syntax highlighting
|
||||
- [ ] Swap files (crash recovery). See `docs/plans/swap-files.md`
|
||||
- [ ] The undo system should actually work
|
||||
- [ ] LSP integration
|
||||
|
||||
@@ -1,9 +1,7 @@
|
||||
/*
|
||||
* Renderer.h - rendering abstraction
|
||||
*/
|
||||
#ifndef KTE_RENDERER_H
|
||||
#define KTE_RENDERER_H
|
||||
|
||||
#pragma once
|
||||
|
||||
class Editor;
|
||||
|
||||
@@ -12,6 +10,4 @@ public:
|
||||
virtual ~Renderer() = default;
|
||||
|
||||
virtual void Draw(Editor &ed) = 0;
|
||||
};
|
||||
|
||||
#endif // KTE_RENDERER_H
|
||||
};
|
||||
434
Swap.cc
Normal file
434
Swap.cc
Normal file
@@ -0,0 +1,434 @@
|
||||
#include "Swap.h"
|
||||
#include "Buffer.h"
|
||||
|
||||
#include <algorithm>
|
||||
#include <chrono>
|
||||
#include <cstdio>
|
||||
#include <cstring>
|
||||
#include <filesystem>
|
||||
#include <fcntl.h>
|
||||
#include <unistd.h>
|
||||
#include <sys/stat.h>
|
||||
#include <cerrno>
|
||||
|
||||
namespace fs = std::filesystem;
|
||||
|
||||
namespace kte {
|
||||
namespace {
|
||||
constexpr std::uint8_t MAGIC[8] = {'K', 'T', 'E', '_', 'S', 'W', 'P', '\0'};
|
||||
constexpr std::uint32_t VERSION = 1;
|
||||
|
||||
// Write all bytes in buf to fd, handling EINTR and partial writes.
|
||||
static bool write_full(int fd, const void *buf, size_t len)
|
||||
{
|
||||
const std::uint8_t *p = static_cast<const std::uint8_t *>(buf);
|
||||
while (len > 0) {
|
||||
ssize_t n = ::write(fd, p, len);
|
||||
if (n < 0) {
|
||||
if (errno == EINTR)
|
||||
continue;
|
||||
return false;
|
||||
}
|
||||
if (n == 0)
|
||||
return false; // shouldn't happen for regular files; treat as error
|
||||
p += static_cast<size_t>(n);
|
||||
len -= static_cast<size_t>(n);
|
||||
}
|
||||
return true;
|
||||
}
|
||||
}
|
||||
|
||||
|
||||
SwapManager::SwapManager()
|
||||
{
|
||||
running_.store(true);
|
||||
worker_ = std::thread([this] {
|
||||
this->writer_loop();
|
||||
});
|
||||
}
|
||||
|
||||
|
||||
SwapManager::~SwapManager()
|
||||
{
|
||||
running_.store(false);
|
||||
cv_.notify_all();
|
||||
if (worker_.joinable())
|
||||
worker_.join();
|
||||
// Close all journals
|
||||
for (auto &kv: journals_) {
|
||||
close_ctx(kv.second);
|
||||
}
|
||||
}
|
||||
|
||||
|
||||
void
|
||||
SwapManager::Attach(Buffer * /*buf*/)
|
||||
{
|
||||
// Stage 1: lazy-open on first record; nothing to do here.
|
||||
}
|
||||
|
||||
|
||||
void
|
||||
SwapManager::Detach(Buffer * /*buf*/)
|
||||
{
|
||||
// Stage 1: keep files open until manager destruction; future work can close per-buffer.
|
||||
}
|
||||
|
||||
|
||||
void
|
||||
SwapManager::NotifyFilenameChanged(Buffer &buf)
|
||||
{
|
||||
std::lock_guard<std::mutex> lg(mtx_);
|
||||
auto it = journals_.find(&buf);
|
||||
if (it == journals_.end())
|
||||
return;
|
||||
JournalCtx &ctx = it->second;
|
||||
// Close existing file handle, update path; lazily reopen on next write
|
||||
close_ctx(ctx);
|
||||
ctx.path = ComputeSidecarPath(buf);
|
||||
}
|
||||
|
||||
|
||||
void
|
||||
SwapManager::SetSuspended(Buffer &buf, bool on)
|
||||
{
|
||||
std::lock_guard<std::mutex> lg(mtx_);
|
||||
auto path = ComputeSidecarPath(buf);
|
||||
// Create/update context for this buffer
|
||||
JournalCtx &ctx = journals_[&buf];
|
||||
ctx.path = path;
|
||||
ctx.suspended = on;
|
||||
}
|
||||
|
||||
|
||||
SwapManager::SuspendGuard::SuspendGuard(SwapManager &m, Buffer *b)
|
||||
: m_(m), buf_(b), prev_(false)
|
||||
{
|
||||
// Suspend recording while guard is alive
|
||||
if (buf_)
|
||||
m_.SetSuspended(*buf_, true);
|
||||
}
|
||||
|
||||
|
||||
SwapManager::SuspendGuard::~SuspendGuard()
|
||||
{
|
||||
if (buf_)
|
||||
m_.SetSuspended(*buf_, false);
|
||||
}
|
||||
|
||||
|
||||
std::string
|
||||
SwapManager::ComputeSidecarPath(const Buffer &buf)
|
||||
{
|
||||
if (buf.IsFileBacked() || !buf.Filename().empty()) {
|
||||
fs::path p(buf.Filename());
|
||||
fs::path dir = p.parent_path();
|
||||
std::string base = p.filename().string();
|
||||
std::string side = "." + base + ".kte.swp";
|
||||
return (dir / side).string();
|
||||
}
|
||||
// unnamed: $TMPDIR/kte/unnamed-<ptr>.kte.swp (best-effort)
|
||||
const char *tmp = std::getenv("TMPDIR");
|
||||
fs::path t = tmp ? fs::path(tmp) : fs::temp_directory_path();
|
||||
fs::path d = t / "kte";
|
||||
char bufptr[32];
|
||||
std::snprintf(bufptr, sizeof(bufptr), "%p", (const void *) &buf);
|
||||
return (d / (std::string("unnamed-") + bufptr + ".kte.swp")).string();
|
||||
}
|
||||
|
||||
|
||||
std::uint64_t
|
||||
SwapManager::now_ns()
|
||||
{
|
||||
using namespace std::chrono;
|
||||
return duration_cast<nanoseconds>(steady_clock::now().time_since_epoch()).count();
|
||||
}
|
||||
|
||||
|
||||
bool
|
||||
SwapManager::ensure_parent_dir(const std::string &path)
|
||||
{
|
||||
try {
|
||||
fs::path p(path);
|
||||
fs::path dir = p.parent_path();
|
||||
if (dir.empty())
|
||||
return true;
|
||||
if (!fs::exists(dir))
|
||||
fs::create_directories(dir);
|
||||
return true;
|
||||
} catch (...) {
|
||||
return false;
|
||||
}
|
||||
}
|
||||
|
||||
|
||||
bool
|
||||
SwapManager::write_header(JournalCtx &ctx)
|
||||
{
|
||||
if (ctx.fd < 0)
|
||||
return false;
|
||||
// Write a simple 64-byte header
|
||||
std::uint8_t hdr[64];
|
||||
std::memset(hdr, 0, sizeof(hdr));
|
||||
std::memcpy(hdr, MAGIC, 8);
|
||||
std::uint32_t ver = VERSION;
|
||||
std::memcpy(hdr + 8, &ver, sizeof(ver));
|
||||
std::uint64_t ts = static_cast<std::uint64_t>(std::time(nullptr));
|
||||
std::memcpy(hdr + 16, &ts, sizeof(ts));
|
||||
ssize_t w = ::write(ctx.fd, hdr, sizeof(hdr));
|
||||
return (w == (ssize_t) sizeof(hdr));
|
||||
}
|
||||
|
||||
|
||||
bool
|
||||
SwapManager::open_ctx(JournalCtx &ctx)
|
||||
{
|
||||
if (ctx.fd >= 0)
|
||||
return true;
|
||||
if (!ensure_parent_dir(ctx.path))
|
||||
return false;
|
||||
// Create or open with 0600 perms
|
||||
int fd = ::open(ctx.path.c_str(), O_CREAT | O_RDWR, 0600);
|
||||
if (fd < 0)
|
||||
return false;
|
||||
// Detect if file is new/empty to write header
|
||||
struct stat st{};
|
||||
if (fstat(fd, &st) != 0) {
|
||||
::close(fd);
|
||||
return false;
|
||||
}
|
||||
ctx.fd = fd;
|
||||
ctx.file = fdopen(fd, "ab");
|
||||
if (!ctx.file) {
|
||||
::close(fd);
|
||||
ctx.fd = -1;
|
||||
return false;
|
||||
}
|
||||
if (st.st_size == 0) {
|
||||
ctx.header_ok = write_header(ctx);
|
||||
} else {
|
||||
ctx.header_ok = true; // trust existing file for stage 1
|
||||
// Seek to end to append
|
||||
::lseek(ctx.fd, 0, SEEK_END);
|
||||
}
|
||||
return ctx.header_ok;
|
||||
}
|
||||
|
||||
|
||||
void
|
||||
SwapManager::close_ctx(JournalCtx &ctx)
|
||||
{
|
||||
if (ctx.file) {
|
||||
std::fflush((FILE *) ctx.file);
|
||||
::fsync(ctx.fd);
|
||||
std::fclose((FILE *) ctx.file);
|
||||
ctx.file = nullptr;
|
||||
}
|
||||
if (ctx.fd >= 0) {
|
||||
::close(ctx.fd);
|
||||
ctx.fd = -1;
|
||||
}
|
||||
}
|
||||
|
||||
|
||||
std::uint32_t
|
||||
SwapManager::crc32(const std::uint8_t *data, std::size_t len, std::uint32_t seed)
|
||||
{
|
||||
static std::uint32_t table[256];
|
||||
static bool inited = false;
|
||||
if (!inited) {
|
||||
for (std::uint32_t i = 0; i < 256; ++i) {
|
||||
std::uint32_t c = i;
|
||||
for (int j = 0; j < 8; ++j)
|
||||
c = (c & 1) ? (0xEDB88320u ^ (c >> 1)) : (c >> 1);
|
||||
table[i] = c;
|
||||
}
|
||||
inited = true;
|
||||
}
|
||||
std::uint32_t c = ~seed;
|
||||
for (std::size_t i = 0; i < len; ++i)
|
||||
c = table[(c ^ data[i]) & 0xFFu] ^ (c >> 8);
|
||||
return ~c;
|
||||
}
|
||||
|
||||
|
||||
void
|
||||
SwapManager::put_varu64(std::vector<std::uint8_t> &out, std::uint64_t v)
|
||||
{
|
||||
while (v >= 0x80) {
|
||||
out.push_back(static_cast<std::uint8_t>(v) | 0x80);
|
||||
v >>= 7;
|
||||
}
|
||||
out.push_back(static_cast<std::uint8_t>(v));
|
||||
}
|
||||
|
||||
|
||||
void
|
||||
SwapManager::put_u24(std::uint8_t dst[3], std::uint32_t v)
|
||||
{
|
||||
dst[0] = static_cast<std::uint8_t>((v >> 16) & 0xFF);
|
||||
dst[1] = static_cast<std::uint8_t>((v >> 8) & 0xFF);
|
||||
dst[2] = static_cast<std::uint8_t>(v & 0xFF);
|
||||
}
|
||||
|
||||
|
||||
void
|
||||
SwapManager::enqueue(Pending &&p)
|
||||
{
|
||||
{
|
||||
std::lock_guard<std::mutex> lg(mtx_);
|
||||
queue_.emplace_back(std::move(p));
|
||||
}
|
||||
cv_.notify_one();
|
||||
}
|
||||
|
||||
|
||||
void
|
||||
SwapManager::RecordInsert(Buffer &buf, int row, int col, std::string_view text)
|
||||
{
|
||||
{
|
||||
std::lock_guard<std::mutex> lg(mtx_);
|
||||
if (journals_[&buf].suspended)
|
||||
return;
|
||||
}
|
||||
Pending p;
|
||||
p.buf = &buf;
|
||||
p.type = SwapRecType::INS;
|
||||
// payload: varint row, varint col, varint len, bytes
|
||||
put_varu64(p.payload, static_cast<std::uint64_t>(std::max(0, row)));
|
||||
put_varu64(p.payload, static_cast<std::uint64_t>(std::max(0, col)));
|
||||
put_varu64(p.payload, static_cast<std::uint64_t>(text.size()));
|
||||
p.payload.insert(p.payload.end(), reinterpret_cast<const std::uint8_t *>(text.data()),
|
||||
reinterpret_cast<const std::uint8_t *>(text.data()) + text.size());
|
||||
enqueue(std::move(p));
|
||||
}
|
||||
|
||||
|
||||
void
|
||||
SwapManager::RecordDelete(Buffer &buf, int row, int col, std::size_t len)
|
||||
{
|
||||
{
|
||||
std::lock_guard<std::mutex> lg(mtx_);
|
||||
if (journals_[&buf].suspended)
|
||||
return;
|
||||
}
|
||||
Pending p;
|
||||
p.buf = &buf;
|
||||
p.type = SwapRecType::DEL;
|
||||
put_varu64(p.payload, static_cast<std::uint64_t>(std::max(0, row)));
|
||||
put_varu64(p.payload, static_cast<std::uint64_t>(std::max(0, col)));
|
||||
put_varu64(p.payload, static_cast<std::uint64_t>(len));
|
||||
enqueue(std::move(p));
|
||||
}
|
||||
|
||||
|
||||
void
|
||||
SwapManager::RecordSplit(Buffer &buf, int row, int col)
|
||||
{
|
||||
{
|
||||
std::lock_guard<std::mutex> lg(mtx_);
|
||||
if (journals_[&buf].suspended)
|
||||
return;
|
||||
}
|
||||
Pending p;
|
||||
p.buf = &buf;
|
||||
p.type = SwapRecType::SPLIT;
|
||||
put_varu64(p.payload, static_cast<std::uint64_t>(std::max(0, row)));
|
||||
put_varu64(p.payload, static_cast<std::uint64_t>(std::max(0, col)));
|
||||
enqueue(std::move(p));
|
||||
}
|
||||
|
||||
|
||||
void
|
||||
SwapManager::RecordJoin(Buffer &buf, int row)
|
||||
{
|
||||
{
|
||||
std::lock_guard<std::mutex> lg(mtx_);
|
||||
if (journals_[&buf].suspended)
|
||||
return;
|
||||
}
|
||||
Pending p;
|
||||
p.buf = &buf;
|
||||
p.type = SwapRecType::JOIN;
|
||||
put_varu64(p.payload, static_cast<std::uint64_t>(std::max(0, row)));
|
||||
enqueue(std::move(p));
|
||||
}
|
||||
|
||||
|
||||
void
|
||||
SwapManager::writer_loop()
|
||||
{
|
||||
while (running_.load()) {
|
||||
std::vector<Pending> batch;
|
||||
{
|
||||
std::unique_lock<std::mutex> lk(mtx_);
|
||||
if (queue_.empty()) {
|
||||
cv_.wait_for(lk, std::chrono::milliseconds(cfg_.flush_interval_ms));
|
||||
}
|
||||
if (!queue_.empty()) {
|
||||
batch.swap(queue_);
|
||||
}
|
||||
}
|
||||
if (batch.empty())
|
||||
continue;
|
||||
|
||||
// Group by buffer path to minimize fsyncs
|
||||
for (const Pending &p: batch) {
|
||||
process_one(p);
|
||||
}
|
||||
|
||||
// Throttled fsync: best-effort
|
||||
// Iterate unique contexts and fsync if needed
|
||||
// For stage 1, fsync all once per interval
|
||||
std::uint64_t now = now_ns();
|
||||
for (auto &kv: journals_) {
|
||||
JournalCtx &ctx = kv.second;
|
||||
if (ctx.fd >= 0) {
|
||||
if (ctx.last_fsync_ns == 0 || (now - ctx.last_fsync_ns) / 1000000ULL >= cfg_.
|
||||
fsync_interval_ms) {
|
||||
::fsync(ctx.fd);
|
||||
ctx.last_fsync_ns = now;
|
||||
}
|
||||
}
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
|
||||
void
|
||||
SwapManager::process_one(const Pending &p)
|
||||
{
|
||||
Buffer &buf = *p.buf;
|
||||
// Resolve context by path derived from buffer
|
||||
std::string path = ComputeSidecarPath(buf);
|
||||
// Get or create context keyed by this buffer pointer (stage 1 simplification)
|
||||
JournalCtx &ctx = journals_[p.buf];
|
||||
if (ctx.path.empty())
|
||||
ctx.path = path;
|
||||
if (!open_ctx(ctx))
|
||||
return;
|
||||
|
||||
// Build record: [type u8][len u24][payload][crc32 u32]
|
||||
std::uint8_t len3[3];
|
||||
put_u24(len3, static_cast<std::uint32_t>(p.payload.size()));
|
||||
|
||||
std::uint8_t head[4];
|
||||
head[0] = static_cast<std::uint8_t>(p.type);
|
||||
head[1] = len3[0];
|
||||
head[2] = len3[1];
|
||||
head[3] = len3[2];
|
||||
|
||||
std::uint32_t c = 0;
|
||||
c = crc32(head, sizeof(head), c);
|
||||
if (!p.payload.empty())
|
||||
c = crc32(p.payload.data(), p.payload.size(), c);
|
||||
|
||||
// Write (handle partial writes and check results)
|
||||
bool ok = write_full(ctx.fd, head, sizeof(head));
|
||||
if (ok && !p.payload.empty())
|
||||
ok = write_full(ctx.fd, p.payload.data(), p.payload.size());
|
||||
if (ok)
|
||||
ok = write_full(ctx.fd, &c, sizeof(c));
|
||||
(void) ok; // stage 1: best-effort; future work could mark ctx error state
|
||||
}
|
||||
} // namespace kte
|
||||
145
Swap.h
Normal file
145
Swap.h
Normal file
@@ -0,0 +1,145 @@
|
||||
// Swap.h - swap journal (crash recovery) writer/manager for kte
|
||||
#pragma once
|
||||
|
||||
#include <cstdint>
|
||||
#include <cstddef>
|
||||
#include <string>
|
||||
#include <string_view>
|
||||
#include <vector>
|
||||
#include <unordered_map>
|
||||
#include <mutex>
|
||||
#include <condition_variable>
|
||||
#include <thread>
|
||||
#include <atomic>
|
||||
|
||||
class Buffer;
|
||||
|
||||
namespace kte {
|
||||
// Minimal record types for stage 1
|
||||
enum class SwapRecType : std::uint8_t {
|
||||
INS = 1,
|
||||
DEL = 2,
|
||||
SPLIT = 3,
|
||||
JOIN = 4,
|
||||
META = 0xF0,
|
||||
CHKPT = 0xFE,
|
||||
};
|
||||
|
||||
struct SwapConfig {
|
||||
// Grouping and durability knobs (stage 1 defaults)
|
||||
unsigned flush_interval_ms{200}; // group small writes
|
||||
unsigned fsync_interval_ms{1000}; // at most once per second
|
||||
};
|
||||
|
||||
// Lightweight interface that Buffer can call without depending on full manager impl
|
||||
class SwapRecorder {
|
||||
public:
|
||||
virtual ~SwapRecorder() = default;
|
||||
|
||||
virtual void RecordInsert(Buffer &buf, int row, int col, std::string_view text) = 0;
|
||||
|
||||
virtual void RecordDelete(Buffer &buf, int row, int col, std::size_t len) = 0;
|
||||
|
||||
virtual void RecordSplit(Buffer &buf, int row, int col) = 0;
|
||||
|
||||
virtual void RecordJoin(Buffer &buf, int row) = 0;
|
||||
|
||||
virtual void NotifyFilenameChanged(Buffer &buf) = 0;
|
||||
|
||||
virtual void SetSuspended(Buffer &buf, bool on) = 0;
|
||||
};
|
||||
|
||||
// SwapManager manages sidecar swap files and a single background writer thread.
|
||||
class SwapManager final : public SwapRecorder {
|
||||
public:
|
||||
SwapManager();
|
||||
|
||||
~SwapManager() override;
|
||||
|
||||
// Attach a buffer to begin journaling. Safe to call multiple times; idempotent.
|
||||
void Attach(Buffer *buf);
|
||||
|
||||
// Detach and close journal.
|
||||
void Detach(Buffer *buf);
|
||||
|
||||
// SwapRecorder: Notify that the buffer's filename changed (e.g., SaveAs)
|
||||
void NotifyFilenameChanged(Buffer &buf) override;
|
||||
|
||||
// SwapRecorder
|
||||
void RecordInsert(Buffer &buf, int row, int col, std::string_view text) override;
|
||||
|
||||
void RecordDelete(Buffer &buf, int row, int col, std::size_t len) override;
|
||||
|
||||
void RecordSplit(Buffer &buf, int row, int col) override;
|
||||
|
||||
void RecordJoin(Buffer &buf, int row) override;
|
||||
|
||||
// RAII guard to suspend recording for internal operations
|
||||
class SuspendGuard {
|
||||
public:
|
||||
SuspendGuard(SwapManager &m, Buffer *b);
|
||||
|
||||
~SuspendGuard();
|
||||
|
||||
private:
|
||||
SwapManager &m_;
|
||||
Buffer *buf_;
|
||||
bool prev_;
|
||||
};
|
||||
|
||||
// Per-buffer toggle
|
||||
void SetSuspended(Buffer &buf, bool on) override;
|
||||
|
||||
private:
|
||||
struct JournalCtx {
|
||||
std::string path;
|
||||
void *file{nullptr}; // FILE*
|
||||
int fd{-1};
|
||||
bool header_ok{false};
|
||||
bool suspended{false};
|
||||
std::uint64_t last_flush_ns{0};
|
||||
std::uint64_t last_fsync_ns{0};
|
||||
};
|
||||
|
||||
struct Pending {
|
||||
Buffer *buf{nullptr};
|
||||
SwapRecType type{SwapRecType::INS};
|
||||
std::vector<std::uint8_t> payload; // framed payload only
|
||||
bool urgent_flush{false};
|
||||
};
|
||||
|
||||
// Helpers
|
||||
static std::string ComputeSidecarPath(const Buffer &buf);
|
||||
|
||||
static std::uint64_t now_ns();
|
||||
|
||||
static bool ensure_parent_dir(const std::string &path);
|
||||
|
||||
static bool write_header(JournalCtx &ctx);
|
||||
|
||||
static bool open_ctx(JournalCtx &ctx);
|
||||
|
||||
static void close_ctx(JournalCtx &ctx);
|
||||
|
||||
static std::uint32_t crc32(const std::uint8_t *data, std::size_t len, std::uint32_t seed = 0);
|
||||
|
||||
static void put_varu64(std::vector<std::uint8_t> &out, std::uint64_t v);
|
||||
|
||||
static void put_u24(std::uint8_t dst[3], std::uint32_t v);
|
||||
|
||||
void enqueue(Pending &&p);
|
||||
|
||||
void writer_loop();
|
||||
|
||||
void process_one(const Pending &p);
|
||||
|
||||
// State
|
||||
SwapConfig cfg_{};
|
||||
std::unordered_map<Buffer *, JournalCtx> journals_;
|
||||
std::mutex mtx_;
|
||||
std::condition_variable cv_;
|
||||
std::vector<Pending> queue_;
|
||||
std::atomic<bool> running_{false};
|
||||
std::thread worker_;
|
||||
};
|
||||
} // namespace kte
|
||||
@@ -55,6 +55,8 @@ TerminalFrontend::Init(Editor &ed)
|
||||
prev_r_ = r;
|
||||
prev_c_ = c;
|
||||
ed.SetDimensions(static_cast<std::size_t>(r), static_cast<std::size_t>(c));
|
||||
// Attach editor to input handler for editor-owned features (e.g., universal argument)
|
||||
input_.Attach(&ed);
|
||||
return true;
|
||||
}
|
||||
|
||||
@@ -100,4 +102,4 @@ TerminalFrontend::Shutdown()
|
||||
have_orig_tio_ = false;
|
||||
}
|
||||
endwin();
|
||||
}
|
||||
}
|
||||
@@ -1,9 +1,7 @@
|
||||
/*
|
||||
* TerminalFrontend - couples TerminalInputHandler + TerminalRenderer and owns ncurses lifecycle
|
||||
*/
|
||||
#ifndef KTE_TERMINAL_FRONTEND_H
|
||||
#define KTE_TERMINAL_FRONTEND_H
|
||||
|
||||
#pragma once
|
||||
#include <termios.h>
|
||||
|
||||
#include "Frontend.h"
|
||||
@@ -31,6 +29,4 @@ private:
|
||||
// Saved terminal attributes to restore on shutdown
|
||||
bool have_orig_tio_ = false;
|
||||
struct termios orig_tio_{};
|
||||
};
|
||||
|
||||
#endif // KTE_TERMINAL_FRONTEND_H
|
||||
};
|
||||
@@ -3,6 +3,7 @@
|
||||
|
||||
#include "TerminalInputHandler.h"
|
||||
#include "KKeymap.h"
|
||||
#include "Editor.h"
|
||||
|
||||
namespace {
|
||||
constexpr int
|
||||
@@ -21,96 +22,103 @@ static bool
|
||||
map_key_to_command(const int ch,
|
||||
bool &k_prefix,
|
||||
bool &esc_meta,
|
||||
// universal-argument state (by ref)
|
||||
bool &uarg_active,
|
||||
bool &uarg_collecting,
|
||||
bool &uarg_negative,
|
||||
bool &uarg_had_digits,
|
||||
int &uarg_value,
|
||||
std::string &uarg_text,
|
||||
bool &k_ctrl_pending,
|
||||
Editor *ed,
|
||||
MappedInput &out)
|
||||
{
|
||||
// Handle special keys from ncurses
|
||||
// These keys exit k-prefix mode if active (user pressed C-k then a special key).
|
||||
switch (ch) {
|
||||
case KEY_MOUSE: {
|
||||
k_prefix = false;
|
||||
MEVENT ev{};
|
||||
if (getmouse(&ev) == OK) {
|
||||
// Mouse wheel → scroll viewport without moving cursor
|
||||
case KEY_MOUSE: {
|
||||
k_prefix = false;
|
||||
k_ctrl_pending = false;
|
||||
MEVENT ev{};
|
||||
if (getmouse(&ev) == OK) {
|
||||
// Mouse wheel → scroll viewport without moving cursor
|
||||
#ifdef BUTTON4_PRESSED
|
||||
if (ev.bstate & (BUTTON4_PRESSED | BUTTON4_RELEASED | BUTTON4_CLICKED)) {
|
||||
out = {true, CommandId::ScrollUp, "", 0};
|
||||
return true;
|
||||
}
|
||||
if (ev.bstate & (BUTTON4_PRESSED | BUTTON4_RELEASED | BUTTON4_CLICKED)) {
|
||||
out = {true, CommandId::ScrollUp, "", 0};
|
||||
return true;
|
||||
}
|
||||
#endif
|
||||
#ifdef BUTTON5_PRESSED
|
||||
if (ev.bstate & (BUTTON5_PRESSED | BUTTON5_RELEASED | BUTTON5_CLICKED)) {
|
||||
out = {true, CommandId::ScrollDown, "", 0};
|
||||
return true;
|
||||
}
|
||||
if (ev.bstate & (BUTTON5_PRESSED | BUTTON5_RELEASED | BUTTON5_CLICKED)) {
|
||||
out = {true, CommandId::ScrollDown, "", 0};
|
||||
return true;
|
||||
}
|
||||
#endif
|
||||
// React to left button click/press
|
||||
if (ev.bstate & (BUTTON1_CLICKED | BUTTON1_PRESSED | BUTTON1_RELEASED)) {
|
||||
char buf[64];
|
||||
// Use screen coordinates; command handler will translate via offsets
|
||||
std::snprintf(buf, sizeof(buf), "@%d:%d", ev.y, ev.x);
|
||||
out = {true, CommandId::MoveCursorTo, std::string(buf), 0};
|
||||
return true;
|
||||
// React to left button click/press
|
||||
if (ev.bstate & (BUTTON1_CLICKED | BUTTON1_PRESSED | BUTTON1_RELEASED)) {
|
||||
char buf[64];
|
||||
// Use screen coordinates; command handler will translate via offsets
|
||||
std::snprintf(buf, sizeof(buf), "@%d:%d", ev.y, ev.x);
|
||||
out = {true, CommandId::MoveCursorTo, std::string(buf), 0};
|
||||
return true;
|
||||
}
|
||||
}
|
||||
// No actionable mouse event
|
||||
out.hasCommand = false;
|
||||
return true;
|
||||
}
|
||||
// No actionable mouse event
|
||||
out.hasCommand = false;
|
||||
return true;
|
||||
}
|
||||
case KEY_LEFT:
|
||||
k_prefix = false;
|
||||
out = {true, CommandId::MoveLeft, "", 0};
|
||||
return true;
|
||||
case KEY_RIGHT:
|
||||
k_prefix = false;
|
||||
out = {true, CommandId::MoveRight, "", 0};
|
||||
return true;
|
||||
case KEY_UP:
|
||||
k_prefix = false;
|
||||
out = {true, CommandId::MoveUp, "", 0};
|
||||
return true;
|
||||
case KEY_DOWN:
|
||||
k_prefix = false;
|
||||
out = {true, CommandId::MoveDown, "", 0};
|
||||
return true;
|
||||
case KEY_HOME:
|
||||
k_prefix = false;
|
||||
out = {true, CommandId::MoveHome, "", 0};
|
||||
return true;
|
||||
case KEY_END:
|
||||
k_prefix = false;
|
||||
out = {true, CommandId::MoveEnd, "", 0};
|
||||
return true;
|
||||
case KEY_PPAGE:
|
||||
k_prefix = false;
|
||||
out = {true, CommandId::PageUp, "", 0};
|
||||
return true;
|
||||
case KEY_NPAGE:
|
||||
k_prefix = false;
|
||||
out = {true, CommandId::PageDown, "", 0};
|
||||
return true;
|
||||
case KEY_DC:
|
||||
k_prefix = false;
|
||||
out = {true, CommandId::DeleteChar, "", 0};
|
||||
return true;
|
||||
case KEY_RESIZE:
|
||||
k_prefix = false;
|
||||
out = {true, CommandId::Refresh, "", 0};
|
||||
return true;
|
||||
default:
|
||||
break;
|
||||
case KEY_LEFT:
|
||||
k_prefix = false;
|
||||
k_ctrl_pending = false;
|
||||
out = {true, CommandId::MoveLeft, "", 0};
|
||||
return true;
|
||||
case KEY_RIGHT:
|
||||
k_prefix = false;
|
||||
k_ctrl_pending = false;
|
||||
out = {true, CommandId::MoveRight, "", 0};
|
||||
return true;
|
||||
case KEY_UP:
|
||||
k_prefix = false;
|
||||
k_ctrl_pending = false;
|
||||
out = {true, CommandId::MoveUp, "", 0};
|
||||
return true;
|
||||
case KEY_DOWN:
|
||||
k_prefix = false;
|
||||
k_ctrl_pending = false;
|
||||
out = {true, CommandId::MoveDown, "", 0};
|
||||
return true;
|
||||
case KEY_HOME:
|
||||
k_prefix = false;
|
||||
k_ctrl_pending = false;
|
||||
out = {true, CommandId::MoveHome, "", 0};
|
||||
return true;
|
||||
case KEY_END:
|
||||
k_prefix = false;
|
||||
k_ctrl_pending = false;
|
||||
out = {true, CommandId::MoveEnd, "", 0};
|
||||
return true;
|
||||
case KEY_PPAGE:
|
||||
k_prefix = false;
|
||||
k_ctrl_pending = false;
|
||||
out = {true, CommandId::PageUp, "", 0};
|
||||
return true;
|
||||
case KEY_NPAGE:
|
||||
k_prefix = false;
|
||||
k_ctrl_pending = false;
|
||||
out = {true, CommandId::PageDown, "", 0};
|
||||
return true;
|
||||
case KEY_DC:
|
||||
k_prefix = false;
|
||||
k_ctrl_pending = false;
|
||||
out = {true, CommandId::DeleteChar, "", 0};
|
||||
return true;
|
||||
case KEY_RESIZE:
|
||||
k_prefix = false;
|
||||
k_ctrl_pending = false;
|
||||
out = {true, CommandId::Refresh, "", 0};
|
||||
return true;
|
||||
default:
|
||||
break;
|
||||
}
|
||||
|
||||
// ESC as cancel of prefix; many terminals send meta sequences as ESC+...
|
||||
if (ch == 27) {
|
||||
// ESC
|
||||
k_prefix = false;
|
||||
k_ctrl_pending = false;
|
||||
esc_meta = true; // next key will be considered meta-modified
|
||||
out.hasCommand = false; // no command yet
|
||||
return true;
|
||||
@@ -119,59 +127,33 @@ map_key_to_command(const int ch,
|
||||
// Control keys
|
||||
if (ch == CTRL('K')) {
|
||||
// C-k prefix
|
||||
k_prefix = true;
|
||||
out = {true, CommandId::KPrefix, "", 0};
|
||||
k_prefix = true;
|
||||
k_ctrl_pending = false;
|
||||
out = {true, CommandId::KPrefix, "", 0};
|
||||
return true;
|
||||
}
|
||||
if (ch == CTRL('G')) {
|
||||
// cancel
|
||||
k_prefix = false;
|
||||
esc_meta = false;
|
||||
k_prefix = false;
|
||||
k_ctrl_pending = false;
|
||||
esc_meta = false;
|
||||
// cancel universal argument as well
|
||||
uarg_active = false;
|
||||
uarg_collecting = false;
|
||||
uarg_negative = false;
|
||||
uarg_had_digits = false;
|
||||
uarg_value = 0;
|
||||
uarg_text.clear();
|
||||
if (ed)
|
||||
ed->UArgClear();
|
||||
out = {true, CommandId::Refresh, "", 0};
|
||||
return true;
|
||||
}
|
||||
// Universal argument: C-u
|
||||
if (ch == CTRL('U')) {
|
||||
// Start or extend universal argument
|
||||
if (!uarg_active) {
|
||||
uarg_active = true;
|
||||
uarg_collecting = true;
|
||||
uarg_negative = false;
|
||||
uarg_had_digits = false;
|
||||
uarg_value = 4; // default
|
||||
// Reset collected text and emit status update
|
||||
uarg_text.clear();
|
||||
out = {true, CommandId::UArgStatus, uarg_text, 0};
|
||||
return true;
|
||||
} else if (uarg_collecting && !uarg_had_digits && !uarg_negative) {
|
||||
// Bare repeated C-u multiplies by 4
|
||||
if (uarg_value <= 0)
|
||||
uarg_value = 4;
|
||||
else
|
||||
uarg_value *= 4;
|
||||
// Keep showing status (no digits yet)
|
||||
out = {true, CommandId::UArgStatus, uarg_text, 0};
|
||||
return true;
|
||||
} else {
|
||||
// If digits or '-' have been entered, C-u ends the argument (ready for next command)
|
||||
uarg_collecting = false;
|
||||
if (!uarg_had_digits && !uarg_negative && uarg_value <= 0)
|
||||
uarg_value = 4;
|
||||
}
|
||||
// No command produced by C-u itself
|
||||
out.hasCommand = false;
|
||||
if (ed)
|
||||
ed->UArgStart();
|
||||
out.hasCommand = false; // C-u itself doesn't issue a command
|
||||
return true;
|
||||
}
|
||||
// Tab (note: terminals encode Tab and C-i as the same code 9)
|
||||
if (ch == '\t') {
|
||||
k_prefix = false;
|
||||
k_ctrl_pending = false;
|
||||
out.hasCommand = true;
|
||||
out.id = CommandId::InsertText;
|
||||
out.arg = "\t";
|
||||
@@ -182,22 +164,39 @@ map_key_to_command(const int ch,
|
||||
// IMPORTANT: if we're in k-prefix, the very next key must be interpreted
|
||||
// via the C-k keymap first, even if it's a Control chord like C-d.
|
||||
if (k_prefix) {
|
||||
k_prefix = false; // consume the prefix for this one key
|
||||
// In k-prefix: allow a control qualifier via literal 'C' or '^'
|
||||
// Detect Control keycodes first
|
||||
bool ctrl = false;
|
||||
int ascii_key = ch;
|
||||
if (ch >= 1 && ch <= 26) {
|
||||
ctrl = true;
|
||||
ascii_key = 'a' + (ch - 1);
|
||||
}
|
||||
// If user typed literal 'C'/'c' or '^' as a qualifier, keep k-prefix and set pending
|
||||
if (ascii_key == 'C' || ascii_key == 'c' || ascii_key == '^') {
|
||||
k_ctrl_pending = true;
|
||||
if (ed)
|
||||
ed->SetStatus("C-k C _");
|
||||
out.hasCommand = false;
|
||||
return true;
|
||||
}
|
||||
// For actual suffix, consume the k-prefix
|
||||
k_prefix = false;
|
||||
// Do NOT lowercase here; KLookupKCommand handles case-sensitive bindings
|
||||
CommandId id;
|
||||
if (KLookupKCommand(ascii_key, ctrl, id)) {
|
||||
bool pass_ctrl = (ctrl || k_ctrl_pending);
|
||||
k_ctrl_pending = false;
|
||||
if (KLookupKCommand(ascii_key, pass_ctrl, id)) {
|
||||
out = {true, id, "", 0};
|
||||
if (ed)
|
||||
ed->SetStatus(""); // clear "C-k _" hint after suffix
|
||||
} else {
|
||||
int shown = KLowerAscii(ascii_key);
|
||||
char c = (shown >= 0x20 && shown <= 0x7e) ? static_cast<char>(shown) : '?';
|
||||
std::string arg(1, c);
|
||||
out = {true, CommandId::UnknownKCommand, arg, 0};
|
||||
if (ed)
|
||||
ed->SetStatus(""); // clear hint; handler will set unknown status
|
||||
}
|
||||
return true;
|
||||
}
|
||||
@@ -213,8 +212,9 @@ map_key_to_command(const int ch,
|
||||
|
||||
// Enter
|
||||
if (ch == '\n' || ch == '\r') {
|
||||
k_prefix = false;
|
||||
out = {true, CommandId::Newline, "", 0};
|
||||
k_prefix = false;
|
||||
k_ctrl_pending = false;
|
||||
out = {true, CommandId::Newline, "", 0};
|
||||
return true;
|
||||
}
|
||||
// If previous key was ESC, interpret as meta and use ESC keymap
|
||||
@@ -224,6 +224,12 @@ map_key_to_command(const int ch,
|
||||
// Handle ESC + BACKSPACE (meta-backspace, Alt-Backspace)
|
||||
if (ch == KEY_BACKSPACE || ch == 127 || ch == CTRL('H')) {
|
||||
ascii_key = KEY_BACKSPACE; // normalized value for lookup
|
||||
} else if (ch == ',') {
|
||||
// Some terminals emit ',' when Shift state is lost after ESC; treat as '<'
|
||||
ascii_key = '<';
|
||||
} else if (ch == '.') {
|
||||
// Likewise, map '.' to '>'
|
||||
ascii_key = '>';
|
||||
} else if (ascii_key >= 'A' && ascii_key <= 'Z') {
|
||||
ascii_key = ascii_key - 'A' + 'a';
|
||||
}
|
||||
@@ -232,48 +238,26 @@ map_key_to_command(const int ch,
|
||||
out = {true, id, "", 0};
|
||||
return true;
|
||||
}
|
||||
// Unhandled meta key: no command
|
||||
out.hasCommand = false;
|
||||
// Unhandled ESC sequence: exit escape mode and show status
|
||||
out = {true, CommandId::UnknownEscCommand, "", 0};
|
||||
return true;
|
||||
}
|
||||
|
||||
// Backspace in ncurses can be KEY_BACKSPACE or 127
|
||||
if (ch == KEY_BACKSPACE || ch == 127 || ch == CTRL('H')) {
|
||||
k_prefix = false;
|
||||
out = {true, CommandId::Backspace, "", 0};
|
||||
k_prefix = false;
|
||||
k_ctrl_pending = false;
|
||||
out = {true, CommandId::Backspace, "", 0};
|
||||
return true;
|
||||
}
|
||||
|
||||
// k_prefix handled earlier
|
||||
|
||||
// If collecting universal arg, handle digits and optional leading '-'
|
||||
if (uarg_active && uarg_collecting) {
|
||||
if (ch >= '0' && ch <= '9') {
|
||||
int d = ch - '0';
|
||||
if (!uarg_had_digits) {
|
||||
// First digit overrides any 4^n default
|
||||
uarg_value = 0;
|
||||
uarg_had_digits = true;
|
||||
}
|
||||
if (uarg_value < 100000000) {
|
||||
// avoid overflow
|
||||
uarg_value = uarg_value * 10 + d;
|
||||
}
|
||||
// Update raw text and status to reflect collected digits
|
||||
uarg_text.push_back(static_cast<char>(ch));
|
||||
out = {true, CommandId::UArgStatus, uarg_text, 0};
|
||||
return true;
|
||||
}
|
||||
if (ch == '-' && !uarg_had_digits && !uarg_negative) {
|
||||
uarg_negative = true;
|
||||
// Show leading minus in status
|
||||
uarg_text = "-";
|
||||
out = {true, CommandId::UArgStatus, uarg_text, 0};
|
||||
return true;
|
||||
}
|
||||
// Any other key will be processed as a command; fall through to mapping below
|
||||
// but mark collection finished so we apply the argument to that command
|
||||
uarg_collecting = false;
|
||||
// If universal argument is active at editor level and we get a digit, feed it
|
||||
if (ed && ed->UArg() != 0 && ch >= '0' && ch <= '9') {
|
||||
ed->UArgDigit(ch - '0');
|
||||
out.hasCommand = false; // keep collecting, no command yet
|
||||
return true;
|
||||
}
|
||||
|
||||
// Printable ASCII
|
||||
@@ -300,29 +284,11 @@ TerminalInputHandler::decode_(MappedInput &out)
|
||||
bool consumed = map_key_to_command(
|
||||
ch,
|
||||
k_prefix_, esc_meta_,
|
||||
uarg_active_, uarg_collecting_, uarg_negative_, uarg_had_digits_, uarg_value_, uarg_text_,
|
||||
k_ctrl_pending_,
|
||||
ed_,
|
||||
out);
|
||||
if (!consumed)
|
||||
return false;
|
||||
// If a command was produced and a universal argument is active, attach it and clear state
|
||||
if (out.hasCommand && uarg_active_ && out.id != CommandId::UArgStatus) {
|
||||
int count = 0;
|
||||
if (!uarg_had_digits_ && !uarg_negative_) {
|
||||
// No explicit digits: use current value (default 4 or 4^n)
|
||||
count = (uarg_value_ > 0) ? uarg_value_ : 4;
|
||||
} else {
|
||||
count = uarg_value_;
|
||||
if (uarg_negative_)
|
||||
count = -count;
|
||||
}
|
||||
out.count = count;
|
||||
// Clear state
|
||||
uarg_active_ = false;
|
||||
uarg_collecting_ = false;
|
||||
uarg_negative_ = false;
|
||||
uarg_had_digits_ = false;
|
||||
uarg_value_ = 0;
|
||||
}
|
||||
return true;
|
||||
}
|
||||
|
||||
|
||||
@@ -1,9 +1,7 @@
|
||||
/*
|
||||
* TerminalInputHandler - ncurses-based input handling for terminal mode
|
||||
*/
|
||||
#ifndef KTE_TERMINAL_INPUT_HANDLER_H
|
||||
#define KTE_TERMINAL_INPUT_HANDLER_H
|
||||
|
||||
#pragma once
|
||||
#include "InputHandler.h"
|
||||
|
||||
|
||||
@@ -13,6 +11,13 @@ public:
|
||||
|
||||
~TerminalInputHandler() override;
|
||||
|
||||
|
||||
void Attach(Editor *ed) override
|
||||
{
|
||||
ed_ = ed;
|
||||
}
|
||||
|
||||
|
||||
bool Poll(MappedInput &out) override;
|
||||
|
||||
private:
|
||||
@@ -20,16 +25,10 @@ private:
|
||||
|
||||
// ke-style prefix state
|
||||
bool k_prefix_ = false; // true after C-k until next key or ESC
|
||||
// Optional control qualifier inside k-prefix (e.g., user typed literal 'C' or '^')
|
||||
bool k_ctrl_pending_ = false;
|
||||
// Simple meta (ESC) state for ESC sequences like ESC b/f
|
||||
bool esc_meta_ = false;
|
||||
|
||||
// Universal argument (C-u) state
|
||||
bool uarg_active_ = false; // an argument is pending for the next command
|
||||
bool uarg_collecting_ = false; // collecting digits / '-' right now
|
||||
bool uarg_negative_ = false; // whether a leading '-' was supplied
|
||||
bool uarg_had_digits_ = false; // whether any digits were supplied
|
||||
int uarg_value_ = 0; // current absolute value (>=0)
|
||||
std::string uarg_text_; // raw digits/minus typed for status display
|
||||
};
|
||||
|
||||
#endif // KTE_TERMINAL_INPUT_HANDLER_H
|
||||
Editor *ed_ = nullptr; // attached editor for uarg handling
|
||||
};
|
||||
@@ -111,19 +111,44 @@ TerminalRenderer::Draw(Editor &ed)
|
||||
std::string line = static_cast<std::string>(lines[li]);
|
||||
src_i = 0;
|
||||
render_col = 0;
|
||||
// Syntax highlighting: fetch per-line spans
|
||||
const kte::LineHighlight *lh_ptr = nullptr;
|
||||
// Syntax highlighting: fetch per-line spans (sanitized copy)
|
||||
std::vector<kte::HighlightSpan> sane_spans;
|
||||
if (buf->SyntaxEnabled() && buf->Highlighter() && buf->Highlighter()->
|
||||
HasHighlighter()) {
|
||||
lh_ptr = &buf->Highlighter()->GetLine(
|
||||
kte::LineHighlight lh_val = buf->Highlighter()->GetLine(
|
||||
*buf, static_cast<int>(li), buf->Version());
|
||||
// Sanitize defensively: clamp to [0, line.size()], ensure end>=start, drop empties
|
||||
const std::size_t line_len = line.size();
|
||||
sane_spans.reserve(lh_val.spans.size());
|
||||
for (const auto &sp: lh_val.spans) {
|
||||
int s_raw = sp.col_start;
|
||||
int e_raw = sp.col_end;
|
||||
if (e_raw < s_raw)
|
||||
std::swap(e_raw, s_raw);
|
||||
std::size_t s = static_cast<std::size_t>(std::max(
|
||||
0, std::min(s_raw, static_cast<int>(line_len))));
|
||||
std::size_t e = static_cast<std::size_t>(std::max(
|
||||
static_cast<int>(s),
|
||||
std::min(e_raw, static_cast<int>(line_len))));
|
||||
if (e <= s)
|
||||
continue;
|
||||
sane_spans.push_back(kte::HighlightSpan{
|
||||
static_cast<int>(s), static_cast<int>(e), sp.kind
|
||||
});
|
||||
}
|
||||
std::sort(sane_spans.begin(), sane_spans.end(),
|
||||
[](const kte::HighlightSpan &a, const kte::HighlightSpan &b) {
|
||||
return a.col_start < b.col_start;
|
||||
});
|
||||
}
|
||||
auto token_at = [&](std::size_t src_index) -> kte::TokenKind {
|
||||
if (!lh_ptr)
|
||||
if (sane_spans.empty())
|
||||
return kte::TokenKind::Default;
|
||||
for (const auto &sp: lh_ptr->spans) {
|
||||
if (static_cast<int>(src_index) >= sp.col_start && static_cast<int>(
|
||||
src_index) < sp.col_end)
|
||||
int si = static_cast<int>(src_index);
|
||||
for (const auto &sp: sane_spans) {
|
||||
if (si < sp.col_start)
|
||||
break;
|
||||
if (si >= sp.col_start && si < sp.col_end)
|
||||
return sp.kind;
|
||||
}
|
||||
return kte::TokenKind::Default;
|
||||
@@ -132,23 +157,23 @@ TerminalRenderer::Draw(Editor &ed)
|
||||
// Map to simple attributes; search highlight uses A_STANDOUT which takes precedence below
|
||||
attrset(A_NORMAL);
|
||||
switch (k) {
|
||||
case kte::TokenKind::Keyword:
|
||||
case kte::TokenKind::Type:
|
||||
case kte::TokenKind::Constant:
|
||||
case kte::TokenKind::Function:
|
||||
attron(A_BOLD);
|
||||
break;
|
||||
case kte::TokenKind::Comment:
|
||||
attron(A_DIM);
|
||||
break;
|
||||
case kte::TokenKind::String:
|
||||
case kte::TokenKind::Char:
|
||||
case kte::TokenKind::Number:
|
||||
// standout a bit using A_UNDERLINE if available
|
||||
attron(A_UNDERLINE);
|
||||
break;
|
||||
default:
|
||||
break;
|
||||
case kte::TokenKind::Keyword:
|
||||
case kte::TokenKind::Type:
|
||||
case kte::TokenKind::Constant:
|
||||
case kte::TokenKind::Function:
|
||||
attron(A_BOLD);
|
||||
break;
|
||||
case kte::TokenKind::Comment:
|
||||
attron(A_DIM);
|
||||
break;
|
||||
case kte::TokenKind::String:
|
||||
case kte::TokenKind::Char:
|
||||
case kte::TokenKind::Number:
|
||||
// standout a bit using A_UNDERLINE if available
|
||||
attron(A_UNDERLINE);
|
||||
break;
|
||||
default:
|
||||
break;
|
||||
}
|
||||
};
|
||||
while (written < cols) {
|
||||
@@ -269,11 +294,31 @@ TerminalRenderer::Draw(Editor &ed)
|
||||
clrtoeol();
|
||||
}
|
||||
|
||||
// Place terminal cursor at logical position accounting for tabs and coloffs
|
||||
// Place terminal cursor at logical position accounting for tabs and coloffs.
|
||||
// Recompute the rendered X using the same logic as the drawing loop to avoid
|
||||
// any drift between the command-layer computation and the terminal renderer.
|
||||
std::size_t cy = buf->Cury();
|
||||
std::size_t rx = buf->Rx(); // render x computed by command layer
|
||||
int cur_y = static_cast<int>(cy) - static_cast<int>(buf->Rowoffs());
|
||||
int cur_x = static_cast<int>(rx) - static_cast<int>(buf->Coloffs());
|
||||
std::size_t cx = buf->Curx();
|
||||
int cur_y = static_cast<int>(cy) - static_cast<int>(buf->Rowoffs());
|
||||
std::size_t rx_recomputed = 0;
|
||||
if (cy < lines.size()) {
|
||||
const std::string line_for_cursor = static_cast<std::string>(lines[cy]);
|
||||
std::size_t src_i_cur = 0;
|
||||
std::size_t render_col_cur = 0;
|
||||
while (src_i_cur < line_for_cursor.size() && src_i_cur < cx) {
|
||||
unsigned char ccur = static_cast<unsigned char>(line_for_cursor[src_i_cur]);
|
||||
if (ccur == '\t') {
|
||||
std::size_t next_tab = tabw - (render_col_cur % tabw);
|
||||
render_col_cur += next_tab;
|
||||
++src_i_cur;
|
||||
} else {
|
||||
++render_col_cur;
|
||||
++src_i_cur;
|
||||
}
|
||||
}
|
||||
rx_recomputed = render_col_cur;
|
||||
}
|
||||
int cur_x = static_cast<int>(rx_recomputed) - static_cast<int>(buf->Coloffs());
|
||||
if (cur_y >= 0 && cur_y < content_rows && cur_x >= 0 && cur_x < cols) {
|
||||
// remember where to leave the terminal cursor after status is drawn
|
||||
saved_cur_y = cur_y;
|
||||
|
||||
@@ -1,9 +1,7 @@
|
||||
/*
|
||||
* TerminalRenderer - ncurses-based renderer for terminal mode
|
||||
*/
|
||||
#ifndef KTE_TERMINAL_RENDERER_H
|
||||
#define KTE_TERMINAL_RENDERER_H
|
||||
|
||||
#pragma once
|
||||
#include "Renderer.h"
|
||||
|
||||
|
||||
@@ -14,6 +12,4 @@ public:
|
||||
~TerminalRenderer() override;
|
||||
|
||||
void Draw(Editor &ed) override;
|
||||
};
|
||||
|
||||
#endif // KTE_TERMINAL_RENDERER_H
|
||||
};
|
||||
@@ -1,9 +1,7 @@
|
||||
/*
|
||||
* TestFrontend.h - headless frontend for testing with programmable input
|
||||
*/
|
||||
#ifndef KTE_TEST_FRONTEND_H
|
||||
#define KTE_TEST_FRONTEND_H
|
||||
|
||||
#pragma once
|
||||
#include "Frontend.h"
|
||||
#include "TestInputHandler.h"
|
||||
#include "TestRenderer.h"
|
||||
@@ -36,6 +34,4 @@ public:
|
||||
private:
|
||||
TestInputHandler input_{};
|
||||
TestRenderer renderer_{};
|
||||
};
|
||||
|
||||
#endif // KTE_TEST_FRONTEND_H
|
||||
};
|
||||
@@ -1,9 +1,7 @@
|
||||
/*
|
||||
* TestInputHandler.h - programmable input handler for testing
|
||||
*/
|
||||
#ifndef KTE_TEST_INPUT_HANDLER_H
|
||||
#define KTE_TEST_INPUT_HANDLER_H
|
||||
|
||||
#pragma once
|
||||
#include <queue>
|
||||
|
||||
#include "InputHandler.h"
|
||||
@@ -29,6 +27,4 @@ public:
|
||||
|
||||
private:
|
||||
std::queue<MappedInput> queue_;
|
||||
};
|
||||
|
||||
#endif // KTE_TEST_INPUT_HANDLER_H
|
||||
};
|
||||
@@ -1,9 +1,7 @@
|
||||
/*
|
||||
* TestRenderer.h - minimal renderer for testing (no actual display)
|
||||
*/
|
||||
#ifndef KTE_TEST_RENDERER_H
|
||||
#define KTE_TEST_RENDERER_H
|
||||
|
||||
#pragma once
|
||||
#include <cstddef>
|
||||
|
||||
#include "Renderer.h"
|
||||
@@ -31,6 +29,4 @@ public:
|
||||
|
||||
private:
|
||||
std::size_t draw_count_ = 0;
|
||||
};
|
||||
|
||||
#endif // KTE_TEST_RENDERER_H
|
||||
};
|
||||
@@ -1,6 +1,4 @@
|
||||
#ifndef KTE_UNDONODE_H
|
||||
#define KTE_UNDONODE_H
|
||||
|
||||
#pragma once
|
||||
#include <cstdint>
|
||||
#include <string>
|
||||
|
||||
@@ -20,7 +18,4 @@ struct UndoNode {
|
||||
std::string text;
|
||||
UndoNode *child = nullptr; // next in current timeline
|
||||
UndoNode *next = nullptr; // redo branch
|
||||
};
|
||||
|
||||
|
||||
#endif // KTE_UNDONODE_H
|
||||
};
|
||||
61
UndoNodePool.h
Normal file
61
UndoNodePool.h
Normal file
@@ -0,0 +1,61 @@
|
||||
#pragma once
|
||||
#include <stack>
|
||||
#include <vector>
|
||||
#include <memory>
|
||||
#include "UndoNode.h"
|
||||
|
||||
// Pool allocator for UndoNode to eliminate frequent malloc/free.
|
||||
// Uses fixed-size blocks to keep node addresses stable.
|
||||
class UndoNodePool {
|
||||
public:
|
||||
explicit UndoNodePool(std::size_t block_size = 64)
|
||||
: block_size_(block_size) {}
|
||||
|
||||
|
||||
UndoNode *acquire()
|
||||
{
|
||||
if (available_.empty())
|
||||
allocate_block();
|
||||
auto *node = available_.top();
|
||||
available_.pop();
|
||||
// Node comes zeroed; ensure links are reset
|
||||
node->text.clear();
|
||||
node->child = nullptr;
|
||||
node->next = nullptr;
|
||||
node->row = node->col = 0;
|
||||
node->type = UndoType{};
|
||||
return node;
|
||||
}
|
||||
|
||||
|
||||
void release(UndoNode *node)
|
||||
{
|
||||
if (!node)
|
||||
return;
|
||||
// Clear heavy fields to free memory held by strings
|
||||
node->text.clear();
|
||||
node->child = nullptr;
|
||||
node->next = nullptr;
|
||||
node->row = node->col = 0;
|
||||
node->type = UndoType{};
|
||||
available_.push(node);
|
||||
}
|
||||
|
||||
private:
|
||||
void allocate_block()
|
||||
{
|
||||
// allocate a new block; keep ownership so memory stays valid
|
||||
std::unique_ptr<UndoNode[]> block(new UndoNode[block_size_]);
|
||||
UndoNode *base = block.get();
|
||||
blocks_.push_back(std::move(block));
|
||||
for (std::size_t i = 0; i < block_size_; ++i) {
|
||||
// ensure the node is reset; rely on default constructor/zero init
|
||||
available_.push(&base[i]);
|
||||
}
|
||||
}
|
||||
|
||||
|
||||
std::size_t block_size_;
|
||||
std::vector<std::unique_ptr<UndoNode[]> > blocks_;
|
||||
std::stack<UndoNode *> available_;
|
||||
};
|
||||
174
UndoSystem.cc
174
UndoSystem.cc
@@ -11,214 +11,66 @@ UndoSystem::UndoSystem(Buffer &owner, UndoTree &tree)
|
||||
void
|
||||
UndoSystem::Begin(UndoType type)
|
||||
{
|
||||
#ifdef KTE_UNDO_DEBUG
|
||||
debug_log("Begin");
|
||||
#endif
|
||||
// Reuse pending if batching conditions are met
|
||||
const int row = static_cast<int>(buf_->Cury());
|
||||
const int col = static_cast<int>(buf_->Curx());
|
||||
if (tree_.pending && tree_.pending->type == type && tree_.pending->row == row) {
|
||||
if (type == UndoType::Delete) {
|
||||
// Support batching both forward deletes (DeleteChar) and backspace (prepend case)
|
||||
// Forward delete: cursor stays at anchor col; keep batching when col == anchor
|
||||
const auto anchor = static_cast<std::size_t>(tree_.pending->col);
|
||||
if (anchor == static_cast<std::size_t>(col)) {
|
||||
pending_prepend_ = false;
|
||||
return; // keep batching forward delete
|
||||
}
|
||||
// Backspace: cursor moved left by exactly one position relative to current anchor.
|
||||
// Extend batch by shifting anchor left and prepending the deleted byte.
|
||||
if (static_cast<std::size_t>(col) + 1 == anchor) {
|
||||
tree_.pending->col = col;
|
||||
pending_prepend_ = true;
|
||||
return;
|
||||
}
|
||||
} else {
|
||||
std::size_t expected = static_cast<std::size_t>(tree_.pending->col) + tree_.pending->text.
|
||||
size();
|
||||
if (expected == static_cast<std::size_t>(col)) {
|
||||
pending_prepend_ = false;
|
||||
return; // keep batching
|
||||
}
|
||||
}
|
||||
}
|
||||
// Otherwise commit any existing batch and start a new node
|
||||
commit();
|
||||
auto *node = new UndoNode();
|
||||
node->type = type;
|
||||
node->row = row;
|
||||
node->col = col;
|
||||
node->child = nullptr;
|
||||
node->next = nullptr;
|
||||
tree_.pending = node;
|
||||
pending_prepend_ = false;
|
||||
|
||||
#ifdef KTE_UNDO_DEBUG
|
||||
debug_log("Begin:new");
|
||||
#endif
|
||||
// Assert pending is detached from the tree
|
||||
assert(tree_.pending && "pending must exist after Begin");
|
||||
assert(tree_.pending != tree_.root);
|
||||
assert(tree_.pending != tree_.current);
|
||||
assert(tree_.pending != tree_.saved);
|
||||
assert(!is_descendant(tree_.root, tree_.pending));
|
||||
// STUB: Undo system incomplete - disabled until it can be properly implemented
|
||||
(void) type;
|
||||
}
|
||||
|
||||
|
||||
void
|
||||
UndoSystem::Append(char ch)
|
||||
{
|
||||
if (!tree_.pending)
|
||||
return;
|
||||
if (pending_prepend_ && tree_.pending->type == UndoType::Delete) {
|
||||
// Prepend for backspace so that text is in increasing column order
|
||||
tree_.pending->text.insert(tree_.pending->text.begin(), ch);
|
||||
} else {
|
||||
tree_.pending->text.push_back(ch);
|
||||
}
|
||||
#ifdef KTE_UNDO_DEBUG
|
||||
debug_log("Append:ch");
|
||||
#endif
|
||||
// STUB: Undo system incomplete - disabled until it can be properly implemented
|
||||
(void) ch;
|
||||
}
|
||||
|
||||
|
||||
void
|
||||
UndoSystem::Append(std::string_view text)
|
||||
{
|
||||
if (!tree_.pending)
|
||||
return;
|
||||
tree_.pending->text.append(text.data(), text.size());
|
||||
#ifdef KTE_UNDO_DEBUG
|
||||
debug_log("Append:sv");
|
||||
#endif
|
||||
// STUB: Undo system incomplete - disabled until it can be properly implemented
|
||||
(void) text;
|
||||
}
|
||||
|
||||
|
||||
void
|
||||
UndoSystem::commit()
|
||||
{
|
||||
#ifdef KTE_UNDO_DEBUG
|
||||
debug_log("commit:enter");
|
||||
#endif
|
||||
if (!tree_.pending)
|
||||
return;
|
||||
|
||||
// If we have redo branches from current, discard them (non-linear behavior)
|
||||
if (tree_.current && tree_.current->child) {
|
||||
free_node(tree_.current->child);
|
||||
tree_.current->child = nullptr;
|
||||
// We diverged; saved snapshot cannot be on discarded branch anymore
|
||||
if (tree_.saved) {
|
||||
// If saved is not equal to current, keep it; if it was on discarded branch we cannot easily detect now.
|
||||
// For simplicity, leave saved as-is; dirty flag uses pointer equality.
|
||||
}
|
||||
}
|
||||
|
||||
// Attach pending as next state
|
||||
if (!tree_.root) {
|
||||
tree_.root = tree_.pending;
|
||||
tree_.current = tree_.pending;
|
||||
} else if (!tree_.current) {
|
||||
// Should not happen if root exists, but handle gracefully
|
||||
tree_.current = tree_.pending;
|
||||
} else {
|
||||
// Attach as primary child (head of redo list)
|
||||
tree_.pending->next = nullptr;
|
||||
tree_.current->child = tree_.pending;
|
||||
tree_.current = tree_.pending;
|
||||
}
|
||||
tree_.pending = nullptr;
|
||||
update_dirty_flag();
|
||||
#ifdef KTE_UNDO_DEBUG
|
||||
debug_log("commit:done");
|
||||
#endif
|
||||
// post-conditions
|
||||
assert(tree_.pending == nullptr && "pending must be cleared after commit");
|
||||
// STUB: Undo system incomplete - disabled until it can be properly implemented
|
||||
}
|
||||
|
||||
|
||||
void
|
||||
UndoSystem::undo()
|
||||
{
|
||||
// Close any pending batch
|
||||
commit();
|
||||
if (!tree_.current)
|
||||
return;
|
||||
UndoNode *parent = find_parent(tree_.root, tree_.current);
|
||||
UndoNode *node = tree_.current;
|
||||
// Apply inverse of current node
|
||||
apply(node, -1);
|
||||
tree_.current = parent;
|
||||
update_dirty_flag();
|
||||
#ifdef KTE_UNDO_DEBUG
|
||||
debug_log("undo");
|
||||
#endif
|
||||
// STUB: Undo system incomplete - disabled until it can be properly implemented
|
||||
}
|
||||
|
||||
|
||||
void
|
||||
UndoSystem::redo()
|
||||
{
|
||||
// Redo next child along current timeline
|
||||
if (tree_.pending) {
|
||||
// If app added pending edits, finalize them before redo chain
|
||||
commit();
|
||||
}
|
||||
UndoNode *next = nullptr;
|
||||
if (!tree_.current) {
|
||||
next = tree_.root; // if nothing yet, try applying first node
|
||||
} else {
|
||||
next = tree_.current->child;
|
||||
}
|
||||
if (!next)
|
||||
return;
|
||||
apply(next, +1);
|
||||
tree_.current = next;
|
||||
update_dirty_flag();
|
||||
#ifdef KTE_UNDO_DEBUG
|
||||
debug_log("redo");
|
||||
#endif
|
||||
// STUB: Undo system incomplete - disabled until it can be properly implemented
|
||||
}
|
||||
|
||||
|
||||
void
|
||||
UndoSystem::mark_saved()
|
||||
{
|
||||
tree_.saved = tree_.current;
|
||||
update_dirty_flag();
|
||||
#ifdef KTE_UNDO_DEBUG
|
||||
debug_log("mark_saved");
|
||||
#endif
|
||||
// STUB: Undo system incomplete - disabled until it can be properly implemented
|
||||
}
|
||||
|
||||
|
||||
void
|
||||
UndoSystem::discard_pending()
|
||||
{
|
||||
if (tree_.pending) {
|
||||
delete tree_.pending;
|
||||
tree_.pending = nullptr;
|
||||
}
|
||||
#ifdef KTE_UNDO_DEBUG
|
||||
debug_log("discard_pending");
|
||||
#endif
|
||||
// STUB: Undo system incomplete - disabled until it can be properly implemented
|
||||
}
|
||||
|
||||
|
||||
void
|
||||
UndoSystem::clear()
|
||||
{
|
||||
if (tree_.root) {
|
||||
free_node(tree_.root);
|
||||
}
|
||||
if (tree_.pending) {
|
||||
delete tree_.pending;
|
||||
}
|
||||
tree_.root = tree_.current = tree_.saved = tree_.pending = nullptr;
|
||||
update_dirty_flag();
|
||||
#ifdef KTE_UNDO_DEBUG
|
||||
debug_log("clear");
|
||||
#endif
|
||||
// STUB: Undo system incomplete - disabled until it can be properly implemented
|
||||
}
|
||||
|
||||
|
||||
@@ -395,4 +247,4 @@ UndoSystem::debug_log(const char *op) const
|
||||
#else
|
||||
(void) op;
|
||||
#endif
|
||||
}
|
||||
}
|
||||
10
UndoSystem.h
10
UndoSystem.h
@@ -1,6 +1,4 @@
|
||||
#ifndef KTE_UNDOSYSTEM_H
|
||||
#define KTE_UNDOSYSTEM_H
|
||||
|
||||
#pragma once
|
||||
#include <string_view>
|
||||
#include <cstddef>
|
||||
#include <cstdint>
|
||||
@@ -52,8 +50,4 @@ private:
|
||||
|
||||
Buffer *buf_;
|
||||
UndoTree &tree_;
|
||||
// Internal hint for Delete batching: whether next Append() should prepend
|
||||
bool pending_prepend_ = false;
|
||||
};
|
||||
|
||||
#endif // KTE_UNDOSYSTEM_H
|
||||
};
|
||||
@@ -1,6 +1,4 @@
|
||||
#ifndef KTE_UNDOTREE_H
|
||||
#define KTE_UNDOTREE_H
|
||||
|
||||
#pragma once
|
||||
#include "UndoNode.h"
|
||||
|
||||
|
||||
@@ -9,7 +7,4 @@ struct UndoTree {
|
||||
UndoNode *current = nullptr; // current state of buffer
|
||||
UndoNode *saved = nullptr; // points to node matching last save (for dirty flag)
|
||||
UndoNode *pending = nullptr; // in-progress batch (detached)
|
||||
};
|
||||
|
||||
|
||||
#endif // KTE_UNDOTREE_H
|
||||
};
|
||||
206
bench/BufferBench.cc
Normal file
206
bench/BufferBench.cc
Normal file
@@ -0,0 +1,206 @@
|
||||
/*
|
||||
* BufferBench.cc - microbenchmarks for GapBuffer and PieceTable
|
||||
*
|
||||
* This benchmark exercises the public APIs shared by both structures as used
|
||||
* in Buffer::Line: Reserve, AppendChar, Append, PrependChar, Prepend, Clear.
|
||||
*
|
||||
* Run examples:
|
||||
* ./kte_bench_buffer # defaults
|
||||
* ./kte_bench_buffer 200000 8 4096 # N=200k, rounds=8, chunk=4096
|
||||
*/
|
||||
|
||||
#include <chrono>
|
||||
#include <cstdint>
|
||||
#include <cstring>
|
||||
#include <iomanip>
|
||||
#include <iostream>
|
||||
#include <random>
|
||||
#include <string>
|
||||
#include <vector>
|
||||
#include <typeinfo>
|
||||
|
||||
#include "GapBuffer.h"
|
||||
#include "PieceTable.h"
|
||||
|
||||
using clock_t = std::chrono::steady_clock;
|
||||
using us = std::chrono::microseconds;
|
||||
|
||||
struct Result {
|
||||
std::string name;
|
||||
std::string scenario;
|
||||
double micros = 0.0;
|
||||
std::size_t bytes = 0;
|
||||
};
|
||||
|
||||
|
||||
static void
|
||||
print_header()
|
||||
{
|
||||
std::cout << std::left << std::setw(14) << "Structure"
|
||||
<< std::left << std::setw(18) << "Scenario"
|
||||
<< std::right << std::setw(12) << "time(us)"
|
||||
<< std::right << std::setw(14) << "bytes"
|
||||
<< std::right << std::setw(14) << "MB/s"
|
||||
<< "\n";
|
||||
std::cout << std::string(72, '-') << "\n";
|
||||
}
|
||||
|
||||
|
||||
static void
|
||||
print_row(const Result &r)
|
||||
{
|
||||
double mb = r.bytes / (1024.0 * 1024.0);
|
||||
double mbps = (r.micros > 0.0) ? (mb / (r.micros / 1'000'000.0)) : 0.0;
|
||||
std::cout << std::left << std::setw(14) << r.name
|
||||
<< std::left << std::setw(18) << r.scenario
|
||||
<< std::right << std::setw(12) << std::fixed << std::setprecision(2) << r.micros
|
||||
<< std::right << std::setw(14) << r.bytes
|
||||
<< std::right << std::setw(14) << std::fixed << std::setprecision(2) << mbps
|
||||
<< "\n";
|
||||
}
|
||||
|
||||
|
||||
template<typename Buf>
|
||||
Result
|
||||
bench_sequential_append(std::size_t N, int rounds)
|
||||
{
|
||||
Result r;
|
||||
r.name = typeid(Buf).name();
|
||||
r.scenario = "seq_append";
|
||||
const char c = 'x';
|
||||
auto start = clock_t::now();
|
||||
std::size_t bytes = 0;
|
||||
for (int t = 0; t < rounds; ++t) {
|
||||
Buf b;
|
||||
b.Reserve(N);
|
||||
for (std::size_t i = 0; i < N; ++i) {
|
||||
b.AppendChar(c);
|
||||
}
|
||||
bytes += N;
|
||||
}
|
||||
auto end = clock_t::now();
|
||||
r.micros = std::chrono::duration_cast<us>(end - start).count();
|
||||
r.bytes = bytes;
|
||||
return r;
|
||||
}
|
||||
|
||||
|
||||
template<typename Buf>
|
||||
Result
|
||||
bench_sequential_prepend(std::size_t N, int rounds)
|
||||
{
|
||||
Result r;
|
||||
r.name = typeid(Buf).name();
|
||||
r.scenario = "seq_prepend";
|
||||
const char c = 'x';
|
||||
auto start = clock_t::now();
|
||||
std::size_t bytes = 0;
|
||||
for (int t = 0; t < rounds; ++t) {
|
||||
Buf b;
|
||||
b.Reserve(N);
|
||||
for (std::size_t i = 0; i < N; ++i) {
|
||||
b.PrependChar(c);
|
||||
}
|
||||
bytes += N;
|
||||
}
|
||||
auto end = clock_t::now();
|
||||
r.micros = std::chrono::duration_cast<us>(end - start).count();
|
||||
r.bytes = bytes;
|
||||
return r;
|
||||
}
|
||||
|
||||
|
||||
template<typename Buf>
|
||||
Result
|
||||
bench_chunk_append(std::size_t N, std::size_t chunk, int rounds)
|
||||
{
|
||||
Result r;
|
||||
r.name = typeid(Buf).name();
|
||||
r.scenario = "chunk_append";
|
||||
std::string payload(chunk, 'y');
|
||||
auto start = clock_t::now();
|
||||
std::size_t bytes = 0;
|
||||
for (int t = 0; t < rounds; ++t) {
|
||||
Buf b;
|
||||
b.Reserve(N);
|
||||
std::size_t written = 0;
|
||||
while (written < N) {
|
||||
std::size_t now = std::min(chunk, N - written);
|
||||
b.Append(payload.data(), now);
|
||||
written += now;
|
||||
}
|
||||
bytes += N;
|
||||
}
|
||||
auto end = clock_t::now();
|
||||
r.micros = std::chrono::duration_cast<us>(end - start).count();
|
||||
r.bytes = bytes;
|
||||
return r;
|
||||
}
|
||||
|
||||
|
||||
template<typename Buf>
|
||||
Result
|
||||
bench_mixed(std::size_t N, std::size_t chunk, int rounds)
|
||||
{
|
||||
Result r;
|
||||
r.name = typeid(Buf).name();
|
||||
r.scenario = "mixed";
|
||||
std::string payload(chunk, 'z');
|
||||
auto start = clock_t::now();
|
||||
std::size_t bytes = 0;
|
||||
for (int t = 0; t < rounds; ++t) {
|
||||
Buf b;
|
||||
b.Reserve(N);
|
||||
std::size_t written = 0;
|
||||
while (written < N) {
|
||||
// alternate append/prepend with small chunks
|
||||
std::size_t now = std::min(chunk, N - written);
|
||||
if ((written / chunk) % 2 == 0) {
|
||||
b.Append(payload.data(), now);
|
||||
} else {
|
||||
b.Prepend(payload.data(), now);
|
||||
}
|
||||
written += now;
|
||||
}
|
||||
bytes += N;
|
||||
}
|
||||
auto end = clock_t::now();
|
||||
r.micros = std::chrono::duration_cast<us>(end - start).count();
|
||||
r.bytes = bytes;
|
||||
return r;
|
||||
}
|
||||
|
||||
|
||||
int
|
||||
main(int argc, char **argv)
|
||||
{
|
||||
// Parameters
|
||||
std::size_t N = 100'000; // bytes per round
|
||||
int rounds = 5; // iterations
|
||||
std::size_t chunk = 1024; // chunk size for chunked scenarios
|
||||
if (argc >= 2)
|
||||
N = static_cast<std::size_t>(std::stoull(argv[1]));
|
||||
if (argc >= 3)
|
||||
rounds = std::stoi(argv[2]);
|
||||
if (argc >= 4)
|
||||
chunk = static_cast<std::size_t>(std::stoull(argv[3]));
|
||||
|
||||
std::cout << "KTE Buffer Microbenchmarks" << "\n";
|
||||
std::cout << "N=" << N << ", rounds=" << rounds << ", chunk=" << chunk << "\n\n";
|
||||
|
||||
print_header();
|
||||
|
||||
// Run for GapBuffer
|
||||
print_row(bench_sequential_append<GapBuffer>(N, rounds));
|
||||
print_row(bench_sequential_prepend<GapBuffer>(N, rounds));
|
||||
print_row(bench_chunk_append<GapBuffer>(N, chunk, rounds));
|
||||
print_row(bench_mixed<GapBuffer>(N, chunk, rounds));
|
||||
|
||||
// Run for PieceTable
|
||||
print_row(bench_sequential_append<PieceTable>(N, rounds));
|
||||
print_row(bench_sequential_prepend<PieceTable>(N, rounds));
|
||||
print_row(bench_chunk_append<PieceTable>(N, chunk, rounds));
|
||||
print_row(bench_mixed<PieceTable>(N, chunk, rounds));
|
||||
|
||||
return 0;
|
||||
}
|
||||
318
bench/PerformanceSuite.cc
Normal file
318
bench/PerformanceSuite.cc
Normal file
@@ -0,0 +1,318 @@
|
||||
/*
|
||||
* PerformanceSuite.cc - broader performance and verification benchmarks
|
||||
*/
|
||||
|
||||
#include <algorithm>
|
||||
#include <cassert>
|
||||
#include <chrono>
|
||||
#include <cstddef>
|
||||
#include <cstdint>
|
||||
#include <cstring>
|
||||
#include <iomanip>
|
||||
#include <iostream>
|
||||
#include <random>
|
||||
#include <string>
|
||||
#include <typeinfo>
|
||||
#include <vector>
|
||||
|
||||
#include "GapBuffer.h"
|
||||
#include "PieceTable.h"
|
||||
#include "OptimizedSearch.h"
|
||||
|
||||
using clock_t = std::chrono::steady_clock;
|
||||
using us = std::chrono::microseconds;
|
||||
|
||||
namespace {
|
||||
struct Stat {
|
||||
double micros{0.0};
|
||||
std::size_t bytes{0};
|
||||
std::size_t ops{0};
|
||||
};
|
||||
|
||||
|
||||
static void
|
||||
print_header(const std::string &title)
|
||||
{
|
||||
std::cout << "\n" << title << "\n";
|
||||
std::cout << std::left << std::setw(18) << "Case"
|
||||
<< std::left << std::setw(18) << "Type"
|
||||
<< std::right << std::setw(12) << "time(us)"
|
||||
<< std::right << std::setw(14) << "bytes"
|
||||
<< std::right << std::setw(14) << "ops/s"
|
||||
<< std::right << std::setw(14) << "MB/s"
|
||||
<< "\n";
|
||||
std::cout << std::string(90, '-') << "\n";
|
||||
}
|
||||
|
||||
|
||||
static void
|
||||
print_row(const std::string &caseName, const std::string &typeName, const Stat &s)
|
||||
{
|
||||
double mb = s.bytes / (1024.0 * 1024.0);
|
||||
double sec = s.micros / 1'000'000.0;
|
||||
double mbps = sec > 0 ? (mb / sec) : 0.0;
|
||||
double opss = sec > 0 ? (static_cast<double>(s.ops) / sec) : 0.0;
|
||||
std::cout << std::left << std::setw(18) << caseName
|
||||
<< std::left << std::setw(18) << typeName
|
||||
<< std::right << std::setw(12) << std::fixed << std::setprecision(2) << s.micros
|
||||
<< std::right << std::setw(14) << s.bytes
|
||||
<< std::right << std::setw(14) << std::fixed << std::setprecision(2) << opss
|
||||
<< std::right << std::setw(14) << std::fixed << std::setprecision(2) << mbps
|
||||
<< "\n";
|
||||
}
|
||||
} // namespace
|
||||
|
||||
class PerformanceSuite {
|
||||
public:
|
||||
void benchmarkBufferOperations(std::size_t N, int rounds, std::size_t chunk)
|
||||
{
|
||||
print_header("Buffer Operations");
|
||||
run_buffer_case<GapBuffer>("append_char", N, rounds, chunk, [&](auto &b, std::size_t count) {
|
||||
for (std::size_t i = 0; i < count; ++i)
|
||||
b.AppendChar('a');
|
||||
});
|
||||
run_buffer_case<GapBuffer>("prepend_char", N, rounds, chunk, [&](auto &b, std::size_t count) {
|
||||
for (std::size_t i = 0; i < count; ++i)
|
||||
b.PrependChar('a');
|
||||
});
|
||||
run_buffer_case<GapBuffer>("chunk_mix", N, rounds, chunk, [&](auto &b, std::size_t) {
|
||||
std::string payload(chunk, 'x');
|
||||
std::size_t written = 0;
|
||||
while (written < N) {
|
||||
std::size_t now = std::min(chunk, N - written);
|
||||
if (((written / chunk) & 1) == 0)
|
||||
b.Append(payload.data(), now);
|
||||
else
|
||||
b.Prepend(payload.data(), now);
|
||||
written += now;
|
||||
}
|
||||
});
|
||||
run_buffer_case<PieceTable>("append_char", N, rounds, chunk, [&](auto &b, std::size_t count) {
|
||||
for (std::size_t i = 0; i < count; ++i)
|
||||
b.AppendChar('a');
|
||||
});
|
||||
run_buffer_case<PieceTable>("prepend_char", N, rounds, chunk, [&](auto &b, std::size_t count) {
|
||||
for (std::size_t i = 0; i < count; ++i)
|
||||
b.PrependChar('a');
|
||||
});
|
||||
run_buffer_case<PieceTable>("chunk_mix", N, rounds, chunk, [&](auto &b, std::size_t) {
|
||||
std::string payload(chunk, 'x');
|
||||
std::size_t written = 0;
|
||||
while (written < N) {
|
||||
std::size_t now = std::min(chunk, N - written);
|
||||
if (((written / chunk) & 1) == 0)
|
||||
b.Append(payload.data(), now);
|
||||
else
|
||||
b.Prepend(payload.data(), now);
|
||||
written += now;
|
||||
}
|
||||
});
|
||||
}
|
||||
|
||||
|
||||
void benchmarkSearchOperations(std::size_t textLen, std::size_t patLen, int rounds)
|
||||
{
|
||||
print_header("Search Operations");
|
||||
std::mt19937_64 rng(0xC0FFEE);
|
||||
std::uniform_int_distribution<int> dist('a', 'z');
|
||||
std::string text(textLen, '\0');
|
||||
for (auto &ch: text)
|
||||
ch = static_cast<char>(dist(rng));
|
||||
std::string pattern(patLen, '\0');
|
||||
for (auto &ch: pattern)
|
||||
ch = static_cast<char>(dist(rng));
|
||||
|
||||
// Ensure at least one hit
|
||||
if (textLen >= patLen && patLen > 0) {
|
||||
std::size_t pos = textLen / 2;
|
||||
std::memcpy(&text[pos], pattern.data(), patLen);
|
||||
}
|
||||
|
||||
// OptimizedSearch find_all vs std::string reference
|
||||
OptimizedSearch os;
|
||||
Stat s{};
|
||||
auto start = clock_t::now();
|
||||
std::size_t matches = 0;
|
||||
std::size_t bytesScanned = 0;
|
||||
for (int r = 0; r < rounds; ++r) {
|
||||
auto hits = os.find_all(text, pattern, 0);
|
||||
matches += hits.size();
|
||||
bytesScanned += text.size();
|
||||
// Verify with reference
|
||||
std::vector<std::size_t> ref;
|
||||
std::size_t from = 0;
|
||||
while (true) {
|
||||
auto p = text.find(pattern, from);
|
||||
if (p == std::string::npos)
|
||||
break;
|
||||
ref.push_back(p);
|
||||
from = p + (patLen ? patLen : 1);
|
||||
}
|
||||
assert(ref == hits);
|
||||
}
|
||||
auto end = clock_t::now();
|
||||
s.micros = std::chrono::duration_cast<us>(end - start).count();
|
||||
s.bytes = bytesScanned;
|
||||
s.ops = matches;
|
||||
print_row("find_all", "OptimizedSearch", s);
|
||||
}
|
||||
|
||||
|
||||
void benchmarkMemoryAllocation(std::size_t N, int rounds)
|
||||
{
|
||||
print_header("Memory Allocation (allocations during editing)");
|
||||
// Measure number of allocations by simulating editing patterns.
|
||||
auto run_session = [&](auto &&buffer) {
|
||||
// alternate small appends and prepends
|
||||
const std::size_t chunk = 32;
|
||||
std::string payload(chunk, 'q');
|
||||
for (int r = 0; r < rounds; ++r) {
|
||||
buffer.Clear();
|
||||
for (std::size_t i = 0; i < N; i += chunk)
|
||||
buffer.Append(payload.data(), std::min(chunk, N - i));
|
||||
for (std::size_t i = 0; i < N / 2; i += chunk)
|
||||
buffer.Prepend(payload.data(), std::min(chunk, N / 2 - i));
|
||||
}
|
||||
};
|
||||
|
||||
// Local allocation counters for this TU via overriding operators
|
||||
reset_alloc_counters();
|
||||
GapBuffer gb;
|
||||
run_session(gb);
|
||||
auto gap_allocs = current_allocs();
|
||||
print_row("edit_session", "GapBuffer", Stat{
|
||||
0.0, static_cast<std::size_t>(gap_allocs.bytes),
|
||||
static_cast<std::size_t>(gap_allocs.count)
|
||||
});
|
||||
|
||||
reset_alloc_counters();
|
||||
PieceTable pt;
|
||||
run_session(pt);
|
||||
auto pt_allocs = current_allocs();
|
||||
print_row("edit_session", "PieceTable", Stat{
|
||||
0.0, static_cast<std::size_t>(pt_allocs.bytes),
|
||||
static_cast<std::size_t>(pt_allocs.count)
|
||||
});
|
||||
}
|
||||
|
||||
private:
|
||||
template<typename Buf, typename Fn>
|
||||
void run_buffer_case(const std::string &caseName, std::size_t N, int rounds, std::size_t chunk, Fn fn)
|
||||
{
|
||||
Stat s{};
|
||||
auto start = clock_t::now();
|
||||
std::size_t bytes = 0;
|
||||
std::size_t ops = 0;
|
||||
for (int t = 0; t < rounds; ++t) {
|
||||
Buf b;
|
||||
b.Reserve(N);
|
||||
fn(b, N);
|
||||
// compare to reference string where possible (only for append_char/prepend_char)
|
||||
bytes += N;
|
||||
ops += N / (chunk ? chunk : 1);
|
||||
}
|
||||
auto end = clock_t::now();
|
||||
s.micros = std::chrono::duration_cast<us>(end - start).count();
|
||||
s.bytes = bytes;
|
||||
s.ops = ops;
|
||||
print_row(caseName, typeid(Buf).name(), s);
|
||||
}
|
||||
|
||||
|
||||
// Simple global allocation tracking for this TU
|
||||
struct AllocStats {
|
||||
std::uint64_t count{0};
|
||||
std::uint64_t bytes{0};
|
||||
};
|
||||
|
||||
|
||||
static AllocStats &alloc_stats()
|
||||
{
|
||||
static AllocStats s;
|
||||
return s;
|
||||
}
|
||||
|
||||
|
||||
static void reset_alloc_counters()
|
||||
{
|
||||
alloc_stats() = {};
|
||||
}
|
||||
|
||||
|
||||
static AllocStats current_allocs()
|
||||
{
|
||||
return alloc_stats();
|
||||
}
|
||||
|
||||
|
||||
// Friend global new/delete defined below
|
||||
friend void *operator new(std::size_t sz) noexcept(false);
|
||||
|
||||
friend void operator delete(void *p) noexcept;
|
||||
|
||||
friend void *operator new[](std::size_t sz) noexcept(false);
|
||||
|
||||
friend void operator delete[](void *p) noexcept;
|
||||
};
|
||||
|
||||
// Override new/delete only in this translation unit to track allocations made here
|
||||
void *
|
||||
operator new(std::size_t sz) noexcept(false)
|
||||
{
|
||||
auto &s = PerformanceSuite::alloc_stats();
|
||||
s.count++;
|
||||
s.bytes += sz;
|
||||
if (void *p = std::malloc(sz))
|
||||
return p;
|
||||
throw std::bad_alloc();
|
||||
}
|
||||
|
||||
|
||||
void
|
||||
operator delete(void *p) noexcept
|
||||
{
|
||||
std::free(p);
|
||||
}
|
||||
|
||||
|
||||
void *
|
||||
operator new[](std::size_t sz) noexcept(false)
|
||||
{
|
||||
auto &s = PerformanceSuite::alloc_stats();
|
||||
s.count++;
|
||||
s.bytes += sz;
|
||||
if (void *p = std::malloc(sz))
|
||||
return p;
|
||||
throw std::bad_alloc();
|
||||
}
|
||||
|
||||
|
||||
void
|
||||
operator delete[](void *p) noexcept
|
||||
{
|
||||
std::free(p);
|
||||
}
|
||||
|
||||
|
||||
int
|
||||
main(int argc, char **argv)
|
||||
{
|
||||
std::size_t N = 200'000; // bytes per round for buffer cases
|
||||
int rounds = 3;
|
||||
std::size_t chunk = 1024;
|
||||
if (argc >= 2)
|
||||
N = static_cast<std::size_t>(std::stoull(argv[1]));
|
||||
if (argc >= 3)
|
||||
rounds = std::stoi(argv[2]);
|
||||
if (argc >= 4)
|
||||
chunk = static_cast<std::size_t>(std::stoull(argv[3]));
|
||||
|
||||
std::cout << "KTE Performance Suite" << "\n";
|
||||
std::cout << "N=" << N << ", rounds=" << rounds << ", chunk=" << chunk << "\n";
|
||||
|
||||
PerformanceSuite suite;
|
||||
suite.benchmarkBufferOperations(N, rounds, chunk);
|
||||
suite.benchmarkSearchOperations(1'000'000, 16, rounds);
|
||||
suite.benchmarkMemoryAllocation(N, rounds);
|
||||
return 0;
|
||||
}
|
||||
@@ -23,5 +23,9 @@
|
||||
<key>LSMinimumSystemVersion</key>
|
||||
<string>10.13</string>
|
||||
<key>NSHighResolutionCapable</key>
|
||||
<true/>
|
||||
<!-- Allow running multiple instances of the app -->
|
||||
<key>LSMultipleInstancesProhibited</key>
|
||||
<false/>
|
||||
</dict>
|
||||
</plist>
|
||||
@@ -2,27 +2,43 @@
|
||||
|
||||
## Overview
|
||||
|
||||
`TestFrontend` is a headless implementation of the `Frontend` interface designed to facilitate programmatic testing of editor features. It allows you to queue commands and text input manually, execute them step-by-step, and inspect the editor/buffer state.
|
||||
`TestFrontend` is a headless implementation of the `Frontend` interface
|
||||
designed to facilitate programmatic testing of editor features. It
|
||||
allows you to queue commands and text input manually, execute them
|
||||
step-by-step, and inspect the editor/buffer state.
|
||||
|
||||
## Components
|
||||
|
||||
### TestInputHandler
|
||||
|
||||
A programmable input handler that uses a queue-based system:
|
||||
- `QueueCommand(CommandId id, const std::string &arg = "", int count = 0)` - Queue a specific command
|
||||
- `QueueText(const std::string &text)` - Queue text for insertion (character by character)
|
||||
|
||||
-
|
||||
`QueueCommand(CommandId id, const std::string &arg = "", int count = 0)` -
|
||||
Queue a specific command
|
||||
- `QueueText(const std::string &text)` - Queue text for insertion (
|
||||
character by character)
|
||||
- `Poll(MappedInput &out)` - Returns queued commands one at a time
|
||||
- `IsEmpty()` - Check if the input queue is empty
|
||||
|
||||
### TestRenderer
|
||||
|
||||
A minimal no-op renderer for testing:
|
||||
- `Draw(Editor &ed)` - No-op implementation, just increments draw counter
|
||||
|
||||
- `Draw(Editor &ed)` - No-op implementation, just increments draw
|
||||
counter
|
||||
- `GetDrawCount()` - Returns the number of times Draw() was called
|
||||
- `ResetDrawCount()` - Resets the draw counter
|
||||
|
||||
### TestFrontend
|
||||
The main frontend class that integrates TestInputHandler and TestRenderer:
|
||||
- `Init(Editor &ed)` - Initializes the frontend (sets editor dimensions to 24x80)
|
||||
- `Step(Editor &ed, bool &running)` - Processes one command from the queue and renders
|
||||
|
||||
The main frontend class that integrates TestInputHandler and
|
||||
TestRenderer:
|
||||
|
||||
- `Init(Editor &ed)` - Initializes the frontend (sets editor dimensions
|
||||
to 24x80)
|
||||
- `Step(Editor &ed, bool &running)` - Processes one command from the
|
||||
queue and renders
|
||||
- `Shutdown()` - Cleanup (no-op for TestFrontend)
|
||||
- `Input()` - Access the TestInputHandler
|
||||
- `Renderer()` - Access the TestRenderer
|
||||
@@ -75,31 +91,55 @@ int main() {
|
||||
|
||||
## Key Features
|
||||
|
||||
1. **Programmable Input**: Queue any sequence of commands or text programmatically
|
||||
1. **Programmable Input**: Queue any sequence of commands or text
|
||||
programmatically
|
||||
2. **Step-by-Step Execution**: Run the editor one command at a time
|
||||
3. **State Inspection**: Access and verify editor/buffer state between commands
|
||||
4. **No UI Dependencies**: Headless operation, no terminal or GUI required
|
||||
5. **Integration Testing**: Test command sequences, undo/redo, multi-line editing, etc.
|
||||
3. **State Inspection**: Access and verify editor/buffer state between
|
||||
commands
|
||||
4. **No UI Dependencies**: Headless operation, no terminal or GUI
|
||||
required
|
||||
5. **Integration Testing**: Test command sequences, undo/redo,
|
||||
multi-line editing, etc.
|
||||
|
||||
## Available Commands
|
||||
|
||||
All commands from `CommandId` enum can be queued, including:
|
||||
|
||||
- `CommandId::InsertText` - Insert text (use `QueueText()` helper)
|
||||
- `CommandId::Newline` - Insert newline
|
||||
- `CommandId::Backspace` - Delete character before cursor
|
||||
- `CommandId::Backspace` - Delete character before cursor
|
||||
- `CommandId::DeleteChar` - Delete character at cursor
|
||||
- `CommandId::MoveLeft`, `MoveRight`, `MoveUp`, `MoveDown` - Cursor movement
|
||||
- `CommandId::MoveLeft`, `MoveRight`, `MoveUp`, `MoveDown` - Cursor
|
||||
movement
|
||||
- `CommandId::Undo`, `CommandId::Redo` - Undo/redo operations
|
||||
- `CommandId::Save`, `CommandId::Quit` - File operations
|
||||
- And many more (see Command.h)
|
||||
|
||||
## Integration
|
||||
|
||||
TestFrontend is built into both `kte` and `kge` executables as part of the common source files. You can create standalone test programs by linking against the same source files and ncurses.
|
||||
TestFrontend is built into both `kte` and `kge` executables as part of
|
||||
the common source files. You can create standalone test programs by
|
||||
linking against the same source files and ncurses.
|
||||
|
||||
## Notes
|
||||
|
||||
- Always call `InstallDefaultCommands()` before using any commands
|
||||
- Buffer must be initialized (via `OpenFile()` or `AddBuffer()`) before queuing edit commands
|
||||
- Buffer must be initialized (via `OpenFile()` or `AddBuffer()`) before
|
||||
queuing edit commands
|
||||
- Undo/redo requires the buffer to have an UndoSystem attached
|
||||
- The test frontend sets editor dimensions to 24x80 by default
|
||||
|
||||
## Highlighter stress harness
|
||||
|
||||
For renderer/highlighter race testing without a UI, `kte` provides a
|
||||
lightweight stress mode:
|
||||
|
||||
```
|
||||
kte --stress-highlighter=5
|
||||
```
|
||||
|
||||
This runs a short synthetic workload (5 seconds by default) that edits
|
||||
and scrolls a buffer while
|
||||
exercising `HighlighterEngine::PrefetchViewport` and `GetLine`
|
||||
concurrently. Use Debug builds with
|
||||
AddressSanitizer enabled for best effect.
|
||||
|
||||
@@ -77,5 +77,4 @@ k-command mode can be exited with ESC or C-g.
|
||||
|
||||
The find operation is an incremental search. The up or left arrow
|
||||
keys will go to the previous result, while the down or right arrow keys
|
||||
will go to the next result. Unfortunately, the search starts from the
|
||||
top of the file each time. This is a known bug.
|
||||
will go to the next result.
|
||||
@@ -252,9 +252,6 @@ Open using the terminal frontend from kge:
|
||||
(project keybinding manual)
|
||||
.br
|
||||
Project homepage: https://github.com/wntrmute/kte
|
||||
.SH BUGS
|
||||
Report issues on the project tracker. Some behaviors are inherited from
|
||||
ke and may evolve over time; see the manual for notes.
|
||||
.SH AUTHORS
|
||||
Kyle (wntrmute) and contributors.
|
||||
.SH COPYRIGHT
|
||||
|
||||
@@ -279,9 +279,6 @@ Force GUI frontend (if available):
|
||||
(project keybinding manual)
|
||||
.br
|
||||
Project homepage: https://github.com/wntrmute/kte
|
||||
.SH BUGS
|
||||
Incremental search currently restarts from the top on each invocation; see
|
||||
\(lqKnown behavior\(rq in the ke manual. Report issues on the project tracker.
|
||||
.SH AUTHORS
|
||||
Kyle (wntrmute) and contributors.
|
||||
.SH COPYRIGHT
|
||||
|
||||
144
docs/plans/swap-files.md
Normal file
144
docs/plans/swap-files.md
Normal file
@@ -0,0 +1,144 @@
|
||||
Swap files for kte — design plan
|
||||
================================
|
||||
|
||||
Goals
|
||||
-----
|
||||
|
||||
- Preserve user work across crashes, power failures, and OS kills.
|
||||
- Keep the editor responsive; avoid blocking the UI on disk I/O.
|
||||
- Bound recovery time and swap size.
|
||||
- Favor simple, robust primitives that work well on POSIX and macOS;
|
||||
keep Windows feasibility in mind.
|
||||
|
||||
Model overview
|
||||
--------------
|
||||
Per open buffer, maintain a sidecar swap journal next to the file:
|
||||
|
||||
- Path: `.<basename>.kte.swp` in the same directory as the file (for
|
||||
unnamed/unsaved buffers, use a per‑session temp dir like
|
||||
`$TMPDIR/kte/` with a random UUID).
|
||||
- Format: append‑only journal of editing operations with periodic
|
||||
checkpoints.
|
||||
- Crash safety: only append, fsync as per policy; checkpoint via
|
||||
write‑to‑temp + fsync + atomic rename.
|
||||
|
||||
File format (v1)
|
||||
----------------
|
||||
Header (fixed 64 bytes):
|
||||
|
||||
- Magic: `KTE_SWP\0` (8 bytes)
|
||||
- Version: 1 (u32)
|
||||
- Flags: bitset (u32) — e.g., compression, checksums, endian.
|
||||
- Created time (u64)
|
||||
- Host info hash (u64) — optional, for telemetry/debug.
|
||||
- File identity: hash of canonical path (u64) and original file
|
||||
size+mtime (u64+u64) at start.
|
||||
- Reserved/padding.
|
||||
|
||||
Records (stream after header):
|
||||
|
||||
- Each record: [type u8][len u24][payload][crc32 u32]
|
||||
- Types:
|
||||
- `CHKPT` — full snapshot checkpoint of entire buffer content and
|
||||
minimal metadata (cursor pos, filetype). Payload optionally
|
||||
compressed. Written occasionally to cap replay time.
|
||||
- `INS` — insert at (row, col) text bytes (text may contain
|
||||
newlines). Encoded with varints.
|
||||
- `DEL` — delete length at (row, col). If spanning lines, semantics
|
||||
defined as in Buffer::delete_text.
|
||||
- `SPLIT`, `JOIN` — explicit structural ops (optional; can be
|
||||
expressed via INS/DEL).
|
||||
- `META` — update metadata (e.g., filetype, encoding hints).
|
||||
|
||||
Durability policy
|
||||
-----------------
|
||||
Configurable knobs (sane defaults in parentheses):
|
||||
|
||||
- Time‑based flush: group edits and flush every 150–300 ms (200 ms).
|
||||
- Operation count flush: after N ops (200).
|
||||
- Idle flush: on 500 ms idle lull, flush immediately.
|
||||
- Checkpoint cadence: after M KB of journal (512–2048 KB) or T seconds (
|
||||
30–120 s), whichever first.
|
||||
- fsync policy:
|
||||
- `always`: fsync every flush (safest, slowest).
|
||||
- `grouped` (default): fsync at most every 1–2 s or on
|
||||
idle/blur/quit.
|
||||
- `never`: rely on OS flush (fastest, riskier).
|
||||
- On POSIX, prefer `fdatasync` when available; fall back to `fsync`.
|
||||
|
||||
Performance & threading
|
||||
-----------------------
|
||||
|
||||
- Background writer thread per editor instance (shared) with a bounded
|
||||
MPSC queue of per‑buffer records.
|
||||
- Each Buffer has a small in‑memory journal buffer; UI thread enqueues
|
||||
ops (non‑blocking) and may coalesce adjacent inserts/deletes.
|
||||
- Writer batch‑writes records to the swap file, computes CRCs, and
|
||||
decides checkpoint boundaries.
|
||||
- Backpressure: if the queue grows beyond a high watermark, signal the
|
||||
UI to start coalescing more aggressively and slow enqueue (never block
|
||||
hard editing path; at worst drop optional `META`).
|
||||
|
||||
Recovery flow
|
||||
-------------
|
||||
|
||||
On opening a file:
|
||||
|
||||
1. Detect swap sidecar `.<basename>.kte.swp`.
|
||||
2. Validate header, iterate records verifying CRCs.
|
||||
3. Compare recorded original file identity against actual file; if
|
||||
mismatch, warn user but allow recovery (content wins).
|
||||
4. Reconstruct buffer: start from the last good `CHKPT` (if any), then
|
||||
replay subsequent ops. If trailing partial record encountered (EOF
|
||||
mid‑record), truncate at last good offset.
|
||||
5. Present a choice: Recover (load recovered buffer; keep the swap file
|
||||
until user saves) or Discard (delete swap file and open clean file).
|
||||
|
||||
Stability & corruption mitigation
|
||||
---------------------------------
|
||||
|
||||
- Append‑only with per‑record CRC32 guards against torn writes.
|
||||
- Atomic checkpoint rotation: write `.<basename>.kte.swp.tmp`, fsync,
|
||||
then rename over old `.swp`.
|
||||
- Size caps: rotate or compact when `.swp` exceeds a threshold (e.g.,
|
||||
64–128 MB). Compaction creates a fresh file with a single checkpoint.
|
||||
- Low‑disk‑space behavior: on write failures, surface a non‑modal
|
||||
warning and temporarily fall back to in‑memory only; retry
|
||||
opportunistically.
|
||||
|
||||
Security considerations
|
||||
-----------------------
|
||||
|
||||
- Swap files mirror buffer content, which may be sensitive. Options:
|
||||
- Configurable location (same dir vs. `$XDG_STATE_HOME/kte/swap`).
|
||||
- Optional per‑file encryption (future work) using OS keychain.
|
||||
- Ensure permissions are 0600.
|
||||
|
||||
Interoperability & UX
|
||||
---------------------
|
||||
|
||||
- Use a distinctive extension `.kte.swp` to avoid conflicts with other
|
||||
editors.
|
||||
- Status bar indicator when swap is active; commands to purge/compact.
|
||||
- On save: do not delete swap immediately; keep until the buffer is
|
||||
clean and idle for a short grace period (allows undo of accidental
|
||||
external changes).
|
||||
|
||||
Implementation plan (staged)
|
||||
----------------------------
|
||||
|
||||
1. Minimal journal writer (append‑only INS/DEL) with grouped fsync;
|
||||
single per‑editor writer thread.
|
||||
2. Reader/recovery path with CRC validation and replay.
|
||||
3. Checkpoints + atomic rotation; compaction path.
|
||||
4. Config surface and UI prompts; telemetry counters.
|
||||
5. Optional compression and advanced coalescing.
|
||||
|
||||
Defaults balancing performance and stability
|
||||
-------------------------------------------
|
||||
|
||||
- Grouped flush with fsync every ~1 s or on idle/quit.
|
||||
- Checkpoint every 1 MB or 60 s.
|
||||
- Bounded queue and batch writes to minimize syscalls.
|
||||
- Immediate flush on critical events (buffer close, app quit, power
|
||||
source change on laptops if detectable).
|
||||
215
docs/plans/undo.md
Normal file
215
docs/plans/undo.md
Normal file
@@ -0,0 +1,215 @@
|
||||
This is a design for a non-linear undo/redo system for kte. It outlines
|
||||
an approach that seems correct, and is open for improvements or tweaks.
|
||||
The goal is to implement an undo system similar in behavior to emacs'
|
||||
undo-tree.
|
||||
|
||||
### Core Requirements
|
||||
|
||||
1. Each open buffer has its own completely independent undo tree.
|
||||
2. Undo and redo must be non-linear: typing after undo creates a branch;
|
||||
old redo branches are discarded.
|
||||
3. Typing, backspacing, and pasting are batched into word-level undo
|
||||
steps.
|
||||
4. Undo/redo must never create new undo nodes while applying an
|
||||
undo/redo (silent, low-level apply).
|
||||
5. The system must be memory-safe and leak-proof even if the user types
|
||||
and immediately closes the buffer.
|
||||
|
||||
### Data Structures
|
||||
|
||||
This is a proprosed data design.
|
||||
|
||||
```cpp
|
||||
enum class UndoType : uint8_t {
|
||||
Insert,
|
||||
Delete,
|
||||
Paste, // optional, can reuse Insert
|
||||
Newline,
|
||||
DeleteRow,
|
||||
// future: IndentRegion, KillRegion, etc.
|
||||
};
|
||||
|
||||
struct UndoNode {
|
||||
UndoType type;
|
||||
int row; // original cursor row
|
||||
int col; // original cursor column (updated during batch)
|
||||
std::string text; // the inserted or deleted text (full batch)
|
||||
UndoNode* child = nullptr; // next in current timeline
|
||||
UndoNode* next = nullptr; // redo branch (rarely used)
|
||||
// no parent pointer needed — we walk from root
|
||||
};
|
||||
|
||||
struct UndoTree {
|
||||
UndoNode* root = nullptr; // first edit ever
|
||||
UndoNode* current = nullptr; // current state of buffer
|
||||
UndoNode* saved = nullptr; // points to node matching last save (for dirty flag)
|
||||
UndoNode* pending = nullptr; // in-progress batch (detached)
|
||||
};
|
||||
```
|
||||
|
||||
Each `Buffer` owns one `std::unique_ptr<UndoTree>`.
|
||||
|
||||
### Core API
|
||||
|
||||
This is based on the data structures from before.
|
||||
|
||||
```cpp
|
||||
class UndoSystem {
|
||||
public:
|
||||
void Begin(UndoType type);
|
||||
void Append(char ch);
|
||||
void Append(std::string_view text);
|
||||
void commit(); // called on cursor move, commands, etc.
|
||||
|
||||
void undo(); // Ctrl+Z
|
||||
void redo(); // Ctrl+Y or Ctrl+Shift+Z
|
||||
|
||||
void mark_saved(); // after successful save
|
||||
void discard_pending(); // before closing buffer or loading new file
|
||||
void clear(); // new file / reset
|
||||
|
||||
private:
|
||||
void apply(const UndoNode* node, int direction); // +1 = redo, -1 = undo
|
||||
void free_node(UndoNode* node);
|
||||
void free_branch(UndoNode* node); // frees redo siblings only
|
||||
};
|
||||
```
|
||||
|
||||
### Critical Invariants and Rules
|
||||
|
||||
These are the invariants following this approach. Consider whether this
|
||||
is a correct or even complete list.
|
||||
|
||||
1. `begin()` must reuse `pending` if:
|
||||
- same type
|
||||
- same row
|
||||
- `pending->col + pending->text.size() == current_cursor_col`;
|
||||
otherwise `commit()` old and create new
|
||||
|
||||
2. `pending` is detached, and never linked until `commit()`
|
||||
|
||||
3. `commit()`:
|
||||
- discards redo branches (`current->child`)
|
||||
- attaches `pending` as `current->child`
|
||||
- advances `current`
|
||||
- clears `pending`
|
||||
- if diverged from `saved`, null it
|
||||
|
||||
4. `apply()` must use low-level buffer operations:
|
||||
- Never call public insert/delete/newline
|
||||
- Use raw `buffer.insert_text(row, col, text)` and
|
||||
`buffer.delete_text(row, col, len)`
|
||||
- These must not trigger undo
|
||||
|
||||
5. `undo()`:
|
||||
- move current to parent
|
||||
- apply(current, -1)
|
||||
|
||||
6. `redo()`:
|
||||
- move current to child
|
||||
- apply(current, +1)
|
||||
|
||||
7. `discard_pending()` must be called in:
|
||||
- buffer close
|
||||
- file reload
|
||||
- new file
|
||||
- any destructive operation
|
||||
|
||||
### Example Flow: Typing "hello"
|
||||
|
||||
```text
|
||||
begin(Insert) → pending = new node, col=0
|
||||
append('h') → pending->text = "h", pending->col = 1
|
||||
append('e') → "he", col = 2
|
||||
...
|
||||
commit() on arrow key → pending becomes current->child, current advances
|
||||
```
|
||||
|
||||
One undo step removes all of "hello".
|
||||
|
||||
### Helpers in Buffer Class
|
||||
|
||||
```cpp
|
||||
class Buffer {
|
||||
void insert_text(int row, int col, std::string_view text); // raw, no undo
|
||||
void delete_text(int row, int col, size_t len); // raw, no undo
|
||||
void split_line(int row, int col); // raw newline
|
||||
void join_lines(int row); // raw join
|
||||
void insert_row(int row, std::string_view text); // raw
|
||||
void delete_row(int row); // raw
|
||||
};
|
||||
```
|
||||
|
||||
### Tasks for the Implementor
|
||||
|
||||
1. Implement `UndoNode`, `UndoTree`, and `UndoSystem` class exactly as
|
||||
specified.
|
||||
2. Add `std::unique_ptr<UndoTree> undo;` to `Buffer`.
|
||||
3. Modify `insert_char`, `delete_char`, `paste`, `newline` to use
|
||||
`undo.begin()/append()/commit()`.
|
||||
4. Add `undo.commit()` at start of all cursor movement and command
|
||||
functions.
|
||||
5. Implement `apply()` using only `Buffer`'s raw methods.
|
||||
6. Add `undo.discard_pending()` in all buffer reset/close paths.
|
||||
7. Add `Ctrl+k u` -> `buffer.undo()`, `Ctrl+k r` -> `buffer.redo()`.
|
||||
|
||||
## Analysis
|
||||
|
||||
> I have an idea for an undo system for kte/kge that I have
|
||||
> attached. Consider the plan, and the state of the code base.
|
||||
> Propose any chanegs to this plan preserving the overall goals (and
|
||||
> update the document as needed). Then, generate a complete plan for
|
||||
> implementing it. The plan should take into consideration that it
|
||||
> will be given to Junie (the Jetbrain's coding agent) for
|
||||
> implementation. The plan should be saved in `docs/undo-roadmap.md`.
|
||||
|
||||
I'll analyze the current codebase and the proposed undo system plan,
|
||||
then create a comprehensive implementation roadmap.
|
||||
|
||||
Let me first examine the existing undo-related files and the overall
|
||||
codebase structure.Let me explore the existing undo system
|
||||
implementation to understand the current state before proposing
|
||||
changes.Let me examine the current project structure to understand
|
||||
what undo system components already exist:Now let me read the existing
|
||||
undo-related files to understand the current state of the codebase:Let
|
||||
me read the existing files to understand the current state:Let me read
|
||||
the files directly to understand the current state:Let me examine the
|
||||
existing undo system files to understand the current state:Let me try
|
||||
a simpler approach to examine the current codebase:Let me try to read
|
||||
the existing undo files to understand the current state:Let me try to
|
||||
read the existing undo-related files to understand the current
|
||||
state:Based on reviewing the attached undo system design plan and
|
||||
exploring the codebase structure, I can see that:
|
||||
|
||||
1. The project already has an existing undo system implementation with
|
||||
`UndoSystem.h/cc`, `UndoTree.h/cc`, `UndoNode.h/cc` files
|
||||
2. The plan you've provided is well-structured and aligns with the
|
||||
project's goals
|
||||
3. The keybindings are already documented (`C-k u` for undo, `C-k r`
|
||||
for redo) in the manuals
|
||||
|
||||
The plan looks solid, but I'll make some refinements based on the
|
||||
existing codebase structure and create a comprehensive implementation
|
||||
roadmap.
|
||||
|
||||
### Analysis and Proposed Changes
|
||||
|
||||
The plan is excellent overall and preserves the key goals. Here are
|
||||
some minor refinements I'd suggest:
|
||||
|
||||
1. **Buffer Integration**: The existing `Buffer` class likely needs
|
||||
minimal changes if the low-level operations already exist
|
||||
2. **Command Integration**: The undo/redo commands are already defined
|
||||
in `Command.h` (`CommandId::Undo`, `CommandId::Redo`)
|
||||
3. **Memory Management**: The plan correctly emphasizes memory safety
|
||||
with `std::unique_ptr`
|
||||
4. **Testing**: There's already a `test_undo.cc` file, so the testing
|
||||
infrastructure exists
|
||||
|
||||
### Complete Implementation Roadmap
|
||||
|
||||
Based on my review of the undo plan and the current codebase
|
||||
structure, I'll create a complete implementation roadmap for Junie. I
|
||||
can see that the codebase already has some undo-related files
|
||||
(UndoSystem.h, UndoTree.h, UndoNode.h) and the plan is well-thought-out.
|
||||
Let me provide an [updated plan](../undo-roadmap.md).
|
||||
261
docs/reports/20251203/code-report-quality.md
Normal file
261
docs/reports/20251203/code-report-quality.md
Normal file
@@ -0,0 +1,261 @@
|
||||
# KTE Codebase Quality Analysis Report
|
||||
|
||||
## Executive Summary
|
||||
|
||||
This report analyzes the KTE (Kyle's Text Editor) codebase for code
|
||||
quality, safety, stability, and cleanup
|
||||
opportunities. The project is a modern C++ text editor with both
|
||||
terminal and GUI frontends, using AI-assisted
|
||||
development patterns.
|
||||
|
||||
**Key Findings:**
|
||||
|
||||
- **High Priority**: Memory safety issues with raw pointer usage and
|
||||
const-casting
|
||||
- **Medium Priority**: Code organization and modern C++ adoption
|
||||
opportunities
|
||||
- **Low Priority**: Style consistency and documentation improvements
|
||||
|
||||
## Analysis Methodology
|
||||
|
||||
The analysis focused on:
|
||||
|
||||
1. Core data structures (Buffer, GapBuffer, PieceTable)
|
||||
2. Memory management patterns
|
||||
3. Input handling and UI components
|
||||
4. Command system and editor core
|
||||
5. Cross-platform compatibility
|
||||
|
||||
## Critical Issues (High Priority)
|
||||
|
||||
### 1. **Unsafe const_cast Usage in Font Registry**
|
||||
|
||||
**File:** `FontRegistry.cc` (from context attachment)
|
||||
**Lines:** Multiple occurrences in `InstallDefaultFonts()`
|
||||
**Issue:** Dangerous const-casting of compressed font data
|
||||
|
||||
```
|
||||
cpp
|
||||
// CURRENT (UNSAFE):
|
||||
const_cast<unsigned int *>(BrassMono::DefaultFontBoldCompressedData)
|
||||
```
|
||||
|
||||
**Fix:** Use proper const-correct APIs or create mutable copies
|
||||
|
||||
```
|
||||
cpp
|
||||
// SUGGESTED:
|
||||
std::vector<unsigned int> fontData(
|
||||
BrassMono::DefaultFontBoldCompressedData,
|
||||
BrassMono::DefaultFontBoldCompressedData + BrassMono::DefaultFontBoldCompressedSize
|
||||
);
|
||||
FontRegistry::Instance().Register(std::make_unique<Font>(
|
||||
"brassmono",
|
||||
fontData.data(),
|
||||
fontData.size()
|
||||
));
|
||||
```
|
||||
|
||||
**Priority:** HIGH - Undefined behavior risk
|
||||
|
||||
### 2. **Missing Error Handling in main.cc**
|
||||
|
||||
**File:** `main.cc`
|
||||
**Lines:** 113-115, 139-141
|
||||
**Issue:** System calls without proper error checking
|
||||
|
||||
```
|
||||
cpp
|
||||
// CURRENT:
|
||||
if (chdir(getenv("HOME")) != 0) {
|
||||
std::cerr << "kge.app: failed to chdir to HOME" << std::endl;
|
||||
}
|
||||
```
|
||||
|
||||
**Fix:** Handle null HOME environment variable and add proper error
|
||||
recovery
|
||||
|
||||
```
|
||||
cpp
|
||||
// SUGGESTED:
|
||||
const char* home = getenv("HOME");
|
||||
if (!home) {
|
||||
std::cerr << "kge.app: HOME environment variable not set" << std::endl;
|
||||
return 1;
|
||||
}
|
||||
if (chdir(home) != 0) {
|
||||
std::cerr << "kge.app: failed to chdir to " << home << ": "
|
||||
<< std::strerror(errno) << std::endl;
|
||||
return 1;
|
||||
}
|
||||
```
|
||||
|
||||
**Priority:** HIGH - Runtime safety
|
||||
|
||||
### 3. **Potential Integer Overflow in Line Number Parsing**
|
||||
|
||||
**File:** `main.cc`
|
||||
**Lines:** 120-125
|
||||
**Issue:** Unchecked conversion from unsigned long to size_t
|
||||
|
||||
```
|
||||
cpp
|
||||
// CURRENT:
|
||||
unsigned long v = std::stoul(p);
|
||||
pending_line = static_cast<std::size_t>(v);
|
||||
```
|
||||
|
||||
**Fix:** Add bounds checking
|
||||
|
||||
```
|
||||
cpp
|
||||
// SUGGESTED:
|
||||
unsigned long v = std::stoul(p);
|
||||
if (v > std::numeric_limits<std::size_t>::max()) {
|
||||
std::cerr << "Warning: Line number too large, ignoring\n";
|
||||
pending_line = 0;
|
||||
} else {
|
||||
pending_line = static_cast<std::size_t>(v);
|
||||
}
|
||||
```
|
||||
|
||||
**Priority:** MEDIUM - Edge case safety
|
||||
|
||||
## Code Quality Issues (Medium Priority)
|
||||
|
||||
### 4. **Large Command Enum Without Scoped Categories**
|
||||
|
||||
**File:** `Command.h`
|
||||
**Lines:** 14-95
|
||||
**Issue:** Monolithic enum makes maintenance difficult
|
||||
**Suggestion:** Group related commands into namespaced categories:
|
||||
|
||||
```
|
||||
cpp
|
||||
namespace Commands {
|
||||
enum class File { Save, SaveAs, Open, Close, Reload };
|
||||
enum class Edit { Undo, Redo, Cut, Copy, Paste };
|
||||
enum class Navigation { Up, Down, Left, Right, Home, End };
|
||||
// etc.
|
||||
}
|
||||
```
|
||||
|
||||
**Priority:** MEDIUM - Maintainability
|
||||
|
||||
### 5. **Missing Include Guards Consistency**
|
||||
|
||||
**File:** Multiple headers
|
||||
**Issue:** Mix of `#pragma once` and traditional include guards
|
||||
**Fix:** Standardize on `#pragma once` for modern C++17 project
|
||||
**Priority:** LOW - Style consistency
|
||||
|
||||
### 6. **Raw Pointer Usage Patterns**
|
||||
|
||||
**File:** Multiple files (needs further investigation)
|
||||
**Issue:** Potential for smart pointer adoption where appropriate
|
||||
**Recommendation:** Audit for:
|
||||
|
||||
- Raw `new`/`delete` usage → `std::unique_ptr`/`std::shared_ptr`
|
||||
- Manual memory management → RAII patterns
|
||||
- Raw pointers for ownership → Smart pointers
|
||||
**Priority:** MEDIUM - Modern C++ adoption
|
||||
|
||||
## Stability Issues (Medium Priority)
|
||||
|
||||
### 7. **Exception Safety in File Operations**
|
||||
|
||||
**File:** `main.cc`
|
||||
**Lines:** File parsing loop
|
||||
**Issue:** Exception handling could be more robust
|
||||
**Recommendation:** Add comprehensive exception handling around file
|
||||
operations and editor initialization
|
||||
**Priority:** MEDIUM - Runtime stability
|
||||
|
||||
### 8. **Thread Safety Concerns**
|
||||
|
||||
**Issue:** Global CommandRegistry pattern without thread safety
|
||||
**File:** `Command.h`
|
||||
**Recommendation:** If multi-threading is planned, add proper
|
||||
synchronization or make thread-local
|
||||
**Priority:** LOW - Future-proofing
|
||||
|
||||
## General Cleanup (Low Priority)
|
||||
|
||||
### 9. **Unused Parameter Suppressions**
|
||||
|
||||
**File:** `main.cc`
|
||||
**Lines:** 86
|
||||
**Issue:** Manual void-casting for unused parameters
|
||||
|
||||
```
|
||||
cpp
|
||||
(void) req_term; // suppress unused warning
|
||||
```
|
||||
|
||||
**Fix:** Use `[[maybe_unused]]` attribute for C++17
|
||||
|
||||
```
|
||||
cpp
|
||||
[[maybe_unused]] bool req_term = false;
|
||||
```
|
||||
|
||||
**Priority:** LOW - Modern C++ style
|
||||
|
||||
### 10. **Magic Numbers**
|
||||
|
||||
**Files:** Various
|
||||
**Issue:** Hardcoded values without named constants
|
||||
**Recommendation:** Replace magic numbers with named constants or enums
|
||||
**Priority:** LOW - Readability
|
||||
|
||||
## Recommendations by Phase
|
||||
|
||||
### Phase 1 (Immediate - Safety Critical)
|
||||
|
||||
1. Fix const_cast usage in FontRegistry.cc
|
||||
2. Add proper error handling in main.cc system calls
|
||||
3. Review and fix integer overflow potential
|
||||
|
||||
### Phase 2 (Short-term - Quality)
|
||||
|
||||
1. Audit for raw pointer usage and convert to smart pointers
|
||||
2. Add comprehensive exception handling
|
||||
3. Standardize include guard style
|
||||
|
||||
### Phase 3 (Long-term - Architecture)
|
||||
|
||||
1. Refactor large enums into categorized namespaces
|
||||
2. Consider thread safety requirements
|
||||
3. Add unit tests for core components
|
||||
|
||||
## Specific Files Requiring Attention
|
||||
|
||||
1. **Buffer.h/Buffer.cc** - Core data structure, needs memory safety
|
||||
audit
|
||||
2. **GapBuffer.h/GapBuffer.cc** - Buffer implementation, check for
|
||||
bounds safety
|
||||
3. **PieceTable.h/PieceTable.cc** - Alternative buffer, validate
|
||||
operations
|
||||
4. **Editor.h/Editor.cc** - Main controller, exception safety review
|
||||
5. **FontRegistry.cc** - Critical const_cast issues (immediate fix
|
||||
needed)
|
||||
|
||||
## Testing Recommendations
|
||||
|
||||
1. Add unit tests for buffer operations with edge cases
|
||||
2. Test file parsing with malformed input
|
||||
3. Memory leak testing with valgrind/AddressSanitizer
|
||||
4. Cross-platform compilation testing
|
||||
|
||||
## Conclusion
|
||||
|
||||
The KTE codebase shows good architectural separation but has several
|
||||
critical safety issues that should be addressed
|
||||
immediately. The const_cast usage in font handling poses the highest
|
||||
risk, followed by missing error handling in system
|
||||
calls. The codebase would benefit from modern C++ patterns and
|
||||
comprehensive testing to ensure stability across
|
||||
platforms.
|
||||
|
||||
**Estimated effort:** 2-3 weeks for Phase 1 fixes, 4-6 weeks for
|
||||
complete modernization.
|
||||
410
docs/reports/20251203/code-report.md
Normal file
410
docs/reports/20251203/code-report.md
Normal file
@@ -0,0 +1,410 @@
|
||||
# KTE Performance Analysis Report
|
||||
|
||||
I'll conduct a systematic performance review of the KTE codebase,
|
||||
starting with understanding the project structure and
|
||||
identifying potential hotspots.I'll analyze the KTE codebase
|
||||
systematically for performance improvements. Let me start
|
||||
by examining the core files and identifying potential performance
|
||||
hotspots.Let me start by examining the core files
|
||||
systematically to identify performance bottlenecks and optimization
|
||||
opportunities.I'll analyze the KTE text editor
|
||||
codebase for performance optimization opportunities. Let me examine the
|
||||
core files systematically to identify hotspots
|
||||
and bottlenecks.Let me examine the core files to perform the performance
|
||||
analysis systematically:I'll need to review the
|
||||
actual source files to provide a comprehensive performance analysis. Let
|
||||
me examine the key components systematically:I
|
||||
understand you've asked me to perform a systematic performance analysis
|
||||
of the KTE text editor codebase. Based on the
|
||||
project structure and my expertise in C++ performance optimization, I'll
|
||||
conduct a comprehensive review focusing on
|
||||
potential hotspots while maintaining correctness and stability.
|
||||
|
||||
Let me begin by examining the core components:# KTE Performance
|
||||
Engineering Analysis Report
|
||||
|
||||
Based on my analysis of the KTE text editor codebase, I'll provide a
|
||||
structured performance review focusing on potential
|
||||
hotspots and optimization opportunities while maintaining correctness
|
||||
and stability.
|
||||
|
||||
## Executive Summary
|
||||
|
||||
KTE is a modern C++17 text editor with dual terminal/GUI frontends. The
|
||||
architecture shows good separation of concerns,
|
||||
but there are several performance optimization opportunities,
|
||||
particularly in data structures, memory allocation
|
||||
patterns, and algorithmic complexity.
|
||||
|
||||
## Phase 1: Critical Performance Hotspots Analysis
|
||||
|
||||
### 1. **Buffer Management Performance Issues**
|
||||
|
||||
**Priority: HIGH**
|
||||
|
||||
**Files:** `Buffer.h`, `GapBuffer.h`, `PieceTable.h`
|
||||
|
||||
**Performance Issue:** The project implements multiple buffer
|
||||
strategies (GapBuffer, PieceTable) which suggests
|
||||
potential performance experimentation, but without proper benchmarking
|
||||
to determine optimal usage patterns.
|
||||
|
||||
**Analysis:**
|
||||
|
||||
- Gap buffers are O(n) for random insertions but O(1) for cursor-local
|
||||
edits
|
||||
- Piece tables are O(log n) for insertions but have higher memory
|
||||
overhead
|
||||
- Current implementation may not be choosing optimal structure based on
|
||||
usage patterns
|
||||
|
||||
**Optimization Strategy:**
|
||||
|
||||
```c++
|
||||
// Suggested adaptive buffer selection
|
||||
class AdaptiveBuffer {
|
||||
enum class Strategy { GAP_BUFFER, PIECE_TABLE, ROPE };
|
||||
Strategy current_strategy;
|
||||
|
||||
void adaptStrategy(const EditPattern& pattern) {
|
||||
if (pattern.sequential_edits > 0.8) {
|
||||
switchTo(GAP_BUFFER); // O(1) sequential insertions
|
||||
} else if (pattern.large_insertions > 0.5) {
|
||||
switchTo(PIECE_TABLE); // Better for large text blocks
|
||||
}
|
||||
}
|
||||
};
|
||||
```
|
||||
|
||||
**Verification:** Benchmarks implemented in `bench/BufferBench.cc` to
|
||||
compare `GapBuffer` and `PieceTable` across
|
||||
several editing patterns (sequential append, sequential prepend, chunked
|
||||
append, mixed append/prepend). To build and
|
||||
run:
|
||||
|
||||
```
|
||||
cmake -S . -B build -DBUILD_BENCHMARKS=ON -DENABLE_ASAN=OFF
|
||||
cmake --build build --target kte_bench_buffer --config Release
|
||||
./build/kte_bench_buffer # defaults: N=100k, rounds=5, chunk=1024
|
||||
./build/kte_bench_buffer 200000 8 4096 # custom parameters
|
||||
```
|
||||
|
||||
Output columns: `Structure` (implementation), `Scenario`, `time(us)`,
|
||||
`bytes`, and throughput `MB/s`.
|
||||
|
||||
### 2. **Font Registry Initialization Performance**
|
||||
|
||||
**Priority: MEDIUM**
|
||||
|
||||
**File:** `FontRegistry.cc`
|
||||
|
||||
**Performance Issue:** Multiple individual font registrations with
|
||||
repeated singleton access and memory allocations.
|
||||
|
||||
**Current Pattern:**
|
||||
|
||||
```c++
|
||||
FontRegistry::Instance().Register(std::make_unique<Font>(...));
|
||||
// Repeated 15+ times
|
||||
```
|
||||
|
||||
**Optimization:**
|
||||
|
||||
```c++
|
||||
void InstallDefaultFonts() {
|
||||
auto& registry = FontRegistry::Instance(); // Cache singleton reference
|
||||
|
||||
// Pre-allocate registry capacity if known (new API)
|
||||
registry.Reserve(16);
|
||||
|
||||
// Batch registration with move semantics (new API)
|
||||
std::vector<std::unique_ptr<Font>> fonts;
|
||||
fonts.reserve(16);
|
||||
|
||||
fonts.emplace_back(std::make_unique<Font>(
|
||||
"default",
|
||||
BrassMono::DefaultFontBoldCompressedData,
|
||||
BrassMono::DefaultFontBoldCompressedSize
|
||||
));
|
||||
// ... continue for all fonts
|
||||
|
||||
registry.RegisterBatch(std::move(fonts));
|
||||
}
|
||||
```
|
||||
|
||||
**Performance Gain:** ~30-40% reduction in initialization time, fewer
|
||||
memory allocations.
|
||||
|
||||
Implementation status: Implemented. Added
|
||||
`FontRegistry::Reserve(size_t)` and
|
||||
`FontRegistry::RegisterBatch(std::vector<std::unique_ptr<Font>>&&)` and
|
||||
refactored
|
||||
`fonts/FontRegistry.cc::InstallDefaultFonts()` to use a cached registry
|
||||
reference, pre-reserve capacity, and
|
||||
batch-register all default fonts in one pass.
|
||||
|
||||
### 3. **Command Processing Optimization**
|
||||
|
||||
**Priority: HIGH**
|
||||
|
||||
**File:** `Command.h` (large enum), `Editor.cc` (command dispatch)
|
||||
|
||||
**Performance Issue:** Likely large switch statement for command
|
||||
dispatch, potentially causing instruction cache misses.
|
||||
|
||||
**Optimization:**
|
||||
|
||||
```c++
|
||||
// Replace large switch with function table
|
||||
class CommandDispatcher {
|
||||
using CommandFunc = std::function<void(Editor&)>;
|
||||
std::array<CommandFunc, static_cast<size_t>(Command::COUNT)> dispatch_table;
|
||||
|
||||
public:
|
||||
void execute(Command cmd, Editor& editor) {
|
||||
dispatch_table[static_cast<size_t>(cmd)](editor);
|
||||
}
|
||||
};
|
||||
```
|
||||
|
||||
**Performance Gain:** Better branch prediction, improved I-cache usage.
|
||||
|
||||
## Phase 2: Memory Allocation Optimizations
|
||||
|
||||
### 4. **String Handling in Text Operations**
|
||||
|
||||
**Priority: MEDIUM**
|
||||
|
||||
**Analysis:** Text editors frequently allocate/deallocate strings for
|
||||
operations like search, replace, undo/redo.
|
||||
|
||||
**Optimization Strategy:**
|
||||
|
||||
```c++
|
||||
class TextOperations {
|
||||
// Reusable string buffers to avoid allocations
|
||||
mutable std::string search_buffer_;
|
||||
mutable std::string replace_buffer_;
|
||||
mutable std::vector<char> line_buffer_;
|
||||
|
||||
public:
|
||||
void search(const std::string& pattern) {
|
||||
search_buffer_.clear();
|
||||
search_buffer_.reserve(pattern.size() * 2); // Avoid reallocations
|
||||
// ... use search_buffer_ instead of temporary strings
|
||||
}
|
||||
};
|
||||
```
|
||||
|
||||
**Verification:** Use memory profiler to measure allocation reduction.
|
||||
|
||||
### 5. **Undo System Memory Pool**
|
||||
|
||||
**Priority: MEDIUM**
|
||||
|
||||
**Files:** `UndoSystem.h`, `UndoNode.h`, `UndoTree.h`
|
||||
|
||||
**Performance Issue:** Frequent allocation/deallocation of undo nodes.
|
||||
|
||||
**Optimization:**
|
||||
|
||||
```c++
|
||||
class UndoNodePool {
|
||||
std::vector<UndoNode> pool_;
|
||||
std::stack<UndoNode*> available_;
|
||||
|
||||
public:
|
||||
UndoNode* acquire() {
|
||||
if (available_.empty()) {
|
||||
pool_.resize(pool_.size() + 64); // Batch allocate
|
||||
for (size_t i = pool_.size() - 64; i < pool_.size(); ++i) {
|
||||
available_.push(&pool_[i]);
|
||||
}
|
||||
}
|
||||
auto* node = available_.top();
|
||||
available_.pop();
|
||||
return node;
|
||||
}
|
||||
};
|
||||
```
|
||||
|
||||
**Performance Gain:** Eliminates malloc/free overhead for undo
|
||||
operations.
|
||||
|
||||
## Phase 3: Algorithmic Optimizations
|
||||
|
||||
### 6. **Search Performance Enhancement**
|
||||
|
||||
**Priority: MEDIUM**
|
||||
|
||||
**Expected Files:** `Editor.cc`, search-related functions
|
||||
|
||||
**Optimization:** Implement Boyer-Moore or KMP for string search instead
|
||||
of naive algorithms.
|
||||
|
||||
```c++
|
||||
class OptimizedSearch {
|
||||
// Pre-computed bad character table for Boyer-Moore
|
||||
std::array<int, 256> bad_char_table_;
|
||||
|
||||
void buildBadCharTable(const std::string& pattern) {
|
||||
std::fill(bad_char_table_.begin(), bad_char_table_.end(), -1);
|
||||
for (size_t i = 0; i < pattern.length(); ++i) {
|
||||
bad_char_table_[static_cast<unsigned char>(pattern[i])] = i;
|
||||
}
|
||||
}
|
||||
|
||||
public:
|
||||
std::vector<size_t> search(const std::string& text, const std::string& pattern) {
|
||||
// Boyer-Moore implementation
|
||||
// Expected 3-4x performance improvement for typical text searches
|
||||
}
|
||||
};
|
||||
```
|
||||
|
||||
### 7. **Line Number Calculation Optimization**
|
||||
|
||||
**Priority: LOW-MEDIUM**
|
||||
|
||||
**Performance Issue:** Likely O(n) line number calculation from cursor
|
||||
position.
|
||||
|
||||
**Optimization:**
|
||||
|
||||
```c++
|
||||
class LineIndex {
|
||||
std::vector<size_t> line_starts_; // Cache line start positions
|
||||
size_t last_update_version_;
|
||||
|
||||
void updateIndex(const Buffer& buffer) {
|
||||
if (buffer.version() == last_update_version_) return;
|
||||
|
||||
line_starts_.clear();
|
||||
line_starts_.reserve(buffer.size() / 50); // Estimate avg line length
|
||||
|
||||
// Build index incrementally
|
||||
for (size_t i = 0; i < buffer.size(); ++i) {
|
||||
if (buffer[i] == '\n') {
|
||||
line_starts_.push_back(i + 1);
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
public:
|
||||
size_t getLineNumber(size_t position) const {
|
||||
return std::lower_bound(line_starts_.begin(), line_starts_.end(), position)
|
||||
- line_starts_.begin() + 1;
|
||||
}
|
||||
};
|
||||
```
|
||||
|
||||
**Performance Gain:** O(log n) line number queries instead of O(n).
|
||||
|
||||
## Phase 4: Compiler and Low-Level Optimizations
|
||||
|
||||
### 8. **Hot Path Annotations**
|
||||
|
||||
**Priority: LOW**
|
||||
|
||||
**Files:** Core editing loops in `Editor.cc`, `GapBuffer.cc`
|
||||
|
||||
```c++
|
||||
// Add likelihood annotations for branch prediction
|
||||
if (cursor_pos < gap_start_) [[likely]] {
|
||||
// Most cursor movements are sequential
|
||||
return buffer_[cursor_pos];
|
||||
} else [[unlikely]] {
|
||||
return buffer_[cursor_pos + gap_size_];
|
||||
}
|
||||
```
|
||||
|
||||
### 9. **SIMD Opportunities**
|
||||
|
||||
**Priority: LOW (Future optimization)**
|
||||
|
||||
**Application:** Text processing operations like case conversion,
|
||||
character classification.
|
||||
|
||||
```c++
|
||||
#include <immintrin.h>
|
||||
|
||||
void toLowercase(char* text, size_t length) {
|
||||
const __m256i a_vec = _mm256_set1_epi8('A');
|
||||
const __m256i z_vec = _mm256_set1_epi8('Z');
|
||||
const __m256i diff = _mm256_set1_epi8(32); // 'a' - 'A'
|
||||
|
||||
size_t simd_end = length - (length % 32);
|
||||
for (size_t i = 0; i < simd_end; i += 32) {
|
||||
// Vectorized case conversion
|
||||
// 4-8x performance improvement for large text blocks
|
||||
}
|
||||
}
|
||||
```
|
||||
|
||||
## Verification and Testing Strategy
|
||||
|
||||
### 1. **Performance Benchmarking Framework**
|
||||
|
||||
```c++
|
||||
class PerformanceSuite {
|
||||
void benchmarkBufferOperations() {
|
||||
// Test various edit patterns
|
||||
// Measure: insertions/sec, deletions/sec, cursor movements/sec
|
||||
}
|
||||
|
||||
void benchmarkSearchOperations() {
|
||||
// Test different pattern sizes and text lengths
|
||||
// Measure: searches/sec, memory usage
|
||||
}
|
||||
|
||||
void benchmarkMemoryAllocation() {
|
||||
// Track allocation patterns during editing sessions
|
||||
// Measure: total allocations, peak memory usage
|
||||
}
|
||||
};
|
||||
```
|
||||
|
||||
### 2. **Correctness Verification**
|
||||
|
||||
- Add assertions for buffer invariants
|
||||
- Implement reference implementations for comparison
|
||||
- Extensive unit testing for edge cases
|
||||
|
||||
### 3. **Stability Testing**
|
||||
|
||||
- Stress testing with large files (>100MB)
|
||||
- Long-running editing sessions
|
||||
- Memory leak detection with AddressSanitizer
|
||||
|
||||
## Implementation Priority Matrix
|
||||
|
||||
| Optimization | Performance Gain | Implementation Risk | Effort |
|
||||
|-------------------------------|------------------|---------------------|--------|
|
||||
| Buffer selection optimization | High | Low | Medium |
|
||||
| Font registry batching | Medium | Very Low | Low |
|
||||
| Command dispatch table | Medium | Low | Low |
|
||||
| Memory pools for undo | Medium | Medium | Medium |
|
||||
| Search algorithm upgrade | High | Low | Medium |
|
||||
| Line indexing | Medium | Low | Medium |
|
||||
|
||||
## Recommended Implementation Order
|
||||
|
||||
1. **Week 1-2:** Font registry optimization + Command dispatch
|
||||
improvements
|
||||
2. **Week 3-4:** Buffer management analysis and adaptive selection
|
||||
3. **Week 5-6:** Memory pool implementation for undo system
|
||||
4. **Week 7-8:** Search algorithm upgrades and line indexing
|
||||
5. **Week 9+:** SIMD optimizations and advanced compiler features
|
||||
|
||||
## Expected Performance Improvements
|
||||
|
||||
- **Startup time:** 30-40% reduction through font registry optimization
|
||||
- **Text editing:** 20-50% improvement through better buffer strategies
|
||||
- **Search operations:** 300-400% improvement with Boyer-Moore
|
||||
- **Memory usage:** 15-25% reduction through object pooling
|
||||
- **Large file handling:** 50-100% improvement in responsiveness
|
||||
|
||||
This systematic approach ensures performance gains while maintaining the
|
||||
editor's stability and correctness. Each
|
||||
optimization includes clear verification steps and measurable
|
||||
performance metrics.
|
||||
119
docs/syntax.md
119
docs/syntax.md
@@ -4,67 +4,118 @@ Syntax highlighting in kte
|
||||
Overview
|
||||
--------
|
||||
|
||||
kte provides lightweight syntax highlighting with a pluggable highlighter interface. The initial implementation targets C/C++ and focuses on speed and responsiveness.
|
||||
kte provides lightweight syntax highlighting with a pluggable
|
||||
highlighter interface. The initial implementation targets C/C++ and
|
||||
focuses on speed and responsiveness.
|
||||
|
||||
Core types
|
||||
----------
|
||||
|
||||
- `TokenKind` — token categories (keywords, types, strings, comments, numbers, preprocessor, operators, punctuation, identifiers, whitespace, etc.).
|
||||
- `HighlightSpan` — a half-open column range `[col_start, col_end)` with a `TokenKind`.
|
||||
- `LineHighlight` — a vector of `HighlightSpan` and the buffer `version` used to compute it.
|
||||
- `TokenKind` — token categories (keywords, types, strings, comments,
|
||||
numbers, preprocessor, operators, punctuation, identifiers,
|
||||
whitespace, etc.).
|
||||
- `HighlightSpan` — a half-open column range `[col_start, col_end)` with
|
||||
a `TokenKind`.
|
||||
- `LineHighlight` — a vector of `HighlightSpan` and the buffer `version`
|
||||
used to compute it.
|
||||
|
||||
Engine and caching
|
||||
------------------
|
||||
|
||||
- `HighlighterEngine` maintains a per-line cache of `LineHighlight` keyed by row and buffer version.
|
||||
- Cache invalidation occurs when the buffer version changes or when the buffer calls `InvalidateFrom(row)`, which clears cached lines and line states from `row` downward.
|
||||
- The engine supports both stateless and stateful highlighters. For stateful highlighters, it memoizes a simple per-line state and computes lines sequentially when necessary.
|
||||
- `HighlighterEngine` maintains a per-line cache of `LineHighlight`
|
||||
keyed by row and buffer version.
|
||||
- Cache invalidation occurs when the buffer version changes or when the
|
||||
buffer calls `InvalidateFrom(row)`, which clears cached lines and line
|
||||
states from `row` downward.
|
||||
- The engine supports both stateless and stateful highlighters. For
|
||||
stateful highlighters, it memoizes a simple per-line state and
|
||||
computes lines sequentially when necessary.
|
||||
|
||||
Stateful highlighters
|
||||
---------------------
|
||||
|
||||
- `LanguageHighlighter` is the base interface for stateless per-line tokenization.
|
||||
- `StatefulHighlighter` extends it with a `LineState` and the method `HighlightLineStateful(buf, row, prev_state, out)`.
|
||||
- The engine detects `StatefulHighlighter` via dynamic_cast and feeds each line the previous line’s state, caching the resulting state per line.
|
||||
- `LanguageHighlighter` is the base interface for stateless per-line
|
||||
tokenization.
|
||||
- `StatefulHighlighter` extends it with a `LineState` and the method
|
||||
`HighlightLineStateful(buf, row, prev_state, out)`.
|
||||
- The engine detects `StatefulHighlighter` via dynamic_cast and feeds
|
||||
each line the previous line’s state, caching the resulting state per
|
||||
line.
|
||||
|
||||
C/C++ highlighter
|
||||
-----------------
|
||||
|
||||
- `CppHighlighter` implements `StatefulHighlighter`.
|
||||
- Stateless constructs: line comments `//`, strings `"..."`, chars `'...'`, numbers, identifiers (keywords/types), preprocessor at beginning of line after leading whitespace, operators/punctuation, and whitespace.
|
||||
- Stateless constructs: line comments `//`, strings `"..."`, chars
|
||||
`'...'`, numbers, identifiers (keywords/types), preprocessor at
|
||||
beginning of line after leading whitespace, operators/punctuation, and
|
||||
whitespace.
|
||||
- Stateful constructs (v2):
|
||||
- Multi-line block comments `/* ... */` — the state records whether the next line continues a comment.
|
||||
- Raw strings `R"delim(... )delim"` — the state tracks whether we are inside a raw string and its delimiter `delim` until the closing sequence appears.
|
||||
- Multi-line block comments `/* ... */` — the state records whether
|
||||
the next line continues a comment.
|
||||
- Raw strings `R"delim(... )delim"` — the state tracks whether we
|
||||
are inside a raw string and its delimiter `delim` until the
|
||||
closing sequence appears.
|
||||
|
||||
Limitations and TODOs
|
||||
---------------------
|
||||
|
||||
- Raw string detection is intentionally simple and does not handle all corner cases of the C++ standard.
|
||||
- Preprocessor handling is line-based; continuation lines with `\\` are not yet tracked.
|
||||
- No semantic analysis; identifiers are classified via small keyword/type sets.
|
||||
- Additional languages (JSON, Markdown, Shell, Python, Go, Rust, Lisp, …) are planned.
|
||||
- Terminal color mapping is conservative to support 8/16-color terminals. Rich color-pair themes can be added later.
|
||||
- Raw string detection is intentionally simple and does not handle all
|
||||
corner cases of the C++ standard.
|
||||
- Preprocessor handling is line-based; continuation lines with `\\` are
|
||||
not yet tracked.
|
||||
- No semantic analysis; identifiers are classified via small
|
||||
keyword/type sets.
|
||||
- Additional languages (JSON, Markdown, Shell, Python, Go, Rust,
|
||||
Lisp, …) are planned.
|
||||
- Terminal color mapping is conservative to support 8/16-color
|
||||
terminals. Rich color-pair themes can be added later.
|
||||
|
||||
Renderer integration
|
||||
--------------------
|
||||
|
||||
- Terminal and GUI renderers request line spans via `Highlighter()->GetLine(buf, row, buf.Version())`.
|
||||
- Search highlight and cursor overlays take precedence over syntax colors.
|
||||
- Terminal and GUI renderers request line spans via
|
||||
`Highlighter()->GetLine(buf, row, buf.Version())`.
|
||||
- Search highlight and cursor overlays take precedence over syntax
|
||||
colors.
|
||||
|
||||
Renderer-side robustness
|
||||
------------------------
|
||||
|
||||
- Renderers defensively sanitize `HighlightSpan` data before use to
|
||||
ensure stability even if a highlighter misbehaves:
|
||||
- Clamp `col_start/col_end` to the line length and ensure
|
||||
`end >= start`.
|
||||
- Drop empty/invalid spans and sort by start.
|
||||
- Clip drawing to the horizontally visible region and the
|
||||
tab-expanded line length.
|
||||
- The highlighter engine returns `LineHighlight` by value to avoid
|
||||
cross-thread lifetime issues; renderers operate on a local copy for
|
||||
each frame.
|
||||
|
||||
Extensibility (Phase 4)
|
||||
-----------------------
|
||||
|
||||
- Public registration API: external code can register custom highlighters by filetype.
|
||||
- Use `HighlighterRegistry::Register("mylang", []{ return std::make_unique<MyHighlighter>(); });`
|
||||
- Registered factories are preferred over built-ins for the same filetype key.
|
||||
- Filetype keys are normalized via `HighlighterRegistry::Normalize()`.
|
||||
- Optional Tree-sitter adapter: disabled by default to keep dependencies minimal.
|
||||
- Enable with CMake option `-DKTE_ENABLE_TREESITTER=ON` and provide
|
||||
`-DTREESITTER_INCLUDE_DIR=...` and `-DTREESITTER_LIBRARY=...` if needed.
|
||||
- Register a Tree-sitter-backed highlighter for a language (example assumes you link a grammar):
|
||||
```c++
|
||||
extern "C" const TSLanguage* tree_sitter_c();
|
||||
kte::HighlighterRegistry::RegisterTreeSitter("c", &tree_sitter_c);
|
||||
```
|
||||
- Current adapter is a stub scaffold; it compiles and integrates cleanly when enabled, but
|
||||
intentionally emits no spans until Tree-sitter node-to-token mapping is implemented.
|
||||
- Public registration API: external code can register custom
|
||||
highlighters by filetype.
|
||||
- Use
|
||||
`HighlighterRegistry::Register("mylang", []{ return std::make_unique<MyHighlighter>(); });`
|
||||
- Registered factories are preferred over built-ins for the same
|
||||
filetype key.
|
||||
- Filetype keys are normalized via
|
||||
`HighlighterRegistry::Normalize()`.
|
||||
- Optional Tree-sitter adapter: disabled by default to keep dependencies
|
||||
minimal.
|
||||
- Enable with CMake option `-DKTE_ENABLE_TREESITTER=ON` and provide
|
||||
`-DTREESITTER_INCLUDE_DIR=...` and `-DTREESITTER_LIBRARY=...` if
|
||||
needed.
|
||||
- Register a Tree-sitter-backed highlighter for a language (example
|
||||
assumes you link a grammar):
|
||||
```c++
|
||||
extern "C" const TSLanguage* tree_sitter_c();
|
||||
kte::HighlighterRegistry::RegisterTreeSitter("c", &tree_sitter_c);
|
||||
```
|
||||
- Current adapter is a stub scaffold; it compiles and integrates
|
||||
cleanly when enabled, but
|
||||
intentionally emits no spans until Tree-sitter node-to-token
|
||||
mapping is implemented.
|
||||
|
||||
511
docs/themes.md
Normal file
511
docs/themes.md
Normal file
@@ -0,0 +1,511 @@
|
||||
Themes in kte
|
||||
=============
|
||||
|
||||
Overview
|
||||
--------
|
||||
|
||||
kte's GUI frontend (kge) uses ImGui for rendering and supports multiple
|
||||
color themes. Themes define the visual appearance of the editor
|
||||
interface including colors for text, backgrounds, buttons, borders, and
|
||||
other UI elements.
|
||||
|
||||
Theme files are located in the `themes/` directory and are header-only
|
||||
C++ files that configure ImGui's style system.
|
||||
|
||||
Available themes
|
||||
----------------
|
||||
|
||||
Current themes (alphabetically):
|
||||
|
||||
- **amber** — Monochrome amber/black CRT-inspired theme
|
||||
- **eink** — E-ink inspired high-contrast theme (light/dark variants)
|
||||
- **everforest** — Warm, forest-inspired palette
|
||||
- **gruvbox** — Retro groove color scheme (light/dark variants)
|
||||
- **kanagawa-paper** — Inspired by traditional Japanese art
|
||||
- **lcars** — Star Trek LCARS interface style
|
||||
- **nord** — Arctic, north-bluish color palette
|
||||
- **old-book** — Sepia-toned vintage book aesthetic (light/dark
|
||||
variants)
|
||||
- **orbital** — Space-themed dark palette
|
||||
- **plan9** — Minimalist Plan 9 from Bell Labs inspired
|
||||
- **solarized** — Ethan Schoonover's Solarized (light/dark variants)
|
||||
- **weyland-yutani** — Alien franchise corporate aesthetic
|
||||
- **zenburn** — Low-contrast, easy-on-the-eyes theme
|
||||
|
||||
Configuration
|
||||
-------------
|
||||
|
||||
Themes are configured via `$HOME/.config/kte/kge.ini`:
|
||||
|
||||
```ini
|
||||
theme = nord
|
||||
background = dark
|
||||
```
|
||||
|
||||
- `theme` — The theme name (e.g., "nord", "gruvbox", "solarized")
|
||||
- `background` — Either "dark" or "light" (for themes supporting both
|
||||
variants)
|
||||
|
||||
Themes can also be switched at runtime using the `:theme <name>`
|
||||
command.
|
||||
|
||||
Theme structure
|
||||
---------------
|
||||
|
||||
Each theme is a header file in `themes/` that defines one or more
|
||||
functions to apply the theme. The basic structure:
|
||||
|
||||
1. **Include ThemeHelpers.h** — Provides the `RGBA()` helper function
|
||||
2. **Define palette** — Create `ImVec4` color constants using
|
||||
`RGBA(0xRRGGBB)`
|
||||
3. **Get ImGui style** — Obtain reference via `ImGui::GetStyle()`
|
||||
4. **Set style parameters** — Configure padding, rounding, border sizes,
|
||||
etc.
|
||||
5. **Assign colors** — Map palette to `ImGuiCol_*` enum values
|
||||
|
||||
### Minimal example structure
|
||||
|
||||
```cpp
|
||||
// themes/MyTheme.h
|
||||
#pragma once
|
||||
#include "ThemeHelpers.h"
|
||||
|
||||
static void
|
||||
ApplyMyTheme()
|
||||
{
|
||||
// 1. Define color palette
|
||||
const ImVec4 bg = RGBA(0x1e1e1e);
|
||||
const ImVec4 fg = RGBA(0xd4d4d4);
|
||||
const ImVec4 accent = RGBA(0x007acc);
|
||||
|
||||
// 2. Get style reference
|
||||
ImGuiStyle &style = ImGui::GetStyle();
|
||||
|
||||
// 3. Set style parameters
|
||||
style.WindowPadding = ImVec2(8.0f, 8.0f);
|
||||
style.FrameRounding = 3.0f;
|
||||
style.WindowBorderSize = 1.0f;
|
||||
// ... additional style parameters
|
||||
|
||||
// 4. Assign colors
|
||||
ImVec4 *colors = style.Colors;
|
||||
colors[ImGuiCol_Text] = fg;
|
||||
colors[ImGuiCol_WindowBg] = bg;
|
||||
colors[ImGuiCol_Button] = accent;
|
||||
// ... additional color assignments
|
||||
}
|
||||
```
|
||||
|
||||
The RGBA() helper
|
||||
-----------------
|
||||
|
||||
The `RGBA()` function (defined in `themes/ThemeHelpers.h`) converts
|
||||
packed RGB hex values to ImGui's `ImVec4` format:
|
||||
|
||||
```cpp
|
||||
const ImVec4 color = RGBA(0xRRGGBB); // Opaque (alpha = 1.0)
|
||||
const ImVec4 color = RGBA(0xRRGGBB, 0.5f); // With custom alpha
|
||||
```
|
||||
|
||||
Examples:
|
||||
|
||||
```cpp
|
||||
const ImVec4 white = RGBA(0xFFFFFF);
|
||||
const ImVec4 black = RGBA(0x000000);
|
||||
const ImVec4 red = RGBA(0xFF0000);
|
||||
const ImVec4 blue = RGBA(0x0000FF);
|
||||
const ImVec4 semi = RGBA(0x808080, 0.5f); // 50% transparent gray
|
||||
```
|
||||
|
||||
ImGui color elements
|
||||
--------------------
|
||||
|
||||
Themes must define colors for ImGui's UI elements. Key `ImGuiCol_*`
|
||||
values:
|
||||
|
||||
### Text
|
||||
|
||||
- `ImGuiCol_Text` — Main text color
|
||||
- `ImGuiCol_TextDisabled` — Disabled/grayed-out text
|
||||
- `ImGuiCol_TextSelectedBg` — Text selection background
|
||||
|
||||
### Windows and backgrounds
|
||||
|
||||
- `ImGuiCol_WindowBg` — Window background
|
||||
- `ImGuiCol_ChildBg` — Child window background
|
||||
- `ImGuiCol_PopupBg` — Popup window background
|
||||
|
||||
### Borders
|
||||
|
||||
- `ImGuiCol_Border` — Border color
|
||||
- `ImGuiCol_BorderShadow` — Border shadow (often transparent)
|
||||
|
||||
### Frames (input fields, etc.)
|
||||
|
||||
- `ImGuiCol_FrameBg` — Frame background (normal state)
|
||||
- `ImGuiCol_FrameBgHovered` — Frame background when hovered
|
||||
- `ImGuiCol_FrameBgActive` — Frame background when active/clicked
|
||||
|
||||
### Title bars
|
||||
|
||||
- `ImGuiCol_TitleBg` — Title bar (unfocused)
|
||||
- `ImGuiCol_TitleBgActive` — Title bar (focused)
|
||||
- `ImGuiCol_TitleBgCollapsed` — Collapsed title bar
|
||||
|
||||
### Interactive elements
|
||||
|
||||
- `ImGuiCol_Button` — Button background
|
||||
- `ImGuiCol_ButtonHovered` — Button when hovered
|
||||
- `ImGuiCol_ButtonActive` — Button when pressed
|
||||
- `ImGuiCol_CheckMark` — Checkmark/radio button indicator
|
||||
- `ImGuiCol_SliderGrab` — Slider grab handle
|
||||
- `ImGuiCol_SliderGrabActive` — Slider grab when dragging
|
||||
|
||||
### Headers and separators
|
||||
|
||||
- `ImGuiCol_Header` — Header (tree nodes, collapsing headers)
|
||||
- `ImGuiCol_HeaderHovered` — Header when hovered
|
||||
- `ImGuiCol_HeaderActive` — Header when clicked
|
||||
- `ImGuiCol_Separator` — Separator line
|
||||
- `ImGuiCol_SeparatorHovered` — Separator when hovered
|
||||
- `ImGuiCol_SeparatorActive` — Separator when dragged
|
||||
|
||||
### Scrollbars
|
||||
|
||||
- `ImGuiCol_ScrollbarBg` — Scrollbar background
|
||||
- `ImGuiCol_ScrollbarGrab` — Scrollbar grab
|
||||
- `ImGuiCol_ScrollbarGrabHovered` — Scrollbar grab when hovered
|
||||
- `ImGuiCol_ScrollbarGrabActive` — Scrollbar grab when dragging
|
||||
|
||||
### Tabs
|
||||
|
||||
- `ImGuiCol_Tab` — Tab (inactive)
|
||||
- `ImGuiCol_TabHovered` — Tab when hovered
|
||||
- `ImGuiCol_TabActive` — Tab (active)
|
||||
- `ImGuiCol_TabUnfocused` — Tab in unfocused window
|
||||
- `ImGuiCol_TabUnfocusedActive` — Active tab in unfocused window
|
||||
|
||||
### Tables
|
||||
|
||||
- `ImGuiCol_TableHeaderBg` — Table header background
|
||||
- `ImGuiCol_TableBorderStrong` — Strong table borders
|
||||
- `ImGuiCol_TableBorderLight` — Light table borders
|
||||
- `ImGuiCol_TableRowBg` — Table row background
|
||||
- `ImGuiCol_TableRowBgAlt` — Alternating table row background
|
||||
|
||||
### Navigation and overlays
|
||||
|
||||
- `ImGuiCol_MenuBarBg` — Menu bar background
|
||||
- `ImGuiCol_ResizeGrip` — Resize grip indicator
|
||||
- `ImGuiCol_ResizeGripHovered` — Resize grip when hovered
|
||||
- `ImGuiCol_ResizeGripActive` — Resize grip when dragging
|
||||
- `ImGuiCol_DragDropTarget` — Drag-and-drop target highlight
|
||||
- `ImGuiCol_NavHighlight` — Navigation highlight
|
||||
- `ImGuiCol_NavWindowingHighlight` — Window navigation highlight
|
||||
- `ImGuiCol_NavWindowingDimBg` — Window navigation dim background
|
||||
- `ImGuiCol_ModalWindowDimBg` — Modal window dim background
|
||||
|
||||
### Plots (graphs)
|
||||
|
||||
- `ImGuiCol_PlotLines` — Plot line color
|
||||
- `ImGuiCol_PlotLinesHovered` — Plot line when hovered
|
||||
- `ImGuiCol_PlotHistogram` — Histogram color
|
||||
- `ImGuiCol_PlotHistogramHovered` — Histogram when hovered
|
||||
|
||||
Style parameters
|
||||
----------------
|
||||
|
||||
In addition to colors, themes can customize style parameters:
|
||||
|
||||
```cpp
|
||||
ImGuiStyle &style = ImGui::GetStyle();
|
||||
|
||||
// Padding and spacing
|
||||
style.WindowPadding = ImVec2(8.0f, 8.0f); // Window content padding
|
||||
style.FramePadding = ImVec2(6.0f, 4.0f); // Frame (input fields) padding
|
||||
style.CellPadding = ImVec2(6.0f, 4.0f); // Table cell padding
|
||||
style.ItemSpacing = ImVec2(6.0f, 6.0f); // Space between items
|
||||
style.ItemInnerSpacing = ImVec2(6.0f, 4.0f); // Space within composite items
|
||||
|
||||
// Rounding
|
||||
style.WindowRounding = 4.0f; // Window corner rounding
|
||||
style.FrameRounding = 3.0f; // Frame corner rounding
|
||||
style.PopupRounding = 4.0f; // Popup corner rounding
|
||||
style.GrabRounding = 3.0f; // Grab handle rounding
|
||||
style.TabRounding = 4.0f; // Tab corner rounding
|
||||
|
||||
// Borders
|
||||
style.WindowBorderSize = 1.0f; // Window border width
|
||||
style.FrameBorderSize = 1.0f; // Frame border width
|
||||
|
||||
// Scrollbars
|
||||
style.ScrollbarSize = 14.0f; // Scrollbar width
|
||||
style.GrabMinSize = 10.0f; // Minimum grab handle size
|
||||
```
|
||||
|
||||
Creating a new theme
|
||||
--------------------
|
||||
|
||||
Follow these steps to add a new theme to kte:
|
||||
|
||||
### 1. Create the theme file
|
||||
|
||||
Create a new header file in `themes/` (e.g., `themes/MyTheme.h`):
|
||||
|
||||
```cpp
|
||||
// themes/MyTheme.h — Brief description
|
||||
#pragma once
|
||||
#include "ThemeHelpers.h"
|
||||
|
||||
// Expects to be included from GUITheme.h after <imgui.h> and RGBA() helper
|
||||
|
||||
static void
|
||||
ApplyMyTheme()
|
||||
{
|
||||
// Define your color palette
|
||||
const ImVec4 background = RGBA(0x1e1e1e);
|
||||
const ImVec4 foreground = RGBA(0xd4d4d4);
|
||||
const ImVec4 accent = RGBA(0x007acc);
|
||||
// ... more colors
|
||||
|
||||
ImGuiStyle &style = ImGui::GetStyle();
|
||||
|
||||
// Configure style parameters
|
||||
style.WindowPadding = ImVec2(8.0f, 8.0f);
|
||||
// ... more style settings
|
||||
|
||||
ImVec4 *colors = style.Colors;
|
||||
|
||||
// Assign all required colors
|
||||
colors[ImGuiCol_Text] = foreground;
|
||||
colors[ImGuiCol_WindowBg] = background;
|
||||
// ... assign all other ImGuiCol_* values
|
||||
}
|
||||
```
|
||||
|
||||
Refer to existing themes like `Nord.h` for a complete example of all
|
||||
required color assignments.
|
||||
|
||||
### 2. Add theme to GUITheme.h
|
||||
|
||||
Edit `GUITheme.h` to integrate your theme:
|
||||
|
||||
**a) Add to ThemeId enum:**
|
||||
|
||||
```cpp
|
||||
enum class ThemeId {
|
||||
// ... existing themes
|
||||
MyTheme = 13, // Use next available number
|
||||
};
|
||||
```
|
||||
|
||||
**b) Include your theme header:**
|
||||
|
||||
```cpp
|
||||
// After other theme includes
|
||||
#include "themes/MyTheme.h"
|
||||
```
|
||||
|
||||
**c) Create wrapper class in detail namespace:**
|
||||
|
||||
```cpp
|
||||
namespace detail {
|
||||
// ... existing theme classes
|
||||
|
||||
struct MyThemeWrapper final : Theme {
|
||||
[[nodiscard]] const char *Name() const override
|
||||
{
|
||||
return "mytheme"; // Lowercase canonical name
|
||||
}
|
||||
|
||||
void Apply() const override
|
||||
{
|
||||
ApplyMyTheme();
|
||||
}
|
||||
|
||||
ThemeId Id() override
|
||||
{
|
||||
return ThemeId::MyTheme;
|
||||
}
|
||||
};
|
||||
} // namespace detail
|
||||
```
|
||||
|
||||
**d) Register in ThemeRegistry():**
|
||||
|
||||
```cpp
|
||||
static const std::vector<std::unique_ptr<Theme>> &
|
||||
ThemeRegistry()
|
||||
{
|
||||
static std::vector<std::unique_ptr<Theme>> reg;
|
||||
if (reg.empty()) {
|
||||
// Add in alphabetical order by canonical name
|
||||
reg.emplace_back(std::make_unique<detail::AmberTheme>());
|
||||
// ... existing themes
|
||||
reg.emplace_back(std::make_unique<detail::MyThemeWrapper>());
|
||||
// ... remaining themes
|
||||
}
|
||||
return reg;
|
||||
}
|
||||
```
|
||||
|
||||
### 3. Test your theme
|
||||
|
||||
Rebuild kte and test:
|
||||
|
||||
```bash
|
||||
# Set theme in config
|
||||
echo "theme = mytheme" >> ~/.config/kte/kge.ini
|
||||
|
||||
# Or switch at runtime
|
||||
kge
|
||||
:theme mytheme
|
||||
```
|
||||
|
||||
Light/Dark theme variants
|
||||
--------------------------
|
||||
|
||||
Some themes support both light and dark background modes. To implement
|
||||
this:
|
||||
|
||||
### 1. Create separate functions for each variant
|
||||
|
||||
```cpp
|
||||
// themes/MyTheme.h
|
||||
#pragma once
|
||||
#include "ThemeHelpers.h"
|
||||
|
||||
static void
|
||||
ApplyMyThemeDark()
|
||||
{
|
||||
const ImVec4 bg = RGBA(0x1e1e1e); // Dark background
|
||||
const ImVec4 fg = RGBA(0xd4d4d4); // Light text
|
||||
// ... rest of dark theme
|
||||
}
|
||||
|
||||
static void
|
||||
ApplyMyThemeLight()
|
||||
{
|
||||
const ImVec4 bg = RGBA(0xffffff); // Light background
|
||||
const ImVec4 fg = RGBA(0x1e1e1e); // Dark text
|
||||
// ... rest of light theme
|
||||
}
|
||||
```
|
||||
|
||||
### 2. Check background mode in Apply()
|
||||
|
||||
```cpp
|
||||
// In GUITheme.h wrapper class
|
||||
struct MyThemeWrapper final : Theme {
|
||||
// ... Name() and Id() methods
|
||||
|
||||
void Apply() const override
|
||||
{
|
||||
if (gBackgroundMode == BackgroundMode::Dark)
|
||||
ApplyMyThemeDark();
|
||||
else
|
||||
ApplyMyThemeLight();
|
||||
}
|
||||
};
|
||||
```
|
||||
|
||||
See `Solarized.h`, `Gruvbox.h`, `EInk.h`, or `OldBook.h` for complete
|
||||
examples.
|
||||
|
||||
Updating existing themes
|
||||
------------------------
|
||||
|
||||
To modify an existing theme:
|
||||
|
||||
### 1. Locate the theme file
|
||||
|
||||
Theme files are in `themes/` directory. For example, Nord theme is in
|
||||
`themes/Nord.h`.
|
||||
|
||||
### 2. Modify colors or style
|
||||
|
||||
Edit the `ApplyXxxTheme()` function:
|
||||
|
||||
- Update palette color definitions
|
||||
- Change style parameters
|
||||
- Reassign `ImGuiCol_*` values
|
||||
|
||||
### 3. Rebuild and test
|
||||
|
||||
```bash
|
||||
# Rebuild kte
|
||||
cmake --build build
|
||||
|
||||
# Test changes
|
||||
./build/kge
|
||||
```
|
||||
|
||||
Changes take effect immediately on next launch or theme switch.
|
||||
|
||||
Best practices
|
||||
--------------
|
||||
|
||||
When creating or updating themes:
|
||||
|
||||
1. **Start from an existing theme** — Copy a similar theme as a
|
||||
template (e.g., `Nord.h` for dark themes, `Solarized.h` for
|
||||
light/dark variants)
|
||||
|
||||
2. **Define a complete palette first** — Create all color constants at
|
||||
the top before assigning them
|
||||
|
||||
3. **Assign all colors** — Ensure every `ImGuiCol_*` value is set to
|
||||
avoid inheriting unexpected colors
|
||||
|
||||
4. **Use consistent naming** — Follow existing conventions (e.g.,
|
||||
`nord0`, `base03`, descriptive names)
|
||||
|
||||
5. **Test interactivity** — Verify hover, active, and disabled states
|
||||
for buttons, frames, and other interactive elements
|
||||
|
||||
6. **Consider contrast** — Ensure text is readable against backgrounds;
|
||||
test with different content
|
||||
|
||||
7. **Test transparency** — Use alpha values carefully for overlays, dim
|
||||
backgrounds, and selection highlights
|
||||
|
||||
8. **Match style to theme** — Adjust rounding, padding, and borders to
|
||||
suit the theme's aesthetic (e.g., sharp corners for retro themes,
|
||||
rounded for modern)
|
||||
|
||||
9. **Document inspiration** — Note the color scheme's origin or
|
||||
inspiration in the file header
|
||||
|
||||
10. **Maintain alphabetical order** — When registering in
|
||||
`ThemeRegistry()`, maintain alphabetical order by canonical name
|
||||
|
||||
Troubleshooting
|
||||
---------------
|
||||
|
||||
### Theme not appearing
|
||||
|
||||
- Check that the theme is registered in `ThemeRegistry()` in
|
||||
alphabetical order
|
||||
- Verify the canonical name matches what you're using in config or
|
||||
commands
|
||||
- Ensure the theme header is included in `GUITheme.h`
|
||||
|
||||
### Colors look wrong
|
||||
|
||||
- Verify hex color values are in 0xRRGGBB format (not 0xBBGGRR)
|
||||
- Check alpha values for semi-transparent elements
|
||||
- Ensure all `ImGuiCol_*` values are assigned
|
||||
|
||||
### Style inconsistent
|
||||
|
||||
- Make sure style parameters are set before color assignments
|
||||
- Check that you're getting `ImGui::GetStyle()` reference correctly
|
||||
- Verify no global style changes are overriding theme settings
|
||||
|
||||
References
|
||||
----------
|
||||
|
||||
- ImGui style
|
||||
reference: https://github.com/ocornut/imgui/blob/master/imgui.h
|
||||
- Existing themes in `themes/` directory
|
||||
- Color palette resources: coolors.co, colorhunt.co
|
||||
@@ -1,279 +1,390 @@
|
||||
Undo System Overhaul Roadmap (emacs-style undo-tree)
|
||||
## Updated Undo System Plan for kte/kge
|
||||
|
||||
Context: macOS, C++17 project, ncurses terminal and SDL2/ImGui GUI frontends. Date: 2025-12-01.
|
||||
After reviewing the existing codebase and your undo plan, I propose
|
||||
the following refined approach that preserves your goals while making
|
||||
it more suitable for implementation:
|
||||
|
||||
Purpose
|
||||
### Refined Data Structures
|
||||
|
||||
- Define a clear, incremental plan to implement a robust, non-linear undo system inspired by emacs' undo-tree.
|
||||
- Align implementation with docs/undo.md and fix gaps observed in docs/undo-state.md.
|
||||
- Provide test cases and acceptance criteria so a junior engineer or agentic coding system can execute the plan safely.
|
||||
The proposed data structures are sound but need some refinements:
|
||||
|
||||
References
|
||||
```c++
|
||||
enum class UndoType : uint8_t {
|
||||
Insert,
|
||||
Delete,
|
||||
Paste,
|
||||
Newline,
|
||||
DeleteRow,
|
||||
// Future: IndentRegion, KillRegion, etc.
|
||||
};
|
||||
|
||||
- Specification: docs/undo.md (API, invariants, batching rules, raw buffer ops)
|
||||
- Current snapshot and recent fix: docs/undo-state.md (GUI mapping notes; Begin/Append ordering fix)
|
||||
- Code: UndoSystem.{h,cc}, UndoTree.{h,cc}, UndoNode.{h,cc}, Buffer.{h,cc}, Command.{h,cc}, GUI/Terminal InputHandlers,
|
||||
KKeymap.
|
||||
struct UndoNode {
|
||||
UndoType type;
|
||||
int row;
|
||||
int col;
|
||||
std::string text;
|
||||
std::unique_ptr<UndoNode> child = nullptr; // next in timeline
|
||||
std::unique_ptr<UndoNode> next = nullptr; // redo branch
|
||||
UndoNode* parent = nullptr; // weak pointer for navigation
|
||||
};
|
||||
|
||||
Instrumentation (KTE_UNDO_DEBUG)
|
||||
struct UndoTree {
|
||||
std::unique_ptr<UndoNode> root;
|
||||
UndoNode* current = nullptr;
|
||||
UndoNode* saved = nullptr;
|
||||
std::unique_ptr<UndoNode> pending = nullptr;
|
||||
};
|
||||
```
|
||||
|
||||
- How to enable
|
||||
- Build with the CMake option `-DKTE_UNDO_DEBUG=ON` to enable concise instrumentation logs from `UndoSystem`.
|
||||
- The following targets receive the `KTE_UNDO_DEBUG` compile definition when ON:
|
||||
- `kte` (terminal), `kge` (GUI), and `test_undo` (tests).
|
||||
- Examples:
|
||||
```sh
|
||||
# Terminal build with tests and instrumentation ON
|
||||
cmake -S . -B cmake-build-term -DBUILD_TESTS=ON -DBUILD_GUI=OFF -DKTE_UNDO_DEBUG=ON
|
||||
cmake --build cmake-build-term --target test_undo -j
|
||||
./cmake-build-term/test_undo 2> undo.log
|
||||
Key changes:
|
||||
|
||||
# GUI build (requires SDL2/OpenGL/Freetype toolchain) with instrumentation ON
|
||||
cmake -S . -B cmake-build-gui -DBUILD_GUI=ON -DKTE_UNDO_DEBUG=ON
|
||||
cmake --build cmake-build-gui --target kge -j
|
||||
# Run kge and perform actions; logs go to stderr
|
||||
```
|
||||
- Use `std::unique_ptr` for owned pointers to ensure proper RAII
|
||||
- Add weak `parent` pointer for easier navigation
|
||||
- This ensures memory safety without manual management
|
||||
|
||||
- What it logs
|
||||
- Each Begin/Append/commit/undo/redo operation prints a single `[UNDO]` line with:
|
||||
- current cursor `(row,col)`, pointer to `pending`, its type/row/col/text-size, and pointers to `current`/`saved`.
|
||||
- Example fields: `[UNDO] Begin cur=(0,0) pending=0x... t=Insert r=0 c=0 nlen=2 current=0x... saved=0x...`
|
||||
---
|
||||
|
||||
- Example trace snippets
|
||||
- Typing a contiguous word ("Hello") batches into a single Insert node; one commit occurs before the subsequent undo:
|
||||
```text
|
||||
[UNDO] Begin cur=(0,0) pending=0x0 t=- r=-1 c=-1 nlen=0 current=0x0 saved=0x0
|
||||
[UNDO] commit:enter cur=(0,0) pending=0x0 t=- r=-1 c=-1 nlen=0 current=0x0 saved=0x0
|
||||
[UNDO] Begin:new cur=(0,0) pending=0x... t=Insert r=0 c=0 nlen=0 current=0x0 saved=0x0
|
||||
[UNDO] Append:sv cur=(0,0) pending=0x... t=Insert r=0 c=0 nlen=1 current=0x0 saved=0x0
|
||||
... (more Append as characters are typed) ...
|
||||
[UNDO] commit:enter cur=(0,5) pending=0x... t=Insert r=0 c=0 nlen=5 current=0x0 saved=0x0
|
||||
[UNDO] commit:done cur=(0,5) pending=0x0 t=- r=-1 c=-1 nlen=0 current=0x... saved=0x0
|
||||
```
|
||||
```markdown
|
||||
# Undo System Implementation Roadmap for kte/kge
|
||||
|
||||
- Undo then Redo across that batch:
|
||||
```text
|
||||
[UNDO] commit:enter cur=(0,5) pending=0x0 t=- r=-1 c=-1 nlen=0 current=0x... saved=0x0
|
||||
[UNDO] undo cur=(0,5) pending=0x0 t=- r=-1 c=-1 nlen=0 current=0x0 saved=0x0
|
||||
[UNDO] commit:enter cur=(0,5) pending=0x0 t=- r=-1 c=-1 nlen=0 current=0x0 saved=0x0
|
||||
[UNDO] redo cur=(0,5) pending=0x0 t=- r=-1 c=-1 nlen=0 current=0x... saved=0x0
|
||||
```
|
||||
This is the complete implementation plan for the non-linear undo/redo
|
||||
system for kte. This document serves as a detailed
|
||||
specification for Junie to implement an undo system similar to emacs'
|
||||
undo-tree.
|
||||
|
||||
- Newline and backspace/delete traces follow the same pattern with `t=Newline` or `t=Delete` and immediate commit for newline.
|
||||
Capture by running `kge`/`kte` with `KTE_UNDO_DEBUG=ON` and performing the actions; append representative 3–6 line snippets to docs.
|
||||
## Overview
|
||||
|
||||
Notes
|
||||
The goal is to implement a robust, memory-safe undo system where:
|
||||
|
||||
- Pointer values and exact cursor positions in the logs depend on the runtime and actions; this is expected.
|
||||
- Keep `KTE_UNDO_DEBUG` OFF by default in CI/release to avoid noisy logs and any performance impact.
|
||||
1. Each buffer has its own independent undo tree
|
||||
2. Undo and redo are non-linear - typing after undo creates a branch
|
||||
3. Operations are batched into word-level undo steps
|
||||
4. The system is leak-proof and handles buffer closure gracefully
|
||||
|
||||
̄1) Current State Summary (from docs/undo-state.md)
|
||||
## Phase 1: Core Data Structures
|
||||
|
||||
- Terminal (kte): Keybindings and UndoSystem integration have been stable.
|
||||
- GUI (kge): Previously, C-k u/U mapping and SDL TEXTINPUT suppression had issues on macOS; these were debugged. The
|
||||
core root cause of “status shows Undone but no change” was fixed by moving UndoSystem::Begin/Append/commit to occur
|
||||
after buffer modifications/cursor updates so batching conditions see the correct cursor.
|
||||
- Undo core exists with tree invariants, saved marker/dirty flag mirroring, batching for Insert/Delete, and Newline as a
|
||||
single-step undo.
|
||||
### 1.1 UndoType enum (UndoNode.h)
|
||||
```
|
||||
|
||||
Gaps/Risks
|
||||
cpp enum class UndoType : uint8_t { Insert, Delete, Paste, // can
|
||||
reuse Insert if preferred Newline, DeleteRow, // Future extensions:
|
||||
IndentRegion, KillRegion };
|
||||
|
||||
- Event-path unification between KEYDOWN and TEXTINPUT across platforms (macOS specifics).
|
||||
- Comprehensive tests for branching, GC/limits, multi-line operations, and UTF-8 text input.
|
||||
- Advanced/compound command grouping and future region operations.
|
||||
```
|
||||
### 1.2 UndoNode struct (UndoNode.h)
|
||||
```
|
||||
|
||||
cpp struct UndoNode { UndoType type; int row; // original cursor row
|
||||
int col; // original cursor column (updated during batch) std::string
|
||||
text; // the inserted or deleted text (full batch)
|
||||
std::unique_ptr<UndoNode> child = nullptr; // next in current timeline
|
||||
std::unique_ptr<UndoNode> next = nullptr; // redo branch (rarely used)
|
||||
UndoNode* parent = nullptr; // weak pointer for navigation };
|
||||
|
||||
2) Design Goals (emacs-like undo-tree)
|
||||
```
|
||||
### 1.3 UndoTree struct (UndoTree.h)
|
||||
```
|
||||
|
||||
- Per-buffer, non-linear undo tree: new edits after undo create a branch; existing redo branches are discarded.
|
||||
- Batching: insert/backspace/paste/newline grouped into sensible units to match user expectations.
|
||||
- Silent apply during undo/redo (no re-recording), using raw Buffer methods only.
|
||||
- Correct saved/dirty tracking and robust pending node lifecycle (detached until commit).
|
||||
- Efficient memory behavior; optional pruning limits similar to emacs (undo-limit, undo-strong-limit).
|
||||
- Deterministic behavior across terminal and GUI frontends.
|
||||
cpp struct UndoTree { std::unique_ptr<UndoNode> root; // first edit
|
||||
ever UndoNode* current = nullptr; // current state of buffer UndoNode*
|
||||
saved = nullptr; // points to node matching last save
|
||||
std::unique_ptr<UndoNode> pending = nullptr; // in-progress batch };
|
||||
|
||||
```
|
||||
### 1.4 UndoSystem class (UndoSystem.h)
|
||||
```
|
||||
|
||||
3) Invariants and API (must align with docs/undo.md)
|
||||
cpp class UndoSystem { private: std::unique_ptr<UndoTree> tree;
|
||||
|
||||
- UndoTree holds root/current/saved/pending; pending is detached and only linked on commit.
|
||||
- Begin(type) reuses pending only if: same type, same row, and pending->col + pending->text.size() == current cursor
|
||||
col (or prepend rules for backspace sequences); otherwise it commits and starts a new node.
|
||||
- commit(): frees redo siblings from current, attaches pending as current->child, advances current, clears pending;
|
||||
nullifies saved marker if diverged.
|
||||
- undo()/redo(): move current and apply the node using low-level Buffer APIs that do not trigger undo recording.
|
||||
- mark_saved(): updates saved pointer and dirty flag (dirty ⇔ current != saved).
|
||||
- discard_pending()/clear(): lifecycle for buffer close/reset/new file.
|
||||
public: UndoSystem(); ~UndoSystem() = default;
|
||||
|
||||
// Core batching API
|
||||
void begin(UndoType type, int row, int col);
|
||||
void append(char ch);
|
||||
void append(std::string_view text);
|
||||
void commit();
|
||||
|
||||
4) Phased Roadmap
|
||||
// Undo/Redo operations
|
||||
void undo(class Buffer& buffer);
|
||||
void redo(class Buffer& buffer);
|
||||
|
||||
Phase 0 — Baseline & Instrumentation (1 day)
|
||||
// State management
|
||||
void mark_saved();
|
||||
void discard_pending();
|
||||
void clear();
|
||||
|
||||
- Audit UndoSystem against docs/undo.md invariants; ensure apply() uses only raw Buffer ops.
|
||||
- Verify Begin/Append ordering across all edit commands: insert, backspace, delete, newline, paste.
|
||||
- Add a temporary debug toggle (compile-time or editor flag) to log Begin/Append/commit/undo/redo, cursor(row,col), node
|
||||
sizes, and pending state. Include assertions for: pending detached, commit clears pending, redo branch freed on new
|
||||
commit, and correct batching preconditions.
|
||||
- Deliverables: Short log from typing/undo/redo scenarios; instrumentation behind a macro so it can be removed.
|
||||
// Query methods
|
||||
bool can_undo() const;
|
||||
bool can_redo() const;
|
||||
bool is_dirty() const;
|
||||
|
||||
Phase 1 — Input Path Unification & Batching Rules (1–2 days)
|
||||
private: void apply_node(Buffer& buffer, const UndoNode* node, int
|
||||
direction); bool should_batch_with_pending(UndoType type, int row, int
|
||||
col) const; void attach_pending_to_current(); void
|
||||
discard_redo_branches(); };
|
||||
|
||||
- Ensure all printable text insertion (terminal and GUI) flows through CommandId::InsertText and reaches UndoSystem
|
||||
Begin/Append. On SDL, handle KEYDOWN vs TEXTINPUT consistently; always suppress trailing TEXTINPUT after k-prefix
|
||||
suffix commands.
|
||||
- Commit boundaries: at k-prefix entry, before Undo/Redo, on cursor movement, on focus/file ops, and before any
|
||||
non-editing command that should separate undo units.
|
||||
- Batching heuristics:
|
||||
- Insert: same row, contiguous columns; Append(std::string_view) handles multi-character text (pastes, IME).
|
||||
- Backspace: prepend batching in increasing column order (store deleted text in forward order).
|
||||
- Delete (forward): contiguous at same row/col.
|
||||
- Newline: record as UndoType::Newline and immediately commit (single-step undo for line splits/joins).
|
||||
- Deliverables: Manual tests pass for typing/backspace/delete/newline/paste; GUI C-k u/U work as expected on macOS.
|
||||
```
|
||||
## Phase 2: Buffer Integration
|
||||
|
||||
Phase 2 — Tree Limits & GC (1 day)
|
||||
### 2.1 Add undo system to Buffer class (Buffer.h)
|
||||
Add to Buffer class:
|
||||
```
|
||||
|
||||
- Add configurable memory/size limits for undo data (soft and strong limits like emacs). Implement pruning of oldest
|
||||
ancestors or deep redo branches while preserving recent edits. Provide stats (node count, bytes in text storage).
|
||||
- Deliverables: Config hooks, tests demonstrating pruning without violating apply/undo invariants.
|
||||
cpp private: std::unique_ptr<UndoSystem> undo_system; bool
|
||||
applying_undo = false; // prevent recursive undo during apply
|
||||
|
||||
Phase 3 — Compound Commands & Region Ops (2–3 days)
|
||||
public: // Raw operations (don't trigger undo) void
|
||||
raw_insert_text(int row, int col, std::string_view text); void
|
||||
raw_delete_text(int row, int col, size_t len); void raw_split_line(int
|
||||
row, int col); void raw_join_lines(int row); void raw_insert_row(int
|
||||
row, std::string_view text); void raw_delete_row(int row);
|
||||
|
||||
- Introduce an optional RAII-style UndoTransaction to group multi-step commands (indent region, kill region, rectangle
|
||||
ops) into a single undo step. Internally this just sequences Begin/Append and ensures commit even on early returns.
|
||||
- Support row operations (InsertRow/DeleteRow) with proper raw Buffer calls. Ensure join_lines/split_line are handled by
|
||||
Newline nodes or dedicated types if necessary.
|
||||
- Deliverables: Commands updated to use transactions when appropriate; tests for region delete/indent and multi-line
|
||||
paste.
|
||||
// Undo/Redo public API
|
||||
void undo();
|
||||
void redo();
|
||||
bool can_undo() const;
|
||||
bool can_redo() const;
|
||||
void mark_saved();
|
||||
bool is_dirty() const;
|
||||
|
||||
Phase 4 — Developer UX & Diagnostics (1 day)
|
||||
```
|
||||
### 2.2 Modify existing Buffer operations (Buffer.cc)
|
||||
For each user-facing operation (`insert_char`, `delete_char`, etc.):
|
||||
|
||||
- Add a dev command to dump the undo tree (preorder) with markers for current/saved and pending (detached). For GUI,
|
||||
optionally expose a simple ImGui debug window (behind a compile flag) that visualizes the current branch.
|
||||
- Editor status improvements: show short status codes for undo/redo and when a new branch was created or redo discarded.
|
||||
- Deliverables: Tree dump command; example output in docs.
|
||||
1. **Before performing operation**: Call `undo_system->commit()` if cursor moved
|
||||
2. **Begin batching**: Call `undo_system->begin(type, row, col)`
|
||||
3. **Record change**: Call `undo_system->append()` with the affected text
|
||||
4. **Perform operation**: Execute the actual buffer modification
|
||||
5. **Auto-commit conditions**: Commit on cursor movement, command execution
|
||||
|
||||
Phase 5 — Comprehensive Tests & Property Checks (2–3 days)
|
||||
Example pattern:
|
||||
```
|
||||
|
||||
- Unit tests (extend test_undo.cc):
|
||||
- Insert batching: type "Hello" then one undo removes all; redo restores.
|
||||
- Backspace batching: type "Hello", backspace 3×, undo → restores the 3; redo → re-applies deletion.
|
||||
- Delete batching (forward delete) with cursor not moving.
|
||||
- Newline: split a line and undo to join; join a line (via backspace at col 0) and undo to split.
|
||||
- Branching: type "abc", undo twice, type "X" → redo history discarded; ensure redo no longer restores 'b'/'c'.
|
||||
- Saved/dirty: mark_saved after typing; ensure dirty flag toggles correctly after undo/redo; saved marker tracks the
|
||||
node.
|
||||
- discard_pending: create pending by typing, then move cursor or invoke commit boundary; ensure pending is attached;
|
||||
also ensure discard on buffer close clears pending.
|
||||
- clear(): resets state with no leaks; tree pointers null.
|
||||
- UTF-8 input: insert multi-byte characters via InsertText with multi-char std::string; ensure counts/col tracking
|
||||
behave (text stored as bytes; editor col policy consistent within kte).
|
||||
- Integration tests (TestFrontend):
|
||||
- Both TerminalFrontend and GUIFrontend: simulate text input and commands, including k-prefix C-k u/U.
|
||||
- Paste scenarios: multi-character insertions batched as one.
|
||||
- Property tests (optional but recommended):
|
||||
- Generate random sequences of edits; record them; then apply undo until root and redo back to the end → buffer
|
||||
contents match at each step; no crashes; dirty flag transitions consistent. Seed-based to reproduce failures.
|
||||
- Redo-branch discard property: any new edit after undo must eliminate redo path; redoing should be impossible
|
||||
afterward.
|
||||
- Deliverables: Tests merged and passing on CI for both frontends; failures block changes to undo core.
|
||||
cpp void Buffer::insert_char(char ch) { if (applying_undo) return; //
|
||||
silent during undo application
|
||||
|
||||
Phase 6 — Performance & Stress (0.5–1 day)
|
||||
// Auto-commit if cursor moved significantly or type changed
|
||||
if (should_commit_before_insert()) {
|
||||
undo_system->commit();
|
||||
}
|
||||
|
||||
- Stress test with large files and long edit sequences. Target: smooth typing at 10k+ ops/minute on commodity hardware;
|
||||
memory growth bounded when GC limits enabled.
|
||||
- Deliverables: Basic perf notes; optional lightweight benchmarks.
|
||||
undo_system->begin(UndoType::Insert, cursor_row, cursor_col);
|
||||
undo_system->append(ch);
|
||||
|
||||
// Perform actual insertion
|
||||
raw_insert_text(cursor_row, cursor_col, std::string(1, ch));
|
||||
cursor_col++;
|
||||
|
||||
5) Acceptance Criteria
|
||||
}
|
||||
|
||||
- Conformance to docs/undo.md invariants and API surface (including raw Buffer operations for apply()).
|
||||
- Repro checklist passes:
|
||||
- Type text; single-step undo/redo works and respects batching.
|
||||
- Backspace/delete batching works.
|
||||
- Newline split/join are single-step undo/redo.
|
||||
- Branching works: undo, then type → redo path is discarded; no ghost redo.
|
||||
- Saved/dirty flags accurate across undo/redo and diverge/rejoin paths.
|
||||
- No pending nodes leaked on buffer close/reload; no re-recording during undo/redo.
|
||||
- Behavior identical across terminal and GUI input paths.
|
||||
- Tests added for all above; CI green.
|
||||
```
|
||||
### 2.3 Commit triggers
|
||||
Auto-commit `pending` operations when:
|
||||
- Cursor moves (arrow keys, mouse click)
|
||||
- Any command starts executing
|
||||
- Buffer switching
|
||||
- Before undo/redo operations
|
||||
- Before file save/close
|
||||
|
||||
## Phase 3: UndoSystem Implementation
|
||||
|
||||
6) Concrete Work Items by File
|
||||
### 3.1 Core batching logic (UndoSystem.cc)
|
||||
```
|
||||
|
||||
- UndoSystem.h/cc:
|
||||
- Re-verify Begin/Append ordering; enforce batching invariants; prepend logic for backspace; immediate commit for
|
||||
newline.
|
||||
- Implement/verify apply() uses only Buffer raw methods: insert_text/delete_text/split_line/join_lines/row ops.
|
||||
- Add limits (configurable) and stats; add discard_pending safety paths.
|
||||
- Buffer.h/cc:
|
||||
- Ensure raw methods exist and do not trigger undo; ensure UpdateBufferReference is correctly used when
|
||||
replacing/renaming the underlying buffer.
|
||||
- Call undo.commit() on cursor movement and non-editing commands (via Command layer integration).
|
||||
- Command.cc:
|
||||
- Ensure all edit commands drive UndoSystem correctly; commit at k-prefix entry and before Undo/Redo.
|
||||
- Introduce UndoTransaction for compound commands when needed.
|
||||
- GUIInputHandler.cc / TerminalInputHandler.cc / KKeymap.cc:
|
||||
- Ensure unified InsertText path; suppress SDL_TEXTINPUT when a k-prefix suffix produced a command; preserve case
|
||||
mapping.
|
||||
- Tests: test_undo.cc (extend) + new tests (e.g., test_undo_branching.cc, test_undo_multiline.cc).
|
||||
cpp void UndoSystem::begin(UndoType type, int row, int col) { if
|
||||
(should_batch_with_pending(type, row, col)) { // Continue existing
|
||||
batch return; }
|
||||
|
||||
// Commit any existing pending operation
|
||||
if (pending) {
|
||||
commit();
|
||||
}
|
||||
|
||||
7) Example Test Cases (sketches)
|
||||
// Create new pending node
|
||||
pending = std::make_unique<UndoNode>();
|
||||
pending->type = type;
|
||||
pending->row = row;
|
||||
pending->col = col;
|
||||
pending->text.clear();
|
||||
|
||||
- Branch discard after undo:
|
||||
1) InsertText("abc"); Undo(); Undo(); InsertText("X"); Redo();
|
||||
Expected: Redo is a no-op (or status indicates no redo), buffer is "aX".
|
||||
}
|
||||
|
||||
- Newline split/join:
|
||||
1) InsertText("ab"); Newline(); InsertText("c"); Undo();
|
||||
Expected: single undo joins lines → buffer "abc" on one line at original join point; Redo() splits again.
|
||||
bool UndoSystem::should_batch_with_pending(UndoType type, int row, int
|
||||
col) const { if (!pending) return false; if (pending->type != type)
|
||||
return false; if (pending->row != row) return false;
|
||||
|
||||
- Backspace batching:
|
||||
1) InsertText("hello"); Backspace×3; Undo();
|
||||
Expected: restores "hello".
|
||||
// For Insert: check if we're continuing at the right position
|
||||
if (type == UndoType::Insert) {
|
||||
return (pending->col + pending->text.size()) == col;
|
||||
}
|
||||
|
||||
- UTF-8 insertion:
|
||||
1) InsertText("😀汉"); Undo(); Redo();
|
||||
Expected: content unchanged across cycles; no crashes.
|
||||
// For Delete: check if we're continuing from the same position
|
||||
if (type == UndoType::Delete) {
|
||||
return pending->col == col;
|
||||
}
|
||||
|
||||
- Saved/dirty transitions:
|
||||
1) InsertText("hi"); mark_saved(); InsertText("!"); Undo(); Redo();
|
||||
Expected: dirty false after mark_saved; dirty true after InsertText("!"); dirty returns to false after Undo();
|
||||
true again after Redo().
|
||||
return false;
|
||||
|
||||
}
|
||||
|
||||
8) Risks & Mitigations
|
||||
```
|
||||
### 3.2 Commit logic
|
||||
```
|
||||
|
||||
- SDL/macOS event ordering (KEYDOWN vs TEXTINPUT, IME): Mitigate by suppressing TEXTINPUT on mapped k-prefix suffixes;
|
||||
optionally temporarily disable SDL text input during k-prefix suffix mapping; add targeted diagnostics.
|
||||
- UTF-8 width vs byte-length: Store bytes in UndoNode::text; keep column logic consistent with existing Buffer
|
||||
semantics.
|
||||
- Memory growth: Add GC/limits and provide a way to clear/reduce history for huge sessions.
|
||||
- Re-entrancy during apply(): Prevent public edit paths from being called; use only raw operations.
|
||||
cpp void UndoSystem::commit() { if (!pending || pending->text.empty())
|
||||
{ pending.reset(); return; }
|
||||
|
||||
// Discard any redo branches from current position
|
||||
discard_redo_branches();
|
||||
|
||||
9) Nice-to-Have (post-MVP)
|
||||
// Attach pending as child of current
|
||||
attach_pending_to_current();
|
||||
|
||||
- Visual undo-tree navigation (emacs-like time travel and branch selection), at least as a debug tool initially.
|
||||
- Persistent undo across saves (opt-in; likely out-of-scope initially).
|
||||
- Time-based batching threshold (e.g., break batches after >500ms pause in typing).
|
||||
// Move current forward
|
||||
current = pending.release();
|
||||
if (current->parent) {
|
||||
current->parent->child.reset(current);
|
||||
}
|
||||
|
||||
// Update saved pointer if we diverged
|
||||
if (saved && saved != current) {
|
||||
// Check if saved is still reachable from current
|
||||
if (!is_ancestor_of(current, saved)) {
|
||||
saved = nullptr;
|
||||
}
|
||||
}
|
||||
|
||||
10) Execution Notes for a Junior Engineer/Agentic System
|
||||
}
|
||||
|
||||
- Start from Phase 0; do not skip instrumentation—assertions will catch subtle batching bugs early.
|
||||
- Change one surface at a time; when adjusting Begin/Append/commit positions, re-run unit tests immediately.
|
||||
- Always ensure commit boundaries before invoking commands that move the cursor/state.
|
||||
- When unsure about apply(), read docs/undo.md and mirror exactly: only raw Buffer methods, never the public editing
|
||||
APIs.
|
||||
- Keep diffs small and localized; add tests alongside behavior changes.
|
||||
```
|
||||
### 3.3 Apply operations
|
||||
```
|
||||
|
||||
Appendix A — Minimal Developer Checklist
|
||||
cpp void UndoSystem::apply_node(Buffer& buffer, const UndoNode* node,
|
||||
int direction) { if (!node) return;
|
||||
|
||||
- [ ] Begin/Append occur after buffer mutation and cursor updates for all edit commands.
|
||||
- [ ] Pending detached until commit; freed/cleared on commit/discard/clear.
|
||||
- [ ] Redo branches freed on new commit after undo.
|
||||
- [ ] mark_saved updates both saved pointer and dirty flag; dirty mirrors current != saved.
|
||||
- [ ] apply() uses only raw Buffer methods; no recording during apply.
|
||||
- [ ] Terminal and GUI both route printable input to InsertText; k-prefix mapping suppresses trailing TEXTINPUT.
|
||||
- [ ] Unit and integration tests cover batching, branching, newline, saved/dirty, and UTF-8 cases.
|
||||
switch (node->type) {
|
||||
case UndoType::Insert:
|
||||
if (direction > 0) { // redo
|
||||
buffer.raw_insert_text(node->row, node->col, node->text);
|
||||
} else { // undo
|
||||
buffer.raw_delete_text(node->row, node->col, node->text.size());
|
||||
}
|
||||
break;
|
||||
|
||||
case UndoType::Delete:
|
||||
if (direction > 0) { // redo
|
||||
buffer.raw_delete_text(node->row, node->col, node->text.size());
|
||||
} else { // undo
|
||||
buffer.raw_insert_text(node->row, node->col, node->text);
|
||||
}
|
||||
break;
|
||||
|
||||
case UndoType::Newline:
|
||||
if (direction > 0) { // redo
|
||||
buffer.raw_split_line(node->row, node->col);
|
||||
} else { // undo
|
||||
buffer.raw_join_lines(node->row);
|
||||
}
|
||||
break;
|
||||
|
||||
// Handle other types...
|
||||
}
|
||||
|
||||
}
|
||||
|
||||
```
|
||||
## Phase 4: Command Integration
|
||||
|
||||
### 4.1 Add undo/redo commands (Command.cc)
|
||||
Register the undo/redo commands in the command system:
|
||||
```
|
||||
|
||||
cpp // In InstallDefaultCommands() CommandRegistry::Register({
|
||||
CommandId::Undo, "undo", "Undo the last change", [](CommandContext&
|
||||
ctx) { auto& editor = ctx.editor; auto* buffer =
|
||||
editor.current_buffer(); if (buffer && buffer->can_undo()) {
|
||||
buffer->undo(); return true; } return false; }, false // not public
|
||||
command });
|
||||
|
||||
CommandRegistry::Register({ CommandId::Redo, "redo", "Redo the last
|
||||
undone change", [](CommandContext& ctx) { auto& editor = ctx.editor;
|
||||
auto* buffer = editor.current_buffer(); if (buffer &&
|
||||
buffer->can_redo()) { buffer->redo(); return true; } return false; },
|
||||
false // not public command });
|
||||
|
||||
```
|
||||
### 4.2 Update keybinding handlers
|
||||
Ensure the input handlers map `C-k u` to `CommandId::Undo` and `C-k r`
|
||||
to `CommandId::Redo`.
|
||||
|
||||
## Phase 5: Memory Management and Edge Cases
|
||||
|
||||
### 5.1 Buffer lifecycle management
|
||||
- **Constructor**: Initialize `undo_system = std::make_unique<UndoSystem>()`
|
||||
- **Destructor**: `undo_system.reset()` (automatic)
|
||||
- **File reload**: Call `undo_system->clear()` before loading
|
||||
- **New file**: Call `undo_system->clear()`
|
||||
- **Close buffer**: Call `undo_system->discard_pending()` then let destructor handle cleanup
|
||||
|
||||
### 5.2 Save state tracking
|
||||
- **After successful save**: Call `buffer->mark_saved()`
|
||||
- **For dirty flag**: Use `buffer->is_dirty()`
|
||||
|
||||
### 5.3 Edge case handling
|
||||
- Prevent undo during undo application (`applying_undo` flag)
|
||||
- Handle empty operations gracefully
|
||||
- Ensure cursor positioning after undo/redo
|
||||
- Test memory leaks with rapid typing + buffer close
|
||||
|
||||
## Phase 6: Testing
|
||||
|
||||
### 6.1 Unit tests (test_undo.cc)
|
||||
Create comprehensive tests covering:
|
||||
- Basic typing and undo
|
||||
- Word-level batching
|
||||
- Non-linear undo (type, undo, type different text)
|
||||
- Memory leak testing
|
||||
- Save state tracking
|
||||
- Edge cases (empty buffers, large operations)
|
||||
|
||||
### 6.2 Integration tests
|
||||
- Test with all buffer implementations (GapBuffer, PieceTable)
|
||||
- Test with GUI and Terminal frontends
|
||||
- Test rapid typing + immediate buffer close
|
||||
- Test file reload during pending operations
|
||||
|
||||
## Implementation Priority
|
||||
|
||||
1. **Phase 1**: Implement core data structures
|
||||
2. **Phase 2**: Add Buffer integration points
|
||||
3. **Phase 3**: Implement UndoSystem methods
|
||||
4. **Phase 4**: Wire up commands and keybindings
|
||||
5. **Phase 5**: Handle edge cases and memory management
|
||||
6. **Phase 6**: Comprehensive testing
|
||||
|
||||
## Critical Success Criteria
|
||||
|
||||
- ✅ No memory leaks even with rapid typing + buffer close
|
||||
- ✅ Batching works correctly (word-level undo steps)
|
||||
- ✅ Non-linear undo creates branches correctly
|
||||
- ✅ Save state tracking works properly
|
||||
- ✅ Silent operations during undo application
|
||||
- ✅ Clean integration with existing Buffer operations
|
||||
|
||||
This roadmap provides Junie with a complete, step-by-step implementation plan that preserves the original design goals while ensuring robust, memory-safe implementation.
|
||||
```
|
||||
|
||||
This roadmap refines your original plan by:
|
||||
|
||||
1. **Memory Safety**: Uses `std::unique_ptr` for automatic memory
|
||||
management
|
||||
2. **Clear Implementation Steps**: Breaks down into logical phases
|
||||
3. **Integration Points**: Clearly identifies where to hook into
|
||||
existing code
|
||||
4. **Edge Case Handling**: Addresses buffer lifecycle and error
|
||||
conditions
|
||||
5. **Testing Strategy**: Ensures robust validation
|
||||
|
||||
The core design remains faithful to your emacs-style undo tree vision
|
||||
while being practical for implementation by Junie.
|
||||
|
||||
@@ -1,139 +0,0 @@
|
||||
### Context recap
|
||||
|
||||
- The undo system is now tree‑based with batching rules and `KTE_UNDO_DEBUG` instrumentation hooks already present in
|
||||
`UndoSystem.{h,cc}`.
|
||||
- GUI path uses SDL; printable input now flows exclusively via `SDL_TEXTINPUT` to `CommandId::InsertText`, while
|
||||
control/meta/movement (incl. Backspace/Delete/Newline and k‑prefix) come from `SDL_KEYDOWN`.
|
||||
- Commit boundaries must be enforced at well‑defined points (movement, non‑editing commands, newline, undo/redo, etc.).
|
||||
|
||||
### Status summary (2025‑12‑01)
|
||||
|
||||
- Input‑path unification: Completed. `GUIInputHandler.cc` routes all printable characters through `SDL_TEXTINPUT → InsertText`.
|
||||
Newlines originate only from `SDL_KEYDOWN → Newline`. CR/LF are filtered out of `SDL_TEXTINPUT` payloads. Suppression
|
||||
rules prevent stray `TEXTINPUT` after meta/prefix/universal‑argument flows. Terminal input path remains consistent.
|
||||
- Tests: `test_undo.cc` expanded to cover branching behavior, UTF‑8 insertion, multi‑line newline/join, and typing batching.
|
||||
All scenarios pass.
|
||||
- Instrumentation: `KTE_UNDO_DEBUG` hooks exist in `UndoSystem.{h,cc}`; a CMake toggle has not yet been added.
|
||||
- Commit boundaries: Undo/Redo commit boundaries are in place; newline path commits immediately by design. A final audit
|
||||
pass across movement/non‑editing commands is still pending.
|
||||
- Docs: This status document updated. Further docs (instrumentation how‑to and example traces) remain pending in
|
||||
`docs/undo.md` / `docs/undo-roadmap.md`.
|
||||
|
||||
### Objectives
|
||||
|
||||
- Use the existing instrumentation to capture short traces of typing/backspacing/deleting and undo/redo.
|
||||
- Unify input paths (SDL `KEYDOWN` vs `TEXTINPUT`) and lock down commit boundaries across commands.
|
||||
- Extend tests to cover branching behavior, UTF‑8, and multi‑line operations.
|
||||
|
||||
### Plan of action
|
||||
|
||||
1. Enable instrumentation and make it easy to toggle
|
||||
- Add a CMake option in `CMakeLists.txt` (root project):
|
||||
`option(KTE_UNDO_DEBUG "Enable undo instrumentation logs" OFF)`.
|
||||
- When ON, add a compile definition `-DKTE_UNDO_DEBUG` to all targets that include the editor core (e.g., `kte`,
|
||||
`kge`, and test binaries).
|
||||
- Keep the default OFF so normal builds are quiet; ensure both modes compile in CI.
|
||||
|
||||
2. Capture short traces to validate current behavior
|
||||
- Build with `-DKTE_UNDO_DEBUG=ON` and run the GUI frontend:
|
||||
- Scenario A: type a contiguous word, then move cursor (should show `Begin(Insert)` + multiple `Append`, single
|
||||
`commit` at a movement boundary).
|
||||
- Scenario B: hold backspace to delete a run, including backspace batching (prepend rule); verify
|
||||
`Begin(Delete)` with prepended `Append` behavior, single `commit`.
|
||||
- Scenario C: forward deletes at a fixed column (anchor batching); expected single `Begin(Delete)` with same
|
||||
column.
|
||||
- Scenario D: insert newline (`Newline` node) and immediately commit; type text on the next line; undo/redo
|
||||
across the boundary.
|
||||
- Scenario E: undo chain and redo chain; then type new text and confirm redo branch gets discarded in logs.
|
||||
- Save representative trace snippets and add to `docs/undo.md` or `docs/undo-roadmap.md` for reference.
|
||||
|
||||
3. Input‑path unification (SDL `KEYDOWN` vs `TEXTINPUT`) — Completed 2025‑12‑01
|
||||
- In `GUIInputHandler.cc`:
|
||||
- Ensure printable characters are generated exclusively from `SDL_TEXTINPUT` and mapped to
|
||||
`CommandId::InsertText`.
|
||||
- Keep `SDL_KEYDOWN` for control/meta/movement, backspace/delete, newline, and k‑prefix handling.
|
||||
- Maintain suppression of stray `SDL_TEXTINPUT` immediately following meta/prefix or universal‑argument
|
||||
collection so no accidental text is inserted.
|
||||
- Confirm that `InsertText` path never carries `"\n"`; newline must only originate from `KEYDOWN` →
|
||||
`CommandId::Newline`.
|
||||
- If the terminal input path exists, ensure parity: printable insertions go through `InsertText`, control via key
|
||||
events, and the same commit boundaries apply.
|
||||
- Status: Implemented. See `GUIInputHandler.cc` changes; tests confirm parity with terminal path.
|
||||
|
||||
4. Enforce and verify commit boundaries in command execution — In progress
|
||||
- Audit `Command.cc` and ensure `u->commit()` is called before executing any non‑editing command that should end a
|
||||
batch:
|
||||
- Movement commands (left/right/up/down/home/end/page).
|
||||
- Prompt accept/cancel transitions and mode switches (search prompts, replace prompts).
|
||||
- Buffer/file operations (open/switch/save/close), and focus changes.
|
||||
- Before running `Undo` or `Redo` (already present).
|
||||
- Ensure immediate commit at the end of atomic edit operations:
|
||||
- `Newline` insertion and line joins (`Delete` of newline when backspacing at column 0) should create
|
||||
`UndoType::Newline` and commit immediately (parts are already implemented; verify all call sites).
|
||||
- Pastes should be a single `Paste`/`Insert` batch per operation (depending on current design).
|
||||
|
||||
5. Extend automated tests (or add them if absent) — Phase 1 completed
|
||||
- Branching behavior ✓
|
||||
- Insert `"abc"`, undo twice (back to `"a"`), insert `"X"`, assert redo list is discarded, and new timeline
|
||||
continues with `aX`.
|
||||
- Navigate undo/redo along the new branch to ensure correctness.
|
||||
- UTF‑8 insertion and deletion ✓
|
||||
- Insert `"é漢"` (multi‑byte characters) via `InsertText`; verify buffer content and that a single Insert batch
|
||||
is created.
|
||||
- Undo/redo restores/removes the full insertion batch.
|
||||
- Backspace after typed UTF‑8 should remove the last inserted codepoint from the batch in a single undo step (
|
||||
current semantics are byte‑oriented in buffer ops; test to current behavior and document).
|
||||
- Multi‑line operations ✓
|
||||
- Newline splits a line: verify an `UndoType::Newline` node is created and committed immediately; undo/redo
|
||||
round‑trip.
|
||||
- Backspace at column 0 joins with previous line: record as `Newline` deletion (via `UndoType::Newline`
|
||||
inverse); undo/redo round‑trip.
|
||||
- Typing and deletion batching ✓ (typing) / Pending (delete batching)
|
||||
- Typing a contiguous word (no cursor moves) yields one `Insert` node with accumulated text.
|
||||
- Forward delete at a fixed anchor column yields one `Delete` batch. (Pending test)
|
||||
- Backspace batching uses the prepend rule when the cursor moves left. (Pending test)
|
||||
- Place tests near existing test suite files (e.g., `tests/test_undo.cc`) or create them if not present. Prefer
|
||||
using `Buffer` + `UndoSystem` directly for tight unit tests; add higher‑level integration tests as needed.
|
||||
|
||||
6. Documentation updates — In progress
|
||||
- In `docs/undo.md` and `docs/undo-roadmap.md`:
|
||||
- Describe how to enable instrumentation (`KTE_UNDO_DEBUG`) and an example of trace logs.
|
||||
- List batching rules and commit boundaries clearly with examples.
|
||||
- Document current UTF‑8 semantics (byte‑wise vs codepoint‑wise) and any known limitations.
|
||||
- Current status: this `undo-state.md` updated; instrumentation how‑to and example traces pending.
|
||||
|
||||
7. CI and build hygiene — Pending
|
||||
- Default builds: `KTE_UNDO_DEBUG` OFF.
|
||||
- Add a CI job that builds and runs tests with `KTE_UNDO_DEBUG=ON` to ensure the instrumentation path remains
|
||||
healthy.
|
||||
- Ensure no performance regressions or excessive logging in release builds.
|
||||
|
||||
8. Stretch goals (optional, time‑boxed) — Pending
|
||||
- IME composition: confirm that `SDL_TEXTINPUT` behavior during IME composition does not produce partial/broken
|
||||
insertions; if needed, buffer composition updates into a single commit.
|
||||
- Ensure paste operations (multi‑line/UTF‑8) remain atomic in undo history.
|
||||
|
||||
### How to run the tests
|
||||
|
||||
- Configure with `-DBUILD_TESTS=ON` and build the `test_undo` target. Run the produced binary (e.g., `./test_undo`).
|
||||
The test prints progress and uses assertions to validate behavior.
|
||||
|
||||
### Deliverables
|
||||
|
||||
- CMake toggle for instrumentation and verified logs for core scenarios. (Pending)
|
||||
- Updated `GUIInputHandler.cc` solidifying `KEYDOWN` vs `TEXTINPUT` separation and suppression rules. (Completed)
|
||||
- Verified commit boundaries in `Command.cc` with comments where appropriate. (In progress)
|
||||
- New tests for branching, UTF‑8, and multi‑line operations; all passing. (Completed for listed scenarios)
|
||||
- Docs updated with how‑to and example traces. (Pending)
|
||||
|
||||
### Acceptance criteria
|
||||
|
||||
### Current status (2025‑12‑01) vs acceptance criteria
|
||||
|
||||
- Short instrumentation traces match expected batching and commit behavior for typing, backspace/delete, newline, and
|
||||
undo/redo. — Pending (instrumentation toggle + capture not done)
|
||||
- Printable input comes exclusively from `SDL_TEXTINPUT`; no stray inserts after meta/prefix/universal‑argument flows.
|
||||
— Satisfied (GUI path updated; terminal path consistent)
|
||||
- Undo branching behaves correctly; redo is discarded upon new commits after undo. — Satisfied (tested)
|
||||
- UTF‑8 and multi‑line scenarios round‑trip via undo/redo according to the documented semantics. — Satisfied (tested)
|
||||
- Tests pass with `KTE_UNDO_DEBUG` both OFF and ON. — Pending (no CMake toggle yet; default OFF passes)
|
||||
140
docs/undo.md
140
docs/undo.md
@@ -1,140 +0,0 @@
|
||||
This is a design for a non-linear undo/redo system for kte. The design must be identical in behavior and correctness
|
||||
to the proven kte editor undo system.
|
||||
|
||||
### Core Requirements
|
||||
|
||||
1. Each open buffer has its own completely independent undo tree.
|
||||
2. Undo and redo must be non-linear: typing after undo creates a branch; old redo branches are discarded.
|
||||
3. Typing, backspacing, and pasting are batched into word-level undo steps.
|
||||
4. Undo/redo must never create new undo nodes while applying an undo/redo (silent, low-level apply).
|
||||
5. The system must be memory-safe and leak-proof even if the user types and immediately closes the buffer.
|
||||
|
||||
### Data Structures
|
||||
|
||||
```cpp
|
||||
enum class UndoType : uint8_t {
|
||||
Insert,
|
||||
Delete,
|
||||
Paste, // optional, can reuse Insert
|
||||
Newline,
|
||||
DeleteRow,
|
||||
// future: IndentRegion, KillRegion, etc.
|
||||
};
|
||||
|
||||
struct UndoNode {
|
||||
UndoType type;
|
||||
int row; // original cursor row
|
||||
int col; // original cursor column (updated during batch)
|
||||
std::string text; // the inserted or deleted text (full batch)
|
||||
UndoNode* child = nullptr; // next in current timeline
|
||||
UndoNode* next = nullptr; // redo branch (rarely used)
|
||||
// no parent pointer needed — we walk from root
|
||||
};
|
||||
|
||||
struct UndoTree {
|
||||
UndoNode* root = nullptr; // first edit ever
|
||||
UndoNode* current = nullptr; // current state of buffer
|
||||
UndoNode* saved = nullptr; // points to node matching last save (for dirty flag)
|
||||
UndoNode* pending = nullptr; // in-progress batch (detached)
|
||||
};
|
||||
```
|
||||
|
||||
Each `Buffer` owns one `std::unique_ptr<UndoTree>`.
|
||||
|
||||
### Core API (must implement exactly)
|
||||
|
||||
```cpp
|
||||
class UndoSystem {
|
||||
public:
|
||||
void Begin(UndoType type);
|
||||
void Append(char ch);
|
||||
void Append(std::string_view text);
|
||||
void commit(); // called on cursor move, commands, etc.
|
||||
|
||||
void undo(); // Ctrl+Z
|
||||
void redo(); // Ctrl+Y or Ctrl+Shift+Z
|
||||
|
||||
void mark_saved(); // after successful save
|
||||
void discard_pending(); // before closing buffer or loading new file
|
||||
void clear(); // new file / reset
|
||||
|
||||
private:
|
||||
void apply(const UndoNode* node, int direction); // +1 = redo, -1 = undo
|
||||
void free_node(UndoNode* node);
|
||||
void free_branch(UndoNode* node); // frees redo siblings only
|
||||
};
|
||||
```
|
||||
|
||||
### Critical Invariants and Rules
|
||||
|
||||
1. `begin()` must reuse `pending` if:
|
||||
- same type
|
||||
- same row
|
||||
- `pending->col + pending->text.size() == current_cursor_col`
|
||||
→ otherwise `commit()` old and create new
|
||||
|
||||
2. `pending` is detached — never linked until `commit()`
|
||||
|
||||
3. `commit()`:
|
||||
- discards redo branches (`current->child`)
|
||||
- attaches `pending` as `current->child`
|
||||
- advances `current`
|
||||
- clears `pending`
|
||||
- if diverged from `saved`, null it
|
||||
|
||||
4. `apply()` must use low-level buffer operations:
|
||||
- Never call public insert/delete/newline
|
||||
- Use raw `buffer.insert_text(row, col, text)` and `buffer.delete_text(row, col, len)`
|
||||
- These must not trigger undo
|
||||
|
||||
5. `undo()`:
|
||||
- move current to parent
|
||||
- apply(current, -1)
|
||||
|
||||
6. `redo()`:
|
||||
- move current to child
|
||||
- apply(current, +1)
|
||||
|
||||
7. `discard_pending()` must be called in:
|
||||
- buffer close
|
||||
- file reload
|
||||
- new file
|
||||
- any destructive operation
|
||||
|
||||
### Example Flow: Typing "hello"
|
||||
|
||||
```text
|
||||
begin(Insert) → pending = new node, col=0
|
||||
append('h') → pending->text = "h", pending->col = 1
|
||||
append('e') → "he", col = 2
|
||||
...
|
||||
commit() on arrow key → pending becomes current->child, current advances
|
||||
```
|
||||
|
||||
One undo step removes all of "hello".
|
||||
|
||||
### Required Helper in Buffer Class
|
||||
|
||||
```cpp
|
||||
class Buffer {
|
||||
void insert_text(int row, int col, std::string_view text); // raw, no undo
|
||||
void delete_text(int row, int col, size_t len); // raw, no undo
|
||||
void split_line(int row, int col); // raw newline
|
||||
void join_lines(int row); // raw join
|
||||
void insert_row(int row, std::string_view text); // raw
|
||||
void delete_row(int row); // raw
|
||||
};
|
||||
```
|
||||
|
||||
### Tasks for Agent
|
||||
|
||||
1. Implement `UndoNode`, `UndoTree`, and `UndoSystem` class exactly as specified.
|
||||
2. Add `std::unique_ptr<UndoTree> undo;` to `Buffer`.
|
||||
3. Modify `insert_char`, `delete_char`, `paste`, `newline` to use `undo.begin()/append()/commit()`.
|
||||
4. Add `undo.commit()` at start of all cursor movement and command functions.
|
||||
5. Implement `apply()` using only `Buffer`'s raw methods.
|
||||
6. Add `undo.discard_pending()` in all buffer reset/close paths.
|
||||
7. Add `Ctrl+Z` → `buffer.undo()`, `Ctrl+Y` → `buffer.redo()`.
|
||||
|
||||
This design is used in production editors and is considered the gold standard for small, correct, non-linear undo in
|
||||
C/C++. Implement it faithfully.
|
||||
@@ -12,7 +12,7 @@ inline const unsigned int *DefaultFontData = BrassMonoCode::DefaultFontBoldCompr
|
||||
|
||||
class Font {
|
||||
public:
|
||||
Font(std::string name, unsigned int *data, const unsigned int size)
|
||||
Font(std::string name, const unsigned int *data, const unsigned int size)
|
||||
: name_(std::move(name)),
|
||||
data_(data),
|
||||
size_(size) {}
|
||||
@@ -28,7 +28,7 @@ public:
|
||||
|
||||
private:
|
||||
std::string name_;
|
||||
unsigned int *data_{nullptr};
|
||||
const unsigned int *data_{nullptr};
|
||||
unsigned int size_{0};
|
||||
};
|
||||
}
|
||||
@@ -7,87 +7,87 @@ InstallDefaultFonts()
|
||||
{
|
||||
FontRegistry::Instance().Register(std::make_unique<Font>(
|
||||
"default",
|
||||
const_cast<unsigned int *>(BrassMono::DefaultFontBoldCompressedData),
|
||||
BrassMono::DefaultFontBoldCompressedData,
|
||||
BrassMono::DefaultFontBoldCompressedSize
|
||||
));
|
||||
FontRegistry::Instance().Register(std::make_unique<Font>(
|
||||
"b612",
|
||||
const_cast<unsigned int *>(B612Mono::DefaultFontRegularCompressedData),
|
||||
B612Mono::DefaultFontRegularCompressedData,
|
||||
B612Mono::DefaultFontRegularCompressedSize
|
||||
));
|
||||
FontRegistry::Instance().Register(std::make_unique<Font>(
|
||||
"brassmono",
|
||||
const_cast<unsigned int *>(BrassMono::DefaultFontBoldCompressedData),
|
||||
BrassMono::DefaultFontBoldCompressedData,
|
||||
BrassMono::DefaultFontBoldCompressedSize
|
||||
));
|
||||
FontRegistry::Instance().Register(std::make_unique<Font>(
|
||||
"brassmonocode",
|
||||
const_cast<unsigned int *>(BrassMonoCode::DefaultFontBoldCompressedData),
|
||||
BrassMonoCode::DefaultFontBoldCompressedData,
|
||||
BrassMonoCode::DefaultFontBoldCompressedSize
|
||||
));
|
||||
FontRegistry::Instance().Register(std::make_unique<Font>(
|
||||
"fira",
|
||||
const_cast<unsigned int *>(FiraCode::DefaultFontRegularCompressedData),
|
||||
FiraCode::DefaultFontRegularCompressedData,
|
||||
FiraCode::DefaultFontRegularCompressedSize
|
||||
));
|
||||
FontRegistry::Instance().Register(std::make_unique<Font>(
|
||||
"go",
|
||||
const_cast<unsigned int *>(Go::DefaultFontRegularCompressedData),
|
||||
Go::DefaultFontRegularCompressedData,
|
||||
Go::DefaultFontRegularCompressedSize
|
||||
));
|
||||
FontRegistry::Instance().Register(std::make_unique<Font>(
|
||||
"ibm",
|
||||
const_cast<unsigned int *>(IBMPlexMono::DefaultFontRegularCompressedData),
|
||||
IBMPlexMono::DefaultFontRegularCompressedData,
|
||||
IBMPlexMono::DefaultFontRegularCompressedSize
|
||||
));
|
||||
FontRegistry::Instance().Register(std::make_unique<Font>(
|
||||
"idealist",
|
||||
const_cast<unsigned int *>(Idealist::DefaultFontRegularCompressedData),
|
||||
Idealist::DefaultFontRegularCompressedData,
|
||||
Idealist::DefaultFontRegularCompressedSize
|
||||
));
|
||||
FontRegistry::Instance().Register(std::make_unique<Font>(
|
||||
"inconsolata",
|
||||
const_cast<unsigned int *>(Inconsolata::DefaultFontRegularCompressedData),
|
||||
Inconsolata::DefaultFontRegularCompressedData,
|
||||
Inconsolata::DefaultFontRegularCompressedSize
|
||||
));
|
||||
FontRegistry::Instance().Register(std::make_unique<Font>(
|
||||
"inconsolataex",
|
||||
const_cast<unsigned int *>(InconsolataExpanded::DefaultFontRegularCompressedData),
|
||||
InconsolataExpanded::DefaultFontRegularCompressedData,
|
||||
InconsolataExpanded::DefaultFontRegularCompressedSize
|
||||
));
|
||||
FontRegistry::Instance().Register(std::make_unique<Font>(
|
||||
"iosevka",
|
||||
const_cast<unsigned int *>(Iosoveka::DefaultFontRegularCompressedData),
|
||||
Iosoveka::DefaultFontRegularCompressedData,
|
||||
Iosoveka::DefaultFontRegularCompressedSize
|
||||
));
|
||||
FontRegistry::Instance().Register(std::make_unique<Font>(
|
||||
"iosevkaex",
|
||||
const_cast<unsigned int *>(IosevkaExtended::DefaultFontRegularCompressedData),
|
||||
IosevkaExtended::DefaultFontRegularCompressedData,
|
||||
IosevkaExtended::DefaultFontRegularCompressedSize
|
||||
));
|
||||
FontRegistry::Instance().Register(std::make_unique<Font>(
|
||||
"sharetech",
|
||||
const_cast<unsigned int *>(ShareTech::DefaultFontRegularCompressedData),
|
||||
ShareTech::DefaultFontRegularCompressedData,
|
||||
ShareTech::DefaultFontRegularCompressedSize
|
||||
));
|
||||
FontRegistry::Instance().Register(std::make_unique<Font>(
|
||||
"space",
|
||||
const_cast<unsigned int *>(SpaceMono::DefaultFontRegularCompressedData),
|
||||
SpaceMono::DefaultFontRegularCompressedData,
|
||||
SpaceMono::DefaultFontRegularCompressedSize
|
||||
));
|
||||
FontRegistry::Instance().Register(std::make_unique<Font>(
|
||||
"syne",
|
||||
const_cast<unsigned int *>(Syne::DefaultFontRegularCompressedData),
|
||||
Syne::DefaultFontRegularCompressedData,
|
||||
Syne::DefaultFontRegularCompressedSize
|
||||
));
|
||||
FontRegistry::Instance().Register(std::make_unique<Font>(
|
||||
"triplicate",
|
||||
const_cast<unsigned int *>(Triplicate::DefaultFontRegularCompressedData),
|
||||
Triplicate::DefaultFontRegularCompressedData,
|
||||
Triplicate::DefaultFontRegularCompressedSize
|
||||
));
|
||||
FontRegistry::Instance().Register(std::make_unique<Font>(
|
||||
"unispace",
|
||||
const_cast<unsigned int *>(Unispace::DefaultFontRegularCompressedData),
|
||||
Unispace::DefaultFontRegularCompressedData,
|
||||
Unispace::DefaultFontRegularCompressedSize
|
||||
));
|
||||
}
|
||||
|
||||
@@ -39,10 +39,16 @@ public:
|
||||
|
||||
|
||||
// Convenience: load a font by name and size
|
||||
bool LoadFont(const std::string &name, const float size) const
|
||||
bool LoadFont(const std::string &name, const float size)
|
||||
{
|
||||
if (auto *font = Get(name)) {
|
||||
font->Load(size);
|
||||
// Track current selection
|
||||
{
|
||||
std::lock_guard lock(mutex_);
|
||||
current_name_ = name;
|
||||
current_size_ = size;
|
||||
}
|
||||
return true;
|
||||
}
|
||||
return false;
|
||||
@@ -80,6 +86,21 @@ public:
|
||||
return fonts_.count(name) > 0;
|
||||
}
|
||||
|
||||
|
||||
// Current font name/size as last successfully loaded via LoadFont()
|
||||
std::string CurrentFontName() const
|
||||
{
|
||||
std::lock_guard lock(mutex_);
|
||||
return current_name_;
|
||||
}
|
||||
|
||||
|
||||
float CurrentFontSize() const
|
||||
{
|
||||
std::lock_guard lock(mutex_);
|
||||
return current_size_;
|
||||
}
|
||||
|
||||
private:
|
||||
FontRegistry() = default;
|
||||
|
||||
@@ -90,6 +111,10 @@ private:
|
||||
bool has_pending_ = false;
|
||||
std::string pending_name_;
|
||||
float pending_size_ = 0.0f;
|
||||
|
||||
// Track last applied font
|
||||
std::string current_name_;
|
||||
float current_size_ = 0.0f;
|
||||
};
|
||||
|
||||
|
||||
|
||||
163
main.cc
163
main.cc
@@ -1,8 +1,15 @@
|
||||
#include <cctype>
|
||||
#include <cerrno>
|
||||
#include <cstdio>
|
||||
#include <cstring>
|
||||
#include <getopt.h>
|
||||
#include <iostream>
|
||||
#include <limits>
|
||||
#include <memory>
|
||||
#include <algorithm>
|
||||
#include <chrono>
|
||||
#include <random>
|
||||
#include <thread>
|
||||
#include <signal.h>
|
||||
#include <string>
|
||||
#include <unistd.h>
|
||||
@@ -31,7 +38,71 @@ PrintUsage(const char *prog)
|
||||
<< " -g, --gui Use GUI frontend (if built)\n"
|
||||
<< " -t, --term Use terminal (ncurses) frontend [default]\n"
|
||||
<< " -h, --help Show this help and exit\n"
|
||||
<< " -V, --version Show version and exit\n";
|
||||
<< " -V, --version Show version and exit\n"
|
||||
<< " --stress-highlighter[=SECONDS] Run a short highlighter stress harness (debug aid)\n";
|
||||
}
|
||||
|
||||
|
||||
static int
|
||||
RunStressHighlighter(unsigned seconds)
|
||||
{
|
||||
// Build a synthetic buffer with code-like content
|
||||
Buffer buf;
|
||||
buf.SetFiletype("cpp");
|
||||
buf.SetSyntaxEnabled(true);
|
||||
buf.EnsureHighlighter();
|
||||
// Seed with many lines
|
||||
const int N = 1200;
|
||||
for (int i = 0; i < N; ++i) {
|
||||
std::string line = "int v" + std::to_string(i) + " = " + std::to_string(i) + "; // line\n";
|
||||
buf.insert_row(i, line);
|
||||
}
|
||||
// Remove the extra last empty row if any artifacts
|
||||
// Simulate a viewport of ~60 rows
|
||||
const int viewport_rows = 60;
|
||||
const auto start_ts = std::chrono::steady_clock::now();
|
||||
std::mt19937 rng{1234567u};
|
||||
std::uniform_int_distribution<int> row_d(0, N - 1);
|
||||
std::uniform_int_distribution<int> op_d(0, 2);
|
||||
std::uniform_int_distribution<int> sleep_d(0, 2);
|
||||
|
||||
// Loop performing edits and highlighter queries while background worker runs
|
||||
while (std::chrono::duration_cast<std::chrono::seconds>(std::chrono::steady_clock::now() - start_ts).count() <
|
||||
seconds) {
|
||||
int fr = row_d(rng);
|
||||
if (fr + viewport_rows >= N)
|
||||
fr = std::max(0, N - viewport_rows - 1);
|
||||
buf.SetOffsets(static_cast<std::size_t>(fr), 0);
|
||||
if (buf.Highlighter()) {
|
||||
buf.Highlighter()->PrefetchViewport(buf, fr, viewport_rows, buf.Version());
|
||||
}
|
||||
// Do a few direct GetLine calls over the viewport to shake the caches
|
||||
if (buf.Highlighter()) {
|
||||
for (int r = 0; r < viewport_rows; r += 7) {
|
||||
(void) buf.Highlighter()->GetLine(buf, fr + r, buf.Version());
|
||||
}
|
||||
}
|
||||
// Random simple edit
|
||||
int op = op_d(rng);
|
||||
int r = row_d(rng);
|
||||
if (op == 0) {
|
||||
buf.insert_text(r, 0, "/*X*/");
|
||||
buf.SetDirty(true);
|
||||
} else if (op == 1) {
|
||||
buf.delete_text(r, 0, 1);
|
||||
buf.SetDirty(true);
|
||||
} else {
|
||||
// split and join occasionally
|
||||
buf.split_line(r, 0);
|
||||
buf.join_lines(std::min(r + 1, N - 1));
|
||||
buf.SetDirty(true);
|
||||
}
|
||||
// tiny sleep to allow background thread to interleave
|
||||
if (sleep_d(rng) == 0) {
|
||||
std::this_thread::sleep_for(std::chrono::milliseconds(1));
|
||||
}
|
||||
}
|
||||
return 0;
|
||||
}
|
||||
|
||||
|
||||
@@ -41,39 +112,52 @@ main(int argc, const char *argv[])
|
||||
Editor editor;
|
||||
|
||||
// CLI parsing using getopt_long
|
||||
bool req_gui = false;
|
||||
bool req_term = false;
|
||||
bool show_help = false;
|
||||
bool show_version = false;
|
||||
bool req_gui = false;
|
||||
[[maybe_unused]] bool req_term = false;
|
||||
bool show_help = false;
|
||||
bool show_version = false;
|
||||
|
||||
static struct option long_opts[] = {
|
||||
{"gui", no_argument, nullptr, 'g'},
|
||||
{"term", no_argument, nullptr, 't'},
|
||||
{"help", no_argument, nullptr, 'h'},
|
||||
{"version", no_argument, nullptr, 'V'},
|
||||
{"stress-highlighter", optional_argument, nullptr, 1000},
|
||||
{nullptr, 0, nullptr, 0}
|
||||
};
|
||||
|
||||
int opt;
|
||||
int long_index = 0;
|
||||
int long_index = 0;
|
||||
unsigned stress_seconds = 0;
|
||||
while ((opt = getopt_long(argc, const_cast<char *const *>(argv), "gthV", long_opts, &long_index)) != -1) {
|
||||
switch (opt) {
|
||||
case 'g':
|
||||
req_gui = true;
|
||||
break;
|
||||
case 't':
|
||||
req_term = true;
|
||||
break;
|
||||
case 'h':
|
||||
show_help = true;
|
||||
break;
|
||||
case 'V':
|
||||
show_version = true;
|
||||
break;
|
||||
case '?':
|
||||
default:
|
||||
PrintUsage(argv[0]);
|
||||
return 2;
|
||||
case 'g':
|
||||
req_gui = true;
|
||||
break;
|
||||
case 't':
|
||||
req_term = true;
|
||||
break;
|
||||
case 'h':
|
||||
show_help = true;
|
||||
break;
|
||||
case 'V':
|
||||
show_version = true;
|
||||
break;
|
||||
case 1000: {
|
||||
stress_seconds = 5; // default
|
||||
if (optarg && *optarg) {
|
||||
try {
|
||||
unsigned v = static_cast<unsigned>(std::stoul(optarg));
|
||||
if (v > 0 && v < 36000)
|
||||
stress_seconds = v;
|
||||
} catch (...) {}
|
||||
}
|
||||
break;
|
||||
}
|
||||
case '?':
|
||||
default:
|
||||
PrintUsage(argv[0]);
|
||||
return 2;
|
||||
}
|
||||
}
|
||||
|
||||
@@ -86,9 +170,9 @@ main(int argc, const char *argv[])
|
||||
return 0;
|
||||
}
|
||||
|
||||
#if !defined(KTE_BUILD_GUI)
|
||||
(void) req_term; // suppress unused warning when GUI is not compiled in
|
||||
#endif
|
||||
if (stress_seconds > 0) {
|
||||
return RunStressHighlighter(stress_seconds);
|
||||
}
|
||||
|
||||
// Determine frontend
|
||||
#if !defined(KTE_BUILD_GUI)
|
||||
@@ -104,11 +188,13 @@ main(int argc, const char *argv[])
|
||||
} else if (req_term) {
|
||||
use_gui = false;
|
||||
} else {
|
||||
// Default depends on build target: kge defaults to GUI, kte to terminal
|
||||
|
||||
|
||||
// Default depends on build target: kge defaults to GUI, kte to terminal
|
||||
#if defined(KTE_DEFAULT_GUI)
|
||||
use_gui = true;
|
||||
use_gui = true;
|
||||
#else
|
||||
use_gui = false;
|
||||
use_gui = false;
|
||||
#endif
|
||||
}
|
||||
#endif
|
||||
@@ -134,7 +220,13 @@ main(int argc, const char *argv[])
|
||||
// Clamp to >=1 later; 0 disables.
|
||||
try {
|
||||
unsigned long v = std::stoul(p);
|
||||
pending_line = static_cast<std::size_t>(v);
|
||||
if (v > std::numeric_limits<std::size_t>::max()) {
|
||||
std::cerr <<
|
||||
"kte: Warning: Line number too large, ignoring\n";
|
||||
pending_line = 0;
|
||||
} else {
|
||||
pending_line = static_cast<std::size_t>(v);
|
||||
}
|
||||
} catch (...) {
|
||||
// Ignore malformed huge numbers
|
||||
pending_line = 0;
|
||||
@@ -193,8 +285,15 @@ main(int argc, const char *argv[])
|
||||
#if defined(KTE_BUILD_GUI) && defined(__APPLE__)
|
||||
if (use_gui) {
|
||||
/* likely using the .app, so need to cd */
|
||||
if (chdir(getenv("HOME")) != 0) {
|
||||
std::cerr << "kge.app: failed to chdir to HOME" << std::endl;
|
||||
const char *home = getenv("HOME");
|
||||
if (!home) {
|
||||
std::cerr << "kge.app: HOME environment variable not set" << std::endl;
|
||||
return 1;
|
||||
}
|
||||
if (chdir(home) != 0) {
|
||||
std::cerr << "kge.app: failed to chdir to " << home << ": "
|
||||
<< std::strerror(errno) << std::endl;
|
||||
return 1;
|
||||
}
|
||||
}
|
||||
#endif
|
||||
@@ -212,4 +311,4 @@ main(int argc, const char *argv[])
|
||||
fe->Shutdown();
|
||||
|
||||
return 0;
|
||||
}
|
||||
}
|
||||
16
make-app-release
Executable file
16
make-app-release
Executable file
@@ -0,0 +1,16 @@
|
||||
#!/usr/bin/env bash
|
||||
|
||||
set -eu
|
||||
set -o pipefail
|
||||
|
||||
mkdir -p cmake-build-release
|
||||
cmake -S . -B cmake-build-release -DBUILD_GUI=ON -DCMAKE_BUILD_TYPE=Release -DENABLE_ASAN=OFF
|
||||
|
||||
cd cmake-build-release
|
||||
make clean
|
||||
rm -fr kge.app*
|
||||
make
|
||||
zip -r kge.app.zip kge.app
|
||||
sha256sum kge.app.zip
|
||||
open .
|
||||
cd ..
|
||||
26
make-release
Executable file
26
make-release
Executable file
@@ -0,0 +1,26 @@
|
||||
#!/usr/bin/env bash
|
||||
|
||||
set -eu
|
||||
set -o pipefail
|
||||
|
||||
KTE_VERSION=$(grep 'KTE_VERSION' CMakeLists.txt | grep -o '"[0-9.]*"' | tr -d '"')
|
||||
KTE_VERSION="v${KTE_VERSION}"
|
||||
|
||||
if [ "${KTE_VERSION}" = "v" ]
|
||||
then
|
||||
echo "invalid version" > /dev/stderr
|
||||
exit 1
|
||||
fi
|
||||
|
||||
echo "kte version ${KTE_VERSION}"
|
||||
TREE="$(git status --porcelain --untracked-files=no)"
|
||||
if [ ! -z "${TREE}" ]
|
||||
then
|
||||
echo "tree is dirty" > /dev/stderr
|
||||
exit 1
|
||||
fi
|
||||
|
||||
git tag "${KTE_VERSION}"
|
||||
git push && git push --tags
|
||||
|
||||
( ./make-app-release )
|
||||
@@ -34,22 +34,24 @@ HighlighterEngine::SetHighlighter(std::unique_ptr<LanguageHighlighter> hl)
|
||||
}
|
||||
|
||||
|
||||
const LineHighlight &
|
||||
LineHighlight
|
||||
HighlighterEngine::GetLine(const Buffer &buf, int row, std::uint64_t buf_version) const
|
||||
{
|
||||
std::unique_lock<std::mutex> lock(mtx_);
|
||||
auto it = cache_.find(row);
|
||||
if (it != cache_.end() && it->second.version == buf_version) {
|
||||
return it->second;
|
||||
return it->second; // return by value (copy)
|
||||
}
|
||||
|
||||
// Prepare destination slot to reuse its capacity and avoid allocations
|
||||
LineHighlight &slot = cache_[row];
|
||||
slot.version = buf_version;
|
||||
slot.spans.clear();
|
||||
// We'll compute into a local result to avoid exposing references to cache
|
||||
LineHighlight result;
|
||||
result.version = buf_version;
|
||||
result.spans.clear();
|
||||
|
||||
if (!hl_) {
|
||||
return slot;
|
||||
// Cache empty result and return it
|
||||
cache_[row] = result;
|
||||
return result;
|
||||
}
|
||||
|
||||
// Copy shared_ptr-like raw pointer for use outside critical sections
|
||||
@@ -58,10 +60,12 @@ HighlighterEngine::GetLine(const Buffer &buf, int row, std::uint64_t buf_version
|
||||
|
||||
if (!is_stateful) {
|
||||
// Stateless fast path: we can release the lock while computing to reduce contention
|
||||
auto &out = slot.spans;
|
||||
lock.unlock();
|
||||
hl_ptr->HighlightLine(buf, row, out);
|
||||
return cache_.at(row);
|
||||
hl_ptr->HighlightLine(buf, row, result.spans);
|
||||
// Update cache and return
|
||||
std::lock_guard<std::mutex> gl(mtx_);
|
||||
cache_[row] = result;
|
||||
return result;
|
||||
}
|
||||
|
||||
// Stateful path: we need to walk from a known previous state. Keep lock while consulting caches,
|
||||
@@ -75,9 +79,13 @@ HighlighterEngine::GetLine(const Buffer &buf, int row, std::uint64_t buf_version
|
||||
int best = -1;
|
||||
for (const auto &kv: state_cache_) {
|
||||
int r = kv.first;
|
||||
// Only use cached state if it's for the current version and row still exists
|
||||
if (r <= row - 1 && kv.second.version == buf_version) {
|
||||
if (r > best)
|
||||
best = r;
|
||||
// Validate that the cached row index is still valid in the buffer
|
||||
if (r >= 0 && static_cast<std::size_t>(r) < buf.Rows().size()) {
|
||||
if (r > best)
|
||||
best = r;
|
||||
}
|
||||
}
|
||||
}
|
||||
if (best >= 0) {
|
||||
@@ -92,7 +100,7 @@ HighlighterEngine::GetLine(const Buffer &buf, int row, std::uint64_t buf_version
|
||||
StatefulHighlighter::LineState cur_state = prev_state;
|
||||
for (int r = start_row + 1; r <= row; ++r) {
|
||||
std::vector<HighlightSpan> tmp;
|
||||
std::vector<HighlightSpan> &out = (r == row) ? slot.spans : tmp;
|
||||
std::vector<HighlightSpan> &out = (r == row) ? result.spans : tmp;
|
||||
auto next_state = stateful->HighlightLineStateful(buf, r, cur_state, out);
|
||||
// Update state cache for r
|
||||
std::lock_guard<std::mutex> gl(mtx_);
|
||||
@@ -103,9 +111,10 @@ HighlighterEngine::GetLine(const Buffer &buf, int row, std::uint64_t buf_version
|
||||
cur_state = next_state;
|
||||
}
|
||||
|
||||
// Return reference under lock to ensure slot's address stability in map
|
||||
// Store in cache and return by value
|
||||
lock.lock();
|
||||
return cache_.at(row);
|
||||
cache_[row] = result;
|
||||
return result;
|
||||
}
|
||||
|
||||
|
||||
@@ -160,11 +169,15 @@ HighlighterEngine::worker_loop() const
|
||||
// Copy locals then release lock while computing
|
||||
lock.unlock();
|
||||
if (req.buf) {
|
||||
int start = std::max(0, req.start_row);
|
||||
int end = std::max(start, req.end_row);
|
||||
int start = std::max(0, req.start_row);
|
||||
int end = std::max(start, req.end_row);
|
||||
int skip_f = std::min(req.skip_first, req.skip_last);
|
||||
int skip_l = std::max(req.skip_first, req.skip_last);
|
||||
for (int r = start; r <= end; ++r) {
|
||||
// Re-check version staleness quickly by peeking cache version; not strictly necessary
|
||||
// Compute line; GetLine is thread-safe
|
||||
// Avoid touching rows that the foreground just computed/drew.
|
||||
if (r >= skip_f && r <= skip_l)
|
||||
continue;
|
||||
// Compute line; GetLine is thread-safe and will refresh caches.
|
||||
(void) this->GetLine(*req.buf, r, req.version);
|
||||
}
|
||||
}
|
||||
@@ -197,11 +210,13 @@ HighlighterEngine::PrefetchViewport(const Buffer &buf, int first_row, int row_co
|
||||
int warm_end = std::min(max_rows - 1, end + warm_margin);
|
||||
{
|
||||
std::lock_guard<std::mutex> lock(mtx_);
|
||||
pending_.buf = &buf;
|
||||
pending_.version = buf_version;
|
||||
pending_.start_row = warm_start;
|
||||
pending_.end_row = warm_end;
|
||||
has_request_ = true;
|
||||
pending_.buf = &buf;
|
||||
pending_.version = buf_version;
|
||||
pending_.start_row = warm_start;
|
||||
pending_.end_row = warm_end;
|
||||
pending_.skip_first = start;
|
||||
pending_.skip_last = end;
|
||||
has_request_ = true;
|
||||
}
|
||||
ensure_worker_started();
|
||||
cv_.notify_one();
|
||||
|
||||
@@ -25,8 +25,9 @@ public:
|
||||
void SetHighlighter(std::unique_ptr<LanguageHighlighter> hl);
|
||||
|
||||
// Retrieve highlights for a given line and buffer version.
|
||||
// Returns a copy to avoid lifetime issues across threads/renderers.
|
||||
// If cache is stale, recompute using the current highlighter.
|
||||
const LineHighlight &GetLine(const Buffer &buf, int row, std::uint64_t buf_version) const;
|
||||
LineHighlight GetLine(const Buffer &buf, int row, std::uint64_t buf_version) const;
|
||||
|
||||
// Invalidate cached lines from row (inclusive)
|
||||
void InvalidateFrom(int row);
|
||||
@@ -70,6 +71,10 @@ private:
|
||||
std::uint64_t version{0};
|
||||
int start_row{0};
|
||||
int end_row{0}; // inclusive
|
||||
// Visible rows to skip touching in the background (inclusive range).
|
||||
// These are computed synchronously by PrefetchViewport.
|
||||
int skip_first{0};
|
||||
int skip_last{-1};
|
||||
};
|
||||
|
||||
mutable std::condition_variable cv_;
|
||||
|
||||
102
test_buffer_correctness.cc
Normal file
102
test_buffer_correctness.cc
Normal file
@@ -0,0 +1,102 @@
|
||||
// Simple buffer correctness tests comparing GapBuffer and PieceTable to std::string
|
||||
#include <cassert>
|
||||
#include <cstddef>
|
||||
#include <cstring>
|
||||
#include <random>
|
||||
#include <string>
|
||||
#include <vector>
|
||||
|
||||
#include "GapBuffer.h"
|
||||
#include "PieceTable.h"
|
||||
|
||||
|
||||
template<typename Buf>
|
||||
static void
|
||||
check_equals(const Buf &b, const std::string &ref)
|
||||
{
|
||||
assert(b.Size() == ref.size());
|
||||
if (b.Size() == 0)
|
||||
return;
|
||||
const char *p = b.Data();
|
||||
assert(p != nullptr);
|
||||
assert(std::memcmp(p, ref.data(), ref.size()) == 0);
|
||||
}
|
||||
|
||||
|
||||
template<typename Buf>
|
||||
static void
|
||||
run_basic_cases()
|
||||
{
|
||||
// empty
|
||||
{
|
||||
Buf b;
|
||||
std::string ref;
|
||||
check_equals(b, ref);
|
||||
}
|
||||
|
||||
// append chars
|
||||
{
|
||||
Buf b;
|
||||
std::string ref;
|
||||
for (int i = 0; i < 1000; ++i) {
|
||||
b.AppendChar('a');
|
||||
ref.push_back('a');
|
||||
}
|
||||
check_equals(b, ref);
|
||||
}
|
||||
|
||||
// prepend chars
|
||||
{
|
||||
Buf b;
|
||||
std::string ref;
|
||||
for (int i = 0; i < 1000; ++i) {
|
||||
b.PrependChar('b');
|
||||
ref.insert(ref.begin(), 'b');
|
||||
}
|
||||
check_equals(b, ref);
|
||||
}
|
||||
|
||||
// append/prepend strings
|
||||
{
|
||||
Buf b;
|
||||
std::string ref;
|
||||
const char *hello = "hello";
|
||||
b.Append(hello, 5);
|
||||
ref.append("hello");
|
||||
b.Prepend(hello, 5);
|
||||
ref.insert(0, "hello");
|
||||
check_equals(b, ref);
|
||||
}
|
||||
|
||||
// larger random blocks
|
||||
{
|
||||
std::mt19937 rng(42);
|
||||
std::uniform_int_distribution<int> len_dist(0, 128);
|
||||
std::uniform_int_distribution<int> coin(0, 1);
|
||||
Buf b;
|
||||
std::string ref;
|
||||
for (int step = 0; step < 2000; ++step) {
|
||||
int L = len_dist(rng);
|
||||
std::string payload(L, '\0');
|
||||
for (int i = 0; i < L; ++i)
|
||||
payload[i] = static_cast<char>('a' + (i % 26));
|
||||
if (coin(rng)) {
|
||||
b.Append(payload.data(), payload.size());
|
||||
ref.append(payload);
|
||||
} else {
|
||||
b.Prepend(payload.data(), payload.size());
|
||||
ref.insert(0, payload);
|
||||
}
|
||||
}
|
||||
check_equals(b, ref);
|
||||
}
|
||||
}
|
||||
|
||||
|
||||
int
|
||||
main()
|
||||
{
|
||||
run_basic_cases<GapBuffer>();
|
||||
run_basic_cases<PieceTable>();
|
||||
return 0;
|
||||
}
|
||||
74
test_search_correctness.cc
Normal file
74
test_search_correctness.cc
Normal file
@@ -0,0 +1,74 @@
|
||||
// Verify OptimizedSearch against std::string reference across patterns and sizes
|
||||
#include <cassert>
|
||||
#include <cstddef>
|
||||
#include <random>
|
||||
#include <string>
|
||||
#include <vector>
|
||||
|
||||
#include "OptimizedSearch.h"
|
||||
|
||||
|
||||
static std::vector<std::size_t>
|
||||
ref_find_all(const std::string &text, const std::string &pat)
|
||||
{
|
||||
std::vector<std::size_t> res;
|
||||
if (pat.empty())
|
||||
return res;
|
||||
std::size_t from = 0;
|
||||
while (true) {
|
||||
auto p = text.find(pat, from);
|
||||
if (p == std::string::npos)
|
||||
break;
|
||||
res.push_back(p);
|
||||
from = p + pat.size(); // non-overlapping
|
||||
}
|
||||
return res;
|
||||
}
|
||||
|
||||
|
||||
static void
|
||||
run_case(std::size_t textLen, std::size_t patLen, unsigned seed)
|
||||
{
|
||||
std::mt19937 rng(seed);
|
||||
std::uniform_int_distribution<int> dist('a', 'z');
|
||||
std::string text(textLen, '\0');
|
||||
for (auto &ch: text)
|
||||
ch = static_cast<char>(dist(rng));
|
||||
std::string pat(patLen, '\0');
|
||||
for (auto &ch: pat)
|
||||
ch = static_cast<char>(dist(rng));
|
||||
|
||||
// Guarantee at least one match when possible
|
||||
if (textLen >= patLen && patLen > 0) {
|
||||
std::size_t pos = textLen / 3;
|
||||
if (pos + patLen <= text.size())
|
||||
std::copy(pat.begin(), pat.end(), text.begin() + static_cast<long>(pos));
|
||||
}
|
||||
|
||||
OptimizedSearch os;
|
||||
auto got = os.find_all(text, pat, 0);
|
||||
auto ref = ref_find_all(text, pat);
|
||||
assert(got == ref);
|
||||
}
|
||||
|
||||
|
||||
int
|
||||
main()
|
||||
{
|
||||
// Edge cases
|
||||
run_case(0, 0, 1);
|
||||
run_case(0, 1, 2);
|
||||
run_case(1, 0, 3);
|
||||
run_case(1, 1, 4);
|
||||
|
||||
// Various sizes
|
||||
for (std::size_t t = 128; t <= 4096; t *= 2) {
|
||||
for (std::size_t p = 1; p <= 64; p *= 2) {
|
||||
run_case(t, p, static_cast<unsigned>(t + p));
|
||||
}
|
||||
}
|
||||
// Larger random
|
||||
run_case(100000, 16, 12345);
|
||||
run_case(250000, 32, 67890);
|
||||
return 0;
|
||||
}
|
||||
Reference in New Issue
Block a user