Claude
b1b0b3de57
- Save's in-place fallbacks (no temp file; no hard-link copy) now apply only when the directory refuses a new name (EACCES, EPERM, ENAMETOOLONG). On ENOSPC, EDQUOT or EIO the in-place write truncated the file and then failed, leaving it corrupt; now the save fails and the file is untouched (checked on a full tmpfs). - replace_rows_text/replace_buffer_text delete and insert only the span between the old and new text's common prefix and suffix (kept on UTF-8 boundaries). Replace-all recorded the whole buffer twice in the undo tree per run. - Regex search skips long lines only while typing (limit lowered to 2,000 bytes, as for renderer highlighting; '.*q' on a 20 KB line took 12 s), reports how many were skipped, and next/previous match search every line. Previously matches on long lines could not be found. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015rcVQiiWyTzoNrsvLSaAfB
36 lines
1.6 KiB
C++
36 lines
1.6 KiB
C++
// RegexGuard.h - keep std::regex from overflowing the stack
|
|
//
|
|
// libstdc++'s std::regex matcher recurses roughly once per character of a
|
|
// match, so a pattern such as ".*" or "a+" on a line of a few tens of
|
|
// thousands of characters (minified JS/JSON) overflows a default 8 MiB
|
|
// stack and crashes the editor.
|
|
#pragma once
|
|
|
|
#include <cstddef>
|
|
#include <functional>
|
|
#include <regex>
|
|
#include <string>
|
|
|
|
namespace kte {
|
|
// Renderers highlight regex matches only on lines up to this many bytes, and
|
|
// search-as-you-type skips longer lines (an explicit search does not):
|
|
// std::regex can take time quadratic in line length even for ordinary
|
|
// patterns (".*q" on a 20 KB line: 12 s), with no way to interrupt it, and
|
|
// these run on every frame or keystroke.
|
|
constexpr std::size_t kRegexRenderLineLimit = 2000;
|
|
constexpr std::size_t kRegexIncrementalLineLimit = 2000;
|
|
|
|
// Run fn to completion on a thread with a large stack (address space is
|
|
// reserved, pages are committed only as used), so regex work over long lines
|
|
// cannot overflow. If such a thread cannot be created, fn runs on the calling
|
|
// thread. Exceptions thrown by fn are rethrown to the caller.
|
|
void RunWithLargeStack(const std::function<void()> &fn);
|
|
|
|
// Call on_match(position, length) for each match of rx in line. Lines short
|
|
// enough to be safe on any stack are matched inline; longer ones on a large
|
|
// stack (a 10,000-byte line already overflowed 8 MiB for some patterns).
|
|
// Throws what std::regex throws.
|
|
void ForEachRegexMatch(const std::string &line, const std::regex &rx,
|
|
const std::function<void(std::size_t, std::size_t)> &on_match);
|
|
} // namespace kte
|