mc/metacrypt
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Add buf lint/breaking targets and fix proto naming violations

Browse Source 
- Add buf.yaml with STANDARD lint rules and FILE-level breaking change detection
- Add proto-lint Makefile target (buf lint + buf breaking --against master)
- Add lint Makefile target (golangci-lint) and include it in all
- Fix proto target: use module= option so protoc writes to gen/ not proto/
- engine.proto: rename rpc Request→Execute and message types accordingly
- acme.proto: drop redundant ACME prefix from SetConfig/ListAccounts/ListOrders messages
- policy.proto: add CreatePolicyResponse/GetPolicyResponse wrappers instead of returning PolicyRule directly from multiple RPCs
- Update grpcserver and webserver/client.go to match renamed types

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This commit is contained in:
Kyle Isom
2026-03-15 10:27:52 -07:00
parent fbaf79a8a0
commit 2336bf5061
22 changed files with 658 additions and 530 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
internal/grpcserver/policy.go
View File

@@ -15,7 +15,7 @@ type policyServer struct {
s *GRPCServer
}
func (ps *policyServer) CreatePolicy(ctx context.Context, req *pb.CreatePolicyRequest) (*pb.PolicyRule, error) {
func (ps *policyServer) CreatePolicy(ctx context.Context, req *pb.CreatePolicyRequest) (*pb.CreatePolicyResponse, error) {
if req.Rule == nil || req.Rule.Id == "" {
return nil, status.Error(codes.InvalidArgument, "rule.id is required")
}
@@ -24,7 +24,7 @@ func (ps *policyServer) CreatePolicy(ctx context.Context, req *pb.CreatePolicyRe
ps.s.logger.Error("grpc: create policy", "error", err)
return nil, status.Error(codes.Internal, "internal error")
}
return ruleToPB(rule), nil
return &pb.CreatePolicyResponse{Rule: ruleToPB(rule)}, nil
}
func (ps *policyServer) ListPolicies(ctx context.Context, _ *pb.ListPoliciesRequest) (*pb.ListPoliciesResponse, error) {
@@ -40,7 +40,7 @@ func (ps *policyServer) ListPolicies(ctx context.Context, _ *pb.ListPoliciesRequ
return &pb.ListPoliciesResponse{Rules: pbRules}, nil
}
func (ps *policyServer) GetPolicy(ctx context.Context, req *pb.GetPolicyRequest) (*pb.PolicyRule, error) {
func (ps *policyServer) GetPolicy(ctx context.Context, req *pb.GetPolicyRequest) (*pb.GetPolicyResponse, error) {
if req.Id == "" {
return nil, status.Error(codes.InvalidArgument, "id is required")
}
@@ -48,7 +48,7 @@ func (ps *policyServer) GetPolicy(ctx context.Context, req *pb.GetPolicyRequest)
if err != nil {
return nil, status.Error(codes.NotFound, "not found")
}
return ruleToPB(rule), nil
return &pb.GetPolicyResponse{Rule: ruleToPB(rule)}, nil
}
func (ps *policyServer) DeletePolicy(ctx context.Context, req *pb.DeletePolicyRequest) (*pb.DeletePolicyResponse, error) {